RFC: move krunnermodel in org.kde.plasma.core

2012-10-03 Thread Marco Martin
Hi all, for some reason the krunner model ended up into its own import, that doesn't make much sense and causes that tad ov overhead of having one more so. its real place would be org.kde.plasma.core together the other libplasma bindings. if this is moved today would cause some annoyances but

Re: RFC: move krunnermodel in org.kde.plasma.core

2012-10-03 Thread Martin Gräßlin
On Wednesday 03 October 2012 13:20:43 Marco Martin wrote: it's probably just a couple of places where is used and wasn't really documented yet (more on documentation issue later) so change would be fairly pailess opinions? ideas? the krunnermodel has been part of a release, right? Given that

Re: RFC: move krunnermodel in org.kde.plasma.core

2012-10-03 Thread Aurélien Gâteau
Le mercredi 3 octobre 2012 13:20:43 Marco Martin a écrit : Hi all, for some reason the krunner model ended up into its own import, that doesn't make much sense and causes that tad ov overhead of having one more so. its real place would be org.kde.plasma.core together the other libplasma

Re: RFC: move krunnermodel in org.kde.plasma.core

2012-10-03 Thread Marco Martin
On Wednesday 03 October 2012, Aurélien Gâteau wrote: the api of the class wouldn't change Makes sense to me. You may want to take advantage of this small breakage to replace the name of the model roles from label to display and icon to decoration. This would make RunnerModel follow

Re: RFC: move krunnermodel in org.kde.plasma.core

2012-10-03 Thread Marco Martin
On Wednesday 03 October 2012, Martin Gräßlin wrote: On Wednesday 03 October 2012 13:20:43 Marco Martin wrote: it's probably just a couple of places where is used and wasn't really documented yet (more on documentation issue later) so change would be fairly pailess opinions? ideas?