Re: Review Request: Add an unit test for Plasma::ConfigLoader
On 2010-09-12 21:47:38, Martin Blumenstingl wrote: /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp, line 172 http://svn.reviewboard.kde.org/r/5329/diff/1/?file=35739#file35739line172 I am not sure why, but actual is always empty. I can't figure out the reason, because building the list is OK in ConfigLoader. I can access the list when I use it in a javascript plasmoid - so there may be something wrong with the code in my test. after a discussion with Aaron: using QListqint32 is wrong here. ItemIntList is a QListint - that's why casting fails. - Martin --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/#review7566 --- On 2010-09-12 21:45:48, Martin Blumenstingl wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/ --- (Updated 2010-09-12 21:45:48) Review request for Plasma. Summary --- Currently I'm changing some of the code in Plasma::ConfigLoader. I want to make sure that I don't break that much ;) Thus I wrote a unit test for the config loader. Currently all it does it testing if the config loader can parse the default-values correctly. One test for each (data-)type which ConfigLoader can handle. Unfortunately ConfigLoaderTest::intListDefaultValue does not work yet (everything else works) Diffs - /trunk/KDE/kdelibs/plasma/tests/configloadertest.xml PRE-CREATION /trunk/KDE/kdelibs/plasma/tests/CMakeLists.txt 1174512 /trunk/KDE/kdelibs/plasma/tests/configloadertest.h PRE-CREATION /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp PRE-CREATION Diff: http://svn.reviewboard.kde.org/r/5329/diff Testing --- I ran the tests on my box. 20/21 were successful. The only one failing is: ConfigLoaderTest::intListDefaultValue (and I need some help there) Thanks, Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add an unit test for Plasma::ConfigLoader
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/ --- (Updated 2010-09-13 17:51:03.041714) Review request for Plasma. Changes --- fixed the failing test :) Summary (updated) --- Currently I'm changing some of the code in Plasma::ConfigLoader. I want to make sure that I don't break that much ;) Thus I wrote a unit test for the config loader. Currently all it does it testing if the config loader can parse the default-values correctly. One test for each (data-)type which ConfigLoader can handle. Diffs (updated) - /trunk/KDE/kdelibs/plasma/tests/configloadertest.xml PRE-CREATION /trunk/KDE/kdelibs/plasma/tests/CMakeLists.txt 1174512 /trunk/KDE/kdelibs/plasma/tests/configloadertest.h PRE-CREATION /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp PRE-CREATION Diff: http://svn.reviewboard.kde.org/r/5329/diff Testing (updated) --- I ran the tests on my box. All of them were successful. Thanks, Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add an unit test for Plasma::ConfigLoader
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/#review7582 --- Ship it! looks great; and it shows a problem in ConfigLoader - it should be using int, not qint32 for the integer list. nice! :) - Aaron On 2010-09-13 17:51:03, Martin Blumenstingl wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/ --- (Updated 2010-09-13 17:51:03) Review request for Plasma. Summary --- Currently I'm changing some of the code in Plasma::ConfigLoader. I want to make sure that I don't break that much ;) Thus I wrote a unit test for the config loader. Currently all it does it testing if the config loader can parse the default-values correctly. One test for each (data-)type which ConfigLoader can handle. Diffs - /trunk/KDE/kdelibs/plasma/tests/configloadertest.xml PRE-CREATION /trunk/KDE/kdelibs/plasma/tests/CMakeLists.txt 1174512 /trunk/KDE/kdelibs/plasma/tests/configloadertest.h PRE-CREATION /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp PRE-CREATION Diff: http://svn.reviewboard.kde.org/r/5329/diff Testing --- I ran the tests on my box. All of them were successful. Thanks, Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Add an unit test for Plasma::ConfigLoader
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/ --- Review request for Plasma. Summary --- Currently I'm changing some of the code in Plasma::ConfigLoader. I want to make sure that I don't break that much ;) Thus I wrote a unit test for the config loader. Currently all it does it testing if the config loader can parse the default-values correctly. One test for each (data-)type which ConfigLoader can handle. Unfortunately ConfigLoaderTest::intListDefaultValue does not work yet (everything else works) Diffs - /trunk/KDE/kdelibs/plasma/tests/configloadertest.xml PRE-CREATION /trunk/KDE/kdelibs/plasma/tests/CMakeLists.txt 1174512 /trunk/KDE/kdelibs/plasma/tests/configloadertest.h PRE-CREATION /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp PRE-CREATION Diff: http://svn.reviewboard.kde.org/r/5329/diff Testing --- I ran the tests on my box. 20/21 were successful. The only one failing is: ConfigLoaderTest::intListDefaultValue (and I need some help there) Thanks, Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add an unit test for Plasma::ConfigLoader
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/#review7566 --- /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp http://svn.reviewboard.kde.org/r/5329/#comment7726 I am not sure why, but actual is always empty. I can't figure out the reason, because building the list is OK in ConfigLoader. I can access the list when I use it in a javascript plasmoid - so there may be something wrong with the code in my test. - Martin On 2010-09-12 21:45:48, Martin Blumenstingl wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/ --- (Updated 2010-09-12 21:45:48) Review request for Plasma. Summary --- Currently I'm changing some of the code in Plasma::ConfigLoader. I want to make sure that I don't break that much ;) Thus I wrote a unit test for the config loader. Currently all it does it testing if the config loader can parse the default-values correctly. One test for each (data-)type which ConfigLoader can handle. Unfortunately ConfigLoaderTest::intListDefaultValue does not work yet (everything else works) Diffs - /trunk/KDE/kdelibs/plasma/tests/configloadertest.xml PRE-CREATION /trunk/KDE/kdelibs/plasma/tests/CMakeLists.txt 1174512 /trunk/KDE/kdelibs/plasma/tests/configloadertest.h PRE-CREATION /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp PRE-CREATION Diff: http://svn.reviewboard.kde.org/r/5329/diff Testing --- I ran the tests on my box. 20/21 were successful. The only one failing is: ConfigLoaderTest::intListDefaultValue (and I need some help there) Thanks, Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
