Re: Review Request: Re-enable showing all holiday types in plasma calendar

2010-06-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4236/#review5991 --- I like it. unfortunately introduces strings, so i think it's too late

Re: Review Request: Re-enable showing all holiday types in plasma calendar

2010-06-05 Thread John Layt
On 2010-06-05 09:25:36, Marco Martin wrote: I like it. unfortunately introduces strings, so i think it's too late for 4.5? No new strings, just an old one moved down few lines. I would have liked to have a label for the 'other' holidays so it's clearer they are not a day off, but

Re: Review Request: Re-enable showing all holiday types in plasma calendar

2010-06-05 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4236/#review5993 --- trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp

Re: Review Request: Re-enable showing all holiday types in plasma calendar

2010-06-05 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4236/#review5997 --- Ship it! looks good; would be very nice to colour the background of