Re: Review Request: Startup Feedback KWin Effect

2010-10-11 Thread Lubos Lunak
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5529/#review8075 --- Ship it! Seems ok. - Lubos On 2010-10-06 08:44:46, Martin

Re: Review Request: Startup Feedback KWin Effect

2010-10-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5529/ --- (Updated 2010-10-06 08:44:46.985052) Review request for kwin, Plasma and

Re: Review Request: Startup Feedback KWin Effect

2010-10-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5529/#review7992 --- for the plasma part i'm ok. would be possible to use this effect

Re: Review Request: Startup Feedback KWin Effect

2010-10-06 Thread Martin Gräßlin
On 2010-10-06 11:08:18, Marco Martin wrote: for the plasma part i'm ok. would be possible to use this effect also when starting applications in other ways? (start menu, dolphin, whatever) It's used everywhere where you currently see the bouncing cursor. It's just that the startup

Review Request: Startup Feedback KWin Effect

2010-10-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5529/ --- Review request for kwin, Plasma and Lubos Lunak. Summary ---

Re: Review Request: Startup Feedback KWin Effect

2010-10-05 Thread Lubos Lunak
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5529/#review7973 --- The KRunner detour is unnecessary, KWin doesn't need to be told

Re: Review Request: Startup Feedback KWin Effect

2010-10-05 Thread Martin Gräßlin
On 2010-10-05 11:26:28, Lubos Lunak wrote: The KRunner detour is unnecessary, KWin doesn't need to be told by KRunner things it can find out on its own. It'd be cleaner to just have the KWin effect use KSelectionOwner to claim a manager selection and KRunner would not do anything