Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Kai Uwe Broulik
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API promise, revisit if we can remove our own implementation

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/#review60536 --- This patch doesn't include Plasma's SectionScroller, so it

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Aleix Pol Gonzalez
On June 19, 2014, 4:26 p.m., David Edmundson wrote: This patch doesn't include Plasma's SectionScroller, so it would be a regression. However I'm not entirely sure what SectionScroller actually does, so possibly not an important one. Shouldn't we either commit to the review request

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Marco Martin
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API promise, revisit if we can remove our own implementation

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread David Edmundson
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API promise, revisit if we can remove our own implementation

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Marco Martin
On June 19, 2014, 4:26 p.m., David Edmundson wrote: This patch doesn't include Plasma's SectionScroller, so it would be a regression. However I'm not entirely sure what SectionScroller actually does, so possibly not an important one. Aleix Pol Gonzalez wrote: Shouldn't we

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Kai Uwe Broulik
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API promise, revisit if we can remove our own implementation

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Marco Martin
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API promise, revisit if we can remove our own implementation

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Kai Uwe Broulik
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API promise, revisit if we can remove our own implementation

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Marco Martin
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API promise, revisit if we can remove our own implementation

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/ --- (Updated June 19, 2014, 6 p.m.) Review request for KDE Frameworks and

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread David Edmundson
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API promise, revisit if we can remove our own implementation

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/#review60553 --- Ship it! Ship It! - Marco Martin On June 19, 2014, 6

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/#review60554 --- This review has been submitted with commit

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/ --- (Updated June 19, 2014, 6:09 p.m.) Status -- This change has been

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/#review60561 --- Note: The property names don't line up 100% in the merge.

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Kai Uwe Broulik
On June 19, 2014, 8:42 p.m., David Edmundson wrote: Note: The property names don't line up 100% in the merge. flickableItem has now become contentItem (which is a default property) All instances in plasma-workspace/plasma-desktop are now updated. That doesn't matter: flickableItem:

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Kai Uwe Broulik
On June 19, 2014, 8:42 p.m., David Edmundson wrote: Note: The property names don't line up 100% in the merge. flickableItem has now become contentItem (which is a default property) All instances in plasma-workspace/plasma-desktop are now updated. Kai Uwe Broulik wrote: That

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Marco Martin
On June 19, 2014, 8:42 p.m., David Edmundson wrote: Note: The property names don't line up 100% in the merge. flickableItem has now become contentItem (which is a default property) All instances in plasma-workspace/plasma-desktop are now updated. Kai Uwe Broulik wrote: That

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2013-12-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114283/#review45057 --- I really like the idea. I think we should keep our Scroll*

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2013-12-03 Thread Mark Gaiser
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API promise, revisit if we can remove our own implementation

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2013-12-03 Thread Marco Martin
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API promise, revisit if we can remove our own implementation

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2013-12-03 Thread Sebastian Kügler
On Tuesday, December 03, 2013 20:55:19 Mark Gaiser wrote: On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: I really like the idea. I think we should keep our Scroll* components in to ease porting, but move away from using it for our own stuff first, and then, before a first API