Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114424/#review99449 --- Closing as this review request is more than 2 years old. If it still applies to current Plasma please reopen this review request. Thanks - David Edmundson On Dec. 13, 2013, 12:53 p.m., Yichao Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114424/ > --- > > (Updated Dec. 13, 2013, 12:53 p.m.) > > > Review request for Plasma, Aaron J. Seigo, Martin Gräßlin, and Ivan Čukić. > > > Bugs: 320995 > http://bugs.kde.org/show_bug.cgi?id=320995 > > > Repository: kdeplasma-addons > > > Description > --- > > The lancelot main window sets the _KDE_NET_WM_SHADOW property to "1" but > never set anything valid to it and therefore has no drop shadow. > This patch add the shadow when using a qt style that is aware of the KDE > shadow hint in the widget's property. I haven't found a documentation for > this property but it seems that they are recognized by oxygen and are also > copied to qtcurve (and probably bespin, haven't checked). > A better solution might be using the plasma shadow although I don't know how > to do that without copying the code to install shadows from kdelibs, unless > someone adds a new api to apply plasma themed shadows to a window. > > > Diffs > - > > applets/lancelot/application/LancelotWindow.cpp c66c565 > > Diff: https://git.reviewboard.kde.org/r/114424/diff/ > > > Testing > --- > > Compiles. > Have shadow with both oxygen and qtcurve. > > > Thanks, > > Yichao Yu > >
Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114424/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been discarded. Review request for Plasma, Aaron J. Seigo, Martin Gräßlin, and Ivan Čukić. Bugs: 320995 http://bugs.kde.org/show_bug.cgi?id=320995 Repository: kdeplasma-addons Description --- The lancelot main window sets the _KDE_NET_WM_SHADOW property to "1" but never set anything valid to it and therefore has no drop shadow. This patch add the shadow when using a qt style that is aware of the KDE shadow hint in the widget's property. I haven't found a documentation for this property but it seems that they are recognized by oxygen and are also copied to qtcurve (and probably bespin, haven't checked). A better solution might be using the plasma shadow although I don't know how to do that without copying the code to install shadows from kdelibs, unless someone adds a new api to apply plasma themed shadows to a window. Diffs - applets/lancelot/application/LancelotWindow.cpp c66c565 Diff: https://git.reviewboard.kde.org/r/114424/diff/ Testing --- Compiles. Have shadow with both oxygen and qtcurve. Thanks, Yichao Yu
Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints
- Yichao --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/#review45626 --- On Dec. 13, 2013, 7:53 a.m., Yichao Yu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/ --- (Updated Dec. 13, 2013, 7:53 a.m.) Review request for Plasma, Aaron J. Seigo, Martin Gräßlin, and Ivan Čukić. Bugs: 320995 http://bugs.kde.org/show_bug.cgi?id=320995 Repository: kdeplasma-addons Description --- The lancelot main window sets the _KDE_NET_WM_SHADOW property to 1 but never set anything valid to it and therefore has no drop shadow. This patch add the shadow when using a qt style that is aware of the KDE shadow hint in the widget's property. I haven't found a documentation for this property but it seems that they are recognized by oxygen and are also copied to qtcurve (and probably bespin, haven't checked). A better solution might be using the plasma shadow although I don't know how to do that without copying the code to install shadows from kdelibs, unless someone adds a new api to apply plasma themed shadows to a window. Diffs - applets/lancelot/application/LancelotWindow.cpp c66c565 Diff: http://git.reviewboard.kde.org/r/114424/diff/ Testing --- Compiles. Have shadow with both oxygen and qtcurve. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints
On Dec. 13, 2013, 2:40 a.m., Martin Gräßlin wrote: This looks like the wrong approach to me. The shadow gets installed by the widget style, but lancelot does not use a normal Qt style, but a Plasma style. Because of that it would need to use the plasma shadow (e.g. panel shadow). The idea of having the shadow being controlled by the style was to not use a generic shadow for any window as before, but to allow windows to use a shadow matching the window content. This would fall back to a generic approach. Please also add ivan to the review. I actually agree ... and I remember the time when almost all shadows in plasma are broken (4.10 last rc or sth like that?). What was the soluction at that time? Is the best solution copying the plasma shadow code to here again? - Yichao --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/#review45626 --- On Dec. 13, 2013, 7:53 a.m., Yichao Yu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/ --- (Updated Dec. 13, 2013, 7:53 a.m.) Review request for Plasma, Aaron J. Seigo, Martin Gräßlin, and Ivan Čukić. Bugs: 320995 http://bugs.kde.org/show_bug.cgi?id=320995 Repository: kdeplasma-addons Description --- The lancelot main window sets the _KDE_NET_WM_SHADOW property to 1 but never set anything valid to it and therefore has no drop shadow. This patch add the shadow when using a qt style that is aware of the KDE shadow hint in the widget's property. I haven't found a documentation for this property but it seems that they are recognized by oxygen and are also copied to qtcurve (and probably bespin, haven't checked). A better solution might be using the plasma shadow although I don't know how to do that without copying the code to install shadows from kdelibs, unless someone adds a new api to apply plasma themed shadows to a window. Diffs - applets/lancelot/application/LancelotWindow.cpp c66c565 Diff: http://git.reviewboard.kde.org/r/114424/diff/ Testing --- Compiles. Have shadow with both oxygen and qtcurve. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/ --- Review request for Plasma, Aaron J. Seigo and Martin Gräßlin. Bugs: 320995 http://bugs.kde.org/show_bug.cgi?id=320995 Repository: kdeplasma-addons Description --- The lancelot main window sets the _KDE_NET_WM_SHADOW property to 1 but never set anything valid to it and therefore has no drop shadow. This patch add the shadow when using a qt style that is aware of the KDE shadow hint in the widget's property. I haven't found a documentation for this property but it seems that they are recognized by oxygen and are also copied to qtcurve (and probably bespin, haven't checked). A better solution might be using the plasma shadow although I don't know how to do that without copying the code to install shadows from kdelibs, unless someone adds a new api to apply plasma themed shadows to a window. Diffs - applets/lancelot/application/LancelotWindow.cpp c66c565 Diff: http://git.reviewboard.kde.org/r/114424/diff/ Testing --- Compiles. Have shadow with both oxygen and qtcurve. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
