Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119965/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119965/#review65399 --- Ship it! I was definitely bothered by the dependency from

Re: Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Aaron J. Seigo
On Aug. 28, 2014, 8:48 a.m., Marco Martin wrote: shell/interactiveconsole.h, line 158 https://git.reviewboard.kde.org/r/119965/diff/1/?file=307929#file307929line158 Could this be an enum? It could, yes. It means importing an enum into the QML runtime, though, and that means

Re: Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119965/ --- (Updated Aug. 28, 2014, 9:53 a.m.) Status -- This change has been