On July 27, 2015, 9:55 a.m., John Layt wrote:
Fantastic to see this :-) Pretty much as I documented it at
https://community.kde.org/Plasma/Clock#Zooming_Calendar (which was a
serious crib from Windows anyway :-) ). The thing to add for the future
will be clicking on the day takes you
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/
---
(Updated July 27, 2015, 9:43 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review83024
---
Fantastic to see this :-) Pretty much as I documented it at
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/
---
(Updated Juli 24, 2015, 1:15 nachm.)
Review request for Plasma and KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review82804
---
Ship it!
Ship It already!
On July 22, 2015, 5:10 p.m., Martin Klapetek wrote:
Ship It already!
Actually hold with the shipping, I've just noticed that the calendar popup with
digital clock has all wrong margins around the grid, this would need fixing.
- Martin
On Mai 21, 2015, 5:24 nachm., Martin Klapetek wrote:
Bump. Can we get this in for 5.4?
Marco Martin wrote:
ugh, i almost forgot about this...
yes please
Just tested the patch. Working beautifully for me from a user perspective :)
- Bernhard
On May 21, 2015, 5:24 p.m., Martin Klapetek wrote:
Bump. Can we get this in for 5.4?
ugh, i almost forgot about this...
yes please
- Marco
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review80706
---
Bump. Can we get this in for 5.4?
- Martin Klapetek
On
On Feb. 9, 2015, 1:21 vorm., Kai Uwe Broulik wrote:
I'd advice against the new C++ functions. You can use setDisplayDate (even
in QML with the displayedDate property) to accomplish the exact same thing
and it keeps the C++ API clean.
If you really want to have the helper functions on
On Feb. 9, 2015, 1:40 a.m., Lukáš Tinkl wrote:
src/declarativeimports/calendar/qml/DaysCalendar.qml, line 125
https://git.reviewboard.kde.org/r/122488/diff/1/?file=347953#file347953line125
I know this is nitpicking but... how is an arrow pointing to the left
implemented as
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75677
---
Ship it!
I like it. It reminds me an old demo Aza Raskin did
would it be useful to see the events of the day (in an agenda) when you
select the day
2015-02-09 4:20 GMT+01:00 Aleix Pol Gonzalez aleix...@kde.org:
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/
+1 I like it.
Why is it even
On Feb. 9, 2015, 2:21 a.m., Kai Uwe Broulik wrote:
I'd advice against the new C++ functions. You can use setDisplayDate (even
in QML with the displayedDate property) to accomplish the exact same thing
and it keeps the C++ API clean.
If you really want to have the helper functions on
On Feb. 9, 2015, 2:40 a.m., Lukáš Tinkl wrote:
src/declarativeimports/calendar/qml/MonthView.qml, line 61
https://git.reviewboard.kde.org/r/122488/diff/1/?file=347954#file347954line61
I know this is not your code but still... we must absolutely not make
any asumptions about how
On Feb. 9, 2015, 4:20 a.m., Aleix Pol Gonzalez wrote:
+1 I like it.
Why is it even possible to select a day though? It doesn't do anything at
the moment...
Maybe it would be food that when hovering a day, the weekday was
highlighted, it's useful to know what day is it.
Can be
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75695
---
Ship it!
The one thing I'm missing is an indicator for the
On Feb. 9, 2015, 2:51 p.m., Sebastian Kügler wrote:
The one thing I'm missing is an indicator for the currently selected year
and month, should be exactly the same tinting as the selected day.
Otherwise, very nice work. When I implemented the combo-like behaviour, it
was really
On Feb. 9, 2015, 3:20 a.m., Aleix Pol Gonzalez wrote:
+1 I like it.
Why is it even possible to select a day though? It doesn't do anything at
the moment...
Maybe it would be food that when hovering a day, the weekday was
highlighted, it's useful to know what day is it.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75633
---
Good stuff!
Perhaps add some visual hover feedback on the
On Feb. 8, 2015, 9:54 nachm., Andrew Lake wrote:
Good stuff!
Perhaps add some visual hover feedback on the month/year so it's evident
that it's live compared to hovering on other text.
Nothing other than that. Very nice!
Yes, I thought the same, I wanted to turn it into a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75635
---
That's some seriously cool stuff. One thing I noticed in the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/
---
(Updated Feb. 8, 2015, 8:52 nachm.)
Review request for Plasma and KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/
---
Review request for Plasma.
Repository: plasma-framework
Description
On Feb. 8, 2015, 10:07 nachm., Martin Klapetek wrote:
That's some seriously cool stuff. One thing I noticed in the video - what
happened with the bottom frame of the calendar? Seems missing.
I'll do proper review tomorrow.
That's a rounding error in the height calculation of the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75641
---
Awesome! But please take care of alternative access
On Feb. 8, 2015, 10:59 nachm., Heiko Tietze wrote:
Awesome! But please take care of alternative access (keyboard, mouse wheel)
and accessibilty.
The calendar lacks any keyboard input and accessibility support whatsoever, so
this should be added separately later.
- Kai Uwe
On Feb. 8, 2015, 10:59 nachm., Heiko Tietze wrote:
Awesome! But please take care of alternative access (keyboard, mouse wheel)
and accessibilty.
Kai Uwe Broulik wrote:
The calendar lacks any keyboard input and accessibility support
whatsoever, so this should be added separately
On Úno. 9, 2015, 2:40 dop., Lukáš Tinkl wrote:
src/declarativeimports/calendar/qml/MonthView.qml, line 61
https://git.reviewboard.kde.org/r/122488/diff/1/?file=347954#file347954line61
I know this is not your code but still... we must absolutely not make
any asumptions about how
On Feb. 8, 2015, 10:59 p.m., Heiko Tietze wrote:
Awesome! But please take care of alternative access (keyboard, mouse wheel)
and accessibilty.
Kai Uwe Broulik wrote:
The calendar lacks any keyboard input and accessibility support
whatsoever, so this should be added separately
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75649
---
src/declarativeimports/calendar/calendar.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75650
---
src/declarativeimports/calendar/daysmodel.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122488/#review75656
---
+1 I like it.
Why is it even possible to select a day
33 matches
Mail list logo
