Re: Review Request 125705: Use LANG for month names in calendar applet

2015-11-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/ --- (Updated Nov. 18, 2015, 5:38 p.m.) Status -- This change has been

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-11-18 Thread David Edmundson
> On Oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to you > LC_DATE is only for the

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-11-17 Thread Martin Klapetek
> On Oct. 28, 2015, 9:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to you > LC_DATE is only for the

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-28 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87617 --- So...any word on this? - Martin Klapetek On Oct. 20, 2015,

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-28 Thread Albert Astals Cid
> On oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote: > > So...any word on this? Re-reading your comment, if i understand it correctly, you claim it is a bug in Qt that it does obey LC_DATE for month names when according to you LC_DATE is only for the formatting and should be using LANG,

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-28 Thread Martin Klapetek
> On Oct. 28, 2015, 9:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to you > LC_DATE is only for the

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-28 Thread David Edmundson
> On Oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to you > LC_DATE is only for the

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87113 --- src/declarativeimports/calendar/calendar.cpp (line 195)

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/ --- (Updated Oct. 20, 2015, 9:04 p.m.) Review request for KDE Frameworks and

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Martin Klapetek
> On Oct. 20, 2015, 9:12 a.m., Xuetian Weng wrote: > > src/declarativeimports/calendar/calendar.cpp, line 195 > > > > > > This only checks LANG, meanwhile, LC_ALL and LC_MESSAGES, and maybe > > even LANGUAGE

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87164 --- src/declarativeimports/calendar/calendar.cpp (line 197)

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-20 Thread Xuetian Weng
> On Oct. 20, 2015, 9:30 p.m., Albert Astals Cid wrote: > > src/declarativeimports/calendar/calendar.cpp, line 197 > > > > > > uilanguages is not good for direct inputing into QLocale (yes i know, > > it's

Review Request 125705: Use LANG for month names in calendar applet

2015-10-19 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/ --- Review request for KDE Frameworks and Plasma. Bugs: 353715

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-10-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/#review87095 --- +1 you won't be able to use this trick for the tooltip