Re: Review Request 126089: Metadata and color edit for plasma theme explorer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126089/#review88590 --- Ship it! Ship It! - Sebastian Kügler On Nov. 18, 2015,

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126089/ --- (Updated Nov. 19, 2015, 12:27 p.m.) Status -- This change has been

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126089/ --- (Updated Nov. 18, 2015, 11:10 a.m.) Review request for Plasma.

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote: > > themeexplorer/package/contents/ui/ColorEditor.qml, lines 326-329 > > > > > > Does keyboard navigation work with that still? ie. return/escape? Also > >

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote: > > themeexplorer/package/contents/ui/ColorEditor.qml, line 97 > > > > > > I think if you made the ColumnLayout the contentItem the Dialog would > > deduce

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126089/#review88477 --- There's a ColorButton in kquickcontrols. Also what's up with

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote: > > themeexplorer/package/contents/ui/ColorEditor.qml, line 95 > > > > > > Doesn't "Dialog" do that automatically? kinda... only if i let him do the buttons,

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

> On Nov. 17, 2015, 1:15 p.m., Sebastian Kügler wrote: > > File Attachment: snapshot18.png - snapshot18.png > > > > > > spacing (also on the right and at the bottom) not sure.. on my system i set the window decoration to be no side

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126089/#review88435 --- Overall, good stuff. Some minor comments, and my review

Review Request 126089: Metadata and color edit for plasma theme explorer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126089/ --- Review request for Plasma. Repository: plasma-sdk Description ---