Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-19 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/#review88590
---

Ship it!


Ship It!

- Sebastian Kügler


On Nov. 18, 2015, 11:10 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126089/
> ---
> 
> (Updated Nov. 18, 2015, 11:10 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> * add a metadata editor functionality that allows to create a theme based 
> upon the default one and edit some of the metadata afterwards
> 
> * add a graphical editor for the color file that has a little preview with 
> fake widgets to give an idea how the colors will look
> 
> 
> Diffs
> -
> 
>   themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/main.qml af61c39 
>   themeexplorer/src/CMakeLists.txt c971784 
>   themeexplorer/src/coloreditor.h PRE-CREATION 
>   themeexplorer/src/coloreditor.cpp PRE-CREATION 
>   themeexplorer/src/main.cpp f2ec4a2 
>   themeexplorer/src/themelistmodel.h 3ae6eb4 
>   themeexplorer/src/themelistmodel.cpp 32a6fd4 
>   themeexplorer/src/thememodel.h 18e404d 
>   themeexplorer/src/thememodel.cpp 5366a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/126089/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot18.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
> snapshot17.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-19 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/
---

(Updated Nov. 19, 2015, 12:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c68db2a257c4ac775ebf28b7d5b6aa00db7c2936 by Marco Martin 
to branch master.


Repository: plasma-sdk


Description
---

* add a metadata editor functionality that allows to create a theme based upon 
the default one and edit some of the metadata afterwards

* add a graphical editor for the color file that has a little preview with fake 
widgets to give an idea how the colors will look


Diffs
-

  themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
  themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
  themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
  themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
  themeexplorer/package/contents/ui/main.qml af61c39 
  themeexplorer/src/CMakeLists.txt c971784 
  themeexplorer/src/coloreditor.h PRE-CREATION 
  themeexplorer/src/coloreditor.cpp PRE-CREATION 
  themeexplorer/src/main.cpp f2ec4a2 
  themeexplorer/src/themelistmodel.h 3ae6eb4 
  themeexplorer/src/themelistmodel.cpp 32a6fd4 
  themeexplorer/src/thememodel.h 18e404d 
  themeexplorer/src/thememodel.cpp 5366a7e 

Diff: https://git.reviewboard.kde.org/r/126089/diff/


Testing
---


File Attachments


snapshot18.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
snapshot17.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-18 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/
---

(Updated Nov. 18, 2015, 11:10 a.m.)


Review request for Plasma.


Repository: plasma-sdk


Description
---

* add a metadata editor functionality that allows to create a theme based upon 
the default one and edit some of the metadata afterwards

* add a graphical editor for the color file that has a little preview with fake 
widgets to give an idea how the colors will look


Diffs (updated)
-

  themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
  themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
  themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
  themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
  themeexplorer/package/contents/ui/main.qml af61c39 
  themeexplorer/src/CMakeLists.txt c971784 
  themeexplorer/src/coloreditor.h PRE-CREATION 
  themeexplorer/src/coloreditor.cpp PRE-CREATION 
  themeexplorer/src/main.cpp f2ec4a2 
  themeexplorer/src/themelistmodel.h 3ae6eb4 
  themeexplorer/src/themelistmodel.cpp 32a6fd4 
  themeexplorer/src/thememodel.h 18e404d 
  themeexplorer/src/thememodel.cpp 5366a7e 

Diff: https://git.reviewboard.kde.org/r/126089/diff/


Testing
---


File Attachments


snapshot18.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
snapshot17.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-18 Thread Marco Martin 


> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/ColorEditor.qml, lines 326-329
> > 
> >
> > Does keyboard navigation work with that still? ie. return/escape? Also 
> > set "isDefault: true" for the default button

tab navigation is fine. enter and escape is indeed broken. but using the 
default buttons is so broken that i would manage the keys on my own


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/#review88477
---


On Nov. 16, 2015, 2:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126089/
> ---
> 
> (Updated Nov. 16, 2015, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> * add a metadata editor functionality that allows to create a theme based 
> upon the default one and edit some of the metadata afterwards
> 
> * add a graphical editor for the color file that has a little preview with 
> fake widgets to give an idea how the colors will look
> 
> 
> Diffs
> -
> 
>   themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/main.qml af61c39 
>   themeexplorer/src/CMakeLists.txt c971784 
>   themeexplorer/src/coloreditor.h PRE-CREATION 
>   themeexplorer/src/coloreditor.cpp PRE-CREATION 
>   themeexplorer/src/main.cpp f2ec4a2 
>   themeexplorer/src/themelistmodel.h 3ae6eb4 
>   themeexplorer/src/themelistmodel.cpp 32a6fd4 
>   themeexplorer/src/thememodel.h 18e404d 
>   themeexplorer/src/thememodel.cpp 5366a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/126089/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot18.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
> snapshot17.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-18 Thread Marco Martin 


> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/ColorEditor.qml, line 97
> > 
> >
> > I think if you made the ColumnLayout the contentItem the Dialog would 
> > deduce window sizing automatically from it

does a white background if i assign as contentItem
if i assign it instead as default property, it deduces correctly the window 
size from ColumnLayout hints, but resizing the column layout from the manually 
resized window won't work


> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/ColorEditor.qml, lines 189-192
> > 
> >
> > You could just make the GridLayout child of the ScrollView

I need to center it horizontally, i don't think it can do that if i don't put 
it in a blank parent?


> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/MetadataEditor.qml, line 39
> > 
> >
> > .forceActiveFocus() ?

works this way too (iirc forceActiveFocus had problems with accessibility?)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/#review88477
---


On Nov. 16, 2015, 2:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126089/
> ---
> 
> (Updated Nov. 16, 2015, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> * add a metadata editor functionality that allows to create a theme based 
> upon the default one and edit some of the metadata afterwards
> 
> * add a graphical editor for the color file that has a little preview with 
> fake widgets to give an idea how the colors will look
> 
> 
> Diffs
> -
> 
>   themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/main.qml af61c39 
>   themeexplorer/src/CMakeLists.txt c971784 
>   themeexplorer/src/coloreditor.h PRE-CREATION 
>   themeexplorer/src/coloreditor.cpp PRE-CREATION 
>   themeexplorer/src/main.cpp f2ec4a2 
>   themeexplorer/src/themelistmodel.h 3ae6eb4 
>   themeexplorer/src/themelistmodel.cpp 32a6fd4 
>   themeexplorer/src/thememodel.h 18e404d 
>   themeexplorer/src/thememodel.cpp 5366a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/126089/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot18.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
> snapshot17.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-17 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/#review88477
---


There's a ColorButton in kquickcontrols.

Also what's up with those custom TextField controls and all?


themeexplorer/package/contents/ui/ColorEditor.qml (line 95)


Doesn't "Dialog" do that automatically?



themeexplorer/package/contents/ui/ColorEditor.qml (line 97)


I think if you made the ColumnLayout the contentItem the Dialog would 
deduce window sizing automatically from it



themeexplorer/package/contents/ui/ColorEditor.qml (lines 189 - 192)


You could just make the GridLayout child of the ScrollView



themeexplorer/package/contents/ui/ColorEditor.qml (line 198)


whitespace



themeexplorer/package/contents/ui/ColorEditor.qml (lines 326 - 329)


Does keyboard navigation work with that still? ie. return/escape? Also set 
"isDefault: true" for the default button



themeexplorer/package/contents/ui/MetadataEditor.qml (line 39)


.forceActiveFocus() ?



themeexplorer/src/thememodel.cpp (line 296)


Should probably be configurable somewhere


- Kai Uwe Broulik


On Nov. 16, 2015, 2:37 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126089/
> ---
> 
> (Updated Nov. 16, 2015, 2:37 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> * add a metadata editor functionality that allows to create a theme based 
> upon the default one and edit some of the metadata afterwards
> 
> * add a graphical editor for the color file that has a little preview with 
> fake widgets to give an idea how the colors will look
> 
> 
> Diffs
> -
> 
>   themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/main.qml af61c39 
>   themeexplorer/src/CMakeLists.txt c971784 
>   themeexplorer/src/coloreditor.h PRE-CREATION 
>   themeexplorer/src/coloreditor.cpp PRE-CREATION 
>   themeexplorer/src/main.cpp f2ec4a2 
>   themeexplorer/src/themelistmodel.h 3ae6eb4 
>   themeexplorer/src/themelistmodel.cpp 32a6fd4 
>   themeexplorer/src/thememodel.h 18e404d 
>   themeexplorer/src/thememodel.cpp 5366a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/126089/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot18.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
> snapshot17.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-17 Thread Marco Martin 


> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote:
> > themeexplorer/package/contents/ui/ColorEditor.qml, line 95
> > 
> >
> > Doesn't "Dialog" do that automatically?

kinda... only if i let him do the buttons, but in that case i can't resize the 
dialog contents based on the dialog size (and the buttons order is hardcoded to 
be gnome/mac as Cancel/Ok) sideeffect of overriding mainItem i have to paint 
the background myself


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/#review88477
---


On Nov. 16, 2015, 2:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126089/
> ---
> 
> (Updated Nov. 16, 2015, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> * add a metadata editor functionality that allows to create a theme based 
> upon the default one and edit some of the metadata afterwards
> 
> * add a graphical editor for the color file that has a little preview with 
> fake widgets to give an idea how the colors will look
> 
> 
> Diffs
> -
> 
>   themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/main.qml af61c39 
>   themeexplorer/src/CMakeLists.txt c971784 
>   themeexplorer/src/coloreditor.h PRE-CREATION 
>   themeexplorer/src/coloreditor.cpp PRE-CREATION 
>   themeexplorer/src/main.cpp f2ec4a2 
>   themeexplorer/src/themelistmodel.h 3ae6eb4 
>   themeexplorer/src/themelistmodel.cpp 32a6fd4 
>   themeexplorer/src/thememodel.h 18e404d 
>   themeexplorer/src/thememodel.cpp 5366a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/126089/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot18.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
> snapshot17.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-17 Thread Marco Martin 


> On Nov. 17, 2015, 1:15 p.m., Sebastian Kügler wrote:
> > File Attachment: snapshot18.png - snapshot18.png
> > 
> >
> > spacing (also on the right and at the bottom)

not sure.. on my system i set the window decoration to be no side borders, but 
since iirc that's not the default, by default, by default there would be a bit 
more size borders than in the screenshots?
(maybe a bit all around could be good never the less)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/#review88435
---


On Nov. 16, 2015, 2:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126089/
> ---
> 
> (Updated Nov. 16, 2015, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> * add a metadata editor functionality that allows to create a theme based 
> upon the default one and edit some of the metadata afterwards
> 
> * add a graphical editor for the color file that has a little preview with 
> fake widgets to give an idea how the colors will look
> 
> 
> Diffs
> -
> 
>   themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/main.qml af61c39 
>   themeexplorer/src/CMakeLists.txt c971784 
>   themeexplorer/src/coloreditor.h PRE-CREATION 
>   themeexplorer/src/coloreditor.cpp PRE-CREATION 
>   themeexplorer/src/main.cpp f2ec4a2 
>   themeexplorer/src/themelistmodel.h 3ae6eb4 
>   themeexplorer/src/themelistmodel.cpp 32a6fd4 
>   themeexplorer/src/thememodel.h 18e404d 
>   themeexplorer/src/thememodel.cpp 5366a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/126089/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot18.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
> snapshot17.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-17 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/#review88435
---


Overall, good stuff. Some minor comments, and my review hasn't been very 
thorough.


File Attachment: snapshot18.png - snapshot18.png


spacing (also on the right and at the bottom)



themeexplorer/package/contents/ui/ColorButton.qml (line 39)


gridUnit?


- Sebastian Kügler


On Nov. 16, 2015, 2:37 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126089/
> ---
> 
> (Updated Nov. 16, 2015, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> ---
> 
> * add a metadata editor functionality that allows to create a theme based 
> upon the default one and edit some of the metadata afterwards
> 
> * add a graphical editor for the color file that has a little preview with 
> fake widgets to give an idea how the colors will look
> 
> 
> Diffs
> -
> 
>   themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
>   themeexplorer/package/contents/ui/main.qml af61c39 
>   themeexplorer/src/CMakeLists.txt c971784 
>   themeexplorer/src/coloreditor.h PRE-CREATION 
>   themeexplorer/src/coloreditor.cpp PRE-CREATION 
>   themeexplorer/src/main.cpp f2ec4a2 
>   themeexplorer/src/themelistmodel.h 3ae6eb4 
>   themeexplorer/src/themelistmodel.cpp 32a6fd4 
>   themeexplorer/src/thememodel.h 18e404d 
>   themeexplorer/src/thememodel.cpp 5366a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/126089/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> snapshot18.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
> snapshot17.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-16 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126089/
---

Review request for Plasma.


Repository: plasma-sdk


Description
---

* add a metadata editor functionality that allows to create a theme based upon 
the default one and edit some of the metadata afterwards

* add a graphical editor for the color file that has a little preview with fake 
widgets to give an idea how the colors will look


Diffs
-

  themeexplorer/package/contents/ui/ColorButton.qml PRE-CREATION 
  themeexplorer/package/contents/ui/ColorEditor.qml PRE-CREATION 
  themeexplorer/package/contents/ui/FormLabel.qml PRE-CREATION 
  themeexplorer/package/contents/ui/MetadataEditor.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/Button.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/CheckBox.qml PRE-CREATION 
  themeexplorer/package/contents/ui/fakecontrols/LineEdit.qml PRE-CREATION 
  themeexplorer/package/contents/ui/main.qml af61c39 
  themeexplorer/src/CMakeLists.txt c971784 
  themeexplorer/src/coloreditor.h PRE-CREATION 
  themeexplorer/src/coloreditor.cpp PRE-CREATION 
  themeexplorer/src/main.cpp f2ec4a2 
  themeexplorer/src/themelistmodel.h 3ae6eb4 
  themeexplorer/src/themelistmodel.cpp 32a6fd4 
  themeexplorer/src/thememodel.h 18e404d 
  themeexplorer/src/thememodel.cpp 5366a7e 

Diff: https://git.reviewboard.kde.org/r/126089/diff/


Testing
---


File Attachments


snapshot18.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/2ec2a6f6-a9db-4527-b3ce-05c9ac4585a2__snapshot18.png
snapshot17.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/3cba4a35-5bf0-485b-a94e-65e6fd07e778__snapshot17.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel