Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 17, 2016, 2:06 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 27 > > > > > > Hold it! ;-) > > > > This is still error prone. Just keep the

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 17, 2016, 2:06 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 27 > > > > > > Hold it! ;-) > > > > This is still error prone. Just keep the

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 17, 2016, 2:06 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 27 > > > > > > Hold it! ;-) > > > > This is still error prone. Just keep the

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92489 ---

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 17, 2016, 2:03 p.m.) Status -- This change has been

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92488 --- Ship it! Ship It! - Martin Gräßlin On Feb. 17, 2016,

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 17, 2016, 10:12 a.m.) Review request for kwin and Plasma.

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 16, 2016, 3:48 p.m.) Review request for kwin and Plasma.

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92455 ---

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92457 ---

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 16, 2016, 3:40 p.m., Martin Gräßlin wrote: > > effects/morphingpopups/package/metadata.desktop, line 5 > > > > > > popups? Rather tooltips? > > Marco Martin wrote: > tooltips and notifications yeah

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 16, 2016, 2:40 p.m., Martin Gräßlin wrote: > > effects/morphingpopups/package/metadata.desktop, line 5 > > > > > > popups? Rather tooltips? tooltips and notifications - Marco

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 11, 2016, 8:52 a.m.) Review request for kwin and Plasma.

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 10, 2016, 6:04 p.m.) Review request for kwin and Plasma.

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 2, 2016, 4:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 86 > > > > > > a) let's have AnimationEffect::retarget(id, values...)?! - progress is

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 2, 2016, 4:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 86 > > > > > > a) let's have AnimationEffect::retarget(id, values...)?! - progress is

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 2, 2016, 4:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 86 > > > > > > a) let's have AnimationEffect::retarget(id, values...)?! - progress is

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92054 ---

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 4, 2016, 12:37 p.m., Anthony Fieroni wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 22 > > > > > > Make duration depend on animation speed config, pls. > > Below

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 4, 2016, 12:37 p.m., Anthony Fieroni wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 22 > > > > > > Make duration depend on animation speed config, pls. > > Below

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 4, 2016, 1:37 p.m., Anthony Fieroni wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 22 > > > > > > Make duration depend on animation speed config, pls. > > Below

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92010 --- I like it, bunch of nitpicky nitpicks below

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 3, 2016, 12:18 a.m., Xuetian Weng wrote: > > I just wonder, does this change also fix: > > https://bugs.kde.org/show_bug.cgi?id=241557 ? > > > > Also, I have impression that if there's a big difference between the size > > of two tooltip window, it will look bad. > > Thomas Lübking

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 2, 2016, 5:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 29 > > > > > > backtrace? > > Martin Gräßlin wrote: > I just created a test case

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 3, 2016, 12:18 a.m., Xuetian Weng wrote: > > I just wonder, does this change also fix: > > https://bugs.kde.org/show_bug.cgi?id=241557 ? > > > > Also, I have impression that if there's a big difference between the size > > of two tooltip window, it will look bad. > > Thomas Lübking

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 2, 2016, 4:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 86 > > > > > > a) let's have AnimationEffect::retarget(id, values...)?! - progress is

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 3, 2016, 9:38 a.m., Kai Uwe Broulik wrote: > > effects/morphingpopups/package/metadata.desktop, line 22 > > > > > > This files doesn't exist :) i can eventually do it ;) - Marco

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92023 --- effects/blur/blur.cpp (line 437)

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 3, 2016, 12:18 a.m., Xuetian Weng wrote: > > I just wonder, does this change also fix: > > https://bugs.kde.org/show_bug.cgi?id=241557 ? > > > > Also, I have impression that if there's a big difference between the size > > of two tooltip window, it will look bad. > > Thomas Lübking

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 2, 2016, 4:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 70 > > > > > > enums (KWin.* should work, but am not sure) doesn't seems to work >

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 2, 2016, 4:40 nachm., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 86 > > > > > > a) let's have AnimationEffect::retarget(id, values...)?! - progress is

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 2, 2016, 8:51 p.m.) Review request for kwin and Plasma.

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 3, 2016, 12:18 a.m., Xuetian Weng wrote: > > I just wonder, does this change also fix: > > https://bugs.kde.org/show_bug.cgi?id=241557 ? > > > > Also, I have impression that if there's a big difference between the size > > of two tooltip window, it will look bad. No, completely

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review91965 ---

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 2, 2016, 5:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 29 > > > > > > backtrace? I just created a test case for it:

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 2, 2016, 4:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 29 > > > > > > backtrace? > > Martin Gräßlin wrote: > I just created a test case

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

> On Feb. 2, 2016, 5:40 p.m., Thomas Lübking wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 29 > > > > > > backtrace? > > Martin Gräßlin wrote: > I just created a test case

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92000 --- I just wonder, does this change also fix:

Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- Review request for kwin and Plasma. Repository: kwin Description

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review91950 --- effects/morphingpopups/package/metadata.desktop (line 2)

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 2, 2016, 2:04 p.m.) Review request for kwin and Plasma.