Re: Review Request 129400: Avoid potential access of .last() on empty list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129400/ --- (Updated Nov. 22, 2016, 10:42 a.m.) Status -- This change has been

Re: Review Request 129400: Avoid potential access of .last() on empty list

> On Nov. 14, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote: > > src/kpackagetool/kpackagetool.cpp, line 502 > > > > > > Then just change to `QStandardPath::locate`? > > David Edmundson wrote: > Sounds sensible

Re: Review Request 129400: Avoid potential access of .last() on empty list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129400/#review100858 --- Fix it, then Ship it! other than that, ship it

Re: Review Request 129400: Avoid potential access of .last() on empty list

> On Nov. 14, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote: > > src/kpackagetool/kpackagetool.cpp, line 502 > > > > > > Then just change to `QStandardPath::locate`? Sounds sensible to me. Though I don't really

Re: Review Request 129400: Avoid potential access of .last() on empty list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129400/#review100834 --- src/kpackagetool/kpackagetool.cpp (line 502)

Review Request 129400: Avoid potential access of .last() on empty list

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129400/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage