[Differential] [Request, 11 lines] D3045: [server] Implement the generic window property in QtSurfaceExtension

2016-10-13 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY Qt supports setting generic data on a QWindow. This change implements the callbac

[Differential] [Updated, 9 lines] D3045: [server] Implement the generic window property in QtSurfaceExtension

2016-10-13 Thread Martin Gräßlin
graesslin updated this revision to Diff 7368. graesslin added a comment. Remove unused variable REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3045?vs=7367&id=7368 BRANCH extended-surface-property REVISION DETAIL https://phabricator.kde.org/D304

[Differential] [Request, 28 lines] D3046: Pass color scheme hint to Wayland compositor using window property

2016-10-13 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Setting a window property on a platform handle passes it to the QtExtendedSurface interface and that wa

[Differential] [Request, 16 lines] D3047: Support custom color scheme for Wayland windows

2016-10-13 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY On Wayland the QtExtendedSurface is used to pass the path to the col

[Differential] [Updated] D3047: Support custom color scheme for Wayland windows

2016-10-13 Thread Martin Gräßlin
graesslin added a dependency: D3045: [server] Implement the generic window property in QtSurfaceExtension. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3047 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_

[Differential] [Updated] D3045: [server] Implement the generic window property in QtSurfaceExtension

2016-10-13 Thread Martin Gräßlin
graesslin added a dependent revision: D3047: Support custom color scheme for Wayland windows. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D3045 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland C

Re: Review Request 129158: [PluginLoader] Use operator<< for finalArgs instead of initializer list

2016-10-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129158/ --- (Updated Oct. 13, 2016, 8:19 a.m.) Status -- This change has been ma

Re: ~Re: lookandfeel and dependencies (and potentially all kde-store related stuff)

2016-10-13 Thread Marco Martin
On Thu, Oct 13, 2016 at 1:19 AM, Aleix Pol wrote: >> What I dislike is that we're creating another package manager in the ~/.local >> directory. I do see a lot of advantages to allowing combinations of packages, >> and it would allow makers to not stupidly copy around sources, but work >> together

KCM for network configuration

2016-10-13 Thread Jan Grulich
Hi, I decided to replace the kde5-nm-connection-editor with a more user friendly KCM with a bit more nicer UI. The KCM is also missing in system settings and would be nice to have it there. I just don't know how it should look like, as developers are poor designers, so I just came up with this

Season of KDE -- please add your ideas

2016-10-13 Thread Valorie Zimmerman
Hello developers, Do you have a project in mind which will help KDE? Season of KDE might be for you. KDE Student Programs has announced the 2016-2017 Season of KDE for those who want to participate in mentored projects which enhance KDE in some way. Projects from past Seasons of KDE include new

[Differential] [Request, 184 lines] D3048: [Colors KCM] Default scheme is now installed as a file

2016-10-13 Thread ochurlaud (Olivier Churlaud)
ochurlaud created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The default values are not anymore taken from the hardcoded ones in kconfigwidget. BUG: 370305 REPOSITORY rPLASMADESKTOP Plasma Desk

[Differential] [Updated] D3048: [Colors KCM] Default scheme is now installed as a file

2016-10-13 Thread ochurlaud (Olivier Churlaud)
ochurlaud added reviewers: Plasma, mart, broulik. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3048 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma, mart, broulik Cc: plasma-devel, lesliezhai, a

[Differential] [Commented On] D3048: [Colors KCM] Default scheme is now installed as a file

2016-10-13 Thread ochurlaud (Olivier Churlaud)
ochurlaud added a comment. One draw back of this way is that if `Default.colors` is erased or not found, there is no "Default", and in case no `*.colors` are found, the kcm will be empty... REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3048 EMAIL

[Differential] [Updated] D3048: [Colors KCM] Default scheme is now installed as a file

2016-10-13 Thread mart (Marco Martin)
mart added a comment. hmm, also wouldn't be loaded if a kde app is loaded from another desktopwithout config prior existing i guess INLINE COMMENTS > colorscm.cpp:118 > const QString name = group.readEntry("Name", info.baseName()); > -QListWidgetItem * newItem = new QListWid

[Differential] [Commented On] D3048: [Colors KCM] Default scheme is now installed as a file

2016-10-13 Thread mart (Marco Martin)
mart added a comment. i am in favor of this chane, but i think the real reson of the breakage should be investigated as well, uf there may be problems in kconfigwidget itself REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3048 EMAIL PREFERENCES

[Differential] [Commented On] D3048: [Colors KCM] Default scheme is now installed as a file

2016-10-13 Thread ochurlaud (Olivier Churlaud)
ochurlaud added a comment. In https://phabricator.kde.org/D3048#56488, @mart wrote: > i am in favor of this chane, but i think the real reson of the breakage should be investigated as well, uf there may be problems in kconfigwidget itself Then I need help :) INLINE COMMENTS > m

[Differential] [Accepted] D3034: Lockscreen: New session only on switchSessionPage

2016-10-13 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3034 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, davidedmundson

[Differential] [Request, 230 lines] D3049: Support passing generic QIcon through PlasmaWindow interface

2016-10-13 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma on Wayland, hein. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY Especially for Xwayland windows the compositor might not have a themed icon

[Differential] [Request, 5 lines] D3050: Use new PlasmaWindowInterface::setIcon

2016-10-13 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, hein. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This allows to pass also Xwayland icons to the task manager.

[Differential] [Updated] D3050: Use new PlasmaWindowInterface::setIcon

2016-10-13 Thread Martin Gräßlin
graesslin added a dependency: D3049: Support passing generic QIcon through PlasmaWindow interface. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3050 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayla

[Differential] [Updated] D3049: Support passing generic QIcon through PlasmaWindow interface

2016-10-13 Thread Martin Gräßlin
graesslin added a dependent revision: D3050: Use new PlasmaWindowInterface::setIcon. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D3049 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, hein Cc:

[Differential] [Commented On] D3050: Use new PlasmaWindowInterface::setIcon

2016-10-13 Thread Martin Gräßlin
graesslin added a comment. F362342: taskmanager-x-icons.png REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3050 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_way

[Differential] [Commented On] D3047: Support custom color scheme for Wayland windows

2016-10-13 Thread Martin Gräßlin
graesslin added a comment. F362344: kwin_colorscheme_wayland.png REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3047 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_o

[Differential] [Commented On] D3048: [Colors KCM] Default scheme is now installed as a file

2016-10-13 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3048#56489, @ochurlaud wrote: > In https://phabricator.kde.org/D3048#56488, @mart wrote: > > > i am in favor of this chane, but i think the real reson of the breakage should be investigated as well, uf there may be problems in kco

[Breeze] [Bug 370648] New: SDDM Breeze theme hardly usable on multiscreen set up with different DPIs

2016-10-13 Thread Jaroslav Reznik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370648 Bug ID: 370648 Summary: SDDM Breeze theme hardly usable on multiscreen set up with different DPIs Product: Breeze Version: 5.8.0 Platform: Fedora RPMs URL: http://r

[Differential] [Closed] D3034: Lockscreen: New session only on switchSessionPage

2016-10-13 Thread subdiff (Roman Gilg)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe7a07a154006: Lockscreen: New session only on switchSessionPage (authored by subdiff). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Breeze] [Bug 370216] breeze sddm theme could have the password and username field text centered

2016-10-13 Thread Nikos Platis via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370216 --- Comment #1 from Nikos Platis --- If this is ever implemented, the change should also be applied to the lock screen, where the password field is also left-aligned currently. -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Commented On] D2914: folderview: port the context menu away from KonqPopupMenu.

2016-10-13 Thread dfaure (David Faure)
dfaure added a comment. Eike: ping? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2914 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, broulik, hein Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jens

[Differential] [Accepted] D2914: folderview: port the context menu away from KonqPopupMenu.

2016-10-13 Thread hein (Eike Hein)
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Sorry, I had this open in the browser and thought I accepted it, somehow that ball got dropped though. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://pha

[Differential] [Closed] D2914: folderview: port the context menu away from KonqPopupMenu.

2016-10-13 Thread dfaure (David Faure)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP3cf22b335871: folderview: port the context menu away from KonqPopupMenu. (authored by dfaure). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

[Differential] [Changed Subscribers] D3049: Support passing generic QIcon through PlasmaWindow interface

2016-10-13 Thread roberts (Lindsay Roberts)
roberts added inline comments. INLINE COMMENTS > plasmawindowmanagement.cpp:489 > +n = QT_READ(fd, buf, sizeof buf); > +if (n == -1 && (errno == EAGAIN) && ++retryCount < 1000) { > +usleep(1000); EAGAIN comes from reads of O_NONBLOCK fd's, but this seems to be a block

Re: ~Re: lookandfeel and dependencies (and potentially all kde-store related stuff)

2016-10-13 Thread Aleix Pol
On Thu, Oct 13, 2016 at 10:56 AM, Marco Martin wrote: > On Thu, Oct 13, 2016 at 1:19 AM, Aleix Pol wrote: >>> What I dislike is that we're creating another package manager in the >>> ~/.local >>> directory. I do see a lot of advantages to allowing combinations of >>> packages, >>> and it would

[Powerdevil] [Bug 370667] powerdevil crashes on battery low

2016-10-13 Thread Christoph Feck via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370667 Christoph Feck changed: What|Removed |Added Version|unspecified |5.8.0 Assignee|unassigned-b...@kde.o

[Powerdevil] [Bug 370667] powerdevil crashes on battery low

2016-10-13 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370667 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de Status|UNC

[Differential] [Request, 3 lines] D3051: [applets/notification] Add nullptr check

2016-10-13 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Hit a crash there, this change prevents it: Thread 1 "plasmashell" received signal SIGSEGV,

[Powerdevil] [Bug 370667] powerdevil crashes on battery low

2016-10-13 Thread Nikola Dodik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370667 --- Comment #2 from Nikola Dodik --- I think I am using the plasmoid? I honestly don't know. I'm using whatever there is in the bottom right corner of my screen. How can I find this out for you? -- You are receiving this mail because: You are the assi