hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D4576
REVISION DETAIL
https://phabricator.kde.org/D4576
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emai
davidedmundson added a comment.
looks sensible.
INLINE COMMENTS
> Messages.sh:6
> +
> +$XGETTEXT `find . -name \*.cc -o -name \*.cpp -o -name \*.h -o -name \*.qml
> | grep -v "/src/filepropertiesplugin/"` -o $podir/baloowidgets.pot
> rm -f rc.cpp
is this not overwriting the generated extra
dfaure added inline comments.
INLINE COMMENTS
> Messages.sh:6
> +
> +$XGETTEXT `find . -name \*.cc -o -name \*.cpp -o -name \*.h -o -name \*.qml
> | grep -v "/src/filepropertiesplugin/"` -o $podir/baloowidgets.pot
> rm -f rc.cpp
This is obviously wrong, it would duplicate a lot of stuff that t
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5e7cbdd445f6: Pressing Enter should open submenus in
Kicker (authored by davidedmundson).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4401?vs=10835&id=113
On dinsdag 14 februari 2017 13:11:04 CET Marco Martin wrote:
> On Wed, Feb 8, 2017 at 11:39 PM, Łukasz Sawicki wrote:
>
>
> > However what saddens me the most is the fact that I warned you guys
> > about potential issues before Plasma 5.8 release in September. [2].
> > Either way it is up to you
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/621/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 16 Feb 2017 10:25:23 +
Build duration: 7 min 22 sec
CHANGE SET
Revision e125eb5d18584df2899e3b6afb5280
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/72/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 16 Feb 2017 10:25:23 +
Build duration: 19 min
CHANGE SET
Revision 815a3a54951a6e1b2bad786088
hein requested changes to this revision.
hein added a reviewer: hein.
This revision now requires changes to proceed.
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D4607
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma,
hein added inline comments.
INLINE COMMENTS
> package.cpp:362
> foreach (const QString &contentsPrefix, d->contentsPrefixPaths) {
> -const QString prefix = fileType == "metadata" ? d->path : (d->path +
> contentsPrefix);
> +const QString prefix = !d->tempRoot.isEmpty() ? (fi
mart updated this revision to Diff 11400.
mart added a comment.
- readability++
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4607?vs=11336&id=11400
BRANCH
arcpatch-D4607
REVISION DETAIL
https://phabricator.kde.org/D4607
AFFECTED FILES
src/kpacka
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
arcpatch-D4607
REVISION DETAIL
https://phabricator.kde.org/D4607
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma, hein
Cc: plas
mart updated this revision to Diff 11402.
mart added a comment.
- remove eventual pre existing plugin actions
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4620?vs=11371&id=11402
BRANCH
phab/setActionsLater
REVISION DETAIL
https://phabricator.kde.org/D46
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:083b229ac85d: finish support for opening compressed
packages (authored by mart).
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4607?vs=11400&id=11403
REVISION DE
hein created this revision.
hein added reviewers: Plasma, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.
REVISION SUMMARY
What happens:
- Activity switch calls invalidateFilter on TaskFilterProxyModel, which may
remove rows in respons
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> tasksmodel.cpp:800
> }
> // Fall through to source order if sorting is disabled or manual, or
> alphabetical by app name otherwise.
>
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D4631
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, davidedm
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:410086d06bf0: Tweak alphabetic (default) sort behavior.
(authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4469?vs=10988&id=11405
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:05826bd5ba25: Fix crash when switching activities.
(authored by hein).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4631?vs=11404&id=11406
REVISION DETA
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/69/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 16 Feb 2017 12:58:06 +
Build duration: 6 min 13 sec
CHANGE SET
Revision f1167336c165d20b02
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/70/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 16 Feb 2017 13:04:30 +
Build duration: 6 min 0 sec
CHANGE SET
Revision 49d79637c53ff724cdc
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/71/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 16 Feb 2017 13:12:23 +
Build duration: 5 min 35 sec
CHANGE SET
Revision 62b803b45dbe14dc24
https://bugs.kde.org/show_bug.cgi?id=375333
--- Comment #10 from Mahendra Tallur ---
Hi ! I just upgraded KDE Frameworks to version 5.31.0 (KDE Neon LTS) and it
seems this bugfix is not included in this version. Is it supposed to ?
Cheers !
--
You are receiving this mail because:
You are the a
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/73/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 16 Feb 2017 13:39:18 +
Build duration: 5 min 39 sec
CHANGE SET
Revision 4d6c618ce793fc347975
On Thursday 16 February 2017 11:38:57 Sebastian Kügler wrote:
> > I would actually remove the button from next 5.8 release at this
> > point, if people are ok
>
> OK, we're not really breaking functionality, and the sooner we do it, the
> better.
done.
button removed from 5.8, all merged and rev
https://bugs.kde.org/show_bug.cgi?id=375333
--- Comment #11 from Mahendra Tallur ---
Hmm, it seems kio is part ofr KDE Frameworks but kio-extras seems to be part of
KDE Applications. Version 16.12.2 of KDE apps doesn't seem to include this fix.
I'll be patient, sorry for bothering ;)
--
You are
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/622/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 16 Feb 2017 13:30:52 +
Build duration: 16 min
CHANGE SET
Revision a261ff25a580759183d20725d9f37d9ba253
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/623/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 16 Feb 2017 13:52:05 +
Build duration: 5 min 47 sec
CHANGE SET
Revision 167f2830b9a2b33c7470d011a05d58
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/74/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 16 Feb 2017 13:45:02 +
Build duration: 17 min
CHANGE SET
Revision 4e0bb534345642730146b98da6
https://bugs.kde.org/show_bug.cgi?id=362988
--- Comment #11 from Elmo R ---
This has been a bug for years, and recently, I noticed it went away, but now
it's back. After four (new, non-cached) clicks in an SFTP connection, the file
browser hangs as "Loading...". It's not a KIO thing because the s
On donderdag 16 februari 2017 14:45:25 CET Marco Martin wrote:
> On Thursday 16 February 2017 11:38:57 Sebastian Kügler wrote:
>
>
>
> > > I would actually remove the button from next 5.8 release at this
> > > point, if people are ok
>
>
>
> > OK, we're not really breaking functionality, and
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Otherwise the positioner will get comp
broulik updated the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4632
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:58f26b8f5563: Split KWin::Xkb into a dedicated .h and
.cpp (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4623?vs=11376&id=11408
REVISION DET
ivan accepted this revision.
ivan added a reviewer: ivan.
ivan added a comment.
This revision is now accepted and ready to land.
Seems ok.
Would be nice to know the reasoning on why the positioning was bad without it
- why it was "confused" in the first place.
REPOSITORY
R120 Plasma Wo
mart created this revision.
mart added a reviewer: apol.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
new elements: AbstractItemViewHeader and ItemViewHeader.
An item that can be used as an header for a ListView.
mart updated this revision to Diff 11414.
mart added a comment.
- reposition shadow for inline headers
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4635?vs=11413&id=11414
BRANCH
phab/ItemViewHeader
REVISION DETAIL
https://phabricator.kde.org/D4635
broulik added a comment.
> why it was "confused" in the first place.
If you just did a hide() it would never put the dialog back into the
"available popups" pool, always reserving the space on screen as occupied by a
popup. The C++ part already does some visibleChanged magic but only for
mck182 added a comment.
> it's quite a mess
No it's not :P It's a delicate complex code with lots of comments. But let me
know if you need some help with that.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4632
EMAIL PREFERENCES
https://phabricator
heikobecker created this revision.
heikobecker added reviewers: Plasma, ivan.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Furthermore handle differently KF5SysGuard differently because,
despite its misleading prefix,
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
I've changed to AbstractItemViewHeader it in Discover and it works. I cannot
really change it completely because it has some extra use-cases so I'm not
really saving much code but I can imagine
Hi all,
Just an update, so far, the following has been changed so far:
- One Messages.sh to create a catalogue used by all components, needs testing;
- Applet renamed to org.kde.plasma.vault and plasma_applet_vault.so
(to fit the rest);
- Icons for the applet added to the breeze plasma and icon t
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129955/
---
(Updated Feb. 17, 2017, 12:23 a.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129955/#review102534
---
Ship it!
Good catch! I was curious and look a bit about i
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129955/
---
(Updated Feb. 17, 2017, 1:50 a.m.)
Status
--
This change has been ma
cfeck added a comment.
Any update?
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D4540
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: idekels, whiting, bbuch, mpyne, cfeck
Cc: broulik, bbuch, cfeck, plasma-devel
idekels added a comment.
I don't know what to do next. should I try change the message again?
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D4540
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: idekels, whiting,
cfeck created this revision.
cfeck added a reviewer: Plasma.
cfeck set the repository for this revision to R106 KSysguard.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
As per https://bugs.kde.org/show_bug.cgi?id=376537
cfeck added a comment.
Use "Update Diff" to upload the correct diff. If you switched between
different branches (as the current diff suggests), please make sure you solve
the git issues first. If everything else fails, "git reset origin/master", and
re-apply your changes.
REPOSITORY
R105
idekels updated this revision to Diff 11427.
idekels added a comment.
Fix password extraction from git after update to Plasma 5.9 in neon
This bug caused ksshaskpass to ask for the password and/or username every
time without storing it in kwallet
REPOSITORY
R105 KDE SSH Password Dialog
C
cfeck added inline comments.
INLINE COMMENTS
> main.cpp:62
> +
> +//Case 3: Fix password extraction from git after update to Plasma 5.9 in
> neon
> +QRegularExpression re3("^(Password|Username) for (.*?)[:] $");
So are these strings really specific to git? Also, it makes no sense to men
idekels updated this revision to Diff 11428.
idekels added a comment.
- Fix password extraction from git. bug number 376228
- remove Plasma version and distribution from comment
REPOSITORY
R105 KDE SSH Password Dialog
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4540?vs=11427&
idekels added a comment.
I suppose that it could work for other apps as well but I only use this
program for git
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D4540
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.
Thanks, looks good now. Do you have commit rights? If not, I will commit it
on your behalf.
REPOSITORY
R105 KDE SSH Password Dialog
BRANCH
master
REVISION DETAIL
https://phabricator.k
idekels added a comment.
I think my commits are right now, but go ahead, it's probably better!
REPOSITORY
R105 KDE SSH Password Dialog
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4540
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
ivan accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R845 Plasma Vault
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4636
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: heikobecker, ivan, #plasma
Cc: p
ivan added a comment.
> If you just did a hide() it would never put the dialog back into the
"available popups" pool, always
> reserving the space on screen as occupied by a popup
Heh, cool :)
As far as I'm concerned, you still have a green light to push.
REPOSITORY
R120 Plasma
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
So far KWin put a version requirement on Breeze which is the current
version number of KWin. Th
57 matches
Mail list logo
