D6216: simplify positioning code

mart added a comment. ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6216 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6215: Make sure size is final after showEvent

mart added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6310: Introduce KDE_NO_GLOBAL_MENU env variable to disable global menu

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D6310 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D6310: Introduce KDE_NO_GLOBAL_MENU env variable to disable global menu

broulik edited the summary of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D6310 To: broulik, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D6310: Introduce KDE_NO_GLOBAL_MENU env variable to disable global menu

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows to run specific applications with global menu disabled in case of issues. TEST PLAN `KDE_NO_GLOBAL_MENU=1 kwrite` didn't

D6189: Add support for fortisslvpn

This revision was automatically updated to reflect the committed changes. Closed by commit R116:78b78cf3dedf: Add support for fortisslvpn (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6189?vs=15372=15679

D6216: simplify positioning code

apol added a comment. Can we maybe include a test? Then it would be much safer to do this kind of changes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6216 To: mart, #plasma, davidedmundson Cc: apol, davidedmundson, plasma-devel, ZrenBot, spstarr,

D6310: Introduce KDE_NO_GLOBAL_MENU env variable to disable global menu

This revision was automatically updated to reflect the committed changes. Closed by commit R135:e912ec46eaf6: Introduce KDE_NO_GLOBAL_MENU env variable to disable global menu (authored by broulik). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D6216: simplify positioning code

This revision was automatically updated to reflect the committed changes. Closed by commit R120:415b6d81a696: simplify positioning code (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6216?vs=15578=15683 REVISION DETAIL

D6215: Make sure size is final after showEvent

davidedmundson added a comment. > no, it just means that who calls show() or the wrong setVisible() would just get the previous behavior of mainItem being shown only at showevent, Ok, great It's somewhat confusing as you have multiple completely independent attempts to

D6215: Make sure size is final after showEvent

mart added a comment. so, on the 5 points: 1. yes, is necessary, resizing windows in their show event is definitely not enough, causes events to arrive to reset to the old geometry in race with the setgeometry done there, if it's the qpa, if it's qwindow, if it's the windowmanager

D6215: Make sure size is final after showEvent

mart edited the summary of this revision. mart edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks,

D6189: Add support for fortisslvpn

mbriza accepted this revision. mbriza added a comment. This revision is now accepted and ready to land. There's nothing to object against in this simple plugin. REPOSITORY R116 Plasma Network Management Applet BRANCH fortisslvpn REVISION DETAIL https://phabricator.kde.org/D6189 To:

D6310: Introduce KDE_NO_GLOBAL_MENU env variable to disable global menu

lilianmoraru added a comment. `Do we have a wiki do document these things?` It would be nice to document these hidden options. @broulik This could be a good place: https://community.kde.org/Plasma/Environment_Variables REPOSITORY R135 Integration for Qt applications in Plasma

D6310: Introduce KDE_NO_GLOBAL_MENU env variable to disable global menu

broulik added a comment. Thanks, I added it there. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D6310 To: broulik, #plasma, mart Cc: lilianmoraru, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D6215: Make sure size is final after showEvent

This revision was automatically updated to reflect the committed changes. Closed by commit R242:eab4aa9909a6: Make sure size is final after showEvent (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6215?vs=15579=15682

D6215: Make sure size is final after showEvent

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6215 To: mart, #plasma, davidedmundson Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks,

D6216: simplify positioning code

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D6216 REVISION DETAIL https://phabricator.kde.org/D6216 To: mart, #plasma, davidedmundson Cc: apol, davidedmundson, plasma-devel, ZrenBot, spstarr,

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

hein added a comment. Yeah, it would be more efficient. Actually, could you audit your code a little more? I think the same issue I had with the busy-looping popups (I was working on https://phabricator.kde.org/D6247 and noticed my plasmashell using 30% CPU and stuttering a lot, and Kai

D6313: WIP: Support device pixel ratio in icon loader and engine

davidedmundson added a comment. For SVG icons this is fine. For pixmap icons this is only part of the needed changes. We don't want to load the 16px image and then resize it, I think that's what this would do? That would be an unacceptable regression. We would need a folder

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol updated this revision to Diff 15686. apol marked 4 inline comments as done. apol added a comment. - Expose the applicationSourceName to KUserFeedback - Include a KUserFeedback schema file - Address Volker's comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D6299: create shell surface only at the right moment

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4c2eb55636fb: create shell surface only at the right moment (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6299?vs=15646=15685

D6141: make shadows work for windows 100%width or height

mart abandoned this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6141 To: mart, #plasma, #kwin, graesslin Cc: luebking, mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts,

[Powerdevil] [Bug 381465] Powerdevil crashes after undocking from Lenovo UltraBase

https://bugs.kde.org/show_bug.cgi?id=381465 Christoph Feck changed: What|Removed |Added Resolution|--- |DUPLICATE

D6313: WIP: Support device pixel ratio in icon loader and engine

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Since Qt 5.9 there's a ScaledPixmapHook in QIconEngine which is called when device pixel ratio is > 1 and it wants a

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

hein requested changes to this revision. hein added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > FolderView.qml:492 > +Component.onCompleted: { > +ready = true > +} Missing semicolon, also ready is defined nowhere.

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

hein added inline comments. INLINE COMMENTS > Zren wrote in FolderView.qml:492 > Arg, curses. > > `ready` is defined 2 lines up. Also, do you want me to put `scrollArea.ready` > so it's not confused with `folderViewLayer.ready` defined in `main.qml`? > >

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

Zren added inline comments. INLINE COMMENTS > hein wrote in FolderView.qml:492 > Maybe I'm blind, but you're linking to a definition of a 'ready' prop in a > different file. FolderView.qml can't depend on a property in main.qml, this > will e.g. break in FolderViewDialog. And yeah,

D6327: [ksshaskpass] Support mercurial (hg) ssh prompts

cfeck created this revision. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The stricter parsing of ssh password prompts causes another regression for mercurial users, see https://bugs.kde.org/show_bug.cgi?id=380085 This is similar

D6332: [kcms/touchpad] Fix warning 'returning reference to temporary'

cfeck created this revision. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Our APIs still should not declare reference results for implicitly shared objects. This is not a problem with the current backends, because they just

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:33793e9e2f56: [FolderView] Don't calculate extra spacing when we don't need to. (authored by Zren). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6322?vs=15709=15719#toc REPOSITORY R119

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

Zren updated this revision to Diff 15709. Zren added a comment. +semicolon and specify it's scrollArea.ready REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6322?vs=15705=15709 REVISION DETAIL https://phabricator.kde.org/D6322 AFFECTED FILES

D6323: Remove roundtrip to XServer from Workspace::xStackingOrderIntroduce a method Workspace::markXStackingOrderAsDirty

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This method replaces the calls x_stacking_dirty = true in the code base allowing for further refactoring of that functionality.

D6324: Make sure we won't modify the aspect ratio of the icons

apol created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 381157 REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D6324 AFFECTED FILES

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

Zren marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6322 To: Zren, hein Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Wait until the ScrollView component has completed before attempting to dynamically size the icons based on the viewport width/height. A

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. I see the definition now with the updated diff - maybe the Phab diff viewer was acting up or something, or I really am blind ... REPOSITORY R119 Plasma Desktop REVISION DETAIL

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

Zren added a comment. So before my commit, it was only needing to do: qml: cellHeight iconHeight 108 qml: cellWidth iconWidth 92 qml: cellHeight iconHeight 108 with no updates after the panel is added. - After my patch logs:

D6322: [FolderView] Don't calculate extra spacing when we don't need to.

Zren added inline comments. INLINE COMMENTS > hein wrote in FolderView.qml:492 > Missing semicolon, also ready is defined nowhere. Arg, curses. `ready` is defined 2 lines up. Also, do you want me to put `scrollArea.ready` so it's not confused with `folderViewLayer.ready` defined in

D6335: [Appmenu Applet] Workaround Connections bug in Qt >= 5.8

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Since Qt 5.8 for some reason the Connections {} on plasmoid.nativeInterface breaks. BUG: 375535 FIXED-IN: 5.10.3 TEST PLAN I

D6336: [AppMenu Applet] Wire up DBusMenuImporter::actionActivationRequested

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ensures that pressing e.g. Alt+F will popup the "File" menu. BUG: 376726 FIXED-IN: 5.10.3 TEST PLAN I upgraded to Qt 5.9 and it was

D6334: [kcms/touchpad] Fix crash with 'Drag me' in X11 test area

cfeck created this revision. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Something really fishy was going on when dragging the 'Drag me' folder in the X11 test area onto itself. Instead of using a custom QStandardItemModel with

D6334: [kcms/touchpad] Fix crash with 'Drag me' in X11 test area

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6334 To: cfeck, #plasma, knambiar, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6332: [kcms/touchpad] Fix warning 'returning reference to temporary'

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6332 To: cfeck, #plasma, subdiff, knambiar, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

Re: Kirigami in Frameworks

As there were no replies for quite a while, i assume there are no particular objections. so, how to proceed? what needs to be doe to do the actual move? On Mon, Jun 5, 2017 at 2:42 PM, Marco Martin wrote: > Hi all, > The Kirigami component set always was targeted to be

D6313: WIP: Support device pixel ratio in icon loader and engine

cfeck added inline comments. INLINE COMMENTS > kiconloader.cpp:863 > + % QLatin1Char('@') > + % QString::number(scale) > % QLatin1Char('_') Please use some rounding here. Scaling factors such as 1.4 cannot be represented exactly. Either add some formatting

D6313: WIP: Support device pixel ratio in icon loader and engine

cfeck added inline comments. INLINE COMMENTS > cfeck wrote in kiconloader.cpp:863 > Please use some rounding here. Scaling factors such as 1.4 cannot be > represented exactly. > > Either add some formatting specifiers, e.g. for three decimal places, or use > qRound(scale * 1000). Just

D6313: WIP: Support device pixel ratio in icon loader and engine

kvermette added a comment. In https://phabricator.kde.org/D6313#118250, @davidedmundson wrote: > For SVG icons this is fine. > > For pixmap icons this is only part of the needed changes. > > We don't want to load the 16px image and then resize it, I think that's what this would

D6313: WIP: Support device pixel ratio in icon loader and engine

cfeck added inline comments. INLINE COMMENTS > kiconloader.cpp:1299 > > -if (d->findCachedPixmapWithPath(key, pix, path)) { > +if (d->findCachedPixmapWithPath(key, pix, path)) {// skip cache > if (path_store) { Is this a left-over change from disabling this check? REPOSITORY

Re: Kirigami in Frameworks

On 21 June 2017 at 15:00, Marco Martin wrote: > As there were no replies for quite a while, i assume there are no > particular objections. > > so, how to proceed? what needs to be doe to do the actual move? Does it comply with the policies (as much as they are relevant for