https://bugs.kde.org/show_bug.cgi?id=358957
Brennan Kinney changed:
What|Removed |Added
CC||polarathene-signup@hotmail.
fvogt created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
When saving, kcm_fonts adds the default selected StyleName,
so it needs to specified here as well to avoid mismatches.
BUG: 383191
TEST PLAN
Ran pkcon install with no kdeglobals.
Without thi
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
stylename
REVISION DETAIL
https://phabricator.kde.org/D7160
To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, les
cfeck added a comment.
Note that saving the style name is a bug, see
https://bugs.kde.org/show_bug.cgi?id=378523
REPOSITORY
R135 Integration for Qt applications in Plasma
BRANCH
stylename
REVISION DETAIL
https://phabricator.kde.org/D7160
To: fvogt, #plasma, davidedmundson
Cc: cfeck,
broulik added inline comments.
INLINE COMMENTS
> devicelisting.cpp:49
> populateListing();
> +setSortingEnabled(true);
> }
Why disable again?
> soldevice.cpp:153
> +const SolDevice * otherDevice = dynamic_cast(&other);
> +if (otherDevice != nullptr)
> +{
Coding style:
fvogt added a comment.
In https://phabricator.kde.org/D7160#132870, @cfeck wrote:
> Note that saving the style name is a bug, see
https://bugs.kde.org/show_bug.cgi?id=378523
While I'm not 100% sure that is true as that's how the user selects the font
in kcm_fonts, I still think t
Am 2017-08-05 17:23, schrieb René J. V. Bertin:
David Edmundson wrote:
In wayland you never query anything, only track events.
There are applications for which this isn't good enough but I guess
there must
be other, low-level ways to query the current state of a given input
device or
sens
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
If ClientConnection fails to get the process id (which happens at least
on FreeBSD) the process id is 0. We should not try to terminate
graesslin added a project: FreeBSD.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7168
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas, apol, mart, lukas
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:b6ed1afd8a8a: libksysguard does not appear to use
QtScript, but just includes it. (authored by carewolf).
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
For a future XFree KWin. Only remaining not guarded usages are in
Workspace::init, but that one needs to be refactored anyway for
beco
bshah accepted this revision as: bshah.
bshah added a comment.
This revision is now accepted and ready to land.
Looks good to me, probably though it's good idea to figure out why it returns
0 as processId?
REPOSITORY
R108 KWin
BRANCH
kill-window-process-0
REVISION DETAIL
https://phabr
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:00281711d9c4: Handle processId being 0 in
ShellClient::killWindow (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7168?vs=17787&id=17798
REVIS
graesslin added a comment.
In https://phabricator.kde.org/D7168#133094, @bshah wrote:
> Looks good to me, probably though it's good idea to figure out why it
returns 0 as processId?
We have a failing auto test for it in KWayland. It looks like
libwayland-server is using a linuxis
tcberner created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7174
AFFECTED FILES
metainfo.yaml
To: tcberner, #freebsd, mart
15 matches
Mail list logo