Re: CI & List Moderation

On mercoledì 13 dicembre 2017 12:25:08 CET Aleix Pol wrote: > > Regards, > > Ben > > If nobody is doing it, you can add me to the list moderation. I am doing it(and david i think), tough perhaps not every day. for ci would be good to add it in whitelist tough -- Marco Martin

D9124: make packageurlinterceptor as noop as possible

mart updated this revision to Diff 23906. mart added a comment. - extra warning REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23905=23906 BRANCH arcpatch-D9124 REVISION DETAIL https://phabricator.kde.org/D9124 AFFECTED

D9324: [Air theme] Add task bar progress graphic

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9324 To: broulik, #plasma, #vdg, ngraham Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9276: highlight PlasmaComponents3.ComboBox list items

mart added a comment. here on master the item under mouse does get highlighted F5548404: Spectacle.Z15071.png INLINE COMMENTS > mvourlakos wrote in ComboBox.qml:49 > yes... it didnt highlight at all, neither the selected item nor the hovered > one...

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/11/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 14 Dec 2017 16:22:49 + Build duration: 12 min and counting JUnit Tests

D8446: [Notifications] Allow selecting text with mouse

broulik added a comment. > I don't think selecting stuff from a notification should be a use case. I occasionally do. Just yesterday I received an SMS and instead of being able to copy something from it I had to grab my phone and send the link to my computer instead. REPOSITORY R120

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 300 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/300/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 Date of build: Thu, 14 Dec 2017 16:22:49 + Build duration: 6 min 27 sec and counting JUnit Tests

D9324: [Air theme] Add task bar progress graphic

abetts added a comment. What should be the move here? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9324 To: broulik, #plasma, #vdg, ngraham Cc: abetts, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9335: invalidate the runtime cache on install

mart created this revision. mart added reviewers: Plasma, sebas. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY at the first time something gets installed, immediately drop runtime cache this

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos abandoned this revision. mvourlakos added a comment. this is Adapta theme issue... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,

D9335: invalidate the runtime cache on install

This revision was automatically updated to reflect the committed changes. Closed by commit R290:a33d3f0f1e73: invalidate the runtime cache on install (authored by mart). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9335?vs=23927=23929 REVISION DETAIL

D9338: [comic] Fix comic updater time interval

anthonyfieroni created this revision. anthonyfieroni added reviewers: davidedmundson, broulik, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In case of invalid update interval every hour download manager stores

D9335: invalidate the runtime cache on install

sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH packagefix REVISION DETAIL https://phabricator.kde.org/D9335 To: mart, #plasma, sebas Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9275: fix RTL appearance for ComboBox

mvourlakos added a subscriber: mart. mvourlakos added a comment. @mart what about this? are you able to reproduce it in your system? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma Cc: mart, plasma-devel, #frameworks,

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a comment. external bug report: https://github.com/PapirusDevelopmentTeam/adapta-kde/issues/26 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma, mart Cc: mart, plasma-devel, #frameworks, ZrenBot,

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a comment. In https://phabricator.kde.org/D9276#179574, @mart wrote: > here on master the item under mouse does get highlighted you are totally right!! so sorry... this is Adapta theme issue, changing to Breeze themes solves this... REPOSITORY R242 Plasma

Re: Plasma-Mycroft is in kdereview

On martedì 5 dicembre 2017 08:52:18 CET Aditya Mehra wrote: > Hi all, > > This is a request email for the review process of the mycroft plasmoid, the > plasma-mycroft project has been moved to kdereview > > The repository url: https://cgit.kde.org/plasma-mycroft.git/ I have no objections about

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

ngraham edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564 To: emateli, plasma-devel, #plasma Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8564: Disallow drop of task manager icons outside of plasmoid when widgets are locked

ngraham added a comment. I found at least one user during my triaging of Task Manager bug who was sufficiently motivated to file a bug that this would resolve: https://bugs.kde.org/show_bug.cgi?id=361984 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8564

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added a comment. just noticed that the reviewer is the person that decides to give the green light so it cant be set by the author without prior communication... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos,

D9323: Use ScreenMapper everywhere as a singleton

amantia added reviewers: Plasma, mwolff, hein. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9323: Use ScreenMapper everywhere as a singleton

broulik added inline comments. INLINE COMMENTS > foldermodel.cpp:124 > +m_complete(false), > +m_screenMapper(ScreenMapper::instance()) > { Why have this member then? > foldermodel.cpp:194 > > +connect(m_screenMapper, ::screensChanged, this, > ::invalidateFilterIfComplete); > +

D9324: [Air theme] Add task bar progress graphic

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This adds a dedicated, green, task bar progress graphic. Currently there isn't

Translations and appstream summaries

Translators, We're getting a bunch of tests failing [1] because of a translation issue. Appstream considers it to be a test failure if any description summary ends in a full stop . In particular for this file: org.kde.plasmashell.metainfo.xml in the repo plasma-desktop we have errors on: uk,

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/12/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 15 Dec 2017 03:48:45 + Build duration: 1 hr 10 min and counting JUnit

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 - Build # 306 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.9/306/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 Date of build: Fri, 15 Dec 2017 03:48:35 + Build duration: 36 min and counting JUnit Tests

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/18/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 15 Dec 2017 03:48:35 + Build duration: 38 min and counting CONSOLE OUTPUT

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 301 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/301/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 Date of build: Fri, 15 Dec 2017 03:48:45 + Build duration: 26 min and counting JUnit Tests

D9325: Use QUrl in the ScreenMapper API

mlaurent added inline comments. INLINE COMMENTS > foldermodeltest.cpp:34 > > +static QUrl stringToUrl(const QString ) { > +return QUrl::fromUserInput(path, {}, QUrl::AssumeLocalFile); new line after ')' > positionertest.cpp:38 > > +static QUrl stringToUrl(const QString ) { > +

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.9 - Build # 331 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.9/331/ Project: Plasma kwin kf5-qt5 SUSEQt5.9 Date of build: Thu, 14 Dec 2017 23:54:35 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 14 Dec 2017 23:54:35 + Build duration: 29 min and counting JUnit Tests Name: (root)

Re: Translations and appstream summaries

2017-12-14 23:40 GMT+01:00 David Edmundson : > Translators, > > We're getting a bunch of tests failing [1] because of a translation issue. I wonder if that's true - appstreamcli will only return a non-zero exist status if you have warnings or errors, the added dot is

D9174: Remove multihead from Plasmashell scripting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b99cbb7be669: Remove multihead from Plasmashell scripting (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9174?vs=23433=23886

D9171: Remove concept of multihead in kcminit

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ad52844c0b6a: Remove concept of multihead in kcminit (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9171?vs=23431=23885

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 299 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/299/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 Date of build: Thu, 14 Dec 2017 08:01:37 + Build duration: 13 min and counting JUnit Tests

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 14 Dec 2017 08:01:37 + Build duration: 6 min 44 sec and counting JUnit

Re: Plasmoid debugging

On 12/12/17 21:50, Aleix Pol wrote:> That's because some distributions change stuff so debug information don't show up on the users' systems. Thank you! Googling for QT_LOGGING_RULES gave me this page which is what I had been missing, http://doc.qt.io/qt-5/qloggingcategory.html And sure

D9197: experimental support for rcc files loading in kpackage

This revision was automatically updated to reflect the committed changes. Closed by commit R290:63f5be21cc84: experimental support for rcc files loading in kpackage (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9197?vs=23864=23892#toc REPOSITORY R290 KPackage

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. just noticed that the reviewer is the person that decides to give the green light so it cant be set by the author without prior communication... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos,

D9323: Use ScreenMapper everywhere as a singleton

amantia updated this revision to Diff 23897. amantia added a comment. Connect to screenammper only if used as a containment CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9323?vs=23894=23897 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9323 AFFECTED FILES

D9325: Use QUrl in the ScreenMapper API

amantia added reviewers: Plasma, mwolff, dakon, broulik. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos removed a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9276 To: mvourlakos, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9275: fix RTL appearance for ComboBox

mvourlakos removed a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9276: highlight PlasmaComponents3.ComboBox list items

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ComboBox.qml:49 > + > +background: Rectangle{ > +width: itemDelegate.width uuh, no, ItemDelegate should highlight by itself when hovered

D9276: highlight PlasmaComponents3.ComboBox list items

mvourlakos added inline comments. INLINE COMMENTS > mart wrote in ComboBox.qml:49 > uuh, no, ItemDelegate should highlight by itself when hovered without having > to do that, this would say that there is a problem in ItemDelegate? yes... it didnt highlight at all, neither the selected item nor

D9323: Use ScreenMapper everywhere as a singleton

amantia added inline comments. INLINE COMMENTS > broulik wrote in foldermodel.cpp:124 > Why have this member then? For convenience > broulik wrote in foldermodel.cpp:194 > I think we shouldn't connect to the signals if we're not a containment? Yes, that makes sense, I will fix it REPOSITORY

D9124: make packageurlinterceptor as noop as possible

mart updated this revision to Diff 23899. mart added a comment. - manage all cases for packages and check for file existence beforehand REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9124?vs=23490=23899 BRANCH arcpatch-D9124 REVISION

D9300: Store screenMapping info only once

amantia added a comment. In https://phabricator.kde.org/D9300#179031, @broulik wrote: > Screen mapper is a singleton type, so it won't cause problems when one screen adds a mapping, it will propagate to the other containments automagically? Before we had `plasmoid.configuration` which

D9313: Don't move back items to second screen if they were manually moved

amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9313 To: amantia, #plasma, hein, mwolff Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/17/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 14 Dec 2017 11:50:27 + Build duration: 1 min 43 sec and counting CONSOLE

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 - Build # 305 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.9/305/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 Date of build: Thu, 14 Dec 2017 11:50:27 + Build duration: 8 min 30 sec and counting JUnit Tests