D10316: [Folder View] Let Alt+Enter open properties dialog

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10316 To: broulik, #plasma, hein Cc: michaelh, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10315: [Notifications] Fix grouping

broulik updated this revision to Diff 26570. broulik added a comment. - Add comment - Use `strlen` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10315?vs=26561=26570 REVISION DETAIL https://phabricator.kde.org/D10315 AFFECTED FILES

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

lshoravi updated this revision to Diff 26573. lshoravi edited the summary of this revision. lshoravi added a comment. Updated author as per ngrahams suggestion. Diff updated for latest framework (assuming that it turned out correctly.) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D10316: [Folder View] Let Alt+Enter open properties dialog

michaelh added a comment. Confusion vanished. :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10316 To: broulik, #plasma, hein Cc: michaelh, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Minutes Monday Plasma Hangout

Crisp and short, but progress! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team Meeting, 5 february 2018 Present: Sho, bshah, sebas, notmart Sho: * [General] Fixed desktop toolbox not closing on click outside and ESC * [FV] Much improved quality of preview thumbnails (were ugly and

Latte Dock findings and maybe useful to Plasma also...

Hello everyone, It isnt a secret that Latte is trying to use internally as more code as possible based on the plasma codepage solutions. These days I discovered that because of that, things fixed or improved in Latte could influence and help Plasma also... I can be wrong so correct me freely...

D10223: Improve preview thumbnail quality

hein added a comment. Before: F5692985: Screenshot_20180205_203453.png After: F5692983: Screenshot_20180205_203401.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 127 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/127/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 05 Feb 2018 12:40:56 + Build duration: 4 min 22 sec and counting CONSOLE

D10268: [appstream runner] Add missing Messages.sh file and set TRANSLATION_DOMAIN

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH appstreamrunnertranslations REVISION DETAIL https://phabricator.kde.org/D10268 To: kossebau, apol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10250: track the validity of the texture

davidedmundson added a comment. > so in that case would be a problem that potentially could come up elsewhere as would make the logic of managedtexturenode not completely correct in those edge cases Textures will never be deleted by anyone else. Docs say: > Warning: The

D10315: [Notifications] Fix grouping

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8164beac15ea: [Notifications] Fix grouping (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10315?vs=26570=26572#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE

D10316: [Folder View] Let Alt+Enter open properties dialog

michaelh added a comment. I'm confused. On my system dolphin already behaves exactly like you described. What did I miss? I also observed when >1 items are selected on Ctrl+Return folders open in new tabs, files open in default application. Can be mixed. With 1 item selected there is no

D10316: [Folder View] Let Alt+Enter open properties dialog

broulik added a comment. This patch is about Folder View (e.g. the desktop icons), not Dolphin REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10316 To: broulik, #plasma, hein Cc: michaelh, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10250: track the validity of the texture

mart added a comment. In https://phabricator.kde.org/D10250#199624, @davidedmundson wrote: > Good analysis on the plotter. Thanks for looking into it. > > > but in some rare cases, it can be deleted too by some external cause, usually when a widget changes its parent > > If

D10316: [Folder View] Let Alt+Enter open properties dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b4f3a883cf91: [Folder View] Let Alt+Enter open properties dialog (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10316?vs=26563=26571

D10315: [Notifications] Fix grouping

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10315 To: broulik, #plasma, davidedmundson, aacid, fvogt Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10223: Improve preview thumbnail quality

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Please remove the unrelated changes before pushing INLINE COMMENTS > foldermodel.cpp:1896-1900 > +if (m_appletInterface) { > +Plasma::Applet *applet = >

D10223: Improve preview thumbnail quality

ngraham added a comment. Nice! The visual artifacts here look similar or the same as ones we sometimes see in Discover and KInfoCenter at HiDPi scale factors: F5693185: Screenshot_20180122_143515.png F5693186: Pixellated logo.png

D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

kossebau resigned from this revision. kossebau added a comment. Tried few times to grasp all the related code to give this some insightful review, but always ran out of time. Sadly not qualitfied to review this code in reasonable amount of time. At least triggered some general quality

D10321: [Notifications] Let clear entry also clear history

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's a "Clear Notifications" context menu entry. So far it

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

lshoravi updated this revision to Diff 26574. lshoravi added a comment. And with that said, I specified the wrong revision in arc. This should be the correct diff. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10305?vs=26573=26574

D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list

lshoravi updated this revision to Diff 26575. lshoravi added a comment. New diff and revision. Assuming that the diff was made correctly, this should work. Correctly set Rene as autho REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

Re: tars up for Plasma 5.12.0

Hello, On Sun, Feb 04, 2018 at 11:24:12AM +0530, Bhushan Shah wrote: > We had a re-roll of kwin tarball, new checksum is, Yet another re-roll, this time plasma-workspace, new checksum is, d5e58c98a43eec206396cd7d3b1d3008c6edba07e9e92c593c24d321f13548b3 It contains the security fix for device

D10223: Improve preview thumbnail quality

markg added a comment. Hmm, weird. In my eyes the knovi thumbnail in the **before** image looks sharper than the after one. It's just blurred in the after one, not better. I'm guessing the QML smooth property has a fairly naive implementation (in Qt). REPOSITORY R119 Plasma Desktop

D10223: Improve preview thumbnail quality

ngraham added a comment. @markg it's now about sharpness or blurring, but rather the "before" screenshot is pixellated and has weird artifacts around the edges. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10223 To: hein, #plasma,

D10223: Improve preview thumbnail quality

ngraham accepted this revision. ngraham added a comment. Either way, to my mind slightly blurry is better than slightly blurry, pixellated, and bugged around the edges, so +1. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10223 To:

D10325: RFC: [KFileWidget] Hide places frame and header

broulik added a comment. > Shouldn't this be controlled by System Settings > Application Style > Widget Style > Breeze > Configure > Frames > Draw Frame around Dockable panels? If that option is enabled you get a frame even with this patch. Otherwise, the default, is nice and clean.

D10325: RFC: [KFileWidget] Hide places frame and header

broulik created this revision. broulik added reviewers: Plasma, VDG, Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This avoids a double "Places" header

D10223: Improve preview thumbnail quality

This revision was automatically updated to reflect the committed changes. Closed by commit R119:db42961ad4d8: Improve preview thumbnail quality (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10223?vs=26304=26589#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 33 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/33/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 05 Feb 2018 15:09:36 + Build duration: 9 min 20 sec and counting

D10325: RFC: [KFileWidget] Hide places frame and header

ngraham added a comment. Shouldn't this be controlled by System Settings > Application Style > Widget Style > Breeze > Configure > Frames > Draw Frame around Dockable panels? Otherwise, people who check that setting will have a visible frame around the Places panel in Dolphin, but not in

D10325: RFC: [KFileWidget] Hide places frame and header

ngraham added a comment. OK, great. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10325 To: broulik, #plasma, #vdg, #frameworks Cc: ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10250: track the validity of the texture

mart added a comment. > However, because it's in a managed texture node, it will get deleted when the node dies. > The node definitely will be killed when you switch window. > > *if* that's the case you're hitting, you're guarding the wrong thing, and will need to guard the node not

D10325: RFC: [KFileWidget] Hide places frame and header

markg added a comment. Why does it show the panel as if it were unlocked? Your before image looks exactly like an unlocked frame in Dolphin. Would it be possible to show it as if it were locked? That would solve all the issues with it, right? REPOSITORY R241 KIO REVISION DETAIL

D10327: [LauncherTasksModel] Support applications: URLs in requestOpenUrls

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Also fix a logic error while at it. TEST PLAN I noticed

D10328: [Task Manager] Use KFilePlacesModel::isHidden

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Which also takes into account hidden groups. TEST PLAN

D10250: track the validity of the texture

mart updated this revision to Diff 26596. mart added a comment. different approach REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10250?vs=26373=26596 BRANCH phab/guardTexture2 REVISION DETAIL https://phabricator.kde.org/D10250 AFFECTED FILES

D10250: track the validity of the texture

davidedmundson added a comment. My valgrind, using your test instructions is showing it is. at 0x75B5D3C: texture (qsgtexturematerial.h:58) by 0x75B5D3C: QSGSimpleTextureNode::texture() const (qsgsimpletexturenode.cpp:264) by 0x26044983: Plotter::render()

D10250: disconnect render() on window change

mart retitled this revision from "track the validity of the texture" to "disconnect render() on window change". mart edited the summary of this revision. REPOSITORY R296 KDeclarative BRANCH phab/guardTexture2 REVISION DETAIL https://phabricator.kde.org/D10250 To: mart, #plasma,

D10250: track the validity of the texture

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH phab/guardTexture2 REVISION DETAIL https://phabricator.kde.org/D10250 To: mart, #plasma, davidedmundson Cc: davidedmundson, broulik, ngraham, plasma-devel,

D10250: disconnect render() on window change

This revision was automatically updated to reflect the committed changes. Closed by commit R296:2617a2ab9d47: disconnect render() on window change (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10250?vs=26596=26597 REVISION DETAIL

D10250: disconnect render() on window change

broulik added a comment. Just some minor points, feel free to ignore INLINE COMMENTS > plotter.cpp:288 > setFlag(ItemHasContents); > +connect(this, ::windowChanged, this, [this]() { > +if (m_window) { Override `QQuickItem::itemChange` instead of a `connect` >

D10315: [Notifications] Fix grouping

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, aacid, fvogt. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Sanitize the body before doing

D10315: [Notifications] Fix grouping

fvogt added inline comments. INLINE COMMENTS > notificationsengine.cpp:266 > const int WORD_PER_MINUTE = 250; > -int count = summary.length() + body.length(); > +int count = summary.length() + (body.length() - 33); // 33 is the length > of and tags > I don't like magic

D10315: [Notifications] Fix grouping

broulik updated this revision to Diff 26561. broulik added a comment. - Get rid of magic numbers REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10315?vs=26558=26561 REVISION DETAIL https://phabricator.kde.org/D10315 AFFECTED FILES

D10315: [Notifications] Fix grouping

davidedmundson added a comment. Note that the unit test doesn't touch any of the code you modified, it passing isn't a sign of anything. Does 5.8 need fixing? INLINE COMMENTS > fvogt wrote in notificationsengine.cpp:266 > I don't like magic numbers, maybe `sizeof(" version="1.0">")-1`?

D10315: [Notifications] Fix grouping

fvogt added inline comments. INLINE COMMENTS > notificationsengine.cpp:230 > +if (previousBody != bodyFinal) { > +bodyFinal = previousBody + QStringLiteral("") + > bodyFinal; > } This results in `...TextSome text...` AFAICT. This also means that the if

D10316: [Folder View] Let Alt+Enter open properties dialog

broulik created this revision. broulik added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is what Dolphin does. The shortcut is hardcoded here

D10316: [Folder View] Let Alt+Enter open properties dialog

broulik edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10316 To: broulik, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

lshoravi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, cfeck Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,

D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list

lshoravi edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10304 To: lshoravi, #plasma, #plasma_accessibility Cc: ngraham, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

lshoravi edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility, cfeck Cc: cfeck, #frameworks, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,

D10315: [Notifications] Fix grouping

fvogt added inline comments. INLINE COMMENTS > fvogt wrote in notificationsengine.cpp:230 > This results in `...TextSome text...` AFAICT. > > This also means that the if condition is always false. According to @broulik the first part is expected, which IMO needs a comment as it does very much

D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list

lshoravi added a comment. Looking through the diff and master branch, it looks like parts of the function has changed since René patched it, which seems to cause issues. I'll try to sort it out. REVISION DETAIL https://phabricator.kde.org/D10304 To: lshoravi, #plasma,

D8695: Fix ampersand characters not showing in tab titles

ngraham added a comment. Hello! I'm very sorry that this patch was somehow missed and not committed in back November, and that another patch with the same diff took its place yesterday. This was an oversight on our part and we will try to make sure that it doesn't happen again! REPOSITORY

D10325: RFC: [KFileWidget] Hide places frame and header

ngraham accepted this revision as: ngraham. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10325 To: broulik, #plasma, #vdg, #frameworks, ngraham Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,

D10232: Include a pixel more in the dirty area

mart updated this revision to Diff 26606. mart added a comment. - comments explainig the workaround REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10232?vs=26325=26606 BRANCH phab/dirty REVISION DETAIL https://phabricator.kde.org/D10232 AFFECTED

D10197: Fix krunner's alt+f2 on wayland

apol added a comment. In https://phabricator.kde.org/D10197#200479, @graesslin wrote: > I fear this broke some functionality of KRunner. It is important to be a dock window! Otherwise KRunner might not be able to go above fullscreen windows and won't be on all desktops. Also without

D10334: RFC: Make KRunner a Dock window

apol created this revision. apol added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Martin requested to make it so on

Re: Compiling and deploying plasma-desktop

On Mon, Feb 5, 2018 at 10:30 PM, pointedstick wrote: > Howdy folks, > > What's the best way to go about compiling plasma-desktop from source and > deploying to /usr/ (in a KDE Neon dev unstable VM; I wouldn't do this on a > real machine), and are there any necessary

D10334: RFC: Make KRunner a Dock window

davidedmundson added a comment. +2 Now we just have to fix whatever this bug in kwin is. Knowing it only affects docks should narrow it down REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10334 To: apol, #plasma, graesslin Cc: davidedmundson,

D10268: [appstream runner] Add missing Messages.sh file and set TRANSLATION_DOMAIN

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2b7dbb611b35: [appstream runner] Add missing Messages.sh file and set TRANSLATION_DOMAIN (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10197: Fix krunner's alt+f2 on wayland

graesslin added a comment. In https://phabricator.kde.org/D10197#201733, @apol wrote: > In https://phabricator.kde.org/D10197#200479, @graesslin wrote: > > > I fear this broke some functionality of KRunner. It is important to be a dock window! Otherwise KRunner might not be able to

D10334: RFC: Make KRunner a Dock window

graesslin added a comment. There is the panel behavior thing missing which used to be in the old code. A panel does not get keyboard focus. With the panel behavior that can be changed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10334 To: apol,

D10328: [Task Manager] Use KFilePlacesModel::isHidden

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10328 To: broulik, #plasma, hein, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10327: [LauncherTasksModel] Support applications: URLs in requestOpenUrls

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. I can't help but feel increasingly bad about the whole applications: URLs thing. If we have to patch 5000 places something is not right. We need to come up with a better way some time soon.

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 128 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/128/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 06 Feb 2018 06:47:17 + Build duration: 16 min and counting JUnit Tests

D10328: [Task Manager] Use KFilePlacesModel::isHidden

hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10328 To: broulik, #plasma, hein, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Compiling and deploying plasma-desktop

Howdy folks, What's the best way to go about compiling plasma-desktop from source and deploying to /usr/ (in a KDE Neon dev unstable VM; I wouldn't do this on a real machine), and are there any necessary dependencies that also always need to be compiled from source? Thanks! Nate

D10302: [x11] Fix interactive point selection

This revision was automatically updated to reflect the committed changes. Closed by commit R108:ea5e70116456: [x11] Fix interactive point selection (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE