D11316: Components for Cards

mart created this revision. mart added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Cards are divided in AbstractCard which is empty and Card, which has

D11292: [RFC] Ordered system tray v2

Pitel updated this revision to Diff 29457. Pitel added a comment. - modified `onConfigurationChanged` so it triggers updates of properties depending on `cfg_shownItems` and `cfg_hiddenItems` - make trash bin not draggable - removed `ComboBox` hack (which was not working anyway) and added

D11205: Fix ActionButton size

icota closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11205 To: icota, #kirigami, mart Cc: ngraham, plasma-devel, #kirigami, apol, davidedmundson, mart, hein

D11306: Give the "Clear History" button some text

Fuchs added a comment. Sorry, but clear -1 from me for the reasons outlined in the Telegram channel. It looks cluttered, and with the very limited space in plasmoids it becomes unpredictable with translations. It removes the very alignment that broulik and I worked hard to achieve.

D11308: Use the default Plasma wallpaper on the lock screen

mart added a comment. -1 from me too REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin Cc: mart, graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11309: Use the default Plasma wallpaper on the login screen

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > theme.conf:3 > +type=image > +background=/usr/share/wallpapers/Next/contents/images/3200x2000.png This must follow `${KDE_INSTALL_DATADIR}` or whatever

D8302: Add FreeBSD port from the development-repo

This revision was automatically updated to reflect the committed changes. Closed by commit R878:36033bac748f: Add FreeBSD port from the development-repo (authored by tcberner). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8302?vs=29455=29456 REVISION

D8302: Add FreeBSD port from the development-repo

tcberner updated this revision to Diff 29455. tcberner added a comment. Update text REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8302?vs=20765=29455 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8302 AFFECTED FILES README.md To:

D11316: Components for Cards

davidedmundson added inline comments. INLINE COMMENTS > AbstractCard.qml:69 > + > +implicitWidth: internal.completed > +? (internal.listView ? internal.listView.width - > internal.listView.spacing * 2 : are you basing the implicit size from the size of the parent layout?

D10944: [taskmanager applet] Do not fill width

hein added a comment. I'm not going to accept the patch as is, sorry - to me this is littering applets with config options that should be handled generically at the containment level instead. I had a brief chat with Marco Martin about this last week and he agreed as well and I think was

D11316: Components for Cards

progwolff added a comment. There seems to be a problem with the overflow menu: F5753673: Screenshot_20180314_121900.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11316 To: mart, #kirigami Cc: davidedmundson,

D11316: Components for Cards

mart added inline comments. INLINE COMMENTS > mart wrote in AbstractCard.qml:69 > no, when it's in a layout the size hints are based purely on the content. > > the different behavior is when it's in a gridview or a listview, where its > sized is based respectively on the cell size or to be

D11316: Components for Cards

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mart wrote in AbstractCard.qml:69 > no, when it's in a layout the size hints are based purely on the content. > > the different behavior is

D10944: [taskmanager applet] Do not fill width

Pitel added a comment. Ahh sorry I misunderstood you. Moving this option to containment level seems reasonable although I'm not sure for how many other applets it might be useful -- except taskbar and Active Windows Control (the global menu applet in my screen shot and it already has this

D11316: Components for Cards

progwolff added a comment. Marked some typos. Note that I am not a native speaker, so please re-check them. Besides that, looks good to me. INLINE COMMENTS > CardsGridViewGallery.qml:61 > +wrapMode: Text.WordWrap > +text: "The Kirigami types AbstractCard and

D10297: Add new "Tools" button above System Monitor's process list

hein added a comment. I haven't been able to review the patch in detail myself, but the basic idea is fantastic IMHO. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein Cc: apol,

D11308: Use the default Plasma wallpaper on the lock screen

mart added a comment. Sadly, the current design doesn't really allow for arbitrary wallpapers (and since is possible already to put any image, that's quite a problem) if a wallpaper should become the default again, the text elements should either have a visible background for contrast (so

D11316: Components for Cards

mart updated this revision to Diff 29486. mart added a comment. - fix typos REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29469=29486 BRANCH mart/Card REVISION DETAIL https://phabricator.kde.org/D11316 AFFECTED FILES

D11316: Components for Cards

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in AbstractCard.qml:69 > are you basing the implicit size from the size of the parent layout? no, when it's in a layout the size hints are based purely on the content. the different behavior is when it's in a gridview or a

D10944: [taskmanager applet] Do not fill width

Pitel added a comment. I understand you do not like adding options that you do not like adding options adjust think which should be configured on another level. But to be able to configure filling empty space at level of panel applets must not claim they need more space than they really do

D11308: Use the default Plasma wallpaper on the lock screen

hein added a comment. FWIW: AIUI this patch isn't about making the lock screen use the current user wallpaper dynamically, which means the vendor gets control over making sure the default wallpaper they pick works with the UI elements at least. REPOSITORY R133 KScreenLocker REVISION

D10944: [taskmanager applet] Do not fill width

hein added a comment. The applet basically exports "this is the space I need at a minimum" and "give me all you got". What I'm saying is that there should be a containment-level option to override the latter and disable fillWidth for the applet. fillWidth is a hint, not a guarantee, and

D11327: [Workspace Options KCM] sync() after writing settings

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures changes take effect immediately TEST PLAN Something

D11316: Components for Cards

apol added a comment. Worked for me. Had to expose the components in the qmldir: diff --git a/src/qmldir b/src/qmldir index f262452..2275600 100644 --- a/src/qmldir +++ b/src/qmldir @@ -36,4 +36,6 @@ AbstractApplicationHeader 2.0 AbstractApplicationHeader.qml

D11306: Give the "Clear History" button some text

broulik resigned from this revision. broulik added a comment. Do whatever you want with this button. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11306 To: ngraham, #plasma, Fuchs Cc: zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11308: Use the default Plasma wallpaper on the lock screen

zzag added a comment. In D11308#225711 , @hein wrote: > > The blue background was not particularly well-received. > > Are you sure you are not reacting to a loud minority? The bright background has some practical benefits, e.g. it allows

D11333: introduce the function containmentGraphicsItemPreview

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY binded to the desktopview function containmentItemForActivity usable

D11316: Components for Cards

mart added a comment. In D11316#225668 , @apol wrote: > Worked for me. Had to expose the components in the qmldir: > > diff --git a/src/qmldir b/src/qmldir > index f262452..2275600 100644 > --- a/src/qmldir > +++ b/src/qmldir

D11190: Make sure we are taking into account hte size of the element when styling

This revision was automatically updated to reflect the committed changes. Closed by commit R858:c41339d7ed30: Make sure we are taking into account hte size of the element when styling (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D11308: Use the default Plasma wallpaper on the lock screen

richardbowen added a comment. Blue screen is fine with me but hey, I like blue. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin Cc: richardbowen, zzag, Pitel, progwolff, abetts, hein, mart, graesslin, plasma-devel,

D11316: Components for Cards

mart added a comment. now it's on top of master and qmldir has all the public files REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11316 To: mart, #kirigami, davidedmundson Cc: apol, ngraham, davidedmundson, progwolff, plasma-devel, mart, hein

D11316: Components for Cards

mart updated this revision to Diff 29514. mart added a comment. - add to qmldir - Merge branch 'master' into mart/Card - add more items to qmldir REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29502=29514 BRANCH mart/Card REVISION DETAIL

D11308: Use the default Plasma wallpaper on the lock screen

Pitel added a comment. +1 for picture instead of blue. With the current UI I would really appreciate option to choose text color independently on plasma color scheme (and such option would solve any static picture). Other possibility I was thinking about was 50 % opaque (default black)

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. In D11308#225711 , @hein wrote: > > The blue background was not particularly well-received. > > Are you sure you are not reacting to a loud minority? The bright background has some practical benefits, e.g. it allows

D11308: Use the default Plasma wallpaper on the lock screen

zzag added a comment. In D11308#225401 , @mart wrote: > Sadly, the current design doesn't really allow for arbitrary wallpapers (and since is possible already to put any image, that's quite a problem) > if a wallpaper should become the

D11072: [Active Window Control] Show window title when app name is missing

martinkostolny added a comment. If you have write access, you can push it to git directly. Otherwise let me know, I can push it for you with your name as the original author :). REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11072

D10753: Provide the source selection as a contextual action

cfeck added a comment. Was this committed? REPOSITORY R134 Discover Software Store BRANCH sourcesUI REVISION DETAIL https://phabricator.kde.org/D10753 To: apol, ngraham Cc: cfeck, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10837: bad textarea width for rename file if filename too short

Pitel added a comment. @painlessroaster is not me. What gave you impression he is? REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma, hein Cc: Pitel, cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed,

D11072: [Active Window Control] Show window title when app name is missing

Pitel added a comment. I do not have write access. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11072 To: Pitel, #plasma, martinkostolny Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [kdecoration] refine shadows

zzag added a comment. In D11069#226041 , @ngraham wrote: > Right, and I can accept that. Visually, I feel like the bottom shadow is a bit too stark and eye-catching. There's a very dark strip right under the bottom of the window that I find a

D11175: [kstyle] refine shadows

zzag added a comment. Please note, I didn't add getters because params struct: - is internal - that's const - that's struct and structures have public fields by default REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11175 To: zzag, #breeze, #vdg,

D10837: bad textarea width for rename file if filename too short

cfeck added a comment. Was this already committed? REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma, hein Cc: cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10837: bad textarea width for rename file if filename too short

ngraham added a comment. Looks like no. I'll be happy to commit it shortly... REVISION DETAIL https://phabricator.kde.org/D10837 To: painlessroaster, #plasma, hein Cc: cfeck, anemeth, ngraham, plasma-devel, hein, davidedmundson, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11316: Components for Cards

davidedmundson added inline comments. INLINE COMMENTS > CardsLayoutGallery.qml:83 > +Kirigami.AbstractCard { > +Layout.fillWidth: true > +showClickFeedback: true Why is it the responsiblility of the user of a CardLayout to set Layout.fillWidth: true

D10837: bad textarea width for rename file if filename too short

ngraham added a subscriber: Pitel. ngraham added a comment. Looks like the patch no longer applies. Radek, can you re-base this on master? You can do this with `git pull --rebase origin master` Also, are you @pitel? If so, it's a bit confusing to have two accounts for the same person;

D11309: Use the default Plasma wallpaper on the login screen

ngraham added a comment. Hmm, doesn't apply for me: This diff is against commit 5286b919498174dbde7b867e166ac45f2032d443, but the commit is nowhere in the working copy. Try to apply it against the current working copy state?

D11335: [System Tray] Fix hiding applets with HiddenStatus

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The `effectiveStatus` didn't take it into account. TEST PLAN

D11308: Use the default Plasma wallpaper on the lock screen

hein added a comment. The argument that it's a semantic abuse of the highlight color is quite convincing to me. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin Cc: richardbowen, zzag, Pitel, progwolff, abetts, hein,

D11333: introduce the function containmentGraphicsItemPreview

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. ShellCorona only creates the containment in currentActivityChanged, so this swiping stuff isn't going to work until you've first switched containment an existing

D11308: Use the default Plasma wallpaper on the lock screen

abetts added a comment. +1 REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin Cc: abetts, hein, mart, graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11306: Give the "Clear History" button some text

ngraham added a comment. I agree that consistency is important! For that reason, I would propose adding text everywhere. Buttons without text are inherently ambiguous unless their icons are //perfect// (and even a broom icon doesn't quite get there IMHO, though it's better). I know

D11308: Use the default Plasma wallpaper on the lock screen

hein added a comment. > The blue background was not particularly well-received. Are you sure you are not reacting to a loud minority? The bright background has some practical benefits, e.g. it allows people to type in their passwords in dark rooms without a backlit keyboard. There may

D11306: Give the "Clear History" button some text

ngraham added a comment. OK, sounds like a plan! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11306 To: ngraham, #plasma, Fuchs Cc: broulik, zzag, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11309: Use the default Plasma wallpaper on the login screen

davidedmundson updated this revision to Diff 29507. davidedmundson added a comment. The same but different REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11309?vs=29454=29507 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11309

D11306: Give the "Clear History" button some text

Fuchs added a comment. In D11306#225695 , @ngraham wrote: > I agree that consistency is important! For that reason, I would propose adding text everywhere. Buttons without text are inherently ambiguous unless their icons are //perfect// (and

D11309: Use the default Plasma wallpaper on the login screen

davidedmundson commandeered this revision. davidedmundson added a reviewer: ngraham. davidedmundson added a comment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11309 To: davidedmundson, #plasma, #vdg, broulik, abetts, ngraham Cc: davidedmundson,

D11308: Use the default Plasma wallpaper on the lock screen

progwolff added a comment. @hein might be right here. If it's the single-click/double-click thing or this issue here: People who are happy with the status quo won't reach out to us. Maybe we need to discuss at a different place if and how we can learn about the opinion of the majority of

D11166: Simplify display when there's only a single input device and a single output device

This revision was automatically updated to reflect the committed changes. Closed by commit R115:86038b5b8c80: Simplify display when theres only a single input device and a single output… (authored by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D11316: Components for Cards

mart updated this revision to Diff 29502. mart added a comment. - fix last binging loop - update the qrc - up to date qmltypes - take layout spacing into account REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11316?vs=29486=29502 BRANCH mart/Card

D11189: Force a content size into the background style item

apol updated this revision to Diff 29505. apol added a comment. Remove a hardcoded size, so it's there just once. Note this depends on D11190 . REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11189?vs=29111=29505

D11306: Give the "Clear History" button some text

broulik added a comment. Either remove the icon or put it on the right, then I wouldn't really mind this change. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11306 To: ngraham, #plasma, broulik, Fuchs Cc: zzag, plasma-devel, ZrenBot, lesliezhai,

D11306: Give the "Clear History" button some text

ngraham added a comment. How about just "Clear" for the text? That should be short enough even in German, no? The word "history" is pretty redundant anyway. And yeah, I agree that we need a better icon for these. For that, I've filed https://bugs.kde.org/show_bug.cgi?id=391855.

D11306: Give the "Clear History" button some text

Fuchs added a comment. In D11306#225691 , @ngraham wrote: > How about just "Clear" for the text? That should be short enough even in German, no? The word "history" is pretty redundant anyway. Actually the oppposite, if you only do

D11327: [Workspace Options KCM] sync() after writing settings

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Something must have changed in KConfig or so since I've seen the same pattern in various other KCMs lately (e.g. looandfeel) I think you're identifying non-issues.

D11316: Components for Cards

mart added a comment. In D11316#225496 , @progwolff wrote: > There seems to be a problem with the overflow menu: > > F5753673: Screenshot_20180314_121900.png fixed in latest version REPOSITORY

D11306: Give the "Clear History" button some text

Fuchs added a comment. In D11306#225667 , @broulik wrote: > Either remove the icon or put it on the right, then I wouldn't really mind this change. putting it on the right would make it inconsistent with every single plasma and KDE

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. In D11308#225251 , @graesslin wrote: > I think we first need to bring back some background for the UI elements. Otherwise it's too difficult to read. In D11308#225401

D11316: Components for Cards

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in AbstractCard.qml:69 > The following should behave the same and it keeps all the semantic meaning > and it means data flows in the right directions > > implicitHeight: mainLayout.implicitHeight + topPadding + bottomPadding

D11306: Give the "Clear History" button some text

Fuchs added a subscriber: broulik. Fuchs added a comment. In D11306#225671 , @broulik wrote: > Do whatever you want with this button. Okay, recommendation: due to all plasma buttons that have an icon having it on the left (see e.g.

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. Currently dragging active items into the trash bin and saving changes results in setting auto visibility and displaying them at the end of both the system tray and configuration list, so it's not really deleting them from user's point of view. I was wondering,

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. I can no longer reproduce the issue with incorrect visibility state in checkboxes. It seems to be working correctly after last patch. Also, I've added some minor styling suggestions, so it looks a little bit more polished in my opinion. INLINE COMMENTS >

D11309: Use the default Plasma wallpaper on the login screen

ngraham accepted this revision. ngraham added a comment. Thanks for grabbing this, David! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11309 To: davidedmundson, #plasma, #vdg, broulik, abetts, ngraham Cc: davidedmundson, broulik, plasma-devel, ZrenBot,

D7537: KDE logout screen - change black icons & texts to white/greyish

ngraham added a comment. You can abandon the revision in favor of that other one using Phabricator's "Add Action..." menu above the comment field. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7537 To: pekkah, #plasma_workspaces, #plasma, #breeze, mart

D11198: [WIP][libbreezecommon] add box shadow helper

zzag updated this revision to Diff 29535. zzag added a comment. Delete #includes. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11198?vs=29126=29535 REVISION DETAIL https://phabricator.kde.org/D11198 AFFECTED FILES CMakeLists.txt

D11198: [libbreezecommon] add box shadow helper

zzag added a comment. Hugo, could you please review this patch? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11198 To: zzag, #breeze, #vdg, hpereiradacosta Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP][kdecoration] refine shadows

zzag updated this revision to Diff 29540. zzag added a comment. - tweak opacity values - bump strength to 100% - don't use aggregate initialization(available only in >= C++20) REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11069?vs=29197=29540 REVISION

D11069: [kdecoration] refine shadows

zzag added a subscriber: abetts. zzag added a comment. Hugo, could you please review this patch? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot,

D11175: [WIP][kstyle] refine shadows

zzag updated this revision to Diff 29541. zzag added a comment. - don't use aggregate initialization(available only in >= C++20) REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11175?vs=29198=29541 BRANCH shadows REVISION DETAIL

D11175: [kstyle] refine shadows

zzag added a subscriber: abetts. zzag added a comment. See current menu shadows in revision's summary. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11175 To: zzag, #breeze, #vdg, hpereiradacosta Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11069: [kdecoration] refine shadows

ngraham added a comment. I still think the light source is a bit too far up on the Y axis, and the bottom shadow is a bit too big compared to the side shadows. But I won't -1 it, since these new shadows are just so awesome in the aggregate! REPOSITORY R31 Breeze REVISION DETAIL

D11175: [kstyle] refine shadows

zzag added a comment. Hugo, could you please review it? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11175 To: zzag, #breeze, #vdg, hpereiradacosta Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [kdecoration] refine shadows

zzag added a comment. In D11069#226026 , @ngraham wrote: > I still think the light source is a bit too far up on the Y axis, and the bottom shadow is a bit too big compared to the side shadows. But I won't -1 it, since these new shadows are

D11069: [kdecoration] refine shadows

abetts added a comment. What is there left to be done in this implementation? Are we close to shipping? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11069 To: zzag, #breeze, #vdg, hpereiradacosta Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel,

D11069: [kdecoration] refine shadows

zzag added a comment. Oh, sorry, I misunderstood you. Bottom shadows should be bigger than side shadows because shadows are casted from north. :) For example, raise a light source above the title bar and look at the window from infinity(I wish I could have such sight). REPOSITORY R31

D11069: [kdecoration] refine shadows

ngraham added a comment. In D11069#226037 , @zzag wrote: > Oh, sorry, I misunderstood you. Bottom shadows should be bigger than side shadows because shadows are casted from north. :) > > For example, raise a light source above the title bar

D11069: [kdecoration] refine shadows

zzag added a comment. In D11069#226036 , @abetts wrote: > What is there left to be done in this implementation? If you're happy about current look of the shadows than nothing. :) I'm still waiting for KWin patches to be reviewed.