KDE CI: Plasma systemsettings kf5-qt5 SUSEQt5.9 - Build # 137 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.9/137/ Project: Plasma systemsettings kf5-qt5 SUSEQt5.9 Date of build: Thu, 22 Mar 2018 09:18:34 + Build duration: 10 min and counting JUnit Tests

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

broulik added inline comments. INLINE COMMENTS > breezewindowmanager.cpp:100 > +#if QT_VERSION >= QT_VERSION_CHECK(5, 11, 0) > +#include > #endif Using private API will lock Breeze to that specific Qt version it was compiled with, requiring a rebuild. This has imho shown to be quite painful

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

volkov added a comment. https://codereview.qt-project.org/224251 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11573 To: volkov, #breeze Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 249 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.9/249/ Project: Plasma plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Thu, 22 Mar 2018 11:49:32 + Build duration: 1 min 46 sec and counting CONSOLE

Plasma Sprint topics

Hello Plasmoids, with plasma sprint drawing closer, I wanted to start a etherpad to collect the topics for Plasma Sprint: https://notes.kde.org/p/plasma-sprint-2018-topics Please fill-in. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B

D11558: Don't show cache memory in systemloadviewer bars

rkflx added a comment. In a sense the cache tells me about aggregated memory pressure from the past (because the cache will only slowly fill up again after it was squeezed), and the unused memory is a metrics showing the current memory pressure. I find it useful, and apparently when it

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 85 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/85/ Project: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 22 Mar 2018 11:49:32 + Build duration: 1 min 32 sec and counting

D11558: Don't show cache memory in systemloadviewer bars

davidedmundson added a comment. Unless you know how much of that cache was actually read back, you have absolutely no knowledge of whether the cache was utilised properly or not. In your example seeing the cache value stay "good" is giving you the same result as seeing the free memory

D11558: Don't show cache memory in systemloadviewer bars

rkflx added a comment. In D11558#231516 , @davidedmundson wrote: > I'm not sure we're talking about the same place. This is the little overview applet, systemloadviewer > > F5762570: Screenshot_20180322_115217.png

D11558: Don't show cache memory in systemloadviewer bars

davidedmundson added a comment. > It's a power user tool anyway, I'm not sure we're talking about the same place. This is the little overview applet, systemloadviewer F5762570: Screenshot_20180322_115217.png KSysguard is the power tool.

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY ... instead of X11 API to initiate window movement by a window manager. It works correctly when

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

volkov added a comment. IIRC, the X server floors coordinates, while Qt rounds them. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11573 To: volkov, #breeze Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D11175: [kstyle] refine shadows

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Ship it, thanks ! REPOSITORY R31 Breeze BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11175 To: zzag, #breeze, #vdg, hpereiradacosta Cc: abetts,

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

davidedmundson added a comment. > Note that now globalPos is used when creating QMouseEvent that > triggers window movement. Otherwise QMouseEvent will take it > from QCursor::pos() with integer coordinates received from the > X server, which may differ from coordinates rounded by Qt for

D11175: [kstyle] refine shadows

zzag requested review of this revision. zzag added a comment. F5762842: mdi-shadows.png //Shadows in Qt Designer// It's hard to see them because background is gray... I couldn't find another app with MDI, sorry. :( REPOSITORY R31 Breeze

D11175: [kstyle] refine shadows

zzag updated this revision to Diff 30238. zzag added a comment. This revision is now accepted and ready to land. - fix MDI child window shadows REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11175?vs=29541=30238 BRANCH shadows REVISION DETAIL

D11069: [kdecoration] refine shadows

hpereiradacosta added a comment. First, I am now running this set of patch routinely and think these new shadows are gorgeous on a dayly usage. (I think the default is too large to my taste, but using a 70% shadow strenght and medium size, I'm quite happy with the result). So no regret with

D11175: [kstyle] refine shadows

zzag planned changes to this revision. zzag added a comment. Fix MDI child window shadows. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11175 To: zzag, #breeze, #vdg, hpereiradacosta Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11175: [kstyle] refine shadows

hpereiradacosta added a comment. In D11175#231610 , @zzag wrote: > Fix MDI child window shadows. I have pushed a fix to the "current" shadows already. so you would need to rebase this patch to master. (I did it locally, this will create

Experience on wayland regressed

Hi, Since the recent removal of QT_QPA_PLATFORM=wayland, we lost some functionality. At the moment it seems that kded is being ran as xcb so the per-screen scaling isn't being set up. Also system settings shows the behavior for xcb instead of the one for wayland also with the per-display UX

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

davidedmundson added a comment. +++ to using this. However, I think we should at least try to get this as public API in Qt, rather than using internals. Breeze is far from the only case where someone would want to do this and QWindow has other system calls it seems to make sense to

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 - Build # 112 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.9/112/ Project: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 Date of build: Thu, 22 Mar 2018 11:49:32 + Build duration: 32 min and counting

D11175: [kstyle] refine shadows

zzag added a comment. In D11175#231614 , @hpereiradacosta wrote: > In D11175#231610 , @zzag wrote: > > > Fix MDI child window shadows. > > > I have pushed a fix to the "current" shadows

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 116 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/116/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 22 Mar 2018 15:03:33 + Build duration: 51 min and counting JUnit Tests Name: (root)

D11175: [kstyle] refine shadows

zzag added a comment. I'd like to land it but KWin patches haven't landed yet. REPOSITORY R31 Breeze BRANCH shadows REVISION DETAIL https://phabricator.kde.org/D11175 To: zzag, #breeze, #vdg, hpereiradacosta Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11175: [kstyle] refine shadows

hpereiradacosta added a comment. >> I have pushed a fix to the "current" shadows already. so you would need to rebase this patch to master. (I did it locally, this will create some minor conflicts). >> I also have a local patch for fixing the MDI shadows on top of this patch, if

D11175: [kstyle] refine shadows

zzag added a comment. In D11175#231649 , @hpereiradacosta wrote: > Still, you'll probably need to rebase your patch to the current master (because of the fix I introduced above) I already rebased onto

D11561: fix typos in UI strings

ivan accepted this revision. ivan added a comment. You can also switch to 'can't' as far as I'm concerned REPOSITORY R845 Plasma Vault BRANCH master REVISION DETAIL https://phabricator.kde.org/D11561 To: schwarzer, ivan, davidedmundson Cc: plasma-devel, ZrenBot, lesliezhai,

Re: Experience on wayland regressed

Am 22. März 2018 15:54:22 MEZ schrieb Aleix Pol : >Hi, >Since the recent removal of QT_QPA_PLATFORM=wayland, we lost some >functionality. At the moment it seems that kded is being ran as xcb so >the per-screen scaling isn't being set up. Also system settings shows >the behavior

D11584: Set a transient parent for SNI context menus

fvogt added a comment. The blank line deletion should be ok, but someone should test on X11 as well. I don't expect any regressions there though. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11584 To: fvogt, #plasma Cc: plasma-devel, ZrenBot,

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

graesslin added a comment. In general I like the idea and that should be extended to Wayland as well, but private API is a no-no for breeze. That has huge runtime breakage potential. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11573 To: volkov, #breeze Cc:

Re: Experience on wayland regressed

Am 2018-03-22 19:13, schrieb Martin Flöser: Am 22. März 2018 15:54:22 MEZ schrieb Aleix Pol : Hi, Since the recent removal of QT_QPA_PLATFORM=wayland, we lost some functionality. At the moment it seems that kded is being ran as xcb so the per-screen scaling isn't being set up.

D11584: Set a transient parent for SNI context menus

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Those had no transient parent set, so they got displayed somewhere, most of the time on the wrong screen. Also pass the

D1231: Add Remote Access interface to KWayland

romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:430 > +target_link_libraries( testRemoteAccess Qt5::Test Qt5::Gui > KF5::WaylandClient KF5::WaylandServer) > +add_test(kwayland-testRemoteAccess testRemoteAccess) > +ecm_mark_as_test(testRemoteAccess) `add_test(NAME

Re: Experience on wayland regressed

>At the moment it seems that kded is being ran as xcb so the per-screen scaling isn't being set u All scaling will be half-broken since that change anyway. Running clients in xwayland means we lose all client high DPI support. ​>. Also system settings shows the behavior for xcb instead of the

D11584: Set a transient parent for SNI context menus

fvogt added a comment. Urgh, arc. I'll split again. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11584 To: fvogt, #plasma Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11584: Set a transient parent for SNI context menus

fvogt updated this revision to Diff 30248. fvogt added a comment. libdbusmenu-qt: Remove nonexistant actions directly from the menu The getLayout response handler compares the new list of actions with the current actions in the menu and calls deleteLater on all actions which aren't

D11586: libdbusmenu-qt: Remove nonexistant actions directly from the menu

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY The getLayout response handler compares the new list of actions with the current actions in the menu and calls deleteLater on

Re: Experience on wayland regressed

Am 22. März 2018 20:36:38 MEZ schrieb David Edmundson : >>At the moment it seems that kded is being ran as xcb so >the per-screen scaling isn't being set u > >All scaling will be half-broken since that change anyway. >Running clients in xwayland means we lose all

D11567: Fix use of assert/crash when removing global shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R119:db311474f048: Fix use of assert/crash when removing global shortcut (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11586: libdbusmenu-qt: Remove nonexistant actions directly from the menu

fvogt added a comment. Looking at the `WAYLAND_DEBUG` output I think I'm closer to understanding the issue now. When the `QMenu::popup` method is called, the chain "opened Event -> LayoutChanged -> GetLayout" gets started. The menu calculates its size and position, and sometime later

D11571: [Battery Monitor] Support "Gaming Input Battery type"

broulik created this revision. broulik added reviewers: Plasma, fvogt, dollinger. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Gives them a nicer icon. The icon does not yet

D11571: [Battery Monitor] Support "Gaming Input Battery type"

anthonyfieroni added a comment. @broulik, does it makes sens, when batteries isn't available (as your screenshot) to be shown, the icon of next device in the list, in systray ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11571 To: broulik, #plasma,

D11571: [Battery Monitor] Support "Gaming Input Battery type"

broulik added a comment. In D11571#231359 , @anthonyfieroni wrote: > @broulik, does it makes sens, when batteries isn't available (as your screenshot) to be shown, the icon and its percentage of next device in the list, in systray ? I

D11591: Remove anchors in layout in wallpaper config

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Looks literally identical No more warnings

D11590: Add mutex round static member used in a thread

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY BackgroundFinder runs in a separate thread,

Re: Experience on wayland regressed

Already proposed. To summarise, we have: My patch to change the default default qpa: https://codereview.qt-project.org/#/c/224225/ Which is what I thought Johan was clearly making all his patches in order to change, yet somehow it didn't materialise so he asked me to submit it to get feedback.

D11590: Add mutex round static member used in a thread

anthonyfieroni added inline comments. INLINE COMMENTS > backgroundlistmodel.cpp:532 > > -m_suffixes = suffixes.toList(); > +s_suffixes = suffixes.toList(); > } Potentially it still can produce a crash, the function returns a reference to list, simultaneously read/write

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 30189. Kanedias added a comment. Remove override fix REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=30092=30189 BRANCH fix-clang REVISION DETAIL https://phabricator.kde.org/D1230 AFFECTED FILES

D11584: Set a transient parent for SNI context menus

fvogt updated this revision to Diff 30251. fvogt added a comment. Now for real. Please arc, cooperate. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11584?vs=30250=30251 BRANCH snitest REVISION DETAIL https://phabricator.kde.org/D11584

D11584: Set a transient parent for SNI context menus

fvogt updated this revision to Diff 30250. fvogt added a comment. Split into https://phabricator.kde.org/D11586 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11584?vs=30248=30250 BRANCH snitest REVISION DETAIL

D11584: Set a transient parent for SNI context menus

davidedmundson added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:63 > onClicked: { > -var pos = plasmoid.nativeInterface.popupPosition(taskIcon, 0, 0); > +var pos = plasmoid.nativeInterface.popupPosition(taskIcon, mouse.x, > mouse.y); > This change is