D7724: [ListItemBase] Open options menu on right click

ngraham added a comment. I'd also prefer for the menu to open under the mouse, if it's not ridiculously difficult to implement. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D7724 To: broulik, #plasma, #vdg, drosca Cc: ngraham, plasma-devel,

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

abetts added a comment. Can it say something like "Unlocking failed. Check your keyboard layout" ? I feel it is more generic. Also, will this message show even though there is only one keyboard layout enabled? Or will it only show when there are multiple layouts? REPOSITORY R120 Plasma

D12498: Fully remove `Application Name` from Details panel

sharvey updated this revision to Diff 33000. sharvey added a comment. - Correct for use of `isEmpty()`; changed `Action ID` to simply `ID` REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12498?vs=32993=33000 BRANCH remove-appname

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

ngraham added a comment. I dunno about "Check your keyboard layout". Would we say "Check your caps lock key?" Instead, we actually show you whether your caps lock key is pressed or not. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3790 To: broulik,

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

broulik added a comment. We do have a capslock indication that shows up as soon as capslock is enabled. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3790 To: broulik, #plasma, #vdg, ngraham Cc: abetts, ngraham, colomar, gregormi, mart, graesslin,

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

broulik updated this revision to Diff 33013. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Simplify REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3790?vs=9288=33013

D9608: [KScreen Effect] Fade opacity only for transparent windows

davidedmundson updated this revision to Diff 33018. davidedmundson added a comment. A better version REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9608?vs=24579=33018 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9608 AFFECTED FILES

D9951: [KUserProxy] Adjust to accounts service

This revision was automatically updated to reflect the committed changes. Closed by commit R296:6655238c0282: [KUserProxy] Adjust to accounts service (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9951?vs=25552=33017#toc REPOSITORY R296 KDeclarative CHANGES

D7181: [Task Manager] Elide context menu entries

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R119:2bf23482a1bf: [Task Manager] Elide context menu entries (authored by broulik). CHANGED PRIOR TO COMMIT

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

ngraham added a comment. I know, that's what I'm saying. For Caps Lock, we actually show the status. For this, it seems weird not to do the same. In other words, I like your original wording (or something like it) better. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

broulik added a comment. Well, the original design also only showed it on error REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3790 To: broulik, #plasma, #vdg, ngraham Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, Pitel,

D12503: [Desktop Theme KCM] Adjust to changes in other KCMs

This revision was automatically updated to reflect the committed changes. Closed by commit R119:03f29a85739c: [Desktop Theme KCM] Adjust to changes in other KCMs (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12503?vs=33011=33015

D12497: Fully remove "Application Name" from details panel

sharvey added a comment. In D12497#253114 , @ngraham wrote: > No need to abandon this revision; you could pull down master, re-branch, do your changes there, and then issue `arc diff --update D12497`, and it will replace the diff here with what

D12498: Fully remove `Application Name` from Details panel

bruns added inline comments. INLINE COMMENTS > AuthDialog.cpp:345 > // neither isEmpty() or isNull() worked (?) > if (actionDescription.description() == "") { > QFont descrFont(action_label->font()); ` == ""` should be identical to .isEmpty(), please recheck >

D12476: kcm_opengl: Fix retrieval of DRI information

roberts marked an inline comment as done. roberts added inline comments. INLINE COMMENTS > wbauer wrote in opengl.cpp:211 > Using just "/driver" (instead of "/driver/module") makes it display "radeon" > instead of "drm" here as I would expect. > > OTOH, as it already runs lspci to get the

D4353: [Applet Configuration] Add mnemonics for dialog buttons

broulik planned changes to this revision. broulik added a comment. Just tried, porting it to QQC2 will give it auto mnemonics \o/ will look into that REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4353 To: broulik, #plasma, davidedmundson Cc:

D12498: Fully remove `Application Name` from Details panel

sharvey created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY `Application Name` removed from PolicyKit details panel (backend code removed long ago) TEST PLAN

D11961: Add QtQuickSettings

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R124:eb65088efe79: Add QtQuickSettings (authored by broulik). CHANGED PRIOR TO COMMIT

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

broulik updated this revision to Diff 32995. broulik edited the summary of this revision. broulik added a comment. This revision is now accepted and ready to land. - Drop "reload" action REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12503: [Desktop Theme KCM] Adjust to changes in other KCMs

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY - Implement undo delete feature - Introduce `currentIndex`

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9a333b48ca1a: [Folder View] Set Refresh shortcut on Refresh/Reload (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems sane to me since it's only shown for the minority of users with multiple keyboard layouts, for whom this may be a legitimate problem. REPOSITORY R120 Plasma Workspace REVISION

D4281: [Task Manager] Limit context menu width

broulik abandoned this revision. broulik added a comment. Cut-off text is ugly REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4281 To: broulik, #plasma, davidedmundson, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12476: kcm_opengl: Fix retrieval of DRI information

roberts updated this revision to Diff 32999. roberts added a comment. Update to use /driver over /driver/module per review. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12476?vs=32904=32999 BRANCH kcm_opengl_fix_dri_info REVISION DETAIL

D12476: kcm_opengl: Fix retrieval of DRI information

alexeymin added a comment. I've tested this and it seems to work! F5821132: kinfocenter DRI info wayland.png But in wayland I had to add some changes: set `IsDirect = true;` before calling `print_screen_info()` in `get_gl_info_egl_qt()` line ~

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

ngraham added a comment. In D3790#253155 , @abetts wrote: > Also, will this message show even though there is only one keyboard layout enabled? No > Or will it only show when there are multiple layouts? Yes REPOSITORY R120

D12499: kcm_opengl: Update to use /driver over /driver/module per review.

roberts created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. roberts requested review of this revision. REPOSITORY R102 KInfoCenter BRANCH kcm_opengl_fix_dri_info REVISION DETAIL https://phabricator.kde.org/D12499

D12498: Fully remove `Application Name` from Details panel

sharvey updated this revision to Diff 33002. sharvey marked an inline comment as done. sharvey added a comment. - Changed `Not Available` to `Missing` REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12498?vs=33000=33002 BRANCH

D10338: Don't show tooltips for inactive windows

broulik abandoned this revision. broulik added a comment. Since tooltip behavior has been improved and the buttons are actually clickable when the window does not have focus, probably should still show them REPOSITORY R129 Window Decoration Library REVISION DETAIL

D9037: use desktop file actions instead of global shortcuts

davidedmundson added a comment. I have a plan for a kconf_update v2 which would resolve the problem above nicely Probably means this would be 5.14. Otherwise you can copy my 4ae36aee91a23dcb0736418295269da14152

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren updated this revision to Diff 33024. Zren changed the repository for this revision from R131 Plasma Wallpapers to R120 Plasma Workspace. Zren added a comment. Remove `.data()` since it seems to work without it. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

kossebau updated this revision to Diff 33027. kossebau retitled this revision from " [Draft] Port baloo krunner plugin to KDBusRunner" to "[Draft] Port baloo krunner plugin to KDBusRunner". kossebau added a comment. update to latest kdbusrunner REPOSITORY R120 Plasma Workspace CHANGES

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

cfeck added a comment. In D12040#253335 , @Zren wrote: > Remove `.data()` since it seems to work without it. Even with gcc 4.8 (openSUSE Leap)? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12040 To:

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. I use `gcc --version 5.4.0`, so I've no idea. I assume that is a QPointer feature though? We can always check the other DownloadDialog initializations: - Image Wallpapers added `m_newStuffDialog->setWindowModality(...)` 9 months ago: -

D12496: Add .arcconfig

This revision was automatically updated to reflect the committed changes. Closed by commit R121:bd0833f6cb52: Add .arcconfig (authored by sharvey, committed by ngraham). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12496?vs=32986=33032

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

fabianr added a comment. +1 As soon as there are enough tasks in the task bar, that you can not any longer read the title at a glimpse or the tasks start to group the task bar, it looses so much of its usefulness. In groups you have to hover , wait, move the mouse and click to activate

D12063: Add a hidden config option for showing icons on the root level of the menu

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6bc448a8ea7d: Add a hidden config option for showing icons on the root level of the menu (authored by aacid). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12476: kcm_opengl: Fix retrieval of DRI information

wbauer added a comment. I gave the patch a try (openSUSE Leap 42.3 with kernel 4.4). The 3D accelerator info is displayed again now (as with kernel < 3.12), but it shows "drm" as kernel module instead of "radeon" as I would expect. INLINE COMMENTS > opengl.cpp:211 > +dri_info.pci =

D12491: [Mouse Cursor KCM] Improve installation workflow

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12491 AFFECTED FILES

D12491: [Mouse Cursor KCM] Improve installation workflow

This revision was automatically updated to reflect the committed changes. Closed by commit R119:edeb3d3b8773: [Mouse Cursor KCM] Improve installation workflow (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12491?vs=32962=32964

D6313: Support Icon Scale from Icon naming specification 0.13

broulik added inline comments. INLINE COMMENTS > cfeck wrote in kiconloader.h:279 > loadIcon("test", mygroup, 2); > > Which overload is called? Looks like it's always taking the one without `scale`. Meh. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To:

D12494: Show lockscreen controls when hitting a modifier

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY I tend to press left control to wake my

D8054: Show headset icons for devices identifying as "Headset" in Description

guilhermesilva added a comment. Hi guys! Sorry to "necro-bump" this issue, but I wanted to share my opinion on this new approach of setting the device icon. From what I've been seeing in random screenshots of the `plasma-pa` applet, most of the times they all have the same icon:

D9037: use desktop file actions instead of global shortcuts

mart updated this revision to Diff 32982. mart added a comment. - Merge branch 'master' into arcpatch-D9037 - add a config update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9037?vs=23123=32982 BRANCH arcpatch-D9037 REVISION DETAIL

D6864: [System Monitor Applet] Add setting for update interval

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2e129f84ce03: [System Monitor Applet] Add setting for update interval (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6864?vs=17090=32983#toc REPOSITORY R120 Plasma

D9037: use desktop file actions instead of global shortcuts

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krunnerglobalshortcuts.cpp:34 > > -migrateEnabledPlugins(); > +KSharedConfig::Ptr config = >

D7724: [ListItemBase] Open options menu on right click

drosca added a comment. In D7724#253041 , @broulik wrote: > Should we go for it or abandon this? If it gets +1 from VDG. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D7724 To: broulik,

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

ngraham added a comment. Just open a new revision, it's easier. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12479 To: sharvey, davidedmundson, ngraham, #plasma Cc: bruns, abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai,

D10571: [AppletAppearance] Remove d QtObject

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5f59b7338949: [AppletAppearance] Remove d QtObject (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10571?vs=27325=32984 REVISION

D4900: RFC: [Folder View] Use fallback icon if failed to load

broulik abandoned this revision. broulik added a comment. I think this is the wrong layer to do this REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4900 To: broulik, #plasma, hein Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D4281: [Task Manager] Limit context menu width

hein added a comment. Does it still have the issues mentioned above? Because then not really ... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4281 To: broulik, #plasma, davidedmundson, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12496: Add .arcconfig

sharvey created this revision. sharvey added reviewers: ngraham, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Add standard `.arcconfig` file REPOSITORY R121

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

ngraham accepted this revision. ngraham added a comment. LTGM! REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH polish-detail-panel (branched from master) REVISION DETAIL https://phabricator.kde.org/D12479 To: sharvey, davidedmundson, ngraham, #plasma Cc: abetts, plasma-devel,

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

mart added a comment. I like the idea a lot, tough i am not sure i like the implementation: right now is kindof hortogonal to pinned tasks and gets confusing as it has a partial, but not complete overlap. I think this should just be the behavior for pinned tasks, in order to map

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

This revision was automatically updated to reflect the committed changes. Closed by commit R121:b340539eca13: Polish `Details` panel; added Not Applicable to fill otherwise blank spaces (authored by sharvey, committed by ngraham). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE

D12494: Show lockscreen controls when hitting a modifier

ngraham accepted this revision. ngraham added a comment. Works for me. Excellent change; I do exactly the same thing! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D12494 To: davidedmundson, #plasma, broulik, ngraham Cc: ngraham,

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

ngraham added a comment. Since you're doing a lot of work in this repo, perhaps your next patch should be to ad an `.arccconfig` file! :) REPOSITORY R121 Policykit (Polkit) KDE Agent BRANCH polish-detail-panel (branched from master) REVISION DETAIL https://phabricator.kde.org/D12479

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

mart added inline comments. INLINE COMMENTS > Zren wrote in wallpaperplugin.cpp:26 > I copy pasted from `image.cpp` ... which apparently hasn't been touched in 4 > years since the import from kde-workspace. > > - >

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

Fuchs added a comment. In D12462#252982 , @mart wrote: > I like the idea a lot, > tough i am not sure i like the implementation: right now is kindof hortogonal to pinned tasks and gets confusing as it has a partial, but not complete overlap.

D12494: Show lockscreen controls when hitting a modifier

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b9f9581f99ef: Show lockscreen controls when hitting a modifier (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D12495: [Desktop Theme KCM] Workaround bug in FileDialog

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When `FileDialog` is created with `visible` set to `true` it will

D12495: [Desktop Theme KCM] Workaround bug in FileDialog

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:230 > active: false > sourceComponent: FileDialog { > title: i18n("Open Theme") would a Component.onCompleted:

D3837: [Calendar] Optimize Backend

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. marking as request changes based on my comments

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

broulik added a comment. So, should I go forward with this now or abandon it? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3790 To: broulik, #plasma:_design, #plasma Cc: colomar, gregormi, mart, graesslin, plasma-devel, ragreen, Pitel, ZrenBot,

D6864: [System Monitor Applet] Add setting for update interval

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Please add the "." that cfeck said, then ship it REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6864 To: broulik, #plasma,

D7724: [ListItemBase] Open options menu on right click

broulik added a comment. Should we go for it or abandon this? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D7724 To: broulik, #plasma, #vdg, drosca Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

sharvey added a subscriber: bruns. sharvey added a comment. In D12479#252978 , @ngraham wrote: > Since you're doing a lot of work in this repo, perhaps your next patch should be to ad an `.arccconfig` file! :) Hm, can your commit be

D12495: [Desktop Theme KCM] Workaround bug in FileDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c5c756623a34: [Desktop Theme KCM] Workaround bug in FileDialog (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12495?vs=32973=32976#toc REPOSITORY R119 Plasma Desktop

D6795: Honor system font settings

broulik abandoned this revision. broulik added a comment. I've been using it for a while and for 99% of websites it makes no difference as they have a custom font set and for the other 1% (fefe basically) it makes it look weird. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D3982: [Panel Containment] Correctly compare applets without order

broulik abandoned this revision. broulik added a comment. The code I did that broke it was reverted so this doesn't apply anymore. Should be revisited at some point perhaps but this particular patch is moot. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D4979: Add places:/ KIO slave

broulik planned changes to this revision. broulik added a comment. Will revisit shortly (famous last words) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4979 To: broulik, #plasma, hein, dfaure Cc: ngraham, elvisangelaccio, plasma-devel, ragreen, Pitel,

D12497: Fully remove "Application Name" from details panel

sharvey created this revision. sharvey added reviewers: bruns, ngraham, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Remove `Application Name` from details

D12497: Fully remove "Application Name" from details panel

sharvey updated this revision to Diff 32991. sharvey added a comment. - Corrected `Not Applicable` to `Not Available` REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12497?vs=32990=32991 BRANCH remove-appname (branched from master)

D12497: Fully remove "Application Name" from details panel

ngraham added a comment. For a removal patch, I see a suspicious amount of green here... REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12497 To: sharvey, bruns, ngraham, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12497: Fully remove "Application Name" from details panel

sharvey added a comment. In D12497#253108 , @ngraham wrote: > For a removal patch, I see a suspicious amount of green here... Forgot to pull a fresh master after you committed my previous change. Abandoning and reworking. Argh.

D12497: Fully remove "Application Name" from details panel

ngraham added a comment. No need to abandon this revision; you could pull down master, re-branch, do your changes there, and then issue `arc diff --update D12497`, and it will replace the diff here with what you have locally. REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL