D14389: Invert shade button by same logic as keep-above button

andykluger created this revision. andykluger added a reviewer: Breeze. andykluger added projects: Breeze, KWin. Restricted Application edited projects, added Plasma; removed KWin. Restricted Application added a subscriber: plasma-devel. andykluger requested review of this revision. REVISION

D14385: Increase backend header text's left margin

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Give the backend name a bit more room

D14385: Increase backend header text's left margin

This revision was automatically updated to reflect the committed changes. Closed by commit R134:3cd95b4a4f4d: Increase backend header texts left margin (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14385?vs=38460=38462

D14380: Improve sizing of menus

This revision was automatically updated to reflect the committed changes. Closed by commit R858:28bf4d54e191: Improve sizing of menus (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14380?vs=38444=38463 REVISION

D14387: Optimise setting up the palette

apol created this revision. apol added a reviewer: mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY For every setBrush/setColor we're initialising a new QBrush instance that

D14347: Fix blocky text on splash screen when using non-integer scale factor

broulik added inline comments. INLINE COMMENTS > Splash.qml:91 > +// https://bugreports.qt.io/browse/QTBUG-67007 > +renderType: Screen.devicePixelRatio % 1 !== 0 ? > Text.QtRendering : Text.NativeRendering > anchors.verticalCenter:

D14349: Clean up casts

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL

D14350: Make sure for loop does not detach

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL

D14351: Remove unused variables

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL

D14352: Use fuzzy compare for floats

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL

D14353: Improve alignment of types

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. In D14339#297233 , @abetts wrote: > In D14339#297211 , @ngraham wrote: > > > Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon

D14354: Improve weather widget usability

underwit created this revision. underwit added a reviewer: Plasma. underwit added a project: Plasma. Restricted Application added a subscriber: plasma-devel. underwit requested review of this revision. REVISION SUMMARY I changed the weather widget setting for better usability. I removed the

D14339: Remove confusing icons from rotation combobox

gladhorn updated this revision to Diff 38382. gladhorn added a comment. Use preview icon REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14339?vs=38350=38382 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14339 AFFECTED FILES

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. F6137062: kcm_rotation_preview.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14339 To: gladhorn, #plasma, #vdg, ngraham Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. Note: I'm all for text changes, but they should be another independent patch. I was also wondering if it makes sense to use a combo box in the first place - we know it's four options always, should it maybe just be four buttons/radio buttons/something else?

D14355: Fix: systemsettings with breeze-dark theme

ppavel created this revision. ppavel added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ppavel requested review of this revision. REVISION SUMMARY Black category title text is displayed on black background

D14064: Dictionary doesn't have enough time to complete query before resetting by milou

McPain added a comment. ping? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D14064 To: McPain, broulik Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14354: Improve weather widget usability

underwit updated this revision to Diff 38392. underwit added a comment. Perform a search when changing the station list REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14354?vs=38376=38392 REVISION DETAIL https://phabricator.kde.org/D14354

D14352: Use fuzzy compare for floats

broulik added inline comments. INLINE COMMENTS > output.cpp:530 > } > -if (d->scale != other->d->scale) { > +if (qFuzzyCompare(d->scale, other->d->scale)) { > changes << ::scaleChanged; Missing negation REPOSITORY R110 KScreen Library REVISION DETAIL

D14350: Make sure for loop does not detach

broulik added inline comments. INLINE COMMENTS > config.cpp:371 > dbg << "KScreen::Config("; > -for (const auto output : config->outputs()) { > +for (const auto : config->outputs()) { > if (output->isConnected()) { This still calls

D14355: Fix: systemsettings with breeze-dark theme

broulik added a comment. Thanks a lot for your patch! This patch souldn't be neccessary, however, as `QtControls2.Label` should do that automatically. Can you check you have `qqc2-desktop-style` installed? What's the Kirigami version? REPOSITORY R124 System Settings REVISION DETAIL

Re: Discussion for Virtual Desktops and Activities future

On martedì 17 luglio 2018 11:16:29 CEST David Edmundson wrote: > > Yes, if you were to configure it to have 4 desktops per activity and you > > add an activity you get 4 more desktops. > > David shouldn't be more, add an activity you get one new virtual desktop, then you can add more for that

D14354: Improve weather widget usability

kossebau added a comment. Thanks for the patch, I agree with you that live searching is better usability. So far though I had stayed away from implementing that, as I have no idea how the weather service providers like their servers getting more hits once in a while . I would

D13935: Remove audio setup from Phonon KCM

nicolasfella abandoned this revision. nicolasfella added a comment. Abandoning in favor of D14340 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13935 To: nicolasfella, #plasma, sitter Cc: plasma-devel, ragreen, Pitel,

D14349: Clean up casts

This revision was automatically updated to reflect the committed changes. Closed by commit R110:ec381c2e0480: Clean up casts (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14349?vs=38374=38393 REVISION DETAIL

D14351: Remove unused variables

This revision was automatically updated to reflect the committed changes. Closed by commit R110:cd72e176d7a3: Remove unused variables (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14351?vs=38377=38395 REVISION DETAIL

D14352: Use fuzzy compare for floats

gladhorn updated this revision to Diff 38396. gladhorn added a comment. Fixed missing negation REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14352?vs=38378=38396 BRANCH arcpatch-D14352 REVISION DETAIL https://phabricator.kde.org/D14352

D14355: Fix: systemsettings with breeze-dark theme

ppavel added a comment. With `qqc2-desktop-style` installed all works fine. My fail. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D14355 To: ppavel, davidedmundson Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14352: Use fuzzy compare for floats

This revision was automatically updated to reflect the committed changes. Closed by commit R110:a96028fdad12: Use fuzzy compare for floats (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14352?vs=38396=38398 REVISION DETAIL

D14358: Make variable name consistent

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY There is nothing current about currentConfig, this is generic.

D14359: Use inintializers and only create m_saveTimer when needed

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Making the other timers lazy-initialized is more tricky, so

Re: Discussion for Virtual Desktops and Activities future

> shouldn't be more, add an activity you get one new virtual desktop, > then you can add more for that activity if you want? +1 I guess that original David's comment was about when we thought all activities would have the same number of VDs. Cheers, Ivan -- KDE, ivan.cu...@kde.org,

Re: Discussion for Virtual Desktops and Activities future

On Wed, Jul 25, 2018 at 10:43 AM, Marco Martin wrote: > On martedì 17 luglio 2018 11:16:29 CEST David Edmundson wrote: > > > Yes, if you were to configure it to have 4 desktops per activity and > you > > > > add an activity you get 4 more desktops. > > > > David > shouldn't be more, add an

D14355: Fix: systemsettings with breeze-dark theme

broulik added a comment. I wonder why that package wasn't installed, though, I thought it was a dependency of Kirigami or Plasma these days. Perhaps file a bug about this to your distribution. You can abandon this revision then, thanks again. REPOSITORY R124 System Settings REVISION

Re: Discussion for Virtual Desktops and Activities future

> > I don't have a strong opinion about > > * I don't have a strong opinion about what we do in the front end

D14359: Use inintializers and only create m_saveTimer when needed

broulik added inline comments. INLINE COMMENTS > daemon.h:79 > +bool m_monitoring = false; > QTimer* m_changeCompressor; > +QTimer* m_saveTimer = nullptr; This is now uninitialized initially REPOSITORY R104 KScreen REVISION DETAIL

D14361: Remove unused function

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL

D14361: Remove unused function

broulik added inline comments. INLINE COMMENTS > daemon.h:38 > > class Q_DECL_EXPORT KScreenDaemon : public KDEDModule > { Can this cause trouble with ABI since this class is exported? But it's probably just exported as an entry point for KDED and not for use as a library REPOSITORY

D14362: Use unpretty channel name in speakertest

nicolasfella created this revision. nicolasfella added reviewers: drosca, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The speaker test did not work when channel

Re: Discussion for Virtual Desktops and Activities future

On mercoledì 25 luglio 2018 12:12:58 CEST David Edmundson wrote: > Adding 1 would mean having the relevant UIs have a separate add activity / > add a new VD to this activity which needs some quite a few more changes. yeah, i was talking about what would happen in the ui, of course the backend

D14364: Test configId in TestSerializer

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL

D14358: Make variable name consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R104:e40e747c4a13: Make variable name consistent (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14358?vs=38399=38409 REVISION DETAIL

D10344: Create panel on current screen

hoffmannrobert updated this revision to Diff 38411. hoffmannrobert added a comment. Regard focus window position only if manually creating panels. This fixes initial panel placement on wrong screen in dual monitor setup. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D10344: Create panel on current screen

hoffmannrobert marked an inline comment as done. hoffmannrobert added a comment. Sorry for the delay. In Wayland there seems to be a problem with QScreen: creating a panel on the second screen crashes plasmashell in QScreen::size(), called by PanelView::panelConfig()

D14250: Sort update items by completion

This revision was automatically updated to reflect the committed changes. Closed by commit R134:42083fa8ac72: Sort update items by completion (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14250?vs=38142=38413 REVISION

D14211: Collapsible Sidebar Mode

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > GlobalDrawer.qml:188 > + */ > +property bool hideContentWhenCollapsed: true > + The documentation says "show" and actually it kind of makes sense. Same

D14211: Collapsible Sidebar Mode

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R169:6b887b056ce6: Collapsible Sidebar Mode (authored by mart). CHANGED PRIOR TO COMMIT

D14347: Fix blocky text on splash screen when using non-integer scale factor

ngraham updated this revision to Diff 38419. ngraham added a comment. Add the right import (this wqsomehow works without it, so there must be an implicit import somewhere...) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14347?vs=38366=38419

D14211: Collapsible Sidebar Mode

mart added inline comments. INLINE COMMENTS > apol wrote in GlobalDrawer.qml:188 > The documentation says "show" and actually it kind of makes sense. > Same with the property below. corrected and flipped back to show in the landed version REPOSITORY R169 Kirigami REVISION DETAIL

D14326: Fix layout of resolution selection

gladhorn added a comment. In D14326#297253 , @ngraham wrote: > I agree. +1 on how it looks with a combobox. Is there any way to manually remove resolutions so I can get it to use a slider and test that case? Just change the if condition

D14368: Let edidDecodeFraction return float

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY All uses of the function are QQuaternion setters which take floats. REPOSITORY R110 KScreen

D14369: When handing out ownership, use Q_REQUIRED_RESULT - Edid::clone

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14369 AFFECTED FILES src/edid.h

D14370: Simplify Edid::Private::edidParseString

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14370 AFFECTED FILES

D14371: Simplify Edid::Private::parse gamma

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY I do wonder if the division by 100 is right though - and where does the +1 come from? Please

D14350: Make sure for loop does not detach

gladhorn updated this revision to Diff 38426. gladhorn added a comment. Use a temporary const for ranged for REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14350?vs=38375=38426 BRANCH arcpatch-D14350 REVISION DETAIL

D14326: Fix layout of resolution selection

ngraham added a comment. Thanks, that should have been obvious! :p I get the same layout issue as Kai with the slider though. With the slider, the label on the left should be top-aligned. and line up with the slider's line. REPOSITORY R104 KScreen REVISION DETAIL

D14339: Remove confusing icons from rotation combobox

ngraham added a comment. Looks nice! I would approve of using radio buttons or four actual inline buttons instead of a combobox. Also +1 on "No Rotation" instead of "Normal", and for doing that in another patch. REPOSITORY R104 KScreen REVISION DETAIL

D14374: Wayland: fix refresh rate conversion error

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY In KWayland, the refresh rate is mHz, so to show it to the user, divide by 1000. REPOSITORY

D14362: Use unpretty channel name in speakertest

broulik added inline comments. INLINE COMMENTS > sink.cpp:100 > ca_proplist_sets(proplist, CA_PROP_MEDIA_ROLE, "test"); > ca_proplist_sets(proplist, CA_PROP_MEDIA_NAME, > name.toLatin1().constData()); > +ca_proplist_sets(proplist, CA_PROP_CANBERRA_FORCE_CHANNEL, >

D14375: [kdecoration] Make shadows slightly lighter

zzag created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY That's the next iteration of the decoration shadows. TODO: put images REPOSITORY R31 Breeze

D14362: Use unpretty channel name in speakertest

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in sink.cpp:100 > Can you check this is still correct? It doesn't seem to play any sounds here front-left/front-right work for me. Rest is untested because I don't have such fancy hardware. Just to be sure: Is your sink

D14375: [kdecoration] Make shadows slightly lighter

ngraham added a comment. Didn't we already do this? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14375 To: zzag, #vdg, #breeze Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14375: [kdecoration] Make shadows slightly lighter

zzag added a comment. In D14375#297923 , @ngraham wrote: > Didn't we already do this? Yes, we did. They are still a little bit dark, but if you think they are fine, I'm okay to abandon this change. REPOSITORY R31 Breeze REVISION

D14377: Changed variable type to int to display squares instead of rectangles

piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REVISION SUMMARY F6044411: squares fix.png On the left there's the old applet and on the right mine after only changing

D14375: [kdecoration] Make shadows slightly lighter

zzag abandoned this revision. zzag added a comment. Meh, maybe, they are fine. Sorry guys for annoying. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14375 To: zzag, #vdg, #breeze Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 updated this revision to Diff 38440. abhijeet2096 marked an inline comment as done. abhijeet2096 added a comment. - Removed FindSoup.cmake,FindGObjectIntrospection.cmake - Removed FwupdTest - using nullptr instead of NULL - Now using file path instead of file - Now using

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 marked 10 inline comments as done. abhijeet2096 added inline comments. INLINE COMMENTS > apol wrote in FwupdBackend.h:48 > gio doesn't seem necessary anymore? I need it for g_ptr_array_index, g_cancellable_new and similar functions REPOSITORY R134 Discover Software Store

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 updated this revision to Diff 38443. abhijeet2096 added a comment. - Removed the testProceed macro REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14050?vs=38440=38443 REVISION DETAIL https://phabricator.kde.org/D14050

D14380: Improve sizing of menus

apol created this revision. apol added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Add some horizontal margins to menu items. Make sure the menu is reporting

D14380: Improve sizing of menus

apol added a comment. F6138415: Screenshot_20180725_181819.png REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D14380 To: apol, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14380: Improve sizing of menus

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better! REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D14380 To: apol, mart, ngraham Cc: ngraham,

D14375: [kdecoration] Make shadows slightly lighter

ngraham added a comment. Yeah, I think they're already fine. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D14375 To: zzag, #vdg, #breeze Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14374: Wayland: fix refresh rate conversion error

This revision was automatically updated to reflect the committed changes. Closed by commit R110:76cd972a93ff: Wayland: fix refresh rate conversion error (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14374?vs=38430=38456

D14381: Wayland: be consistent about screen name

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14381 AFFECTED FILES

D14377: Changed variable type to int to display squares instead of rectangles

ngraham closed this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D14377 To: piotrkakol, ngraham Cc: davidedmundson, plasma-devel, ngraham, gladhorn, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14384: Renamed dot to square in variables and filenames

piotrkakol created this revision. Restricted Application added a project: Plasma. piotrkakol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D14384 AFFECTED FILES