D11909: Properly use kpackage_install_package

This revision was automatically updated to reflect the committed changes. Closed by commit R31:45ca8d95d543: Properly use kpackage_install_package (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11909?vs=31238=40899 REVISION DETAIL

D15093: Add WireGuard capability.

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Much better now! General notes: - there are various checks on lengths of strings like `str.length() > 0` or `str.length() != 0`: if all you need is check whether a string is

D15093: Add WireGuard capability.

andersonbruce added inline comments. INLINE COMMENTS > pino wrote in wireguard.cpp:175-178 > KConfig already supports comma-separated lists -- just pass QStringList() as > `default` value to readEntry(), so KConfigGroup knows the value is a list. The problem with using the KConfig method is if

D15233: Add a tooltip for the appentry in the kicker

underwit created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. underwit requested review of this revision. REVISION SUMMARY Hello! My improvement shows a tooltip for applications in ther kicker menu. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D15226: Check against QRect whether pointer is inside DecorationButton

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. would adding bool DecorationButton::contains(QPoint) const make sense? INLINE COMMENTS > decoration.cpp:386 > for (DecorationButton *button : d->buttons) { >

D15226: Check against QRect whether pointer is inside DecorationButton

zzag added a comment. In D15226#319409 , @davidedmundson wrote: > would adding > > bool DecorationButton::contains(QPoint) const > > make sense? Yes, it would. I'll add this method. :-) REPOSITORY R129 Window Decoration

D15093: Add WireGuard capability.

jgrulich added inline comments. INLINE COMMENTS > wireguard.cpp:71 > +{ > +regexStrings.ip4Range = new QString( > +"(?:[0-1]?[0-9]?[0-9]|2[0-4][0-9]|25[0-5])"); You can use simpleipv[4,6]validator we have in plasma-nm instead of using everything below. Or maybe QHostAddress can

D15093: Add WireGuard capability.

andersonbruce added a comment. In D15093#319253 , @pino wrote: > Much better now! > > - regarding the UI for all the pre/post scripts: since they are file paths, better use a KUrlRequester widget (limited to local existing files only, no

D15226: Check against QRect whether pointer is inside DecorationButton

zzag updated this revision to Diff 40900. zzag added a comment. Add test REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15226?vs=40876=40900 BRANCH fix-hover-with-zero-spacing REVISION DETAIL https://phabricator.kde.org/D15226

Monday meeting notes for 2018-09-03 (week 36)

Marco: - DONE - Kirigami: * irc and matrix channels, all bridged together (done by Bhushan) * start translations for kirigami gallery in its standalone repo * bugfix: refine when icons get forced to monochrome and when not, should fix mobile issues on some apps getting colored icons

D15245: Start looking for the context from the delegate itself

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Rather than the view, otherwise we don't get to access the view's properties, which may be

D15243: Remove some double look-ups

apol updated this revision to Diff 40919. apol added a comment. Add missing part REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15243?vs=40915=40919 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15243 AFFECTED FILES

D15226: Check against QRect whether pointer is inside DecorationButton

This revision was automatically updated to reflect the committed changes. Closed by commit R129:c9cfd840137b: Check against QRect whether pointer is inside DecorationButton (authored by zzag). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE

Plasma 5.14 Release Announcement

Hi all, please fill in all the exciting stuff you've been working on this release cycle into the following etherpad: https://notes.kde.org/p/plasma_5_14 For Plasma 5.14 I would suggest we let our awesome new promo folks come up with an announcement. What do you think? Thanks Kai Uwe

D15226: Check against QRect whether pointer is inside DecorationButton

davidedmundson accepted this revision. davidedmundson added a comment. thanks REPOSITORY R129 Window Decoration Library BRANCH fix-hover-with-zero-spacing REVISION DETAIL https://phabricator.kde.org/D15226 To: zzag, #kwin, davidedmundson Cc: davidedmundson, plasma-devel, ragreen,

D15226: Check against QRect whether pointer is inside DecorationButton

zzag updated this revision to Diff 40905. zzag added a comment. Add `contais` method REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15226?vs=40900=40905 BRANCH fix-hover-with-zero-spacing REVISION DETAIL

D15243: Remove some double look-ups

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN My apps still work REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL

D15247: Show tooltips in krunner

ngraham added reviewers: Plasma, broulik. ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. The patch does not apply because of an extraneous `milou` in the path for your diff: `milou/lib/qml/ResultDelegate.qml` should

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.11 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.11/19/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.11 Date of build: Mon, 03 Sep 2018 20:42:51 + Build duration: 3 min 17 sec and counting CONSOLE

D15254: Fix Firefox profile location lookup after location has changed

bruns created this revision. bruns added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY When the profile has initially been looked up, the location is saved to the global config.

D15243: Remove some double look-ups

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > broulik wrote in delegaterecycler.cpp:73 > `m_refs.erase(itRef)`? Thanks! > broulik wrote in delegaterecycler.cpp:83 > Unrelated question: Where does this get removed from `items`? They are unused items

D15243: Remove some double look-ups

apol updated this revision to Diff 40947. apol marked an inline comment as done. apol added a comment. Remove another lookup, thanks Kai! REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15243?vs=40919=40947 BRANCH arcpatch-D15243 REVISION DETAIL

D15243: Remove some double look-ups

broulik added a comment. +1 INLINE COMMENTS > delegaterecycler.cpp:73 > +if (*itRef <= 0) { > m_refs.remove(component); > + `m_refs.erase(itRef)`? > delegaterecycler.cpp:83 > +if (items.length() >= s_cacheSize) { > item->deleteLater(); > return;

D14999: [PanelShadows] Use 0 offset for disabled borders on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1cfe69b80d47: [PanelShadows] Use 0 offset for disabled borders on Wayland (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15093: Add WireGuard capability.

pino added a comment. In D15093#319336 , @andersonbruce wrote: > If you as a representative of the plasma-nm philosophy have a preference on which way to go or have a brilliant idea which solves all the problems, I will follow your lead.

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

McPain updated this revision to Diff 40923. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14895?vs=39934=40923 REVISION DETAIL https://phabricator.kde.org/D14895 AFFECTED FILES dataengines/soliddevice/CMakeLists.txt dataengines/soliddevice/soliddeviceengine.cpp

D15247: Show tooltips in krunner

McPain created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY In case of something long in krunner you can't read the whole string because of one line restriction and fixed krunner width.

D11233: Ordered system tray

kives added a comment. I think this is a useful feature to add to KDE. If others disagree with the way @wsdfhjxc implemented it I think they should provide a clear pathway to getting it accepted. As long as this can be implemented in a way that doesn't affect default sorting behavior, it

D15257: Set favicon DB path when when places DB path is retrieved from config

bruns created this revision. bruns added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY When the path of the places DB is fetched from the config, the path of the favicon DB is not

D15256: [Mouse KCM] Avoid changes to touchpads in libinput backend

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Similar to evdev backend we need to ignore touchpad devices explicitly in the libinput backend

D15254: Fix Firefox profile location lookup after location has changed

bruns added a comment. The check for QFile::exists was initially added here: https://github.com/KDE/kde-workspace/commit/5c6e27750605de3bba186c9dbd6a0509b68beb90#diff-57c8456496e7f0219f33e5b735f7e3f3 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D15254

D15228: Export install location for DBUS interfaces via CMake

This revision was automatically updated to reflect the committed changes. Closed by commit R133:bfd3fe9cbe02: Export install location for DBUS interfaces via CMake (authored by bruns). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15228?vs=40880=40936

D15229: Specify minimum version for KScreenlocker, use correct DBUS path

This revision was automatically updated to reflect the committed changes. Closed by commit R120:aab6b5c23ea5: Specify minimum version for KScreenlocker, use correct DBUS path (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

KDE CI: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.11 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.11/16/ Project: Plasma plasma-workspace kf5-qt5 FreeBSDQt5.11 Date of build: Mon, 03 Sep 2018 20:42:51 + Build duration: 5 min 0 sec and counting