D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. this has been bugging me/us for years, glad you finally decided to patch it :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17034 To: filipf, ngraham, #vdg, #plasma Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17032: Fix a few memory leaksASAN: Fix leak in XWindowTasksModel

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D17032 To: kfunk, davidedmundson Cc: davidedmundson,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#362635 , @ngraham wrote: > In D16031#362634 , @rooty wrote: > > > Another fair point: Why not just pick an image that doesn't really interfere with the boxes and

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. In D17034#362739 , @rooty wrote: > > This is actually pretty neat considering Kickoff and Notifications are the only two widgets where this is a noticeable problem. And the icons on the desktop (not a

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. In D16031#362634 , @rooty wrote: > Another fair point: Why not just pick an image that doesn't really interfere with the boxes and icons that much then you don't need blur at all. Because within reason, it's the

D17032: Fix a few memory leaksASAN: Fix leak in XWindowTasksModel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e2ba40a4912a: Fix a few memory leaks (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17032?vs=45850=45854#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. (LOL I accidentally removed the comment) NativeRendering really is the gift that keeps on giving. F6432908: nativerendering.png QtRendering renders a lot better. F6432910: qtrendering.png

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham added a comment. Thing is, if we're going to reduce the blur that much, why not just show the original image? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16031 To: ngraham, #vdg, #plasma, rizzitello, davidedmundson Cc: romangg, davidedmundson,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#362566 , @ngraham wrote: > Thing is, if we're going to reduce the blur that much, why not just show the original image? That's a fair point. Another fair point: Why not just pick an image that doesn't

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

filipf added a comment. In D16031#362072 , @rooty wrote: > People have been complaining about the blur, but is it necessary to do away with it, or is it a better idea to run with it like they do in Windows Fluent Design (Deepin too actually)?

D17025: Perf: Do expensive regexp construction earlier

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. FWIW, if we use the new https://codereview.qt-project.org/#/c/225432/ we can both remove the regex and have all the filtering done in dbus-server which will save even more

D17034: [Kickoff] Fix bad kerning in tab labels

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch explicitly sets the QML text rendering variable for Kickoff tab labels as QtRendering. The effect is that the tab labels

D17032: Fix a few memory leaksASAN: Fix leak in XWindowTasksModel

kfunk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kfunk requested review of this revision. REVISION SUMMARY Trace: Direct leak of 24 byte(s) in 3 object(s) allocated from: #0 0x544cc0 in operator new(unsigned long)

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. **Explanation:** Kerning refers to the spacing between letters in text. It's important to get it right because otherwise the UI can look unprofessional (and ugly). Currently there is a QML bug that renders all

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. NativeRendering truly is the gift that keeps on giving F6432893: nativerendering.png This is what happens if I specify that JobDetailsItem.qml use QtRendering F6432899: qtrendering.png

D17025: Perf: Do expensive regexp construction earlier

apol added inline comments. INLINE COMMENTS > systemtray.cpp:88 > qCDebug(SYSTEM_TRAY) << "ST Found DBus-able Applet: " << > info.pluginId() << dbusactivation; > -m_dbusActivatableTasks[info.pluginId()] = dbusactivation; > +QRegExp rx(dbusactivation); > +

D17034: [Kickoff] Fix bad kerning in tab labels

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. This isn't an acceptable patch, sorry - we can't just randomly sprinkle a different font rasterizer into the UI. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17034: [Kickoff] Fix bad kerning in tab labels

filipf added a comment. In D17034#362786 , @hein wrote: > we can't just randomly sprinkle a different font rasterizer into the UI. Someone's already done this though. Check line 32 on the left here:

D17034: [Kickoff] Fix bad kerning in tab labels

broulik added a comment. Widget explorer also shows this behavior, however this is more a problem of the labels being not aligned to a pixel grid rather than `NativeRendering` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17034 To: filipf, ngraham, #vdg,

D17034: [Kickoff] Fix bad kerning in tab labels

hein added a comment. Thanks, that should probably be reverted, although there might have been some reason I'm unaware of in that case since it also sets the font style to outline rendering. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17034 To: filipf,

D17003: Fix mouse events being withheld from the scrollbar.

hein updated this revision to Diff 45864. hein added a comment. Fix RTL bug REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17003?vs=45777=45864 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17003 AFFECTED FILES

D17022: [Kickoff] Depends on D16988, Enable Esc to close Kickoff and Tab to switch to Search

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY #Summary: #Test Plan: #Subscribers: 1. NEW DIFFERENTIAL REVISION 2. Describe the changes in this new revision. #

D17023: [Kickoff] Depends on D16988, Change search label and username font size

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY Included commits in branch kickoff-visible-and-unfocused-fonts-type: 78eb4b0d4e08 [Kickoff] Depends on D16988

D17020: [Kickoff] Depends on D16988, Reenable hover to show system information

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch reenables the mouseover to show system information function introduced by Nate Graham and tailors it to D16988

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham added a comment. IMHO spread 0.1 doesn't provide enough contrast against the toughest backgrounds: F6432627: Screenshot_20181119_124804.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16879 To:

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

ngraham updated this revision to Diff 45833. ngraham edited the test plan for this revision. ngraham added a comment. Tweak shadows REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16879?vs=45461=45833 BRANCH lock-and-login-screen-contrast-tweaks

D17025: Perf: Do expensive regexp construction earlier

kfunk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kfunk requested review of this revision. REVISION SUMMARY SystemTray::serviceRegistered is called tons of times; the regexp construction inside the for-loop is expensive and should be

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

patrickelectric created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira debugger: Use a stringlist to search in different paths for debugger

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

patrickelectric updated this revision to Diff 45830. patrickelectric added a comment. Typo REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17024?vs=45829=45830 BRANCH fix REVISION DETAIL https://phabricator.kde.org/D17024 AFFECTED FILES

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

patrickelectric updated this revision to Diff 45831. patrickelectric added a comment. - debugger: Use c++11 for REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17024?vs=45830=45831 BRANCH fix REVISION DETAIL https://phabricator.kde.org/D17024

D16918: [brightnesscontrol] Do not change screen brightness on invalid values

anthonyfieroni added a comment. So i made simple script to test, it looks like the problem is that xset dpms force off sleep 1 cat /sys/class/backlight/intel_backlight/max_brightness cat /sys/class/backlight/intel_backlight/brightness cat

D17003: Fix mouse events being withheld from the scrollbar.

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. If you run in arabic/RTL the scrollbars will be on the left. If you add: anchors.left: parent.left It should get automatically flipped to the right

D16990: [kded] Change configuration storage path

broulik added a comment. Can you provide a kconf update script or have it also check the old locations? Losing all screen config after an upgrade is bad. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D16990 To: romangg, #plasma Cc: broulik, plasma-devel, ragreen,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. People have been complaining about the blur, but is it necessary to do away with it, or is it a better idea to run with it like they do in Windows Fluent Design (Deepin too actually)? F6431816: image.png This theme, for

D17006: Compress calls to `updateSize`

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Use of callLater seems like a neat solution, does it make aboutToPopulate redundant? INLINE COMMENTS > GroupDialog.qml:265 > // only update size once the repeater

D16906: Update about KDE text

This revision was automatically updated to reflect the committed changes. Closed by commit R856:639764da6b61: Update about KDE text (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16906?vs=45538=45781 REVISION DETAIL

D16297: [DBusMenuImporter] Don't call removeAction() to avoid an empty QMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R120:73339208cd34: [DBusMenuImporter] Dont call removeAction() to avoid an empty QMenu (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16988: [Kickoff] Make the visible search field unfocused by default

gladhorn added a comment. In D16988#361980 , @ngraham wrote: > There are a lot of good changes in here, like those keyboard navigation improvements! And I appreciate all the work that clearly went into this. However, the problem with huge

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Actually this sounds like it might help our cause. Especially when the search bar can be tabbed into, that's really nice. The problem is that we would like to focus to be on the selected item, such as the one that gets launched when pressing enter. The search should

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. @gladhorn More food for though, by the way: in this patch (and the master) the search field is focused while searching and while navigating the search results - it still accepts input even though you've technically navigated away from it. Should this functionality be

D17006: Compress calls to `updateSize`

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in GroupDialog.qml:265 > I remember looking into this. > > I was thinking this should be: > > (!groupRepeater.aboutToPopulate && visualParent.childCount == > groupRepeater.count) > > As if we're still aboutToPopulate then we

D17006: Compress calls to `updateSize`

davidedmundson added inline comments. INLINE COMMENTS > hein wrote in GroupDialog.qml:265 > The suggested code is the same as the present code, so not sure ... can you > clarify? > > The aboutToPopulate thing is done for the focus-active-task. I'm not sure I > want to replace this with

D16990: [kded] Change configuration storage path

davidedmundson added a comment. Why? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D16990 To: romangg, #plasma Cc: davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17006: Compress calls to `updateSize`

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ab26ebb18b74: Compress calls to `updateSize` (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17006?vs=45780=45785#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D16988: [Kickoff] Make the visible search field unfocused by default

gladhorn added a comment. In D16988#362104 , @rooty wrote: > @gladhorn More food for thought by the way: in this patch (and the master) the search field is focused while searching and while navigating the search results - it still accepts input

D17007: Do hash and hex name based output hashes

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY The hash of an output is based on its name in case no EDID information is available. In order

D16170: [Device Notifier] Restore busy indicator

thsurrel added a comment. Ping ! Anyone could have a look at this patch ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16170 To: thsurrel, #plasma, #vdg, broulik, bruns Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

Conceptual changes to KScreen

Hi all, I've written over the last few days a patch series for KScreen, that restructures part of the code, but more importantly introduces new configuration concepts on a fundamental level. I write this mail to get some feedback on these concepts, if there are aspects I overlooked when

Relicensing of file in plasma-phone-components

Hello everyone, I am writing to you since you have commited to the plasma-phone-components/dialer/src/dialerutils.* code. (Volker in CC list because he raised the current issue, Volker is not committer to files.) Current code is GPL2, which is incompatible with the Apache2 license of

D16898: [kcm] Remove profiles code

dvratil added a subscriber: afiestas. dvratil added a comment. Profiles were supposed to allow various screen layouts per single setup, for instance, if you have your monitor and TV both connected to your PC, you may want to have "Monitor", "Monitor+TV" and "TV-only" profiles. The idea was

D16400: Prefer to set current mode in resolution combobox

volkov closed this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D16400 To: volkov, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Conceptual changes to KScreen

The concept of the global values makes sense. But I think you've over complicated it. I don't think we should retroactively apply global changes to setups. The UX is super confusing, and we have all these state problems that require more and more code on top. All I think is needed is: - we save

D16898: [kcm] Remove profiles code

davidedmundson accepted this revision. davidedmundson added a comment. I remember Alex at the time had a thing that new features should be in master but in #ifdefs so it's easier for other devs to test things than having a giant patchset that no-one can even find and have to keep switching

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. Okay so from what I can tell: (1) Kicker takes the focus off the search field when you go through the results by either mouse or keyboard. This makes it easy to go back to the search field by typing or using the arrow keys (to add more words etc.) (2) Krunner

Monday meeting notes for 19/11/2018

Eike: * I've come back from extended absence + a short vacation, and started going through my giant backlog of tickets today * Out of that came a Task Manager performance improvement, two Kickoff regression fixes and some other bugfix so far * Currently I'm to stem a tide of brokenness in Folder

D16988: [Kickoff] Make the visible search field unfocused by default

chempfling added a comment. In D16988#362160 , @rooty wrote: > Okay so from what I can tell: > > (1) Kicker takes the focus off the search field when you go through the results by either mouse or keyboard. This makes it easy to go back to

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#362206 , @chempfling wrote: > In D16988#362160 , @rooty wrote: > > > Okay so from what I can tell: > > > > (1) Kicker takes the focus off the search field when

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

romangg accepted this revision. romangg added a comment. In D16937#362012 , @ngraham wrote: > You know what, I tried this out and I like it. The differing line widths don't actually seem all that weird when actually using it for a a bit. I think

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty added a comment. my real name is Kresimir Cohar, email address: kco...@gmail.com thanks you guys :D i just realized i have a pseudonym on kde identity... i might have to fix that REPOSITORY R119 Plasma Desktop BRANCH kickoff-leaner-separators (branched from master) REVISION

D16988: [Kickoff] Make the visible search field unfocused by default

romangg added a comment. I like all the changes, but they should go into separate patches: > (1) Keeps the search field visible by default but leaves it unfocused until triggered by the keyboard Patch 1 > (2) Enables the tab key to select/focus the search field just like any

Re: Conceptual changes to KScreen

On 19.11.2018 11:11, Roman Gilg wrote: D1 is at coordinates (0, 0) and has logical size 3840x2160. D2 is therefore at coordinates (3841, 0). Is the single-pixel gap intended, or should that read (3840, 0)?

D17016: Show menu bar, how to re-enable, common shortcut dialog

lsartorelli created this revision. lsartorelli added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lsartorelli requested review of this revision. REVISION SUMMARY Usage example for D17013 and D17014

D16988: [Kickoff] Make the visible search field unfocused by default

romangg added a comment. In D16988#362160 , @rooty wrote: > (1) Kicker takes the focus off the search field when you go through the results by either mouse or keyboard. This makes it easy to go back to the search field by typing or using the

D15855: Port Kickoff to shared view component using single-MouseArea pattern

ngraham added a comment. With the benefit of a good nightly sleep, I can see now that my comment was really passive-aggressive, for which I apologize. You're right, of course. Thanks for the quick fix! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15855

Re: Conceptual changes to KScreen

On Mon, Nov 19, 2018 at 3:00 PM Christoph Feck wrote: > > On 19.11.2018 11:11, Roman Gilg wrote: > > D1 is at coordinates (0, 0) and has logical size 3840x2160. D2 is > > therefore at coordinates (3841, 0). > > Is the single-pixel gap intended, or should that read (3840, 0)? > It should be indeed

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Why does it make it easy? Sorry I have no idea what I was thinking when I wrote that. It doesn't. (I think my point was that it works regardless of the focus being drawn away from it?) > - By default search field looks unactivated but has focus. Arrow

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#362281 , @romangg wrote: > I like all the changes, but they should go into separate patches: Patches that would patch this patch or patches that would each patch master separately? REPOSITORY R119

Re: Conceptual changes to KScreen

On Mon, Nov 19, 2018 at 11:56 AM David Edmundson wrote: > > The concept of the global values makes sense. But I think you've over > complicated it. > > I don't think we should retroactively apply global changes to setups. > The UX is super confusing, and we have all these state problems that

D16988: [Kickoff] Make the visible search field unfocused by default

romangg added a comment. In D16988#362323 , @rooty wrote: > Clipboard works like this but the coding is beyond my abilities. Krunner does this too except it opens up with the search field in focus. This Kickoff patched version can't do that,

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > You can do this as you see fit. I would recommend though in this case to make a patch series where patches depend on each other since otherwise it can become difficult to keep all the independent patches consistent with each other. Excellent. > I believe in

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

This revision was automatically updated to reflect the committed changes. Closed by commit R119:dfce50030dd9: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length… (authored by Krešimir Čohar kco...@gmail.com, committed by ngraham). REPOSITORY R119 Plasma Desktop

D16988: [Kickoff] Make the visible search field unfocused by default

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988 To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17003: Fix mouse events being withheld from the scrollbar.

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks Eike! Can confirm that this fixes the issue, and the code change looks eminently sane. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D16988: [Kickoff] Make the visible search field unfocused by default

ngraham added a comment. Cool, I'm looking forward to most of these changes. And you may yet convince me on the visually-unfocused-search-field-by-default thing. :) Here's the documentation for creating a dependency chain of patches:

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. Thanks! Ironically, I do like it focused too 藍 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988 To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel,

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45820. rooty added a comment. - [Kickoff] Make search field unfocused but visible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45757=45820 BRANCH kickoff-visible-and-unfocused (branched from master)