D21797: do not set a hardcoded minimum size

sitter added a comment. Pre-computation is not going to work 100% because the backtracewidget is actually changing its content based on state (a whole other can of worms that :S). What's the specific problem with wrapped qlabels though? Shouldn't they still correctly hint? I mean, the

D21802: move various properties away from qapp and to kaboutdata

This revision was automatically updated to reflect the committed changes. Closed by commit R871:b428aa049ee6: move various properties away from qapp and to kaboutdata (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21802?vs=59796=59797

D21799: actually set kaboutdata as application aboutdata

This revision was automatically updated to reflect the committed changes. Closed by commit R871:bd205d4d2b75: actually set kaboutdata as application aboutdata (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21799?vs=59784=59791 REVISION

D21797: do not set a hardcoded minimum size

cfeck added a comment. I think I now see why we messed with sizes. There are wrapped QLabels in the dialog, and these break minimum size hints. What we generally do to resolve this issue is to use `setMinimumSize(sizeHint())`. REPOSITORY R871 DrKonqi REVISION DETAIL

D21802: move various properties away from qapp and to kaboutdata

sitter updated this revision to Diff 59796. sitter added a comment. ditch explicit values REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21802?vs=59792=59796 BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21802 AFFECTED FILES

D21802: move various properties away from qapp and to kaboutdata

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. I would leave out the explicit setting of otherwise default values, but people's preferences differ :) INLINE COMMENTS > main.cpp:78 > i18n("(C) 2000-2018,

D21797: do not set a hardcoded minimum size

cfeck added a comment. I guess sizeHint() from a paged dialog doesn't pick all pages, so the correct way to resolve this issue is to iterate over all pages, compute their sizeHint(), and use the combined size as the minium size, see `QSize::expandedTo()`. REPOSITORY R871 DrKonqi

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 214 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/214/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 14 Jun 2019 14:17:10 + Build duration: 1 min 23 sec and counting CONSOLE OUTPUT

D21802: move various properties away from qapp and to kaboutdata

sitter created this revision. sitter added a reviewer: kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this is possible now that we actually call KAboutData::setApplicationData which forwards a whole

D21799: actually set kaboutdata as application aboutdata

kossebau added inline comments. INLINE COMMENTS > main.cpp:89 > QStringLiteral("sp...@kde.org")); > +KAboutData::setApplicationData(aboutData); > qa.setWindowIcon(QIcon::fromTheme(QStringLiteral("tools-report-bug"), > qa.windowIcon())); This is partially

D21797: do not set a hardcoded minimum size

cfeck added a comment. What happens if you (instead/also) remove the next line? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D21797 To: sitter, #plasma Cc: cfeck, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

kossebau added a comment. Compare with DialogPrivate::updateTheme(): https://phabricator.kde.org/source/plasma-framework/browse/master/src/plasmaquick/dialog.cpp$229 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21803 To: kossebau, #plasma Cc:

D21801: force the backtracewidget into loading state when the generator is loading

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this specifically unsets the m_highlighter which absolutely must not be present when in loading

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY With Plasma dialogs & tooltips the mask is only set on the widget itself if compositing is

D21797: do not set a hardcoded minimum size

sitter added a comment. Practically right now nothing, technically I think (?) Qt goes for the sizeHint() by default, so in theory the resize may have an effect. That said, I am not opposed to dropping that call as well if we can agree on that. REPOSITORY R871 DrKonqi REVISION DETAIL

D21725: Use a native application for starting plasma

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:f0647b712c52: Use a native application for starting plasma (authored by apol). CHANGED PRIOR TO COMMIT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 271 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/271/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 14 Jun 2019 15:00:42 + Build duration: 2 min 21 sec and counting CONSOLE OUTPUT

D21797: do not set a hardcoded minimum size

cfeck added a comment. If the backtrace is filled later, and that would cause the minimumSize to change, then it will automatically get propagated to the window. A wordwrapped label is supposed to adapt to any with _or_ any height, so its minimum size is its minimum with and its minimum

D21605: Don't give up if no results arrive after 500ms

fvogt updated this revision to Diff 59789. fvogt marked an inline comment as done. fvogt added a comment. Remove whitespace change. Will land on Monday if no objections. REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21605?vs=59204=59789 BRANCH dontgiveup

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

kossebau updated this revision to Diff 59800. kossebau added a comment. for completeness also remove mask for m_backgroundHints == Plasma::Types::NoBackground REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21803?vs=59798=59800 BRANCH

D21794: Style the session selector to be more Breeze

filipf added a comment. Thanks for the new version, almost there. INLINE COMMENTS > KeyboardButton.qml:25 > +style: QQCS.MenuStyle { > +frame: Rectangle { > +color: PlasmaCore.ColorScope.backgroundColor One more thing that I realized is missing here and

D21794: Style the session selector to be more Breeze

filipf added inline comments. INLINE COMMENTS > ngraham wrote in BreezeMenuStyle.qml:6 > Why does this have to be QQC1? AFAIK we can't style QQC2 Menus :/ There's also another non-style error that pops up. I would suggest to consider import porting for some future date. REPOSITORY R120

D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze

filipf added a comment. @cblack great patch, keep it up! I pushed it to the 5.16 branch so we should already see this improvement in 5.16.1. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21794 To: cblack, #vdg, filipf Cc: apol, plasma-devel,

D21794: Style the session selector to be more Breeze

cblack added a comment. As requested by @apol, here is a screenshot of the menu with the new styling (I'm using a custom colorscheme currently, which is why the menu appears black in this screenshot). F6889655: image.png INLINE COMMENTS > filipf wrote

5.17 Kickoff Meeting

We would typically have a start of cycle Kickoff meeting sometime in the coming week. But there is a Sprint happening next Wednesday to the following Wednesday. I'm also aware that plenty people who normally spend time on Plasma are otherwise engaged and won't be able to take on so much in the

D21794: Style the session selector to be more Breeze

filipf added a comment. Final comments and then it's a ship it from me! INLINE COMMENTS > BreezeMenuStyle.qml:12 > +property color borderColor: PlasmaCore.ColorScope.textColor > +border.color: Qt.rgba(borderColor.r, borderColor.g, borderColor.b, > 0.3) > +

D21794: Style the session selector to be more Breeze

cblack updated this revision to Diff 59809. cblack removed a subscriber: ngraham. cblack added a comment. Remove unneeded property. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59808=59809 BRANCH better-session-menu (branched from

Re: 5.17 Kickoff Meeting

On Fri, Jun 14, 2019 at 7:08 PM Jonathan Riddell wrote: > > We would typically have a start of cycle Kickoff meeting sometime in the > coming week. But there is a Sprint happening next Wednesday to the following > Wednesday. I'm also aware that plenty people who normally spend time on >

D21794: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze

This revision was automatically updated to reflect the committed changes. Closed by commit R120:16d3eb60a984: [sddm-theme] Style the session and keyboard layout selectors to be more Breeze (authored by cblack, committed by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21794: Style the session selector to be more Breeze

cblack updated this revision to Diff 59806. cblack added a comment. Menu border, less hardcoding, and moving the menu style into a seperate file to reduce duplicated code. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59803=59806

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks for restoring my sanity & faith in panels, this annoyed me for weeks :) REPOSITORY R120 Plasma Workspace BRANCH alignpanelmaskhandlingtodialog REVISION DETAIL

D21794: Style the session selector to be more Breeze

cblack updated this revision to Diff 59808. cblack added a comment. Tweak border coloration (steal it from Kirigami) and remove whitespace REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59806=59808 BRANCH better-session-menu (branched

D19389: Rewrite kworkspace logout, shutdown and suspend API

davidedmundson updated this revision to Diff 59811. davidedmundson added a comment. Update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19389?vs=55363=59811 REVISION DETAIL https://phabricator.kde.org/D19389 AFFECTED FILES

D21794: Style the session selector to be more Breeze

cblack updated this revision to Diff 59803. cblack added a comment. Less harcoding & style keyboard button as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21794?vs=59771=59803 BRANCH better-session-menu (branched from master) REVISION

D21794: Style the session selector to be more Breeze

cblack added a comment. @filipf Don't know but the answer is probably a no. INLINE COMMENTS > ngraham wrote in BreezeMenuStyle.qml:6 > Why does this have to be QQC1? 1. Styles are a QQC1 thing (QQC2 components can't take them) 2. The PlasmaComponents.ToolButton's `menu` property won't

D21794: Style the session selector to be more Breeze

ngraham added inline comments. INLINE COMMENTS > BreezeMenuStyle.qml:6 > +import QtQuick.Controls.Styles 1.4 as QQCS > +import QtQuick.Controls 1.3 as QQC > + Why does this have to be QQC1? REPOSITORY R120 Plasma Workspace BRANCH better-session-menu (branched from master) REVISION DETAIL

D21794: Style the session selector to be more Breeze

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Thanks again :) Do you have commit access? INLINE COMMENTS > BreezeMenuStyle.qml:11 > +color: PlasmaCore.ColorScope.backgroundColor > +property color borderColor:

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 272 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/272/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 14 Jun 2019 18:50:27 + Build duration: 8 min 8 sec and counting JUnit Tests Name:

D21810: [desktoppackage] Re-add spacing between inline message and first UI element

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. TBH I really don't like this message anyway. It's so in-your-face. But while it exists, I guess we should make it look prettier. :) INLINE COMMENTS >

D21811: [Calculator] Fix popup size and minimum size for expanded version

ngraham created this revision. ngraham added reviewers: davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY In D21503 , I messed up the popup size and

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

ngraham added a comment. Patch to fix: D21811 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21503 To: ngraham, #plasma, broulik Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel,

D21810: [desktoppackage] Re-add spacing between inline message and first UI element

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch fixes the lack of spacing between the inline message that shows up when widgets and locked and the first UI element

D21810: [desktoppackage] Re-add spacing between inline message and first UI element

filipf updated this revision to Diff 59831. filipf added a comment. - better solution: Layout.bottomMargin - remove string change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21810?vs=59829=59831 BRANCH fix-glued-msg-and-combobox (branched

D21810: [desktoppackage] Re-add spacing between inline message and first UI element

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c11527c04b1a: [desktoppackage] Re-add spacing between inline message and first UI element (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D21690: Only show system total cpu usage by default on high core count machines

ngraham added a comment. @rappelman can you please provide your email address so we can land this patch with correct authorship information? Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21690 To: rappelman, #plasma, #vdg, davidedmundson Cc:

D21815: [sddm-theme] Start moving from QQC1 to QQC2

cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Components that used QQC1 in `sddm-theme/` (excluding the symlinked `components` folder) have

D21815: [sddm-theme] Start moving from QQC1 to QQC2

cblack updated this revision to Diff 59842. cblack added a comment. Looks like this change managed to hide from Arcanist's gaze. Should have been there in the first place. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=59841=59842

D21810: [desktoppackage] Re-add spacing between inline message and first UI element

filipf added a comment. I added double the smallSpacing because it seemed to more closely match the gap between the form layout and the image frame. Thoughts? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21810 To: filipf, #vdg, ngraham Cc: plasma-devel,

D21785: Don't track subsystem status

This revision was automatically updated to reflect the committed changes. Closed by commit R856:37f48b7e4fde: Dont track subsystem status (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21785?vs=59740=59776 REVISION

D21797: do not set a hardcoded minimum size

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY setting the minimum size manually like this is overriding the actual calculated minimum size (as

D21799: actually set kaboutdata as application aboutdata

sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY otherwise kcrash won't be able to determine the bugaddress and without bugaddress the drkonqi

D21785: Don't track subsystem status

broulik added a comment. I think in the options page we don't really have a choice since it's a separate page opened by the user when the extension is already running. If we ever do breaking changes in the extension script and need to check it, we can still reintroduce something.