D23152: [energy kcm] Display Vendor and model

2019-08-22 Thread Méven Car
meven added a comment. In the end it would mean we would have only two categories "Battery" and "Energy" (since I am about to remove the system one). Just to make sure, that's what you suggest @ngraham REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23152 To:

D23334: Remove slideWindow(QWidget*) overload with recent KWindowSystem

2019-08-22 Thread David Faure
dfaure created this revision. dfaure added a reviewer: zzag. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. TEST PLAN Fixes the build after https://phabricator.kde.org/D23213 REPOSITORY R130 Frameworks integration plugin

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

2019-08-22 Thread Méven Car
meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The current behavior to change password is quite unfriendly to say the least. Clicking in a line

D23174: Improve the look of the Activities KCM UI

2019-08-22 Thread Björn Feber
GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop BRANCH improved-activities-kcm-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D23174 To: GB_2, #plasma, #vdg, ivan, ngraham, #kactivities Cc: #kactivities, ivan, ngraham, #vdg, plasma-devel, #plasma,

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

2019-08-22 Thread Méven Car
meven updated this revision to Diff 64278. meven added a comment. Replace Q_FOREACH by for REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23337?vs=64276=64278 BRANCH arcpatch-D23337 REVISION DETAIL https://phabricator.kde.org/D23337 AFFECTED

D23198: Skip mime type check only for files on network mounts

2019-08-22 Thread Méven Car
meven added a comment. In D23198#514335 , @davidedmundson wrote: > > True, but then that implies that KFileItem::isSlow() which has the same code is flawed in the same way. > > It is. We have ironic lockups there. Indeed after

D23342: Add a per-process network information plugin

2019-08-22 Thread Arjen Hiemstra
ahiemstra created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a ksysguard process plugin that provides information about how much data is being used by a certain process. Since

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

2019-08-22 Thread Méven Car
meven added a comment. The issue was highlighted in https://youtu.be/Fl7TWroe2Zw?t=709 REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D23337 To: meven, #plasma, ngraham, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

2019-08-22 Thread Méven Car
meven updated this revision to Diff 64276. meven added a comment. Add a const before a for REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23337?vs=64275=64276 BRANCH arcpatch-D23337 REVISION DETAIL https://phabricator.kde.org/D23337 AFFECTED

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

2019-08-22 Thread Méven Car
meven updated this revision to Diff 64279. meven added a comment. Fix tab order REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23337?vs=64278=64279 BRANCH arcpatch-D23337 REVISION DETAIL https://phabricator.kde.org/D23337 AFFECTED FILES

D23342: Add a per-process network information plugin

2019-08-22 Thread Arjen Hiemstra
ahiemstra marked 2 inline comments as done. ahiemstra added inline comments. INLINE COMMENTS > davidedmundson wrote in network.cpp:74 > why 2? We call parts.at(6) > > Also code style {} Good point. I cannot recall why I used 2 so changed it to 7 now. REPOSITORY R106 KSysguard REVISION

D23342: Add a per-process network information plugin

2019-08-22 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 64295. ahiemstra added a comment. - Reject lines <7 elements instead of <2 REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23342?vs=64293=64295 BRANCH network_plugin REVISION DETAIL

D23334: Remove slideWindow(QWidget*) overload with recent KWindowSystem

2019-08-22 Thread David Faure
dfaure closed this revision. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D23334 To: dfaure, zzag Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

2019-08-22 Thread Björn Feber
GB_2 added inline comments. INLINE COMMENTS > account.ui:227 > > - > - > - > - 0 > - 0 > - > - > + > Add the icon `document-edit` REPOSITORY R128 User Manager BRANCH master REVISION DETAIL

D23198: Skip mime type check only for files on network mounts

2019-08-22 Thread Méven Car
meven added a comment. My last change is more a Proof of Concept : using Solid to avoid mime check. I would be in favor of adding a static function to Solid encompassing this use case. For instance : bool Solid::isMountedOnNetworkShare(const QString ) static; But the good part is

D23342: Add a per-process network information plugin

2019-08-22 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 64293. ahiemstra added a comment. - Add missing header and remove unneeded forward declares - Code style fixes REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23342?vs=64289=64293 BRANCH network_plugin

D23345: Fix mpris plugin in Firefox when Content-Security-Policy is enabled

2019-08-22 Thread Carl Schwan
ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Credit to kbroulik, he did all the work. TEST PLAN Tested in firefox, chromium with Nextclould Music and Youtube REPOSITORY

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

2019-08-22 Thread Méven Car
meven updated this revision to Diff 64275. meven added a comment. Add icon document-edit REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23337?vs=64274=64275 BRANCH arcpatch-D23337 REVISION DETAIL https://phabricator.kde.org/D23337 AFFECTED

D23342: Add a per-process network information plugin

2019-08-22 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > network.cpp:74 > +const auto parts = line.splitRef(QLatin1Char('|'), > QString::SkipEmptyParts); > +if (parts.size() < 2) > +continue; why 2? We call parts.at(6) Also code style {} >

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

2019-08-22 Thread Méven Car
meven added a comment. This is not yet "great" but makes things more usable. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D23337 To: meven, #plasma, ngraham, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23198: Skip mime type check only for files on network mounts

2019-08-22 Thread Méven Car
meven updated this revision to Diff 64283. meven added a comment. Use solid to find network shares REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23198?vs=63859=64283 BRANCH arcpatch-D23198 REVISION DETAIL https://phabricator.kde.org/D23198

D23324: Show progress for PackageKit update fetching

2019-08-22 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 64288. apol added a comment. Center in the updates page REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23324?vs=64238=64288 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23324 AFFECTED

D23342: Add a per-process network information plugin

2019-08-22 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > CMakeLists.txt:21 > + > +if (HAVE_LIBCAP) > +install( This isn't set. libcap_FOUND is > CMakeLists.txt:26 > +CAP_NET_RAW=+ep > +\$ENV{DESTDIR}${CMAKE_INSTALL_FULL_BINDIR}/ksgrd_network_helper)" > +) Can we use

D23350: Chaning default iconSize in systemtray

2019-08-22 Thread Nathaniel Graham
ngraham added a comment. So this is a complaint that comes up a lot. I do see what you mean, and in my opinion, what we need is a dual-mode size control UI that lets you switch between "scale icons to fit in panel", "static icon size", and "n columns". However we don't have a UI that

D23350: Chaning default iconSize in systemtray

2019-08-22 Thread Alexey Min
alexeymin added a comment. I can confirm the issue that tray icons are to small on 4k display REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23350 To: xshram, ngraham Cc: alexeymin, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23350: Chaning default iconSize in systemtray

2019-08-22 Thread Anthony Fieroni
anthonyfieroni added a comment. In D23350#516765 , @ngraham wrote: > So this is a complaint that comes up a lot. I do see what you mean, and in my opinion, what we need is a dual-mode size control UI that lets you switch between "scale icons to

D23350: Chaning default iconSize in systemtray

2019-08-22 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. The label says: > On high DPI systems those values would be scaled up, depending on the DPI So I gather that's not working? If not, we should fix that, not work around

D23350: Chaning default iconSize in systemtray

2019-08-22 Thread Nathaniel Graham
ngraham added a comment. Looks to me that scaling is working just fine for system tray items in your screenshot. It's deliberate that they have that much padding on the top and bottom (at least with the default size settings). REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23152: [energy kcm] Display Vendor and model

2019-08-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. That looks fantastic to me! REPOSITORY R102 KInfoCenter BRANCH dev2 REVISION DETAIL https://phabricator.kde.org/D23152 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n,

KDE CI: Plasma » plasma-nm » stable-kf5-qt5 SUSEQt5.12 - Build # 51 - Failure!

2019-08-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-nm/job/stable-kf5-qt5%20SUSEQt5.12/51/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 22 Aug 2019 16:28:47 + Build duration: 1 min 0 sec and counting CONSOLE OUTPUT

D23248: Make "Network Disconnected" notification low priority

2019-08-22 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R116:b8e7d4c03b39: Make Network Disconnected notification low priority (authored by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D23152: [energy kcm] Display Vendor and model

2019-08-22 Thread Méven Car
meven added a comment. @ngraham How about ? F7269705: Screenshot_20190822_113559.png This is rebased on master and with D23130 applied and with the "Current charge" field added as I felt it was missing.

D23287: Create a plugin framework for processes

2019-08-22 Thread David Edmundson
davidedmundson updated this revision to Diff 64291. davidedmundson added a comment. Split ProcessAttribute into a new file Install headers correctly REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64189=64291 BRANCH master REVISION

D23350: Chaning default iconSize in systemtray

2019-08-22 Thread Vladislav Vekyu
xshram added a comment. In D23350#516738 , @ngraham wrote: > The label says: > > > On high DPI systems those values would be scaled up, depending on the DPI > > So I gather that's not working? If not, we should fix that, not work around

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

2019-08-22 Thread Nathaniel Graham
ngraham added a subscriber: nicolasfella. ngraham added a comment. The text "change password" is not accurate when you're setting up a new user. For that case, it should say "set password". But the new user creation process is really weird and needs to be redone anyway, so maybe that's the

D23350: Chaning default iconSize in systemtray

2019-08-22 Thread Vladislav Vekyu
xshram added a comment. In D23350#516753 , @ngraham wrote: > Looks to me that scaling is working just fine for system tray items in your screenshot. It's deliberate that they have that much padding on the top and bottom (at least with the

D23125: fix bridge master:slave mapping by-name

2019-08-22 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R116:9fccc9a8d599: fix bridge master:slave mapping by-name (authored by sitter). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 104 - Failure!

2019-08-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/104/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 22 Aug 2019 16:29:32 + Build duration: 4 min 26 sec and counting CONSOLE OUTPUT [...truncated

D23342: Add a per-process network information plugin

2019-08-22 Thread Arjen Hiemstra
ahiemstra marked an inline comment as done. ahiemstra added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:26 > Can we use KDE_INSTALL_LIBEXECDIR? We can, if there is a decent way to find executables in libexec, because I couldn't find anything in QStandardPaths.

D22514: Show if KRunner is still searching for more things

2019-08-22 Thread David Edmundson
davidedmundson added a comment. Seems to work. There's some comments from Kai above. INLINE COMMENTS > RunCommand.qml:86 > +margins: units.smallSpacing > +rightMargin: height > +} Does using Kirigami.ActionTextField help with

D23342: Add a per-process network information plugin

2019-08-22 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > ahiemstra wrote in CMakeLists.txt:26 > We can, if there is a decent way to find executables in libexec, because I > couldn't find anything in QStandardPaths. There's nothing at runtime, but we know KDE_INSTALL_LIBEXECDIR_FULL at

D23324: Show progress for PackageKit update fetching

2019-08-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R134:27550f8a6d7f: Show progress for PackageKit update fetching (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23324?vs=64288=64308

D23350: Chaning default iconSize in systemtray

2019-08-22 Thread Vladislav Vekyu
xshram created this revision. xshram created this object with edit policy "Administrators". Herald added a project: Plasma. Herald added a subscriber: plasma-devel. xshram requested review of this revision. REVISION SUMMARY A patch for small icons on 4k displays and it doesn't break icons on

D23324: Show progress for PackageKit update fetching

2019-08-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this looks so much nicer now! REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D23324 To: apol, ngraham Cc: plasma-devel,

D22514: Show if KRunner is still searching for more things

2019-08-22 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > davidedmundson wrote in RunCommand.qml:86 > Does using Kirigami.ActionTextField help with positioning? Since it's using QQC2.TextField, won't it be using a completely different colour scheme? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23342: Add a per-process network information plugin

2019-08-22 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 64310. ahiemstra added a comment. - Use libexec dir for the helper install location - Don't use nonexistant variables REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23342?vs=64295=64310 BRANCH network_plugin

D23342: Add a per-process network information plugin

2019-08-22 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:26 > There's nothing at runtime, but we know KDE_INSTALL_LIBEXECDIR_FULL at > configure time, so we can pass that to the plugin. Oh, that's a good idea, I totally did not think about that. REPOSITORY

D23356: Add ksysguard plugin for taskmanager integration

2019-08-22 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Currently this is all hardcoded in ProcessModel. By moving it into a

D23356: Add ksysguard plugin for taskmanager integration

2019-08-22 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > taskmanager.cpp:23 > + > +#include > +#include Unused > taskmanager.cpp:58 > +const QModelIndex index = m_model->index(i, 0, QModelIndex()); > +if > (!index.data(TaskManager::AbstractTasksModel::IsWindow).toBool()) { >

D21860: Set a font for gtk applications in the fonts kcm

2019-08-22 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 64329. gikari added a comment. - Delegate gtk fonts configuration to Gtk Daemon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21860?vs=64002=64329 BRANCH set-gtk-font-in-fonts-kcm (branched from master)

D21860: Set a font for gtk applications in the fonts kcm

2019-08-22 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 64331. gikari added a comment. - Remove redundant saveFontToGtkSettings method declaration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21860?vs=64330=64331 BRANCH set-gtk-font-in-fonts-kcm (branched from

D23357: Show update issues on a popup instead of as passive messages

2019-08-22 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. So much better! REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D23357 To: apol, ngraham Cc: plasma-devel, LeGast00n,

D21860: Set a font for gtk applications in the fonts kcm

2019-08-22 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 64339. gikari marked 2 inline comments as done. gikari added a comment. - Remove redundant includes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21860?vs=64331=64339 BRANCH set-gtk-font-in-fonts-kcm

D23151: Implement Web Share API through Purpose

2019-08-22 Thread Kai Uwe Broulik
broulik planned changes to this revision. broulik added a comment. It should only add the `navigator.share` stuff if the host side is supported and loaded, in case you run old host with new extension. The setting will be correctly hidden but since it is enabled by default it will still add

D23350: Chaning default iconSize in systemtray

2019-08-22 Thread Nathaniel Graham
ngraham added a comment. In D23350#516835 , @anthonyfieroni wrote: > In D23350#516765 , @ngraham wrote: > > > So this is a complaint that comes up a lot. I do see what you mean, and in my opinion,

D23356: Add ksysguard plugin for taskmanager integration

2019-08-22 Thread Eike Hein
hein added a comment. Do you really need a TasksModel, or is a WindowTasksModel enough? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D23356 To: davidedmundson, #plasma Cc: hein, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D21860: Set a font for gtk applications in the fonts kcm

2019-08-22 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 64342. gikari added a comment. - Remove QStandardPaths as redundant include REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21860?vs=64339=64342 BRANCH set-gtk-font-in-fonts-kcm (branched from master) REVISION

D21860: Set a font for gtk applications in the fonts kcm

2019-08-22 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 64330. gikari marked an inline comment as done. gikari added a comment. - Remove redundant xml stuff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21860?vs=64329=64330 BRANCH set-gtk-font-in-fonts-kcm

D22514: Show if KRunner is still searching for more things

2019-08-22 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > apol wrote in RunCommand.qml:86 > Since it's using QQC2.TextField, won't it be using a completely different > colour scheme? There was some code to make that magically work. (maybe it was that URLInterceptor we removed?) If it doesn't

D23357: Show update issues on a popup instead of as passive messages

2019-08-22 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Otherwise they may disappear. BUG: 411182 REPOSITORY R134 Discover Software Store BRANCH

D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

2019-08-22 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: Plasma, broulik, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Using this Plasma component in an app causes the icons to disappear when using a

D21860: Set a font for gtk applications in the fonts kcm

2019-08-22 Thread Mikhail Zolotukhin
gikari added a comment. Since awesome @nicolasfella committed his changes to Gtk Daemon, I have modified the interface according to it. No more wacky xml stuff, because the daemon became a kded module with the adequate dbus signatures.

D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

2019-08-22 Thread Nathaniel Graham
ngraham updated this revision to Diff 64382. ngraham added a comment. Don't use width: and height: on items in a Layout REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23368?vs=64380=64382 BRANCH port-away-from-WorkspaceComponents.BatteryIcon

D23298: Unify busy spinner appearance on update page

2019-08-22 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of the vastly superior D23357 . REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D23298 To: ngraham, #discover_software_store, apol Cc:

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 332 - Fixed!

2019-08-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/332/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 13 Aug 2019 14:54:07 + Build duration: 31 min and counting BUILD ARTIFACTS

D23357: Show update issues on a popup instead of as passive messages

2019-08-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R134:3c605c3f9c5d: Show update issues on a popup instead of as passive messages (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23357?vs=64336=64363#toc REPOSITORY R134

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 285 - Still unstable!

2019-08-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/285/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 13 Aug 2019 11:24:47 + Build duration: 1 hr 7 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 344 - Fixed!

2019-08-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/344/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 20 Aug 2019 17:46:29 + Build duration: 14 min and counting BUILD ARTIFACTS

Re: Unified git commit message guideline

2019-08-22 Thread Marc Deop i Argemí
On Sunday, 11 August 2019 23:52:55 CEST Roman Gilg wrote: > After looking around a bit what I found to be very interesting was the > Conventional Commits specification[1]. It is based on the AngularJS > commit message policy, which is imo a very well formulated policy. Please make sure to

D23228: Port away from deprecated KWindowSystem API

2019-08-22 Thread Vlad Zagorodniy
zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. > Builds, didn't test yet. Whitelisted shortcuts still work. REPOSITORY R133 KScreenLocker BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D23228 To: dfaure, zzag,

D23228: Port away from deprecated KWindowSystem API

2019-08-22 Thread Vlad Zagorodniy
zzag added a comment. Thank you for doing God's work. ;-) REPOSITORY R133 KScreenLocker BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D23228 To: dfaure, zzag, graesslin, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23228: Port away from deprecated KWindowSystem API

2019-08-22 Thread David Faure
dfaure closed this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23228 To: dfaure, zzag, graesslin, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D23228: Port away from deprecated KWindowSystem API

2019-08-22 Thread David Faure
dfaure added a comment. Thanks for the testing! REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23228 To: dfaure, zzag, graesslin, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,