D24866: Wired setting: improve handling of link negotiation

dvalter added a comment. Looks like a complete fix to #413211 . I've tested it on Arch Linux with different modes. For me Ignore, Auto and 10/100/1000 Mbps modes worked as intended as well as duplex setup for 10 and 100. The only

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 111 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/111/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 04 Nov 2019 14:34:48 + Build duration: 3 min 25 sec and counting CONSOLE OUTPUT

D25074: Disable the restore defaults button if the KCModule says so

davidedmundson added inline comments. INLINE COMMENTS > ModuleView.cpp:427 > d->mHelp->setEnabled(buttons & KCModule::Help ); > -d->mDefault->setEnabled(buttons & KCModule::Default ); > } Not saying this is wrong, but can you explain this change? In https://phabricator.kde.org/D25072

D24893: [Lock Screen] Add option to hide clock when idle

ngraham added a comment. In D24893#558451 , @mart wrote: > clock "always show" is fine too tough Given that the setting will be off by default, its opposite state is clear enough I'd say. It's not the best string ever, but maybe we

D25074: Disable the restore defaults button if the KCModule says so

This revision was automatically updated to reflect the committed changes. Closed by commit R124:fe180972acbb: Disable the restore defaults button if the KCModule says so (authored by ervin). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

Re: KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 111 - Failure!

Issue is just CI being slow on the relevant frameworks changes. It's a false positive, we don't need to act. David

D25140: kcm/fonts: set initial settings correctly

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. LGTM. This now ignores the return value of the `xft.get*` calls, but that seems to be useless anyway: bool KXftConfig::getSubPixelType(SubPixel::Type ) { type =

D25141: Use a RowLayout for laying out ToolBarPageHeader

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. These changes make the KNSQuick components all happy :) F7735334: image.png and F7735337: image.png

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

kmaterka added a comment. Any chance to get this reviewed? :) REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D24843 To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella Cc: plasma-devel, LeGast00n,

D25134: Add KDEClangFormat cmake support

This revision was automatically updated to reflect the committed changes. Closed by commit R120:401d326ba14a: Add KDEClangFormat cmake support (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25134?vs=69240=69283 REVISION

D25074: Disable the restore defaults button if the KCModule says so

ervin updated this revision to Diff 69275. ervin added a comment. Deal with David's comment and realign ModuleView with KCMultiDialog regarding button state management. REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25074?vs=69044=69275 REVISION

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.13/74/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 04 Nov 2019 14:34:47 + Build duration: 2 hr 6 min and counting CONSOLE OUTPUT

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge added a comment. In D25018#558503 , @ahiemstra wrote: > Hmm, I would like to see some smarter sys file handling for this. Right now, multiple calls to getSysFileValue result in the same file being read from disk over and over. While the

D25141: Use a RowLayout for laying out ToolBarPageHeader

ahiemstra updated this revision to Diff 69282. ahiemstra added a comment. - Correctly hide everything if no page actions are set REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25141?vs=69280=69282 BRANCH headerLayout REVISION DETAIL

D25018: Move ACPI battery information from /proc/acpi to /sys

ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. Hmm, I would like to see some smarter sys file handling for this. Right now, multiple calls to getSysFileValue result in the same file being read from disk over and over.

D25074: Disable the restore defaults button if the KCModule says so

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in ModuleView.cpp:427 > Not saying this is wrong, but can you explain this change? > > In https://phabricator.kde.org/D25072 > > we do setEnabled((buttons & Default) && !defaulted) rather than changing > visibility,

D25086: [WIP] Port to KGlobalAccel

davidre updated this revision to Diff 69279. davidre marked an inline comment as done. davidre added a comment. Thanks for spotting! REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69107=69279 BRANCH globalaccel (branched from master)

D25018: Move ACPI battery information from /proc/acpi to /sys

jjorge requested review of this revision. jjorge added a comment. So asking again for feedback, if I understand well how phabricator works ... REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D25018 To: jjorge, davidedmundson, #plasma, ahiemstra Cc: plasma-devel,

Clang Format Update

By the end of tonight there will be a patch in every plasma repo adding a build target called "clang-format" using the new ECM macros. Running "make clang-format" or "ninja clang-format" will tidy up all code in all repos. I have shipped this target now so that all devs can test the upcoming

D25147: Remove gtkrc-2.0 legacy settings

ngraham added a comment. Presumably 5.17 bugfix material assuming we can test it well enough. @apol, does this look sane to you as well? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH remove-legacy-gtkrc-settings (branched from master) REVISION DETAIL

D25147: Remove gtkrc-2.0 legacy settings

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Previously GTK KCM wrote to gtkrc redundant settings lines: 1. `include "path to chosen gtk2 theme"` 2. style

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

ngraham added a comment. In D25144#558663 , @davidre wrote: > In D25144#558630 , @ngraham wrote: > > > However I see a problem with changing "Application Launchers" to "Applications": It implies

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

ngraham added a comment. Oh I see lol. Well I guess my only complaint is with the name chosen for the Plasma category. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25144 To: davidre, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

KDE CI: Plasma » plasma-workspace-wallpapers » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace-wallpapers/job/kf5-qt5%20FreeBSDQt5.13/15/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 04 Nov 2019 18:24:32 + Build duration: 2 hr 12 min and counting

D25145: Focus search field by default

ngraham created this revision. ngraham added reviewers: VDG, Plasma, cfeck. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY In general, apps that have Search Fields always visible put the focus there by

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

davidre added a comment. In D25144#558630 , @ngraham wrote: > However I see a problem with changing "Application Launchers" to "Applications": It implies that the items in that category will give you access to change all the shortcuts for those

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Currently the shortcuts are divided into two lists. "Application Launchers" for shortcuts added via .desktop files (actually

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

davidre added a comment. In D25144#558665 , @ngraham wrote: > In D25144#558663 , @davidre wrote: > > > In D25144#558630 , @ngraham wrote: > > > > >

D25147: Remove gtkrc-2.0 legacy settings

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. This LGTM. Would probably check a variety of configs with a variety of applications just to be on the safe side and make sure there's no visual oddities, but it should be fine. REPOSITORY

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

davidre added a comment. In D25144#558670 , @ngraham wrote: > Hmm, I think that would be confusing. "Session" isn't the name of any user-facing applications. That stuff is really a part of Plasma, both technically speaking, and also in terms of

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

ngraham added a comment. Instead of "Plasma", how about "System Services"? That would match the categories in the Notifications KCM's similar list. However I see a problem with changing "Application Launchers" to "Applications": It implies that the items in that category will give you

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

ngraham added a comment. Hmm, I think that would be confusing. "Session" isn't the name of any user-facing applications. That stuff is really a part of Plasma, both technically speaking, and also in terms of the user expectation. Is there any way we could force it to live in the

D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication

ngraham added a comment. I think so. This is a bugfix. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D25150 To: filipf, #vdg, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D24068: docs: add contributing guide

romangg added a comment. In D24068#558466 , @davidedmundson wrote: > README is really good. > > Did you email kde-devel about this commit policy? I thought you did, but I can't find it. > As someone who regularly commits across many

D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication

filipf added a comment. In D25150#558758 , @ngraham wrote: > I think so. This is a bugfix. OK, I'll land this there then (once the repo gets unbroken). REPOSITORY R124 System Settings BRANCH master REVISION DETAIL

D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Icon view currently sets a dialog-warning emblem on the sidebar icons for KCMs that require root authentication (SDDM, KDE Wallet).

D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication

filipf added a comment. Might also be worth mentioning this now makes it consistent with sidebar view, which doesn't use this emblem. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D25150 To: filipf, #vdg, ngraham Cc: plasma-devel, LeGast00n,

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 254 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/254/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 05 Nov 2019 04:34:47 + Build duration: 4 min 14 sec and counting CONSOLE OUTPUT [...truncated

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kglobalshortcutseditor.cpp:436 > +// Do we have an application with that name? > +KService::List apps = >

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 253 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/253/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 04 Nov 2019 23:45:08 + Build duration: 54 sec and counting CONSOLE OUTPUT [...truncated 484

D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication

filipf added a comment. Would this be an acceptable change for the 5.17 branch? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D25150 To: filipf, #vdg, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 112 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/112/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 05 Nov 2019 00:02:10 + Build duration: 58 sec and counting CONSOLE OUTPUT [...truncated 340

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.13/75/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 05 Nov 2019 00:02:09 + Build duration: 50 sec and counting CONSOLE OUTPUT

D25147: Remove gtkrc-2.0 legacy settings

ervin added a comment. FWIW, LGTM as well, agree with Nate that it likely requires some more extensive testing though. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH remove-legacy-gtkrc-settings (branched from master) REVISION DETAIL https://phabricator.kde.org/D25147 To: gikari,

D25140: kcm/fonts: set initial settings correctly

bshah created this revision. bshah added reviewers: Plasma, fvogt, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY During initial load we check if certain settings are set or not, and if they

D25140: kcm/fonts: set initial settings correctly

fvogt added a comment. That seems like just the order of assignments is wrong and more logic isn't actually needed. What about something like this: KXftConfig::SubPixel::Type spType = KXftConfig::SubPixel::NotSet; // we get subpixel type from config xft.getSubPixelType(spType);

D24879: [ComboBox] Follow focusPolicy

mart added a comment. one thing that may be tried is to use input handlers instead of the mousearea to manage the wheel (tough i am not sure we can already use them in frameworks due to qt version requirements) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D25140: kcm/fonts: set initial settings correctly

bshah added a comment. > That seems like just the order of assignments is wrong and more logic isn't actually needed. What about something like this: Important thing to note is, setSubPixelType doesn't actually write config. It just sets the internal configuration. Actual setting of

D25140: kcm/fonts: set initial settings correctly

bshah updated this revision to Diff 69258. bshah added a comment. update based on fvogt comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25140?vs=69255=69258 BRANCH bshah/fonts REVISION DETAIL https://phabricator.kde.org/D25140 AFFECTED

D24743: Update GTK settings according to Plasma settings

gikari updated this revision to Diff 69259. gikari marked an inline comment as done. gikari added a comment. Fix the typo REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24743?vs=69141=69259 BRANCH gtk-settings-in-respective-kcms

D24893: [Lock Screen] Add option to hide clock when idle

mart added a comment. clock "always show" is fine too tough REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24893 To: broulik, #plasma, #vdg, ngraham Cc: mart, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25140: kcm/fonts: set initial settings correctly

bshah added a comment. OH wait! nvm, I see what you mean.. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25140 To: bshah, #plasma, fvogt, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D24883: [ComboBox] Don't indicate focus when popup is open

This revision was automatically updated to reflect the committed changes. Closed by commit R858:5dc1c74cad6f: [ComboBox] Dont indicate focus when popup is open (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D24879: [ComboBox] Follow focusPolicy

This revision was automatically updated to reflect the committed changes. Closed by commit R858:b1452c37b49c: [ComboBox] Follow focusPolicy (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24879?vs=68586=69256#toc REPOSITORY R858 Qt Quick Controls 2: Desktop Style

D24743: Update GTK settings according to Plasma settings

ervin added a comment. Just a minor thing, otherwise LGTM, I'll let Kai give the last stamp of approval. INLINE COMMENTS > gtkconfig.cpp:113 > +setFont(); > +setFont(); > +setIconTheme(KIconLoader::Group::Desktop); Are you sure you want to call setFont() twice here? That looks

D25064: docs: add contributing guide

davidedmundson added a comment. Let's do all review on D24068 . If that has a ship it, consider this a ship it. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D25064 To: romangg, #plasma Cc: davidedmundson,

monday meeting notes sent for 4/11/2019

Kai Uwe KWin: * Fixed startupfeedback with "resolution independent" cursor size (basically reverting it for this case...) Plasma: * Digital clock date format setting now has live preview * Made Milou use theme.disabledColor to improve readability on dark backgrounds * Turned out to be a bit

D25042: Rename cmake project to KActivityManagerd, remove unused option

This revision was automatically updated to reflect the committed changes. Closed by commit R161:fbcd08aacb5f: Rename cmake project to KActivityManagerd, remove unused option (authored by meven). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE

D24068: docs: add contributing guide

davidedmundson added a comment. README is really good. Did you email kde-devel about this commit policy? I thought you did, but I can't find it. As someone who regularly commits across many many repos if every maintainer enforced their own thing I would really struggle. INLINE