D27360: Go back to saving to sddm.conf

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The SDDM KCM is broken right now because the kde_settings.conf file is never created with the right permissions. This means that the

D27362: Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs

jakobkummerow created this revision. jakobkummerow added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jakobkummerow requested review of this revision. REVISION SUMMARY Getting CPU information starts with reading /proc/cpuinfo into a

D27367: fix activity runner

McPain created this revision. McPain added reviewers: broulik, ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY Activity runner is now useless: m_activities is always nullptr in

D27367: fix activity runner

davidedmundson added a comment. Urgh. I suspect this was a hidden bug from when runnermanager never emitted teardown. Given how runnermanager currently seems to work, this patch does make sense. INLINE COMMENTS > activityrunner.cpp:79 > { > +delete m_activities; > +

D27365: fix condition in KonsoleProfiles::run

McPain created this revision. McPain added a reviewer: heikobecker. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY Looks like there's a typo and it's not intended to exec "konsole --profile" with empty profile

How to contribute to Plasma Mobile

Hi guys, I'm an IT student who would like to contribute to PM project. I read on the main site that I can obtain more informations via this mailing list. I know how to write code in C++ with Qt and I have basic knowledge of qml and Kirigami; I also have lots of experience with GNU/Linux systems

D27362: Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs

ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. I agree with what @cfeck says. I can also already think of at least one case where even a 256KiB buffer would be too small, which is a dual-cpu Epyc system, where you can

D27276: Powerdevil: allow using qt5widget classes with powerdevil

alnikiforov abandoned this revision. alnikiforov added a comment. Abandoning in favour of D27279 and D27357 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D27276 To: alnikiforov, apol,

D27365: fix condition in KonsoleProfiles::run

McPain added a comment. Happens to be a regression after 2f3bcfa REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27365 To: McPain, heikobecker Cc: plasma-devel, Orage, LeGast00n,

D27362: Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs

jakobkummerow added a comment. cfeck: Sure, an even better long-term fix would be to stop depending on a hard-coded buffer size. Interleaved reading and parsing would be one way to achieve that; another way would be a dynamic buffer size: start small, and if it's too small then allocate a

D27362: Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs

cfeck added a comment. From that bug report: Newer x86_64 kernels, however, allow up to 4096 CPUs, so either the buffer needs to be much bigger, or we should do interleaved /proc/cpuinfo reading and parsing. REPOSITORY R106 KSysguard REVISION DETAIL

D17217: Implement free memory notifier

McPain added a comment. In D17217#412961 , @davidedmundson wrote: > > It would just be nice not to have to think about this stuff > > There is an OOM killer. That OOM killer is faster than a human, has access to more info about processes

D27368: [Styles KCM] Set style display name as window title

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bc5c45e8aa9d: [Styles KCM] Set style display name as window title (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27368?vs=75607=75612

Re: 2 kirigami fixes for a point release

On jeudi 13 février 2020 09:46:20 CET David Edmundson wrote: > > Kirigami seems to be rather unstable, I wonder if anything can be done to > > improve upon that [*]. > > One important thing seems to have been getting sloppy in those repos; > mandatory code reviews. > That's an easy thing to

D27364: Kirigami: Convert license headers to SPDX markers

cordlandwehr created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX markers and add license files as required by REUSE specification. REPOSITORY

D27368: [Styles KCM] Set style display name as window title

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `StyleConfigDialog` doesn't actually load the config plugin, so it doesn't use the argument for

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

jakobkummerow updated this revision to Diff 75617. jakobkummerow added a comment. Minor update: size_t instead of int. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27362?vs=75616=75617 REVISION DETAIL https://phabricator.kde.org/D27362 AFFECTED FILES

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. That's even better, thanks. Do you have commit access? REVISION DETAIL https://phabricator.kde.org/D27362 To: jakobkummerow, davidedmundson, ahiemstra Cc: ahiemstra, cfeck,

D27199: [Applet]Update layout based on T10470

ngraham added a comment. Can reproduce; it's consistent. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

Re: How to contribute to Plasma Mobile

Hi Yari, Welcome! You can find here a workboard with a bunch of tasks to do. You could consider taking one to start. https://phabricator.kde.org/project/view/28/ Cheers, Aleix On Thu, Feb 13, 2020 at 1:18 PM Yari Polla wrote: > > Hi guys, > > I'm an IT student who would like to contribute to PM

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

jakobkummerow added a comment. ahiemstra: Thanks! I don't have commit access, so I'd appreciate it if you could land this for me. cfeck: Yes, realloc might be a nice improvement (if you think it even matters for this case). Wanna submit a followup PR? REVISION DETAIL

D27379: Baloo KCM: Do not anchor fill ScrollView

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY ScrollView will resize any single child flickabe to the right size. However, this

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

cfeck added a comment. That looks clever. Since CpuInfoBufSize is a static variable, it will remember the last used size and not reallocate again (unless you plug in new CPUs). Is realloc() an option? It should help the case where the library can actually grow the buffer without an

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

jakobkummerow updated this revision to Diff 75616. jakobkummerow retitled this revision from "Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs" to "Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs". jakobkummerow edited the summary of this revision. jakobkummerow added a

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. Added highlight as mention, and brought back background. To do that, had to ignore, theme's margins. I need to clean code, before uploading. **I'm not so sure about this:** When a row is expanded, moving from bottom to top. **Highlight disappears with button,

Plasma 5.18 release post-mortem

Plasma 5.18 was a pretty buggy release, and I'd like to start a discussion about how we think it happened and what we can do better next time. Here are some of the top bugs that our users are reporting: - https://bugs.kde.org/show_bug.cgi?id=417424 [Can't enter edit mode if widgets were

D27379: Baloo KCM: Do not anchor fill ScrollView

davidedmundson accepted this revision. davidedmundson added a comment. Cool, I'm happy as long as there's a known reason. REPOSITORY R119 Plasma Desktop BRANCH baloo_scrollbar REVISION DETAIL https://phabricator.kde.org/D27379 To: ahiemstra, #plasma, ngraham, davidedmundson Cc:

D27380: [GTK Config] Write Font without style name

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY It has been reported, that on localized systems the font style was written in local language. Therefore config line was

D27380: [GTK Config] Write Font without style name

IlyaBizyaev added a comment. I don't understand the problem in-depth, but isn't it possible to write non-localized style name instead? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari Cc: IlyaBizyaev, plasma-devel, Orage,

D27383: kscreen-doctor: reset color before exiting

z3ntu added a comment. Of the four scopes (api, kwayland, qscreen & randr) I have no idea where to put this in. If you have a suggestion, I can update the commit message. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu,

D27383: kscreen-doctor: reset color before exiting

romangg added a comment. In D27383#611101 , @z3ntu wrote: > Of the four scopes (api, kwayland, qscreen & randr) I have no idea where to put this in. If you have a suggestion, I can update the commit message. Scopes are only optional.

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

The-Feren-OS-Dev added a comment. Other people are confirming that this patch also fixes the issue: https://bugs.kde.org/show_bug.cgi?id=416358 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meven, ngraham,

D27383: fix: reset doctor output color before exiting

z3ntu added a comment. No I don't have commit rights. Luca Weiss l...@z3ntu.xyz (but isn't this information already as commit author?) REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: romangg,

D27383: fix: reset doctor output color before exiting

cfeck added a comment. According to https://phabricator.kde.org/R982:8dffcc64d2aec4041129d67809839f136fec080a you have commit rights? REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: cfeck, romangg,

Re: Plasma 5.18 release post-mortem

On 2/13/20 8:11 PM, David Edmundson wrote: I'm also seeing a rising amount of pushing without review on the core repos. I would like for us all to (nicely) call that out if we see any instances. Reviews are super important, the best time to fix a bug is before it even happens. Even for small

D27381: [sidebar] Resolve changes in module before switching

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY After some refactoring we close the module before checking if there are

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

bport created this revision. bport added reviewers: Plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY This will resolve a bug (apply never enabled).

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

The-Feren-OS-Dev accepted this revision. The-Feren-OS-Dev added a comment. This revision is now accepted and ready to land. I can confirm this fixes the bug. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi,

D27383: fix: reset doctor output color before exiting

romangg added a comment. Do you have commit rights? Otherwise I need your name and email for author information. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: romangg, plasma-devel, Orage, LeGast00n,

D27383: fix: reset doctor output color before exiting

cfeck added a comment. Oh, okey. That was just misleading. I also suggest to ask for commit rights then. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: cfeck, romangg, plasma-devel, Orage, LeGast00n,

D27383: fix: reset doctor output color before exiting

romangg added a comment. Yea, but sadly I have already committed it: https://cgit.kde.org/libkscreen.git/commit/?id=274d94ed645387b29386daa077b2cb6a3dafbeff So Luca, you need to write an additional one. ;) REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL

D27358: Sync ("Wayland") appending to match SDDM

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Wasn't this something that SDDM was going to stop doing in its next release? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL

Re: Plasma 5.18 release post-mortem

The important part right now is that we get on top with fixing them. For 5.18 there was /wy/ too much feature pushing for this release. Even if the new stuff itself doesn't introduce breakages, it takes developer and review time away from what should be a month of being totally on top of

D27379: Baloo KCM: Do not anchor fill ScrollView

davidedmundson added a comment. What I don't understand from this patch is that plasmathemeexplorer which has the same anchors but uses a gridview doesn't have this problem Nor plasma NM's Add Connection Dialog REPOSITORY R119 Plasma Desktop BRANCH baloo_scrollbar REVISION DETAIL

D27379: Baloo KCM: Do not anchor fill ScrollView

This revision was automatically updated to reflect the committed changes. Closed by commit R119:83b920946c52: Baloo KCM: Do not anchor fill ScrollView (authored by ahiemstra). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27379?vs=75631=75637

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

The-Feren-OS-Dev added a comment. Started building plasma-desktop over here on an affected machine with this diff applied REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson Cc:

D27084: Don't delay ksplash until the entire slideshow is loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a58bbc050723: Dont delay ksplash until the entire slideshow is loaded (authored by davidre). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27383: kscreen-doctor: reset color before exiting

z3ntu updated this revision to Diff 75643. z3ntu added a comment. Change commit message REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27383?vs=75638=75643 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 AFFECTED FILES

D27383: fix: reset doctor output color before exiting

romangg added a comment. True, thanks anyway. You can ask for commit rights by https://community.kde.org/Infrastructure/Get_a_Developer_Account REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: romangg,

D27380: [GTK Config] Write Font without style name

cfeck added a comment. So... is this all related to bug https://bugs.kde.org/show_bug.cgi?id=378523 ? :/ REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven Cc: cfeck, ngraham, IlyaBizyaev, plasma-devel,

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

The-Feren-OS-Dev added a comment. In D27384#611135 , @davidedmundson wrote: > I still don't fully understand the bug and the fix > > So what we're saying is: > Something changes us to needs save early on startup > We emit changed early

Re: Plasma 5.18 release post-mortem

On Thu, Feb 13, 2020 at 6:55 PM Vlad Zahorodnii wrote: > > On 2/13/20 8:11 PM, David Edmundson wrote: > > I'm also seeing a rising amount of pushing without review on the core > > repos. I would like for us all to (nicely) call that out if we see > > any instances. Reviews are super important,

D27383: fix: reset doctor output color before exiting

z3ntu added a comment. > Merged by Carl Schwan 3 days ago https://invent.kde.org/websites/plasma-mobile-org/merge_requests/39 No I don't. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: cfeck,

D27383: fix: reset doctor output color before exiting

cfeck added a comment. Since this patch isn't critical, it would make a perfect candidate for your first steps with committing :) REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: cfeck, romangg,

D27380: [GTK Config] Write Font without style name

ngraham added a comment. In D27380#611031 , @IlyaBizyaev wrote: > I don't understand the problem in-depth, but isn't it possible to write non-localized style name instead? Indeed. Is the problem that the style name is already

D27360: Go back to saving to sddm.conf

ngraham added a comment. Maybe @davidedmundson can help you fix it so we don't need to revert stuff? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27360 To: filipf, davidedmundson, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27382: KCM: Fix connection list background and padding

ahiemstra created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. ahiemstra requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH scrollview_anchor REVISION DETAIL

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

davidedmundson added a comment. I still don't fully understand the bug and the fix So what we're saying is: Something changes us to needs save early on startup We emit changed early That gets lost (?) So we have to reset back to unchanged after loading so that future changes will

D27380: [GTK Config] Write Font without style name

ngraham added a comment. In D27380#611146 , @gikari wrote: > In D27380#611132 , @ngraham wrote: > > > Is the problem that the style name is already localized by the time we get it from the Fonts

D27380: [GTK Config] Write Font without style name

gikari added a comment. In D27380#611132 , @ngraham wrote: > Is the problem that the style name is already localized by the time we get it from the Fonts KCM? Yes. It's already displayed localized, so that I cannot do anything with it.

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

davidedmundson added a comment. > This patch however fixes that for me Sure, but why/how? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, The-Feren-OS-Dev Cc:

D27381: [sidebar] Resolve changes in module before switching

ngraham accepted this revision. ngraham added a comment. ^^ same REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D27381 To: davidedmundson, #plasma, bport, ngraham Cc: ngraham, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27383: fix: reset doctor output color before exiting

This revision was automatically updated to reflect the committed changes. Closed by commit R110:274d94ed6453: fix: reset doctor output color before exiting (authored by z3ntu, committed by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D27380: [GTK Config] Write Font without style name

ngraham added a comment. *groan* I guess we need to fix it Qt then. I don't know much about fonts but maybe it could display the localized string in the UI but write an un-localized version to the config file? Would that work? And then maybe we can somehow finally fix

D27380: [GTK Config] Write Font without style name

gikari added a comment. In D27380#611150 , @ngraham wrote: > So maybe that's something we can fix in the Fonts KCM? Or Is it caused by the Qt bug ultimately causing https://bugs.kde.org/show_bug.cgi?id=378523? Probably a Qt bug, because

D27360: Go back to saving to sddm.conf

filipf abandoned this revision. filipf added a comment. Thanks to @davidedmundson's input we found out the cause, so fixed in: D27388 REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27360 To: filipf,

D27358: Sync ("Wayland") appending to match SDDM

davidedmundson added a comment. Given we have that .endsWith("Wayland") check, there isn't any rush to remove it REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27358 To: davidedmundson, #plasma, ngraham Cc: ngraham,

D27386: Set toolbox to invisble when it's invisible

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY opacity was bound to editMode, but this did not affect visibility or

D27360: Go back to saving to sddm.conf

davidedmundson added a comment. > The SDDM KCM is broken right now because the kde_settings.conf file is never created with the right permissions. This means that the KCM can't read the settings file. that doesn't match the bug report. The bug report shows it does have the right

D27386: Set toolbox to invisble when it's invisible

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice find! Fixes the bug and makes sense to me. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27386 To: davidedmundson, #plasma,

D27380: [GTK Config] Write Font without style name

davidedmundson added a comment. Take this code: static QString styleStringHelper(int weight, QFont::Style style) { QString result; if (weight > QFont::Normal) { if (weight >= QFont::Black) result =

D27388: Fix being unable to set the right permissions for kde_settings.conf

filipf created this revision. filipf added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY If we are creating a config file and its directory doesn't exist, we fail to set the right

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

bport added a comment. @davidedmundson We have 2 bugs : - KCModuleQML apply button will stay disabled forever if at the end of load function need save is true (probably qml connection not yet done or something like that I guess, not yet found why) => We need to investigate on it too,

D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme

cblack updated this revision to Diff 75644. cblack added a comment. Rebase on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24375?vs=67227=75644 BRANCH colors-kcm-recolor-gtk2 (branched from master) REVISION DETAIL

D27360: Go back to saving to sddm.conf

filipf added a comment. In D27360#611155 , @davidedmundson wrote: > > The SDDM KCM is broken right now because the kde_settings.conf file is never created with the right permissions. This means that the KCM can't read the settings file. >

D27388: Fix being unable to set the right permissions for kde_settings.conf

filipf updated this revision to Diff 75653. filipf added a comment. Fix the permissions for people who have already had the file created with the wrong permissions REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27388?vs=75651=75653

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

davidedmundson added a comment. > About KCModuleQML didn't investigate a lot but KCModule (parent class) emit a changed false on showEvent (the way the handle to set need save to false. Aha! What a weird bit of code. so I think I see what happens: 1. KCModule::showEvent() 2.

D27390: [GTK3] Fix menubar colours

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This patch uses strictly content fg/bg for menubars instead of a mix, and moves the window

D27391: [Applet]Fix dimensions of traffic Monitor

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Remove top margin. Workaround to get paintedheight for label. (Undefined or

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. I made 3 smaller patches, to decrease this patch's size. D27391 D27392 D27393 @ngraham Before I make any change here, can you tell me if you can still

D27392: [Applet]Add info messages.

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Add info messages, when there are no available connections. "Airplane mode is enabled"

D27393: [Applet]Fix details layout.

gvgeo added a comment. This patch keeps left margins and opacity. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27393 To: gvgeo, #plasma, #vdg, jgrulich Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27393: [Applet]Fix details layout.

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Fix binding loop with detailValueLabel's width. Remove workaround for contentRect

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

bport added a comment. Yes emiting signal from setNeedsSave in all case fix stuff too So this patch is here to solve for "short term" In more long term we need to fix ConfigModule do you think is better to do a setNeedsSave(false) after loading or emiting signal in all case ?

D27379: Baloo KCM: Do not anchor fill ScrollView

ahiemstra added a comment. Both use QtQuick Controls 1 ScrollView, which works quite a bit different if I recall correctly. So they are not really comparable. REPOSITORY R119 Plasma Desktop BRANCH baloo_scrollbar REVISION DETAIL https://phabricator.kde.org/D27379 To: ahiemstra,

Re: Plasma 5.18 release post-mortem

On 2020-02-13 11:55, Vlad Zahorodnii wrote: On 2/13/20 8:11 PM, David Edmundson wrote: I'm also seeing a rising amount of pushing without review on the core repos.  I would like for us all to (nicely) call that out if we see any instances. Reviews are super important, the best time to fix a bug

D27383: kscreen-doctor: reset color before exiting

z3ntu created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. z3ntu requested review of this revision. REVISION SUMMARY Without this patch the blue from the "primary" output 'leaks' into the prompt of some shells (e.g. busybox ash). TEST PLAN Run

D27383: kscreen-doctor: reset color before exiting

romangg added a comment. Please respect the Commit Message Guideline when pushing the change: https://cgit.kde.org/libkscreen.git/tree/CONTRIBUTING.md#n22 REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc:

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

ngraham added a comment. I was not able to reproduce the issue, but this patch causes no regressions for me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, The-Feren-OS-Dev

D27381: [sidebar] Resolve changes in module before switching

bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. Can reproduce bug and fix work as expected REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D27381 To: davidedmundson, #plasma, bport Cc:

Re: 2 kirigami fixes for a point release

On 02/13/20 08:42, Ben Cooksley wrote: Part of the issue here is that Plasma has been known to add API to Frameworks and then immediately, without any delay, start using it (pretty much always breaking CI in the process) This means that other changes are likely being pushed into Frameworks by

Re: 2 kirigami fixes for a point release

On Thu, Feb 13, 2020 at 9:00 PM Christoph Feck wrote: > > On 02/13/20 08:42, Ben Cooksley wrote: > > Part of the issue here is that Plasma has been known to add API to > > Frameworks and then immediately, without any delay, start using it > > (pretty much always breaking CI in the process) > > >

D27344: [Notifications] Only let details label grow, never shrink

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0fb8e51b8e13: [Notifications] Only let details label grow, never shrink (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27358: Sync ("Wayland") appending to match SDDM

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY For historical reasons some .desktop files in wayland-sessions suffix