D27495: Remove unnecessary code and function calls

alex created this revision. alex added reviewers: davidedmundson, ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The ShellConfig class has been deleted. This config class was in KDE4 for the run

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added a comment. Weird, I've tested again, and works like expected on my machine. Is it the `widgetStyle` entry from `KDE` group ? I have also an entry named `widgetStyle` in group `General` but we are not interested in that one. REPOSITORY R119 Plasma Desktop REVISION DET

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75971. gvgeo added a comment. Kirigami units. Remove unnecessary preferred width. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75935&id=75971 BRANCH kcmports2 REVISION DETAIL https://

D27482: Update kdeglobals config file for Breeze widgetStyle

bport added inline comments. INLINE COMMENTS > style_widgetstyle_default_breeze.pl:8 > +chomp; > +s/widgetStyle=breeze/widgetStyle=Breeze/; > +print "$_\n"; This will fix only for Breeze theme This will fix existing case but we also need to fix the root cause (i.e. how we end up wit

D27482: Update kdeglobals config file for Breeze widgetStyle

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Works : replace widgetStyle in group KDE and selects the application style in systemsettings; Does not edit widgetStyle in group General +1 on fixing whatever lowercased the value in the

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added a comment. In D27482#614006 , @meven wrote: > Works : replace widgetStyle in group KDE and selects the application style in systemsettings; Does not edit widgetStyle in group General Thanks for the confirmation. > +1 on

D27481: [WIP]Panel spacer that can center things

broulik added inline comments. INLINE COMMENTS > main.xml:15 > length in pixels of the spacer. Configuration effective only > if expanding is set to false. > +-1 > Please mention in the label what `-1` means > main.qml:30 > + > +z: > +property bool horizonta

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

This revision was automatically updated to reflect the committed changes. Closed by commit R106:7a103a45e349: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs (authored by jakobkummerow, committed by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabric

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

ahiemstra added a comment. Now pushed with correct author information. :) Thanks! REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D27362 To: jakobkummerow, davidedmundson, ahiemstra Cc: ngraham, ahiemstra, cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cb

D27407: Breeze widgetStyle value is Breeze

meven added inline comments. INLINE COMMENTS > defaults:8 > [kdeglobals][Icons] > Theme=breeze > ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham Cc: ngraham, plasma-devel, Orage, LeGas

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

jakobkummerow added a comment. Thank you! REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D27362 To: jakobkummerow, davidedmundson, ahiemstra Cc: ngraham, ahiemstra, cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB

D27481: [WIP]Panel spacer that can center things

mart added inline comments. INLINE COMMENTS > broulik wrote in main.qml:30 > Why that? no idea, is from the old applet and appears useless (also phab gets confused and doesn't understand the move of main.qml to a subfolder) > broulik wrote in main.qml:77 > Does `Qt.callLater(foo)` work? It als

D27481: [WIP]Panel spacer that can center things

mart updated this revision to Diff 75980. mart marked 3 inline comments as done. mart added a comment. - use a binding - use twinlayouts only when both are expanding REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=75925&id=75980 BRANCH

D27316: [Folder view]Make shadow scale aware

gvgeo added a comment. In D27316#613771 , @davidedmundson wrote: > I don't know > > You can find > > ./qml/QtGraphicalEffects/private/DropShadowBase.qml > > somewhere in /usr on your local system, > > add in some > console.log

D27316: [Folder view]Make shadow scale aware

broulik added a comment. plasmashell doesn't use Qt scaling, so using `units.devicePixelRatio` is correct. It will be 2 when not used, and then divide by Qt scaling so Qt scales back up resulting in the same effect. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.

D27316: [Folder view]Make shadow scale aware

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Oh, of course REPOSITORY R119 Plasma Desktop BRANCH shadow2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27316 To: gvgeo, #plasma, #vdg, apol,

D27481: [WIP]Panel spacer that can center things

mart updated this revision to Diff 75988. mart added a comment. - put the second spacer at the beginning REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=75980&id=75988 BRANCH mart/panelSpacer REVISION DETAIL https://phabricator.kde.or

D27481: [WIP]Panel spacer that can center things

mart added a comment. demo of adding 2 spacers and centering mode F8112648: vokoscreen-2020-02-19_13-43-02.mp4 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27481 To: mart, #plasma, #vdg Cc: broulik, ngraham, plasm

D27481: Panel spacer that can center things

mart updated this revision to Diff 75990. mart added a comment. - bigger in edit mode REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=75988&id=75990 BRANCH mart/panelSpacer REVISION DETAIL https://phabricator.kde.org/D27481 AFFECTED

D27481: Panel spacer that can center things

davidre added a comment. I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but that can be done in the future if desired. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27481 To: mart, #plasma, #vdg Cc: davidre, b

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport created this revision. bport added reviewers: Plasma, meven, crossi, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27503 AFFECTED FILES

D27316: [Folder view]Make shadow scale aware

ngraham added a comment. So will we need to remove this multiplying by `units.devicePixelRatio` bit if and when we finally make plasmashell respect Qt scaling and fix https://bugs.kde.org/show_bug.cgi?id=356446? REPOSITORY R119 Plasma Desktop BRANCH shadow2 (branched from master) REVIS

D27495: Remove unnecessary code and function calls

meven added inline comments. INLINE COMMENTS > shellrunner.cpp:68 > { > Q_UNUSED(match); > you can remove this line REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27495 To: alex, davidedmundson, ngraham, broulik Cc: meven, plasma-devel, Orage, LeGast

D27505: Do not crash when icon's width or height is 0

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY When Icon's width or height is 0, I get a crash with the following backtrace: #0

D27422: [KCM]Update Device item layout based on applet

ngraham added a comment. I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows: F8112849: Screenshot_20200219_075319.png This is just 1x scaling with no weird font DPI fiddling. REPOSITORY R115 Plasma Audio V

D27481: Panel spacer that can center things

ngraham added a comment. Yeah it would be nice to call this an "Expanding spacer" or something like that. That's the term that we use for the rough equivalent for KXMLGui toolbars. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27481 To: mart, #plasma, #vd

D27505: Do not crash when icon's width or height is 0

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Weird. plasma-framework's version of icon (which this is copied from) has had that check for years. Would be good to dump this test qml somewhere in the repo. A folder f

D27481: Panel spacer that can center things

davidre added a comment. In D27481#614167 , @davidre wrote: > I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but that can be done in the future if desired. An idea could be to display somethin

D27316: [Folder view]Make shadow scale aware

davidedmundson added a comment. we would not need to remove it REPOSITORY R119 Plasma Desktop BRANCH shadow2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27316 To: gvgeo, #plasma, #vdg, apol, ngraham, davidedmundson Cc: broulik, davidedmundson, apol, ngraham, pl

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi updated this revision to Diff 76004. crossi marked 6 inline comments as done. crossi added a comment. Consider Kevin's comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=75360&id=76004 REVISION DETAIL https://phabricator.kde.o

D27481: Panel spacer that can center things

mart added a comment. In D27481#614250 , @davidre wrote: > In D27481#614167 , @davidre wrote: > > > I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but t

D27505: Do not crash when icon's width or height is 0

ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=417844? REPOSITORY R169 Kirigami BRANCH icon_crash REVISION DETAIL https://phabricator.kde.org/D27505 To: ahiemstra, #kirigami, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, fbampaloukas, GB_2, dom

D27316: [Folder view]Make shadow scale aware

ngraham added a comment. You've got so many landed patches under your belt now that I think it's time to apply for a developer account. :) https://community.kde.org/Infrastructure/Get_a_Developer_Account REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D273

D27316: [Folder view]Make shadow scale aware

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4056e24b353d: [Folder view]Make shadow scale aware (authored by gvgeo, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27316?vs=75476&i

D27505: Do not crash when icon's width or height is 0

ahiemstra added a comment. It most likely does, since Icon also has no implicit width/height it will default to 0 and crash when there's no special layout properties specified. REPOSITORY R169 Kirigami BRANCH icon_crash REVISION DETAIL https://phabricator.kde.org/D27505 To: ahiemstra

D27495: Remove unnecessary code and function calls

alex updated this revision to Diff 76009. alex added a comment. Remove unnecessary Q_UNUSED macro REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27495?vs=75963&id=76009 BRANCH shellrunner_cleanup REVISION DETAIL https://phabricator.kde.org/D2

D27509: Introduce ProcessDataModel

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Last release a plugin system was introduced that allowed plugins to provide columns of process data in a way that in

D27088: [applets/SystemTray] Implement sorting in the model

kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in sortedsystemtraymodel.cpp:47 > I think calling QSortFilterProxyModel::lessThan(left, right); would do the > same > > then you don't need compareDisplayAlphabetically > > your implementation looks fine though, so do which

D27505: Do not crash when icon's width or height is 0

ahiemstra added a comment. In D27505#614240 , @davidedmundson wrote: > Would be good to dump this test qml somewhere in the repo. A folder full of tests which just have one component in a bunch of configurations. > I've been pushing for that

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. > I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows: I cannot replicate this. And I cannot see how I could have created this. Or where to start. Here's my short list of problems. F8113183: problems.png

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove added a comment. In D26946#602022 , @ngraham wrote: > What I care about is that the margins are consistent and things are properly left-aligned by default. That is to say, nothing should have to override the default margins to have eve

D27346: emojier: Improve resizing performance

apol abandoned this revision. apol added a comment. Solved as https://commits.kde.org/plasma-desktop/91c446e0c4430289369963bf44e64228add67d18 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27346 To: apol, #plasma Cc: ngraham, Zren, plasma-devel, Orage, LeGas

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham added a comment. All right, feel free to re-open it and re-base on current master (there has been a lot of work to these applets lately). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26946 To: niccolove, #vdg, #plasma Cc: gvgeo, ngraham, plasma-d

D27513: Kill Runner: Remove duplicate function calls and refactor

alex created this revision. alex added reviewers: davidedmundson, ngraham, broulik, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Duplicate function calls to load the config in the runner/config have been

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 76023. alex added a comment. Remove QDebug include, add license REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=76022&id=76023 BRANCH killrunner_cleanup (branched from master) REVISION DETAIL https:/

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove updated this revision to Diff 76024. niccolove added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26946?vs=74443&id=76024 BRANCH smallspacingmargin (branched from master) REVISION DETAIL https://phabricator.kde.o

D26945: Added smallSpacing to leftMargin

niccolove updated this revision to Diff 76025. niccolove added a comment. - Merge branch 'master' of https://anongit.kde.org/kscreen REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26945?vs=74438&id=76025 BRANCH master REVISION DETAIL https://phabricat

D27088: [applets/SystemTray] Implement sorting in the model

kmaterka updated this revision to Diff 76026. kmaterka added a comment. Review fixes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27088?vs=75112&id=76026 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27088 AFFECTED FILES app

D27088: [applets/SystemTray] Implement sorting in the model

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d86c690d133: [applets/SystemTray] Implement sorting in the model (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27088?vs=76026&id=

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 76028. kmaterka added a comment. Second (and last) change extracted from this one is in master. Rebased, ready for review. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=75134&id=76028 BRANCH mast

D26992: [SystemTray] Use unified data model everywhere

ngraham added a comment. UI looks good except for one thing: the changes to show a highlight effect on hover in the popup are unrelated and should be done in a separate patch (preferably in coordination with #VDG folks since we're moving towards the ide

D26945: Added smallSpacing to leftMargin

ngraham added a comment. Since this patch is for KScreen, you need to follow the commit message guidelines: https://cgit.kde.org/kscreen.git/tree/CONTRIBUTING.md#n22 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D26945 To: niccolove, #vdg Cc: ngraham, plasma-devel,

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham added a comment. So, with a left panel, I see the following: F8113684: Screenshot_20200219_153618.png Things are improved, but the vertical alignment is still not perfect. :( REPOSITORY R120 Plasma Workspace REVISION DETAIL https:/

D27514: Fix incorrect use of case statements in accountmodel.cpp

bero created this revision. bero added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bero requested review of this revision. REVISION SUMMARY Building user-manager 5.18.1 with clang++ 10.0 resulted in 2 compiler warnings - a quick look at the c

D27514: Fix incorrect use of case statements in accountmodel.cpp

bero added a comment. Actually the obvious fix doesn't work (thought it was so obvious that I submitted it before testing, sorry) because Qt::DisplayRole and AccountModel::FriendlyName are both 0 (-> duplicate case value) and Qt::DecorationRole and AccountModel::Face are both 1 (-> duplicate

D27514: Fix incorrect use of case statements in accountmodel.cpp

bero updated this revision to Diff 76032. bero added a comment. Probably best to just add a comment explaining what needs to be done if AccountModel::* roles ever diverge from DisplayRole/DecorationRole... Leaving the code the way it is now will result in a harder to trace error if Qt ev

D27514: Fix incorrect use of case statements in accountmodel.cpp

bero added a comment. Another option would be switching the code to use if instead of switch/case so the || operator would actually do what the code expected (and x || x, unlike duplicate case values, isn't an error) REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.o

D27426: [KRDB] Rename GTK colours to be exported

ongunkanat added a comment. Hi, I am the reporter of this bug. I saw the e-mail but never had time to comment on the issue. It seems it has been approved quite fast. I am glad that it is at least possible to modify the style and GTK accepts those changes without hassle. However I ha

D27345: Don't emit palette changes if the palette didn't change

apol updated this revision to Diff 76033. apol added a comment. Icon: fix rendering of image: urls on High DPI QQuickImageProvider wants the requestedSize to be accounting for the dpi scaling. We have no information about about the DPI from the implementation anyway. This is also how

D27515: Icon: fix rendering of image: urls on High DPI

apol created this revision. apol added reviewers: Plasma, Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY QQuickImageProvider wants the requestedSize to be accounting for the dpi scaling. We hav

D27345: Don't emit palette changes if the palette didn't change

apol updated this revision to Diff 76036. apol added a comment. unrelated changes. Hating arc right now... REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27345?vs=76033&id=76036 BRANCH arcpatch-D27345 REVISION DETAIL https://phabricator.kde.org/D2734