Re: Problems in KWayland causes by API and ABI compatibility promises

On Tue, Mar 17, 2020 at 11:27 AM David Edmundson wrote: > > There's definitely a problem, and I think it's a lot more than just > discussing location and protocol versions. > > My typical workflow is reading the wayland protocol in detail, and > kwayland is in that awkward position where I

D10042: feat: parse EDID on the backend side

dvratil updated this revision to Diff 77825. dvratil edited the summary of this revision. dvratil added a comment. - Rebase on current master - Move Edid construction to WaylandOutput::edid REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE

D10042: feat: parse EDID on the backend side

dvratil marked an inline comment as done. dvratil added inline comments. INLINE COMMENTS > romangg wrote in waylandbackend.cpp:81 > Let the backend populate the Private here is unusual, or is it not? On the > other side it makes sense. Let the consumer only access the public interface > and

D10042: feat: parse EDID on the backend side

dvratil added a comment. Here's kscreen-console output for one of my monitors under Wayland with this patch applied: [15:31:16.520] kscreen-console(422251:422251) unknown: Id: 3 [15:31:16.520] kscreen-console(422251:422251) unknown: Name: "Eizo Nanao Corporation

D28086: Improve CMake handling of GNOME libraries

cblack added a comment. In D28086#628957 , @gikari wrote: > It builds, but why aren't you using that stuff inside of `FingGTK3.cmake` module? It actually uses it inside already, but with some bugs, that prevents from building last patch.

D10042: feat: parse EDID on the backend side

dvratil added a comment. Agreed. deviceId is not actually used (it's stored in KDED config files, but the value doesn't seem to be used anywhere). I'll fix it in a separate commit (since it also needs adjusting a bunch of unit-tests in libkscreen and kscreen). REPOSITORY R110 KScreen

D28103: introduce PassiveNotification type

mart updated this revision to Diff 77843. mart added a comment. - export the item REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28103?vs=77842=77843 BRANCH mart/passivenotification REVISION DETAIL https://phabricator.kde.org/D28103 AFFECTED FILES

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 626 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/626/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 15:05:25 + Build duration: 1 hr 0 min and counting JUnit Tests Name: (root) Failed: 0

D28103: introduce PassiveNotification type

ngraham added inline comments. INLINE COMMENTS > PassiveNotification.qml:18 > +notifications in the app. > + * used to show messages of limited importance that make sense only when > + * the user is using the application and wouldn't be suited as a global `messages of limited importance` ->

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 625 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/625/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 14:53:06 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncated 3079

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack added a comment. In D27959#629133 , @broulik wrote: > I think you should cache the X props, otherwise every `data` access causes a round trip to the X server. Implemented a cache for appmenus, but as I don't know what to listen to

D28081: Populate Greeter process exit stderr

romangg added a comment. In D28081#628985 , @davidedmundson wrote: > Can we use categorised logging please. Yea, but I haven't seen any categorized logging in KScreenLocker so I opted for now with non-categorized logging as the rest of

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. I think if you added those properties `KWindowInfo`, you'd get change events, cache eviction, less manual X code basically for free :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik,

D28098: remove pointless and arbitrary 4 line frame limit

bcooksley requested changes to this revision. bcooksley added a comment. This revision now requires changes to proceed. There should be no further changes to Dr Konqi at this time as it fails to build from source on both FreeBSD and Windows. Please see the relevant CI jobs for more

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 622 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/622/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 14:37:31 + Build duration: 6 min 53 sec and counting CONSOLE OUTPUT [...truncated 2890

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 466 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/466/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 14:52:12 + Build duration: 2 min 38 sec and counting CONSOLE OUTPUT [...truncated

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 77834. cblack marked 5 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77681=77834 BRANCH cblack/appmenu-libtaskmanager (branched

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil updated this revision to Diff 77838. dvratil added a comment. - Simplify a bit more REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27675?vs=77837=77838 BRANCH arcpatch-D27675 REVISION DETAIL https://phabricator.kde.org/D27675 AFFECTED FILES

D28103: introduce PassiveNotification type

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY PassiveNotification is a type for small, passive and inline notifications in the app. used to show

D28103: introduce PassiveNotification type

mart added a comment. In D28103#629313 , @ngraham wrote: > Didn't this already exist in Kirigami, or am I imagining that? there is ApplicationWindow.showPassiveNotification. it was only accessible by that (and not accessible by kcms)

D28090: [applet] Fix button bar right margin

This revision was automatically updated to reflect the committed changes. Closed by commit R97:3c2175fe8e04: [applet] Fix button bar right margin (authored by ngraham). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28090?vs=77798=77845 REVISION DETAIL

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 623 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/623/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 14:44:26 + Build duration: 5 min 51 sec and counting CONSOLE OUTPUT [...truncated 3114

D28086: Improve CMake handling of GNOME libraries

gikari accepted this revision. gikari added a comment. This revision is now accepted and ready to land. Fine. It builds. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH better-gtk-glib-etc-usage (branched from master) REVISION DETAIL https://phabricator.kde.org/D28086 To: cblack,

D28099: Show command output on unknown failure

This revision was automatically updated to reflect the committed changes. Closed by commit R845:1e2988d7d3ca: Show command output on unknown failure (authored by ivan). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28099?vs=77828=77836 REVISION DETAIL

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil updated this revision to Diff 77837. dvratil added a comment. - Make the lambda more explicit - Address review comments REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27675?vs=76457=77837 BRANCH arcpatch-D27675 REVISION DETAIL

D28057: Fix/Allow folderview popup mode icon and list icon size

ngraham added a comment. Making a second slider is fine, but it's not actually necessary. Instead, you could make `cfg_iconSize` and `cfg_listViewIconSize` not be aliases, and instead bind the single slider's value to whichever one is appropriate, like so: value: viewMode.currentIndex

D28086: Improve CMake handling of GNOME libraries

cblack updated this revision to Diff 77831. cblack added a comment. Rebase on master for reverted commits REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28086?vs=77790=77831 BRANCH better-gtk-glib-etc-usage (branched from master)

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 465 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/465/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 14:44:36 + Build duration: 2 min 30 sec and counting CONSOLE OUTPUT [...truncated

D27675: feat: avoid duplicated text when assembling user-facing output names

romangg added a comment. In D27675#629182 , @dvratil wrote: > As you described, the system makes sense on X11 where you get something like `HDMI-1 (Sony GigaTV-12345)` so you see which device it is and what physical output it's connected to.

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 467 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/467/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 14:57:35 + Build duration: 20 min and counting JUnit Tests Name: projectroot

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 77835. cblack added a comment. Don't double lookup cached appmenus REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77834=77835 BRANCH cblack/appmenu-libtaskmanager (branched from master) REVISION

D28103: introduce PassiveNotification type

ngraham added a comment. Didn't this already exist in Kirigami, or am I imagining that? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28103 To: mart, #kirigami Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson,

D28103: introduce PassiveNotification type

mart added a comment. One thing I'm not sure of is whether going this way, with one popup that shows only one notification or having a popup with a listview that can show multiple notifications at once... tough for me an important thing is that this thing does *-NOT* become a full fledged

[Breeze] [Bug 418949] plymouth-theme-breeze should have a background/wallpaper option

https://bugs.kde.org/show_bug.cgi?id=418949 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 621 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/621/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 14:32:56 + Build duration: 1 min 6 sec and counting CONSOLE OUTPUT [...truncated 1636

D27677: feat: fix build after EDID changes in libkscreen

dvratil updated this revision to Diff 77830. dvratil added a comment. - Fix commit message REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27677?vs=76460=77830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27677 AFFECTED FILES

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 464 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/464/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 14:40:33 + Build duration: 3 min 5 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 624 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/624/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 14:50:19 + Build duration: 2 min 46 sec and counting CONSOLE OUTPUT [...truncated 3357

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/75/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 15:00:12 + Build duration: 20 sec and counting CONSOLE OUTPUT

D10042: feat: parse EDID on the backend side

romangg added a comment. Thanks, so I'm talking about this line: [15:31:16.521] kscreen-console(422251:422251) unknown: Device ID: "xrandr-Eizo Nanao Corporation-DP-7-EV2736W/96211045" There it says xrandr, which should likely be not there. REPOSITORY R110 KScreen Library

KDE CI: Plasma » kde-gtk-config » kf5-qt5 SUSEQt5.12 - Build # 123 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/123/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 15:00:12 + Build duration: 55 sec and counting CONSOLE OUTPUT [...truncated 233

D28086: Improve CMake handling of GNOME libraries

This revision was automatically updated to reflect the committed changes. Closed by commit R99:db87b4d270a1: Improve CMake handling of GNOME libraries (authored by cblack). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28086?vs=77831=77833

D27669: [kstyle] Tools area

hpereiradacosta added a comment. Hi, finally had some time to double-check into kiconloader, and confirmed that setting the custom palette and reseting is pretty harmless since it does not invalidate the cache. So to me it is fine to leave this part as it is now. I have added a few

D28096: Don't overwrite status

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. TEST PLAN set an attentionIconByName in kstatusnotifieritemtest REPOSITORY R120 Plasma Workspace BRANCH attention (branched from master)

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 461 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/461/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 14:08:16 + Build duration: 30 sec and counting CONSOLE OUTPUT [...truncated 160

D28099: Show command output on unknown failure

davidedmundson added inline comments. INLINE COMMENTS > mountdialog.cpp:57 > + > +QMessageBox::critical(this, i18n("Error details"), message); > + Kded is one of the processes that shouldn't freeze, lets avoid nested event loops Some sort of box = new QMessageBox()

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 620 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/620/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Mar 2020 14:08:16 + Build duration: 1 min 6 sec and counting CONSOLE OUTPUT [...truncated 223

D28099: Show command output on unknown failure

ivan updated this revision to Diff 77828. REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28099?vs=77822=77828 REVISION DETAIL https://phabricator.kde.org/D28099 AFFECTED FILES .gitignore kded/engine/backends/cryfs/cryfsbackend.cpp

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 462 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/462/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 14:32:56 + Build duration: 56 sec and counting CONSOLE OUTPUT [...truncated 1595

D28099: Show command output on unknown failure

ivan added a comment. Of course... I need to reboot my brain it seems. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D28099 To: ivan, #plasma, davidedmundson, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28083: Use methods in KF5-activities to switch to previous/next activity

This revision was automatically updated to reflect the committed changes. Closed by commit R120:805e70bb6e75: Use methods in KF5-activities to switch to previous/next activity (authored by muesli). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28098: remove pointless and arbitrary 4 line frame limit

sitter updated this revision to Diff 77821. sitter added a comment. update comment as well REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28098?vs=77817=77821 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28098 AFFECTED FILES

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil added a comment. The system makes sense on X11 where you get something like `HDMI-1 (Sony GigaTV-12345)` so you see which device it is and what physical output it's connected to. Since KWin does not use to output names but only the names of the actually connected devices, the needed

D28098: remove pointless and arbitrary 4 line frame limit

sitter created this revision. sitter added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY ... and update a related test case the original motivation here was garbage _start traces

D28099: Show command output on unknown failure

ivan created this revision. ivan added reviewers: Plasma, davidedmundson, ngraham, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY If the error is unknown (all errors in encfs), show the 'details...' button

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 463 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/463/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 14:37:31 + Build duration: 2 min 56 sec and counting CONSOLE OUTPUT [...truncated

D28106: fix: transfer tablet mode properties

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY I forgot to copy over the tablet-mode-available and -engaged data from one config to the next

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

ahmadsamir added a comment. I spent some time looking (and hacking at a kdeplatformfontdialoghelper...) at the code in kdeplatformfiledialoghelper, KFontChooser and KFontDialog, and I am starting to think that moving KFontDialog to KWidgetAddons (where KFontChooser and KFontRequester live)

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

cblack added a comment. In D28072#629439 , @gikari wrote: > > You simply test the recolouration like how it's been up until now—restart the applications. > > It doesn't work. This is what I was talking about: > > > It seems like it

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#629441 , @cblack wrote: > In D28072#629439 , @gikari wrote: > > > > You simply test the recolouration like how it's been up until now—restart the applications. >

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

cblack added a comment. In D28072#629448 , @gikari wrote: > In D28072#629441 , @cblack wrote: > > > In D28072#629439 , @gikari wrote: > > > > > > You

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 77860. gikari edited the summary of this revision. gikari added a comment. - Remove the recolor module. It is D28076 now REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. The GTK+ module shouldn't be in this patch, as it and the functions to write CSS are separate changes. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77858. cblack added a comment. Update CMakeLists.txt REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77857=77858 BRANCH arcpatch-D28076 REVISION DETAIL https://phabricator.kde.org/D28076

D28107: Fix overlayIcon sometimes not visible

anthonyfieroni added a comment. Can we just set/clear OverlayIconName depends of icon presence then `overlays: model.OverlayIconName` ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28107 To: davidre, kmaterka, #plasma, broulik, davidedmundson Cc:

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 77855. gikari added a comment. - Rebase on master - Add recoloration module REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28072?vs=77723=77855 BRANCH set-colors REVISION DETAIL

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

cblack added a comment. In D28072#629425 , @gikari wrote: > - I should add the recoloration module to autoload with GTK applications > > In D28072#629422 , @cblack wrote: > > > The GTK+ module

D28104: [applets/digital-clock] Increase size of calendar in pop-up

ngraham created this revision. ngraham added reviewers: VDG, broulik, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Various people were complaining that the calendar was too squished after D27903

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. I don't think the described behavior is not a bug in IconItem but rather a quirk in the interaction of all three (data engine, IconItem and KIconEngine) components. SO nothing to fix on that side. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77862. cblack added a comment. Fix bad symbol management REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77858=77862 BRANCH arcpatch-D28076 REVISION DETAIL

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77857. cblack added a comment. Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77768=77857 BRANCH arcpatch-D28076 REVISION DETAIL https://phabricator.kde.org/D28076

D28107: Fix overlayIcon sometimes not visible

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Workaround a specific behavior in IconItem if the source is a QIcon with a name and pixmaps. IconItem will use the name to find

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari planned changes to this revision. gikari added a comment. - I should add the recoloration module to autoload with GTK applications In D28072#629422 , @cblack wrote: > The GTK+ module shouldn't be in this patch, as it and the functions

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. > You simply test the recolouration like how it's been up until now—restart the applications. It doesn't work. This is what I was talking about: > It seems like it applies randomly whenever the GTK app would like to update the colors, but with that module

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

broulik added a comment. I think you should cache the X props, otherwise every `data` access causes a round trip to the X server. INLINE COMMENTS > xwindowtasksmodel.cpp:472 > > +static const QByteArray s_x11AppMenuServiceNamePropertyName = >

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77871. cblack added a comment. Address feedback REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77862=77871 BRANCH arcpatch-D28076 REVISION DETAIL https://phabricator.kde.org/D28076

D28106: fix: transfer tablet mode properties

This revision was automatically updated to reflect the committed changes. Closed by commit R110:6ba447e9e59d: fix: transfer tablet mode properties (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28106?vs=77852=77874 REVISION

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. In D28107#629521 , @kmaterka wrote: > Yep, icons in SNI are a mess... > Icons are processed in `StatusNotifierItemSource`, including overlay - that's were this should be fixed. From you comment I see it won't be

D28109: [applets/systemtray] Simplify icon size logic

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY This change simplifies icon size logic - now it is controled only in one place: AbstractItem.

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. In D28107#629446 , @anthonyfieroni wrote: > Can we just set/clear OverlayIconName depends of icon presence then `overlays: model.OverlayIconName` ? Of course thats much easier! Thank you! REPOSITORY R120

D28096: Don't overwrite status

kmaterka added a comment. > Oh you're right. It was not wokring for me on 5.18 so I changed this and it worked. But matter of fact it worked on master all allong :) 5.18 is not using this data model, in 5.18 it is used only in configuration page. In 5.19 this model is everywhere.

D28096: Don't overwrite status

kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. > The qml checks the value against the enum but updateItemData inserts the string. These are two different roles: "status" with enum value "Status" from SNI data

D28096: Don't overwrite status

davidre abandoned this revision. davidre added a comment. In D28096#629508 , @kmaterka wrote: > > The qml checks the value against the enum but updateItemData inserts the string. > > These are two different roles: > "status" with enum

D28107: Fix overlayIcon sometimes not visible

kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. Yep, icons in SNI are a mess... Icons are processed in `StatusNotifierItemSource`, including overlay - that's were this should be fixed. From you comment I see it won't be

D28109: [applets/systemtray] Simplify icon size logic

kmaterka added inline comments. INLINE COMMENTS > ExpanderArrow.qml:31 > implicitHeight: implicitWidth > -visible: root.hiddenLayout.contentItem.children.length > 0 > +visible: root.hiddenLayout.count > 0 > This fixes issue (regression) with expander arrow not hiding when all

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:3 > + > +enable_language(C) > + Why is this needed? Aren't the CMake default languages in project (parent CMakeLists) both `CXX` and `C`? > reloader.c:35 > +__attribute__((visibility("default"))) void gtk_module_init(gint *argc,

D28107: Fix overlayIcon sometimes not visible

davidre updated this revision to Diff 77866. davidre added a comment. Only set the role conditionally REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28107?vs=77853=77866 BRANCH workaround (branched from master) REVISION DETAIL

D28113: Fix initial loading of autostart program names

yuyichao created this revision. yuyichao added reviewers: apol, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. yuyichao requested review of this revision. REVISION SUMMARY When the auto start entry is first loaded, the module only take into account

D28068: Cleanup file resolving

keithzg requested changes to this revision. keithzg added a comment. This revision now requires changes to proceed. Compiles when included in an Android Debug build but when attempting to run an application I hit an immediate crash on startup with: name=Android logcat

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. It builds, but why aren't you using that stuff inside of `FingGTK3.cmake` module? It actually uses it inside already, but with some bugs, that prevents from building last patch. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH better-gtk-glib-etc-usage (branched

D28055: Fix on wayland activating minimized window will move window to current desktop

zzag added a comment. Yes, on Wayland, a window can be more on than just one desktop. However, in this scenario, the minimized window should not be placed on other desktops. > how should I proceed ? First, we need to make sure that plasmashell doesn't put the window on other

[Breeze] [Bug 418949] New: plymouth-theme-breeze should have a background/wallpaper option

https://bugs.kde.org/show_bug.cgi?id=418949 Bug ID: 418949 Summary: plymouth-theme-breeze should have a background/wallpaper option Product: Breeze Version: unspecified Platform: Other OS: Linux

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex added a comment. In D28057#628853 , @ngraham wrote: > Thanks! > > Now we have a new problem though: the default icon size for list view is synchronized with the default icon size for icon view, so it's now gigantic by default:

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir added a comment. For background see: https://bugs.kde.org/show_bug.cgi?id=414742 I may be wrong, but personally I think QMimeDatabase is acting sensibly by not allowing to remove the "main" glob pattern of a mimetype. Also IIUC it seems other tools are sort of doing the

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex updated this revision to Diff 77808. pereira.alex added a comment. Using separate configs for list and icon mode Like previously talked, added listViewIconSize to the config xml. ( i also fix a little typoo, hope it doesn't make the commit invalid ) My solution was

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/14/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 17 Mar 2020 08:23:31 + Build duration: 1 min 52 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 69 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/69/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 08:23:32 + Build duration: 43 sec and counting CONSOLE OUTPUT [...truncated 292

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

bcooksley added a comment. This change, and changes subsequent to it have broken the build of kde-gtk-config. Please see https://build.kde.org/view/Failing/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/ and

D28081: Populate Greeter process exit stderr

davidedmundson added a comment. Can we use categorised logging please. But general +1 REPOSITORY R133 KScreenLocker BRANCH debug REVISION DETAIL https://phabricator.kde.org/D28081 To: romangg, #plasma, apol Cc: davidedmundson, zzag, plasma-devel, Orage, LeGast00n,

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/74/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Mar 2020 08:48:33 + Build duration: 56 sec and counting

  1   2   >