D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Instead of kuserfeedback which uploads data collected prior users consent, I believe this patch is good enough. @ngraham It appears that I should let you know that, I'm no longer going to work on it under these circumstances, so that you can use it if you want.

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 78 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/78/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 09:01:21 + Build duration: 15 min and counting

D27576: Kill Runner: Move config keys to new file

alex updated this revision to Diff 78137. alex added a comment. Use cast for the default value REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27576?vs=76172=78137 BRANCH arcpatch-D27576 REVISION DETAIL https://phabricator.kde.org/D27576

D27576: Kill Runner: Move config keys to new file

alex marked an inline comment as done. alex added inline comments. INLINE COMMENTS > meven wrote in killrunner.cpp:65 > You can use the enum as default value here I guess : Sort::NONE What you suggested is not possible, because the enum is not declared as an enum qobject and declaring it just

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

dfaure added a comment. I wrote QMimeDatabase, and my only intent was to move the main glob to be first. Not to prevent people from removing it. So this is a Qt bug. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D28079 To: ahmadsamir, #plasma, dfaure,

KDE CI: Plasma » kde-gtk-config » kf5-qt5 SUSEQt5.12 - Build # 126 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/126/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 21 Mar 2020 09:01:21 + Build duration: 1 min 30 sec and counting JUnit Tests Name: (root)

D27783: Add new Account portal

jgrulich added a comment. In D27783#630734 , @ngraham wrote: > UserInfoDialog.qml an Item with a Rectangle in it, could you use a Window? > > https://doc.qt.io/qt-5/qml-qtquick-window-window.html I don't think that would be correct

Re: Manner in which kde-gtk-config development is conducted

You're absolutely right that mistakes were made and have reason to be frustrated. kde-gtk-config is now maintained by new developers. Plasma has a new influx of new people which is good to see and something we need to foster carefully. Overall these new devs are doing a super job and we want to

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. This has been reverted. @cblack, please take a look at what has happened. Seems like CI is missing some dependency. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28176: Implement Keyboard Keycode support as suggested in the spec

apol added a comment. It was in kwin, I guess we forgot to get it in the portal. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D28176 To: apol, jgrulich Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

Re: Manner in which kde-gtk-config development is conducted

On Sat, Mar 21, 2020, 10:27 AM Johan Ouwerkerk wrote: > On Sat, Mar 21, 2020 at 1:32 AM Ben Cooksley wrote: > > > > Comments welcome. Please note that simply fixing the dependency > > breakage in this case is not enough to resolve this - there are > > underlying issues which need to be

Re: Manner in which kde-gtk-config development is conducted

First up: I would like to apologize for submitting and landing https://phabricator.kde.org/D28076 and https://phabricator.kde.org/D28086 without properly checking that everything was behaving as it should. For the initial breakage of https://phabricator.kde.org/D28076, I failed to check that it

D18392: [mobile/broadband] Port to SimpleKCM and FormLayout

jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. I would approve, but @ngraham requested some changes. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18392 To:

Re: Manner in which kde-gtk-config development is conducted

On Sat, Mar 21, 2020 at 1:32 AM Ben Cooksley wrote: > > Comments welcome. Please note that simply fixing the dependency > breakage in this case is not enough to resolve this - there are > underlying issues which need to be addressed here. > > Regards, > Ben Cooksley > KDE Sysadmin I cannot

D28183: [kioslave/desktop] Attempt at making test more robust

kmaterka added a comment. In theory `QTRY_VERIFY` should wait up to 5 seconds until condition is met. `qWait(250)` shouldn't change much... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma Cc: kmaterka, plasma-devel, Orage,

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. > In theory QTRY_VERIFY should wait up to 5 seconds until condition is met. qWait(250) shouldn't change much... The big difference is that before if one spyFilesAdded is emitted after say 10ms, we'll continue immediately on with the test Whereas now

D21905: [Digital Clock] Open KOrganizer with event details on click

apol added a comment. LGTM +1 INLINE COMMENTS > CalendarView.qml:194 > +// showEventDetails introduced in KF5 5.61 > +enabled: typeof monthView.daysModel.showEventDetails === > "function" > + I'd use instanceof. Also you can depend on a new KF5

D28183: [kioslave/desktop] Attempt at making test more robust

kmaterka added a comment. In D28183#631966 , @davidedmundson wrote: > The failure was always on this line: > > > QCOMPARE(fileItem.targetUrl(), QUrl::fromLocalFile(destFilePath)); Oh, I see. So maybe this:

D21905: [Digital Clock] Open KOrganizer with event details on click

dvratil added a comment. Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21905 To: dvratil, #plasma Cc: broulik, apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D28172: [applets/digital-clock] Fix date sizing in vertical panel

muesli added a comment. Your patch indeed makes the date behave like in previous releases again! However I noticed it's still not quite consistent in its behavior: when I start plasmashell freshly, the date is a lot wider than after resizing it to roughly the same width. I've added a new

D28176: Implement Keyboard Keycode support as suggested in the spec

This revision was automatically updated to reflect the committed changes. Closed by commit R838:cdd01df4e539: Implement Keyboard Keycode support as suggested in the spec (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28176?vs=78134=78168#toc REPOSITORY R838 Flatpak

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. Just to clarify something the failure was always on this line: > QCOMPARE(fileItem.targetUrl(), QUrl::fromLocalFile(destFilePath)); and we saw one thing still have a ".part" suffix. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28107: Fix overlayIcon sometimes not visible

kmaterka added a comment. In D28107#630144 , @davidre wrote: > It seems it is possible to do this (removing stuff from the data engine) after all. I will try to work on this in the next time IMO, ideally `StatusNotifierItemSource` should

D28176: Implement Keyboard Keycode support as suggested in the spec

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. I thought I already had support for this, maybe it got lost somewhere. Looks good otherwise. INLINE COMMENTS > waylandintegration.cpp:386 > +if (m_streamInput && m_fakeInput) { >

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We have an unstable test. KCoreDirLister has a timer involved set to 200ms

D28185: [applet/systemtray] Us model binding instead of copy

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY The `effectiveStatus` parameter was passed as a copy, use proper binding. TEST

D28185: [applet/systemtray] Us model binding instead of copy

apol added a comment. I'm not convinced this is all that better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28185 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson. kmaterka added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Expander arrow should hide when all

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka added inline comments. INLINE COMMENTS > ExpanderArrow.qml:31 > implicitHeight: implicitWidth > -visible: root.hiddenLayout.contentItem.children.length > 0 > +visible: root.hiddenLayout.itemCount > 0 > ideally `root.hiddenLayout.count` should be used, but `count` is not

D28107: Fix overlayIcon sometimes not visible

davidre added a comment. In D28107#631804 , @kmaterka wrote: > In D28107#630144 , @davidre wrote: > > > It seems it is possible to do this (removing stuff from the data engine) after all. I will

D28109: [applets/systemtray] Simplify icon size logic

kmaterka updated this revision to Diff 78185. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28109?vs=78184=78185 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28109 AFFECTED FILES

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

ngraham added a comment. This works, but I wonder if there's a conceptually cleaner way to do it. Not that I know of one, so I'll wait for a #plasma person to comment. Oh and thanks for the code comments. Always very helpful! REPOSITORY R120

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. > OK, one small wait won't kill the world, right? :) Not in a unit test. If it ends up not making a difference I'll revert. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma, kmaterka

D28183: [kioslave/desktop] Attempt at making test more robust

This revision was automatically updated to reflect the committed changes. Closed by commit R120:715be958eaa5: [kioslave/desktop] Attempt at making test more robust (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78194. cblack added a comment. Render tools area background in drawWidgetPrimitive REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78065=78194 BRANCH cblack/toolsarea REVISION DETAIL

D28134: Add ColorUtils

cblack updated this revision to Diff 78188. cblack added a comment. Avoid leaving unused connections; effectively removing leaking state related to item grabbing REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=78187=78188 BRANCH

D28134: Add ColorUtils

cblack added a comment. In D28134#632087 , @davidedmundson wrote: > What's your intended usecase? Generating UI colours from images, icons, etc. and then applying transformations on them to make them more usable. Examples: -

D27669: [kstyle] Tools area

hpereiradacosta added a comment. Hi Carlston, Thanks for the updated patch and screenshot. First I agree that the new (latest) checks on whether the toolbar palette was changed or not are much more elegant and just as efficient as the previous implementation. Second, some more

D28109: [applets/systemtray] Simplify icon size logic

kmaterka updated this revision to Diff 78184. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28109?vs=77865=78184 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28109 AFFECTED FILES

D28183: [kioslave/desktop] Attempt at making test more robust

kmaterka accepted this revision. kmaterka added a comment. This revision is now accepted and ready to land. In D28183#632057 , @davidedmundson wrote: > That won't work as is because I would need to re-run > > const KFileItem fileItem =

D28134: Add ColorUtils

cblack updated this revision to Diff 78187. cblack added a comment. Make brightnessForItem and averageColorForItem take QVariants REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=78069=78187 BRANCH cblack/colour-utils REVISION DETAIL

D27669: [kstyle] Tools area

hpereiradacosta added a comment. In D27669#630974 , @ngraham wrote: > Nice, the colors are better now. I still see a difference in animation speed when the titlebar and toolbar change color though. It's especially visible with the current

Re: CI talk (Was: re: Manner in which kde-gtk-config development is conducted)

El sáb., 21 de mar. de 2020 a la(s) 20:00, Johan Ouwerkerk (jm.ouwerk...@gmail.com) escribió: > Out of interest, apart from the amount of work it might take what > would be the main blocker for using VMs and things like Vagrant boxes > for FreeBSD as the next best thing to containers? I'd ask the

D27669: [kstyle] Tools area

cblack added a comment. In D27669#632147 , @hpereiradacosta wrote: > In D27669#630974 , @ngraham wrote: > > > Nice, the colors are better now. I still see a difference in animation speed when the

D27669: [kstyle] Tools area

cblack added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezetoolsareamanager.cpp:133 > Did you check that this chunk of code (changing the contents margins of the > QMainWindow) has any effect ? I had my doubt so I changed the margin to 100 > instead of 1, added a printout

D27669: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > cblack wrote in breezetoolsareamanager.cpp:133 > This only triggers when the window has no items in the tools area—it's used > in conjunction with line 878 of breezestyle.cpp in order to render a border > at the top of the window. Clear

D27669: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > cblack wrote in breeze.h:104 > With: F8185479: image.png > Without: F8185480: image.png Sorry for the many postings, I had another unrelated comment on these

D27669: [kstyle] Tools area

cblack added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breeze.h:104 > Sorry for the many postings, I had another unrelated comment on these > screeshot: > I find it strange that the toolarea separator color in this screenshot is > brighter than the toolbar separators (the

D27669: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > cblack wrote in breeze.h:104 > The tools area's separator has to separate two large areas of the window and > thus should be stronger than the separators that only have to separate > borderless and backgroundless buttons. As I said, to

D27669: [kstyle] Tools area

ngraham added a comment. Regarding the Tools Area separator color being different: I agree with Hugo, and have voiced this concern before. It's also not consistent with the mockups and IMO the presented justification demonstrates why the different color isn't needed: the Tools Area's

Re: Manner in which kde-gtk-config development is conducted

On Sun, Mar 22, 2020 at 3:27 AM Johan Ouwerkerk wrote: > > On Sat, Mar 21, 2020 at 1:32 AM Ben Cooksley wrote: > > > > Comments welcome. Please note that simply fixing the dependency > > breakage in this case is not enough to resolve this - there are > > underlying issues which need to be

D28185: [applet/systemtray] Us model binding instead of copy

kmaterka updated this revision to Diff 78178. kmaterka added a comment. Bind model as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28185?vs=78169=78178 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28185 AFFECTED FILES

D28185: [applet/systemtray] Us model binding instead of copy

kmaterka added a comment. In D28185#631972 , @apol wrote: > I'm not convinced this is all that better. Without this `effectiveStatus` never changes. Right now it works by happy coincidence - Item is simple destroyed and created in a

Re: Manner in which kde-gtk-config development is conducted

On Sun, Mar 22, 2020 at 3:08 AM David Edmundson wrote: > > You're absolutely right that mistakes were made and have reason to be > frustrated. > > kde-gtk-config is now maintained by new developers. > Plasma has a new influx of new people which is good to see and > something we need to foster

D28185: [applet/systemtray] Use model binding instead of copy

apol added a comment. I like it better now, +1. Please address Kai's comment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28185 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson, apol Cc: apol, plasma-devel, Orage, LeGast00n,

D28172: [applets/digital-clock] Fix date sizing in vertical panel

ngraham added a comment. Yeah, I've noticed that too. I haven't been able to figure out how to improve it. Where it decides to wrap is also not very deterministic. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28172 To: ngraham, #vdg, #plasma Cc: muesli,

D28185: [applet/systemtray] Use model binding instead of copy

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > broulik wrote in AbstractItem.qml:36 > You can simplify this to > > model.status || PlasmaCore.Types.UnknownStatus Done REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28185: [applet/systemtray] Use model binding instead of copy

kmaterka updated this revision to Diff 78181. kmaterka added a comment. Simplify JS REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28185?vs=78178=78181 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28185 AFFECTED FILES

D28185: [applet/systemtray] Use model binding instead of copy

This revision was automatically updated to reflect the committed changes. Closed by commit R120:17153c4ae204: [applet/systemtray] Use model binding instead of copy (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28192: WIP: Refactor dictionary runner

alex created this revision. alex added reviewers: broulik, ngraham, sitter, mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The config key has been moved to a separate file, some foreach have been

CI talk (Was: re: Manner in which kde-gtk-config development is conducted)

On Sat, Mar 21, 2020 at 10:27 PM Ben Cooksley wrote: > > On Sun, Mar 22, 2020 at 3:27 AM Johan Ouwerkerk > wrote: > > > > On Sat, Mar 21, 2020 at 1:32 AM Ben Cooksley wrote: > > > > > > Comments welcome. Please note that simply fixing the dependency > > > breakage in this case is not enough to

D28194: [WIP] Fix loading button icons from qrc

nicolasfella created this revision. nicolasfella added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Allow to use `icon.source: "qrc:/testicon.png"` in buttons. WIP as there

D27837: Fix about page with Qt 5.15

This revision was automatically updated to reflect the committed changes. Closed by commit R169:6223aa661c61: Fix about page with Qt 5.15 (authored by jbbgameich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27837?vs=78200=78201#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST

D28185: [applet/systemtray] Use model binding instead of copy

broulik added inline comments. INLINE COMMENTS > AbstractItem.qml:36 > property Item iconItem > -property int /*PlasmaCore.Types.ItemStatus*/ status > -property int /*PlasmaCore.Types.ItemStatus*/ effectiveStatus > +property int /*PlasmaCore.Types.ItemStatus*/ status:

D21905: [Digital Clock] Open KOrganizer with event details on click

ngraham added a comment. +1 in general. Probably needs a rebase as I twiddled with a lot of this code recently. INLINE COMMENTS > CalendarView.qml:196 > + > +onClicked: { > +monthView.daysModel.showEventDetails(modelData.uid) If there's an

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. That won't work as is because I would need to re-run const KFileItem fileItem = lister->findByUrl(destUrl); REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma Cc: kmaterka, plasma-devel,

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka added a comment. In D28180#632058 , @ngraham wrote: > This works, but I wonder if there's a conceptually cleaner way to do it. Not that I know of one, so I'll wait for a #plasma person to

D28134: Add ColorUtils

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. What's your intended usecase? Is Kirigami the right place? The original scope for that was "core application building blocks". INLINE COMMENTS >

D27869: Separate processcore/{formatter,unit} into its own library

arfrever added a comment. cmake fails with: ... -- Configuring done CMake Error at formatter/declarative/CMakeLists.txt:3 (add_library): Target "FormatterPlugin" links to target "Qt5::Qml" but the target was not found. Perhaps a find_package() call is missing for an

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. ..it made no difference REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma, kmaterka Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78196. cblack added a comment. Check for presence of KDE_COLOR_SCHEME_PATH and utilize it if set REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78194=78196 BRANCH cblack/toolsarea REVISION DETAIL

D27837: Fix about page with Qt 5.15

jbbgameich updated this revision to Diff 78200. jbbgameich added a comment. rebase REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27837?vs=76948=78200 BRANCH about-page-qt-515 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27837

D28194: [WIP] Fix loading button icons from qrc

nicolasfella added a comment. For more context see https://github.com/nextcloud/desktop/issues/1746 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28194 To: nicolasfella, #plasma, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78198. cblack marked 8 inline comments as done. cblack added a comment. Specifically set bottom margin on bottommost toolbar instead of using a metric REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78196=78198

Re: CI talk (Was: re: Manner in which kde-gtk-config development is conducted)

On Sun, Mar 22, 2020 at 12:00 PM Johan Ouwerkerk wrote: > > On Sat, Mar 21, 2020 at 10:27 PM Ben Cooksley wrote: > > > > On Sun, Mar 22, 2020 at 3:27 AM Johan Ouwerkerk > > wrote: > > > > > > On Sat, Mar 21, 2020 at 1:32 AM Ben Cooksley wrote: > > > > > > > > Comments welcome. Please note

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78199. cblack added a comment. Address some feedback and fix issues REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78198=78199 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669

D26956: Remove export header from static install

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:0aa162f2e838: Remove export header from static install (authored by masonm, committed by jbbgameich). REPOSITORY

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir abandoned this revision. ahmadsamir added a comment. OK. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D28079 To: ahmadsamir, #plasma, dfaure, davidedmundson, apol Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,