Re: CI talk (Was: re: Manner in which kde-gtk-config development is conducted)

On Mon, Mar 23, 2020 at 6:53 AM Albert Astals Cid wrote: > > El diumenge, 22 de març de 2020, a les 16:12:04 CET, Ben Cooksley va escriure: > > On Mon, Mar 23, 2020 at 12:49 AM Albert Astals Cid wrote: > > > > > > El diumenge, 22 de març de 2020, a les 3:19:57 CET, Ben Cooksley va > > >

D28214: Add background portal

jgrulich updated this revision to Diff 78271. jgrulich added a comment. Replace my custom function for quoting of arguments with KShell REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28214?vs=78270=78271 BRANCH

D28211: [applets/systemtray] Make Pin button a bit larger

broulik added a comment. F8194458: Screenshot_20200323_102203.png Gets pretty large here, surely bigger than `small` icon size. Maybe another PlasmaComponents 3 issue? REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched

D28209: [applets/notes] Actually hide button row when it's not visible

broulik added a comment. Wouldn't this cause the text field to resize and shift around? Perhaps set `enabled` to false instead. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28209 To: ngraham, #plasma, #vdg Cc: broulik, plasma-devel, Orage, LeGast00n,

D28214: Add background portal

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Implements Background portal, providing APIS related to applications running in the background. Implemented according to:

D26904: Use Qt5 syntax for signal, rename files

alex abandoned this revision. alex added a comment. Abandoning this because of D27503: [KCM Spellchecking] port to KPropertySkeletonItem REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26904 To: alex, mlaurent,

D27098: Konsole Runner: optimize and simplify

alex added inline comments. INLINE COMMENTS > alex wrote in konsoleprofiles.cpp:155 > It has been refactored and is now in line 132/188: > `match.setRelevance((float) term.length() / (float) > data.displayName.length());` Ups, 118 not 188 REPOSITORY R114 Plasma Addons BRANCH

D28167: packagekit: Fix checking of APT::Periodic::Update-Package-Lists

eliac added a comment. On the off-chance it's me you're asking - sure :) (First time contributor, not sure how the process works...) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D28167 To: eliac, #discover_software_store, apol, ngraham Cc:

D18392: [mobile/broadband] Port to SimpleKCM and FormLayout

bshah requested changes to this revision. bshah added a comment. Currently I am working on making this actually functional, so let's drop this diff, my patch already uses the ScrollViewKCM. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex added inline comments. INLINE COMMENTS > apol wrote in konsoleprofiles.cpp:155 > Why has the relevance code been removed? It has been refactored and is now in line 132/188: `match.setRelevance((float) term.length() / (float) data.displayName.length());` REPOSITORY R114 Plasma Addons

D28211: [applets/systemtray] Make Pin button a bit larger

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. +1 for using standard size instead of using an hardcoded size. REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL

D28215: [RFC]: WIP: Make mobile broadband actually functional

bshah created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. bshah requested review of this revision. REVISION SUMMARY Previously it was totally not-functional TEST PLAN currently still need to actually connect to

D28216: [VirtualDesktopInfo] Connect to rowsChanged singal

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Rather than relying on KWin to have reconfigured, which isn't the case when merely changing

D27869: Separate processcore/{formatter,unit} into its own library

ahiemstra added a comment. See https://phabricator.kde.org/D28217 for a fix for that. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D27869 To: ahiemstra, #plasma, davidedmundson Cc: arfrever, zzag, ngraham, plasma-devel, Orage, LeGast00n,

D28217: Fix Formatter library CMake

ahiemstra added inline comments. INLINE COMMENTS > romangg wrote in CMakeLists.txt:30 > I removed experimentally the Qml and Quick package specifiers and it still > compiled. It's in response to the comment here: https://phabricator.kde.org/D27869#632172 REPOSITORY R111 KSysguard Library

D28219: odrs: Remove seemingly unused cache files

apol created this revision. apol added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D28219

D27166: Refactor converter runner

alex updated this revision to Diff 78281. alex added a comment. Allow +/- before values, add testcase Small detail I forgot to add and a testcase for this. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=78121=78281 BRANCH

D28219: odrs: Remove seemingly unused cache files

This revision was automatically updated to reflect the committed changes. Closed by commit R134:a79eb4efa4a6: odrs: Remove seemingly unused cache files (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28219?vs=78280=78283#toc REPOSITORY R134 Discover Software Store

D28218: FileChooser: add option to open file with or without write access

apol added a comment. This is a feature we generally don't show. What's the use-case? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D28218 To: jgrulich, #plasma Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

KDE CI: Plasma » kdeplasma-addons » kf5-qt5 FreeBSDQt5.14 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/kf5-qt5%20FreeBSDQt5.14/4/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 23 Mar 2020 13:16:42 + Build duration: 3 min 20 sec and counting JUnit Tests Name:

D28141: Add KSysGuard::Sensors library

zzag added inline comments. INLINE COMMENTS > Sensor.h:2 > +/* > +Copyright (C) 2019 Vlad Zagorodniy > +Copyright (C) 2020 Arjen Hiemstra Could you please update my last name? git grep -l 'Vlad Zagorodniy' | xargs sed -i 's/Vlad Zagorodniy/Vlad Zahorodnii/g' REPOSITORY R111

D28167: packagekit: Fix checking of APT::Periodic::Update-Package-Lists

This revision was automatically updated to reflect the committed changes. Closed by commit R134:76fcc0ecf29e: packagekit: Fix checking of APT::Periodic::Update-Package-Lists (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D27166: Refactor converter runner

This revision was automatically updated to reflect the committed changes. Closed by commit R114:08bb4ec7370c: Refactor converter runner (authored by alex, committed by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27166?vs=78281=78287#toc REPOSITORY R114 Plasma Addons

D28214: Add background portal

jgrulich updated this revision to Diff 78272. jgrulich added a comment. Avoid potential crash when captured variable goes out of scope REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28214?vs=78271=78272 BRANCH

D28217: Fix Formatter library CMake

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Compiles again on Neon. INLINE COMMENTS > CMakeLists.txt:30 > > -find_package(Qt5 ${QT_MIN_VERSION} REQUIRED CONFIG COMPONENTS DBus Network > Widgets) > +find_package(Qt5

KDE CI: Plasma » kdeplasma-addons » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 23 Mar 2020 12:58:23 + Build duration: 3 min 25 sec and counting CONSOLE OUTPUT

D28217: Fix Formatter library CMake

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY On older versions, install(TARGETS target PUBLIC_HEADER) does not seem to work too well,

D28217: Fix Formatter library CMake

romangg added inline comments. INLINE COMMENTS > romangg wrote in CMakeLists.txt:30 > Accidentally added QML and Quick? I removed experimentally the Qml and Quick package specifiers and it still compiled. REPOSITORY R111 KSysguard Library BRANCH cmake_fixes REVISION DETAIL

D28218: FileChooser: add option to open file with or without write access

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH filechooser-readonly REVISION DETAIL https://phabricator.kde.org/D28218

D28194: [WIP] Fix loading button icons from qrc

mart added inline comments. INLINE COMMENTS > kquickstyleitem.cpp:218 > opt->icon = QIcon(icon.value().toLocalFile()); > +} else if (icon.canConvert() && icon.value().scheme() == > QLatin1String("qrc")) { > +const QString iconUrl = icon.value().mid(3); should

D28217: Fix Formatter library CMake

This revision was automatically updated to reflect the committed changes. Closed by commit R111:7a13a67827ea: Fix Formatter library CMake (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28217?vs=78276=78282 REVISION DETAIL

D28218: FileChooser: add option to open file with or without write access

jgrulich added a comment. In D28218#632843 , @apol wrote: > This is a feature we generally don't show. What's the use-case? The document portal can mount a file to the sandbox either as read-only or with write access. REPOSITORY R838

monday meeting notes from 23/3/2020

Kai Uwe Notifications: * Ported `knotifyconfig` to use `libcanberra` for its sound preview * Makes the preview consistent with what the notification ends up using for playing the sound, since Phonon supports all sorts of formats but canberra is basically just WAV and OGG qqc2-desktop-style: *

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 78275. ahiemstra added a comment. - Don't use PUBLIC_HEADERS, it's not well supported on earlier CMake REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=78080=78275 BRANCH sensors_lib REVISION

D27783: Add new Account portal

jgrulich added a comment. In D27783#632600 , @ngraham wrote: > How can I test this? I don't know if there is any application using this, but I test it with my testing application in libportal. You can get it here:

D28086: Improve CMake handling of GNOME libraries

gikari added a comment. See https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/49 for possible resolution REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28086 To: cblack, #plasma, gikari, apol Cc: apol, plasma-devel, Orage, LeGast00n,

D28192: WIP: Refactor dictionary runner

sitter added a comment. About fixing the UX: There is some kind of preview tech in milou which you can take a look at and maybe build upon. The line space is just never going to be enough for a text only representation of a dict entry, plus it looks fairly forced anyway. So, my thinking

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham added a comment. The size is actually perfect for being a ToolButton: F8194949: Screenshot_20200323_085422.png However yeah, the actual icon size in a ToolButton is `smallMedium`, so I guess the fact that you need to use `small` to get the

D28209: [applets/notes] Actually hide button row when it's not visible

ngraham added a comment. No, there's space reserved for the row even when it's invisible, so the size of the text field doesn't jump around. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28209 To: ngraham, #plasma, #vdg Cc: broulik, plasma-devel, Orage,

D27783: Add new Account portal

ngraham added a comment. Ok. When trying to compile I get the following: In file included from ../libportal/portal-qt5.h:20, from libportal-qt/a370903@@LibPortalQt@sha/../../../libportal-qt/portal_p.h:24, from

D28172: [applets/digital-clock] Fix date sizing in vertical panel

muesli added a comment. While it's not completely consistent yet, it still's an improvement that reverts the recent regression. As such, I'm tempted to say LGTM. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28172 To: ngraham, #vdg, #plasma Cc: muesli,

D28216: [VirtualDesktopInfo] Connect to rowsChanged singal

ngraham added a comment. +1, makes logical sense. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28216 To: broulik, #plasma, hein Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D28129: Read the new message string after rather than before

sitter added a comment. Mh. Not quite what I had in mind but I suppose it makes sense this way. I think we need a test case for the highlighter though :| It totally blows up in my face when I trace a running dolphin because toskip isn't quite right. INLINE COMMENTS >

A new plasma shell: Plasma Bigscreen

Hi all, announcing a new project that has been brewing for a while (was developed mostly internally at Bluesystems for now, even tough in a public repo): It's a plasma shell meant as "welcome screen" for smart tvs, the code can be found at https://invent.kde.org/kde/plasma-bigscreen there is a

D28218: FileChooser: add option to open file with or without write access

ngraham added a comment. Hmm, this seems like the kind of nerdy exposing-implementation-details thing that would be problematic from a UX standpoint. I can see the use cases for wanting to open a read-only file read-write so you can actually save to it, but I think a better UX for this

D26688: WIP: [Night Color] Display time when the next transition will start

zzag updated this revision to Diff 78291. zzag added a comment. Rebase on master. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26688?vs=73686=78291 BRANCH show-next-transition-timings REVISION DETAIL https://phabricator.kde.org/D26688

D27783: Add new Account portal

jgrulich added a comment. In D27783#632940 , @ngraham wrote: > Ah, thanks. LGTM. Would you be okay with me submitting a patch to alter/polish the UI after it lands? Absolutely! REPOSITORY R838 Flatpak Support: KDE Portal for XDG

D28222: Add ShadowedImage and ShadowedTexture items

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds the ShadowedImage and ShadowedTexture items. The first is a QML-only item

D28218: FileChooser: add option to open file with or without write access

ngraham added a reviewer: VDG. ngraham added a comment. In D28218#632918 , @jgrulich wrote: > In D28218#632909 , @ngraham wrote: > > > In D28218#632907 ,

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

This revision was automatically updated to reflect the committed changes. Closed by commit R119:38a874ab82aa: [KCM Spellchecking] port to KPropertySkeletonItem (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27503?vs=77267=78297

D28208: Move sni icon handling logic from data engine to applet

davidre marked 3 inline comments as done and an inline comment as not done. davidre added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:90 > +bottom: iconItem.bottom > +bottomMargin: 0.05 * iconItem.width > +rightMargin: anchors.bottomMargin Hmm

D28218: FileChooser: add option to open file with or without write access

ngraham added a comment. In D28218#632907 , @jgrulich wrote: > but you can restrict the write access if you don't the sandboxed application to modify the file. Under what circumstance would you want that? REPOSITORY R838 Flatpak

D27783: Add new Account portal

jgrulich added a comment. In D27783#632900 , @ngraham wrote: > Ok. When trying to compile I get the following: > > In file included from ../libportal/portal-qt5.h:20, >from

D28218: FileChooser: add option to open file with or without write access

jgrulich added a comment. In D28218#632909 , @ngraham wrote: > In D28218#632907 , @jgrulich wrote: > > > but you can restrict the write access if you don't the sandboxed application to modify the

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham added a subscriber: mart. ngraham added a comment. The PC3 ToolButton has been "fixed" half a dozen times already and I imagine poor @mart is thoroughly sick of it by now... REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL

D28211: [applets/systemtray] Make Pin button a bit larger

mart added a comment. if the size of that button changes in systray, it muct change in calndar too REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL https://phabricator.kde.org/D28211 To: ngraham, #vdg, #plasma, ognarb Cc: mart,

D28211: [applets/systemtray] Make Pin button a bit larger

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. wait, if you mean that you want the pin button with 22x22px icon size, this patch is not correct and it should have no size parameters REPOSITORY R120 Plasma Workspace REVISION

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 804 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/804/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 23 Mar 2020 17:13:18 + Build duration: 5 min 33 sec and counting CONSOLE OUTPUT

D27783: Add new Account portal

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, thanks. LGTM. Would you be okay with me submitting a patch to alter/polish the UI after it lands? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH

D28211: [applets/systemtray] Make Pin button a bit larger

ndavis added a comment. In D28211#632893 , @ngraham wrote: > The size is actually perfect for being a ToolButton: F8194949: Screenshot_20200323_085422.png > > However yeah, the actual icon size in a

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 78298. davidre added a comment. Use units iconsizes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78253=78298 BRANCH sni (branched from master) REVISION DETAIL

D28211: [applets/systemtray] Make Pin button a bit larger

mart added a comment. icon comes from plasma theme, which is F8195182: image.png it needs padding REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28211 To: ngraham, #vdg, #plasma, ognarb, mart Cc: mart, ndavis,

D28208: Move sni icon handling logic from data engine to applet

davidre marked an inline comment as done. davidre added a comment. I think for now we should just recreate the old behaviour from statusnotifieritemsource as this commit is about moving the icon handling. And in a follow up commit we can then change it REPOSITORY R120 Plasma Workspace

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham updated this revision to Diff 78300. ngraham added a comment. Remove all size overrides; the problem is in the Plasma theme icon having no padding and will be fixed there in a different patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

ahmadsamir added a comment. This failed to build on the CI https://build.kde.org/job/Plasma/job/plasma-desktop/, I guess you'll need to bump the min required version of KF5 to 5.69.0. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27503 To: bport, #plasma,

D28218: FileChooser: add option to open file with or without write access

jgrulich added a comment. In D28218#632902 , @ngraham wrote: > Hmm, this seems like the kind of nerdy exposing-implementation-details thing that would be problematic from a UX standpoint. I can see the use cases for wanting to open a read-only

D28218: FileChooser: add option to open file with or without write access

jgrulich added a comment. For the record, GTK file dialog has same option: F8195023: gtkdialog.png "Otevřít soubory pouze pro čtení" -> "Open files as read-only" REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL

D27783: Add new Account portal

This revision was automatically updated to reflect the committed changes. Closed by commit R838:75a8fa728347: Add new Account portal (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 23 Mar 2020 17:13:18 + Build duration: 4 min 0 sec and counting CONSOLE OUTPUT

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

ngraham added a comment. Looks like this failed in the CI. [2020-03-23T17:18:47.106Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/spellchecking/spellcheckingskeleton.cpp:24:10: fatal error: Sonnet/ConfigView: No such file or directory

D28222: Add ShadowedImage and ShadowedTexture items

mart added a comment. +100, works very well here. an api question. it was supposed to be possible to have the corners with independent radius (to have things like an image rounded only at top) would it still be possible with that approach? i guess would be expanding roundedrectangle to

D28222: Add ShadowedImage and ShadowedTexture items

ahiemstra added a comment. Yeah if we split the radius into 4 that should be doable. The shader supports it, just need to bubble everything up all the way to the items. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28222 To: ahiemstra, #kirigami Cc: mart,

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78306. cblack added a comment. Use explicit setting instead of colour palette heuristics REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78303=78306 BRANCH cblack/toolsarea REVISION DETAIL

D27669: [kstyle] Tools area

hpereiradacosta added a comment. Hi Carson, Thanks for the update. At first glance this all look pretty good. I should be able to do some more in depth testing and code review by the end of tomorrow. Hugo REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669

D28209: [applets/notes] Actually hide button row when it's not visible

This revision was automatically updated to reflect the committed changes. Closed by commit R114:7eaad09e1fd1: [applets/notes] Actually hide button row when its not visible (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78303. cblack marked an inline comment as done. cblack added a comment. Drop giant if REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78199=78303 BRANCH cblack/toolsarea REVISION DETAIL

D28209: [applets/notes] Actually hide button row when it's not visible

davidedmundson added a comment. > Wouldn't this cause the text field to resize and shift around? Perhaps set enabled to false instead. That's something layouts do. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28209 To: ngraham, #plasma, #vdg,

D28172: [applets/digital-clock] Fix date sizing in vertical panel

cblack accepted this revision as: VDG, cblack. cblack added a comment. This revision is now accepted and ready to land. Visually looks nice, but would wait on review from a more experienced Plasma person since this looks like it could potentially be problematic and indeterministic at a

D28133: [applets/digital-clock] Switch timezones by clicking on them in the popup

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e5caa59acb13: [applets/digital-clock] Switch timezones by clicking on them in the popup (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28208: Move sni icon handling logic from data engine to applet

kmaterka added inline comments. INLINE COMMENTS > davidre wrote in StatusNotifierItem.qml:90 > Hmm to me it looks it doesn't even have an margin. Or am I reading ` > p.drawPixmap(QRect(m_iconPixmap.width()-size, m_iconPixmap.height()-size, > size, size), overlay->pixmap(size, size),

D28167: packagekit: Fix checking of APT::Periodic::Update-Package-Lists

ngraham added a comment. Very nice patch! May it be the first of many. :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D28167 To: eliac, #discover_software_store, apol, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, semareit,

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added a comment. Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28200 To: develoot, #vdg, #plasma, #frameworks, davidedmundson Cc:

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski added a comment. In D27972#627281 , @ngraham wrote: > In D27972#626302 , @broulik wrote: > > > > > > Could you update the description to be a bit more clear about what exactly has

D28086: Improve CMake handling of GNOME libraries

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:22 > +pkg_check_modules(GIO REQUIRED IMPORTED_TARGET gio-2.0) > +pkg_check_modules(giomm REQUIRED IMPORTED_TARGET giomm-2.4) > + If I understand correctly this line is redundant. > CMakeLists.txt:7 >

D28208: Move sni icon handling logic from data engine to applet

bruns added inline comments. INLINE COMMENTS > kmaterka wrote in StatusNotifierItem.qml:90 > Yes, you are correct, my mistake. So `StatusNotifierItemSource` has no margin > and `KIconLoader` has 5% of icon size - another inconsistency. > What about 'always round when multiplying by a

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > ngraham wrote in filteredfoldermodel.cpp:36 > this handy little function feels like it wants to be in KCoreAddons or > something Now its likely inlined by the compiler ... > ngraham wrote in main.qml:112 >

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

usta added a comment. Not just include problem but also got a problem about new Qt version : [ 64%] Linking CXX shared module ../../bin/kcm_notifications.so /home/usta/kde/src/plasma-desktop/kcms/spellchecking/spellchecking.cpp: In member function ‘void

D28208: Move sni icon handling logic from data engine to applet

ngraham added inline comments. INLINE COMMENTS > kmaterka wrote in StatusNotifierItem.qml:90 > Yes, you are correct, my mistake. So `StatusNotifierItemSource` has no margin > and `KIconLoader` has 5% of icon size - another inconsistency. > What about 'always round when multiplying by a

D28166: Add support for power sensors from lm-sensors

This revision was automatically updated to reflect the committed changes. Closed by commit R106:00f522a7ceec: Add support for power sensors from lm-sensors (authored by raghuraman, committed by ngraham). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D28166: Add support for power sensors from lm-sensors

ngraham added a comment. Nice patch! Keep 'em coming! :) REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D28166 To: raghuraman, mlaurent, davidedmundson Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski updated this revision to Diff 78317. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27972?vs=78315=78317 REVISION DETAIL https://phabricator.kde.org/D27972 AFFECTED FILES applets/nightcolor/package/contents/ui/main.qml applets/nightcolor/plugin/monitor.cpp

D28211: Make Pin buttons consistently sized in System Tray and Clock pop-ups

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3a44e360e01e: Make Pin buttons consistently sized in System Tray and Clock pop-ups (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 78332. bruns marked 2 inline comments as done. bruns added a comment. update REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=78064=78332 BRANCH baloo_config_rework REVISION DETAIL

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 78333. bruns marked 2 inline comments as done. bruns added a comment. update2 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=78332=78333 BRANCH baloo_config_rework REVISION DETAIL

D27972: [NightColor] fix for plasmoid status and tooltip subtext

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. @zzag, is this okay for you? REVISION DETAIL https://phabricator.kde.org/D27972 To: pdabrowski, #plasma, zzag, ngraham, #vdg Cc: broulik, plasma-devel, Orage, LeGast00n,

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski updated this revision to Diff 78315. pdabrowski edited the summary of this revision. pdabrowski edited the test plan for this revision. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27972?vs=77473=78315 REVISION DETAIL

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. Ok, will do. I just have a few comments about the backend bits, just minor stuff. Overall this is really good! I plan to polish the UI after this lands, but left comments on the front-end component anyway so you can sharpen your QML skills (which are quite good

D28154: Add users KCM

ngraham added a comment. Regarding groups, obviously if it isn't a part of this patch, then it isn't a part of this patch. I don't think it makes sense to WONTFIX the idea of it though. I not-infrequenrly wish for a GUI method of changing my user's group membership. Yes, I know how to do it