D28707: Show purpose context menu only when enabled

broulik updated this revision to Diff 80149. broulik added a comment. - Remove caching We update the menu on startup and when settings change, no need to cache it. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28707?vs=79721=80149

D28838: fix the title of the mobile wifi kcm connection editor

tfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. tfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH mobileWifiTitle (branched from master) REVISION DETAIL

D28838: show ssid as title in mobile wifi connection editor

This revision was automatically updated to reflect the committed changes. Closed by commit R116:e527a2f0026f: show ssid as title in mobile wifi connection editor (authored by tfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28262: [applets/analog-clock] Optional minute hand

aloiseau abandoned this revision. aloiseau added a comment. No problem :) If someone find it useful, then he/she will find it there and can apply it locally in its ~/.local/share folder. Note for anyone wanting to apply this patch locally in the future: hiding minute marks around the clock

D28262: [applets/analog-clock] Optional minute hand

ngraham added a comment. Heh. Thanks anyway! And now you have a dev environment set up so your next patch will be easier. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28262 To: aloiseau, #vdg, #plasma, ngraham Cc: broulik, ngraham, aloiseau,

D28072: [GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. So, is it ok to land? If so, approve please. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n,

D28837: Add device icons to KDE Connect context menu

nicolasfella added a comment. Cool, +1 REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28837 To: broulik, #plasma, #kde_connect, fvogt, ndavis Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28799: Refactor and fix the mobile wifi kcm

This revision was automatically updated to reflect the committed changes. Closed by commit R116:7e65fd05b38e: Refactor and fix the mobile wifi kcm (authored by tfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28837: Add device icons to KDE Connect context menu

broulik created this revision. broulik added reviewers: Plasma, KDE Connect, fvogt, ndavis. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Firefox supports setting icons on menus [1]. Chrome refuses to create

D28842: Raise size of default fixed-width font from 9 to 10pt

ngraham created this revision. ngraham added reviewers: VDG, Plasma, KTextEditor, Kate, Konsole. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY See discussion in T12744 .

D28841: Raise size of default fixed-width font from 9 to 10pt

ngraham created this revision. ngraham added reviewers: VDG, Plasma, KTextEditor, Kate, Konsole. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY See discussion in T12744 .

D28792: [Purpose Plugin] Open shared URL when clicking notification

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:ae4890cf6f1a: [Purpose Plugin] Open shared URL when clicking notification (authored by broulik). REPOSITORY R856

D20569: RFC: Use more compact OSD

ngraham added a comment. https://bugs.kde.org/show_bug.cgi?id=344393 now has two duplicates. I would like to propose reconsidering this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc: alexde, achauvel, abetts, ngraham,

Kickoff menu with empty history tab

Hello. It's been bugging me for a long time now but my kickoff menu doesn't display any application nor document in its "History" tab. I thought it was because I was using Debian Testing and that what I thought was a bug would be fixed soon. However, today, on a newly

D28841: Raise size of default fixed-width font from 9 to 10pt

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R135 Integration for Qt applications in Plasma BRANCH even-bigger-hack (branched from master) REVISION DETAIL https://phabricator.kde.org/D28841 To: ngraham, #vdg,

D28072: [GTK Config] Apply color scheme to GTK3 applications

This revision was automatically updated to reflect the committed changes. Closed by commit R99:a5d4ddb3b1a2: [GTK Config] Apply color scheme to GTK3 applications (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D28070: [KRDB] Remove GTK3 color export

This revision was automatically updated to reflect the committed changes. Closed by commit R119:23aeddc99ad6: [KRDB] Remove GTK3 color export (authored by gikari). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28070?vs=9=80165 REVISION DETAIL

D28841: Raise size of default fixed-width font from 9 to 10pt

ngraham added a comment. There's also D28842 if you wanna be the VDG approver for that as well. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH even-bigger-hack (branched from master) REVISION DETAIL

D27972: [NightColor] fix for plasmoid status and tooltip subtext

rscholar added a comment. In D27972#645517 , @pdabrowski wrote: > This widget could probably contain (at least) the information from the tooltip as mocked above or in D26688 . Or maybe even some settings

D20569: RFC: Use more compact OSD

Armstrong added a comment. the solution that @broulik is the ideal. Simply reposition it to a location that is not the center of the screen. Please reconsider adding that. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg

Re: Update on Status of Gitlab Migration

Hi all, While I do like the invent name, I agree there should be a redirect of some sort from git.kde.org to it. The aforementioned Debian salsa server has one as well - https:// git.debian.org/ - a message stating that the new server is 'salsa.debian.org' Cheers, Ivan -- dr Ivan Čukić

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge added a comment. I have finished my corrections. Is it nice now? Thanks. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D28127 To: jjorge, #plasma, davidedmundson, ahiemstra Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28706: Restore old Audio prototype after exportFunction

broulik reclaimed this revision. broulik added a comment. This revision is now accepted and ready to land. Apparently there's no good alternative. In the future might make sense to refactor this to use a `moz-extensions`

D28662: KCM LookAndFeel check widgetStyle availability before applying it

crossi updated this revision to Diff 80067. crossi added a comment. Fix comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28662?vs=79597=80067 REVISION DETAIL https://phabricator.kde.org/D28662 AFFECTED FILES kcms/lookandfeel/kcm.cpp

Re: Update on Status of Gitlab Migration

On Mon, Apr 13, 2020 at 9:29 AM Johan Ouwerkerk wrote: > > On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk > wrote: > > > > > > > > We may need to do on-the-fly conversion of the kde: repo paths if they > > > won't be expressible as 'kde:foo' in the future, but we should have the > > >

Re: Update on Status of Gitlab Migration

On Tue, Apr 14, 2020 at 2:37 PM Nate Graham wrote: > > On 4/13/20 6:59 PM, Ben Cooksley wrote: > > Why do we need to mimic them? > > > > If you Google "KDE Gitlab" then the first hit is invent.kde.org > > . > > To flip it around: why do we need to do something different? I

D28744: Rewrite of the global shortcuts kcm

crossi added inline comments. INLINE COMMENTS > shortcutsmodel.h:83 > +void save(); > +bool needsSave(); > +bool isDefault(); should be const > shortcutsmodel.h:84 > +bool needsSave(); > +bool isDefault(); > + should be const REPOSITORY R119 Plasma Desktop REVISION

D27271: [kcms/colors] RFC: Accent Colours

crossi added a comment. These new properties can be managed by KConfig. It will automatically handle the read/write process and isSaveNeeded/isDefault status. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27271 To: cblack, #plasma, #vdg Cc: crossi,

[Powerdevil] [Bug 383307] Brightness level is not remembered/restoring after sleep and levels up to maximum level

https://bugs.kde.org/show_bug.cgi?id=383307 Méven Car changed: What|Removed |Added CC||meven@enioka.com Status|REPORTED

D27701: [ComboBox] Use transparent dimmer

This revision was automatically updated to reflect the committed changes. Closed by commit R858:2c777b1b4661: [ComboBox] Use transparent dimmer (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27701?vs=76546=80072#toc REPOSITORY R858 Qt Quick Controls 2: Desktop

D26444: [RunnerResultsModel] Watch krunnerrc and reparse configuration when it changed

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. krunner also has horrible file watcher. This either makes sense at a library level (krunner) or in the frontend (krunner) but milou somewhere in the

D28657: [Notifications] Report roleNames in the relevant places

This revision was automatically updated to reflect the committed changes. Closed by commit R120:07dc5c49876c: [Notifications] Report roleNames in the relevant places (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28817: Fix KScreen output identifier position on wayland

bport updated this revision to Diff 80085. bport added a comment. update commit message REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28817?vs=80082=80085 REVISION DETAIL https://phabricator.kde.org/D28817 AFFECTED FILES kcm/CMakeLists.txt

D28818: Identify output according to current applied position, not an unapplied position

bport updated this revision to Diff 80086. bport added a comment. update commit message REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28818?vs=80083=80086 REVISION DETAIL https://phabricator.kde.org/D28818 AFFECTED FILES kcm/config_handler.h

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 80088. davidre added a comment. - Search when entering text and correctly color delegates - use fallback if action doesn't have a friendly name - Remove friend declaration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28817: Fix KScreen output identifier position on wayland

bport added a comment. I don't think we have a leak, on destructor we delete all view qDeleteAll(m_views); REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28817 To: bport, #plasma, meven, ervin Cc: davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n,

D28817: Fix KScreen output identifier position on wayland

anthonyfieroni added a comment. In D28817#647912 , @bport wrote: > I don't think we have a leak, on destructor we delete all view > qDeleteAll(m_views); At that point, when rootObj is nullptr, view is not added to m_views. REPOSITORY

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. Seems fine to me now. You didn't have a developer account right? REPOSITORY R106 KSysguard BRANCH acpi-energy REVISION DETAIL https://phabricator.kde.org/D28127 To: jjorge,

D28792: [Purpose Plugin] Open shared URL when clicking notification

broulik updated this revision to Diff 80070. broulik added a comment. - Remove unrelated changes REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28792?vs=80011=80070 REVISION DETAIL https://phabricator.kde.org/D28792 AFFECTED FILES

D28725: Drop QWindow and explicit devicePixelRatio usage for ComboBox

This revision was automatically updated to reflect the committed changes. Closed by commit R31:0eaf762705d8: Drop QWindow and explicit devicePixelRatio usage for ComboBox (authored by broulik). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28725?vs=79773=80071

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added inline comments. INLINE COMMENTS > ngraham wrote in FullRepresentation.qml:31 > the visibility should be dependent on it having any items in it; or else it's > still visible when Bluetooth is disabled. I though that was done by toolbar.visible = (state == "DevicesState" ||

D28650: [Notifications] Don't reverse() Array

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0fd991aa577a: [Notifications] Dont reverse() Array (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28650?vs=79565=80080 REVISION

D28799: Refactor and fix the mobile wifi kcm

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. I wanted to let @ngraham to review this UI wise, but I see there are no UI changes. I don't follow mobile KCM development so I'm not sure I'm the right person to review this, but it

D28706: Restore old Audio prototype after exportFunction

This revision was automatically updated to reflect the committed changes. Closed by commit R856:08468773f1fe: Restore old Audio prototype after exportFunction (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28799: Refactor and fix the mobile wifi kcm

tfella updated this revision to Diff 80076. tfella added a comment. Minor Fixes REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28799?vs=80029=80076 BRANCH mobileWifiFix (branched from master) REVISION DETAIL

D28817: Fix KScreen output identifier position on wayland

bport created this revision. bport added reviewers: Plasma, meven, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY BUG: 385672 REPOSITORY R104 KScreen REVISION DETAIL

D28818: Identify output according to current applied position, not an unapplied position

bport created this revision. bport added reviewers: Plasma, meven, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Depends on D28817 . REPOSITORY R104 KScreen

D28678: adjust smb kcm size to be sufficient vis a vis headers

This revision was automatically updated to reflect the committed changes. Closed by commit R102:f2c5e10d4af3: adjust smb kcm size to be sufficient vis a vis headers (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28678?vs=79638=80087

D28744: Rewrite of the global shortcuts kcm

davidre marked 5 inline comments as done. davidre added inline comments. INLINE COMMENTS > broulik wrote in main.qml:94 > Is `contentItem` the default property? Yes REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28744 To: davidre, #vdg, #plasma Cc: broulik,

D28034: [Applet] Port to ExpandableListItem

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Those were probably all issues I could find. I will keep using it and if I find something later, I will let you know. Thank you. REPOSITORY R116 Plasma Network Management Applet

D28817: Fix KScreen output identifier position on wayland

bport updated this revision to Diff 80090. bport added a comment. Remove border and shadow REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28817?vs=80085=80090 REVISION DETAIL https://phabricator.kde.org/D28817 AFFECTED FILES kcm/CMakeLists.txt

D28744: Rewrite of the global shortcuts kcm

davidre added inline comments. INLINE COMMENTS > filteredmodel.cpp:41 > +bool displayMatches = > index.data(Qt::DisplayRole).toString().contains(m_filter, > Qt::CaseInsensitive); > +if (!source_parent.isValid() || displayMatches) { > +return displayMatches; If it's a toplevel

D28818: Identify output according to current applied position, not an unapplied position

davidedmundson added a comment. Seems very sensible. +1 Note that kscreen has a commit message schema different to every other KDE policy. See CONTRIBUTING.md at the root level. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28818 To: bport, #plasma, meven,

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 80074. davidre marked 33 inline comments as done. davidre added a comment. Minor things and codestyle REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=79940=80074 BRANCH kcmkeys2 (branched from master)

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge added a comment. In D28127#647747 , @ahiemstra wrote: > Seems fine to me now. You didn't have a developer account right? Yes, I don't. REPOSITORY R106 KSysguard BRANCH acpi-energy REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

davidre added inline comments. INLINE COMMENTS > shortcutsmodel.h:59 > +friend FilteredShortcutsModel; > +enum Roles { > +SectionRole = Qt::UserRole, Nevermind it goes through data, apparently I forgot that I changed that :) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

davidre marked an inline comment as done. davidre added inline comments. INLINE COMMENTS > shortcutsmodel.h:59 > +friend FilteredShortcutsModel; > +enum Roles { > +SectionRole = Qt::UserRole, It does in filterAcceptRows to not have to go through data each time REPOSITORY R119

D28817: Fix KScreen output identifier position on wayland

anthonyfieroni added inline comments. INLINE COMMENTS > output_identifier.cpp:58 > if (!rootObj) { > continue; > } view leaks, no? I see it's not a problem in this patch. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28817 To: bport,

D28817: Fix KScreen output identifier position on wayland

davidedmundson added a comment. Technically this introduces a visual change. Dialog draws a border and shadow by default which appears outside our red border from the QML. I'm pretty sure you can disable it in Dialog, but frankly this looks way better so maybe it's a feature.

D28783: krunner: polish placement

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c963fe873f7c: krunner: polish placement (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28783?vs=80036=80091 REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

davidre edited subscribers, added: davidedmundson; removed: crossi. davidre added a comment. Answering general comments first: In D28744#647378 , @ngraham wrote: > - When a shortcut is to launch an app, and that shortcut's name would be

D28744: Rewrite of the global shortcuts kcm

broulik added a comment. Very nice! I really like the default shortcuts with checkboxes with additional ones to the right. INLINE COMMENTS > filteredmodel.cpp:40 > +const QModelIndex index = sourceModel()->index(source_row, 0, > source_parent); > +bool displayMatches = >

D28467: Converted to Page with a PlasmoidHeading in the heading

ngraham added inline comments. INLINE COMMENTS > niccolove wrote in FullRepresentation.qml:31 > I though that was done by > > toolbar.visible = (state == "DevicesState" || state == "NoDevicesState"); > > At the end of the file. If you try to use the widget standalone, you will > notice that

D28821: [Notifier] Port from KRun::runCommand

This revision was automatically updated to reflect the committed changes. Closed by commit R134:53375168eb03: [Notifier] Port from KRun::runCommand (authored by broulik). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28821?vs=80097=80101

D28817: fix (kcm): correct output identifier position on wayland

davidedmundson accepted this revision. davidedmundson added a comment. Using the protocol makes sense, using a class that does it already makes more sense than duplicating/ Especially as the other OSD is already a dialog. From a plasma side, ship it REPOSITORY R104 KScreen

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

ngraham updated this revision to Diff 80112. ngraham added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28321?vs=78594=80112 BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

ngraham updated this revision to Diff 80113. ngraham added a comment. Rebase correctly REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28321?vs=80112=80113 BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL

D28817: Fix KScreen output identifier position on wayland

romangg added a comment. Please explain your solution in the summary. I don't directly understand how this change fixes the bug. Thanks. INLINE COMMENTS > CMakeLists.txt:32 > KF5::QuickAddons > +KF5::PlasmaQuick > KF5::Screen lexicographic order > output_identifier.cpp:69 >

D28821: [Notifier] Port from KRun::runCommand

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Use `ApplicationLauncherJob` for launching the main application and `CommandLauncherJob` for

D28821: [Notifier] Port from KRun::runCommand

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D28821 To: broulik, #plasma, apol Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28822: Create StreamRestore channel if none exists

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY We need one channel to be able to control the volume. This

D28818: fix(kcm): Identify output according to current applied position, not an unapplied position

romangg added a comment. Header subject and commit message body must have shorter line length in line with message guideline. Also note regarding capitalization Angular's subject guideline

D28817: fix (kcm): correct output identifier position on wayland

romangg added a comment. Conceptually makes sense. +1 form me on that. Good solution. Thanks for outlining it in the summary. This patch can land with a fix for the view leak or without. I accept when my inline comments are fixed. @davidedmundson: can you give a quick accept on the

D28678: adjust smb kcm size to be sufficient vis a vis headers

mart added a comment. In D28678#644926 , @ngraham wrote: > I really wish that KCMshell didn't add its own scrollview, so we didn't end up with issues like this. The KCM itself should be responsible for its own layouting needs. > > Then

D28817: fix (kcm): correct output identifier position on wayland

bport updated this revision to Diff 80121. bport added a comment. Fix import order (remove unused one) Remove QTimer m_timer (field not used). Let me know if you want this one in a separate commit. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D28714: Refactor enableBluetooth function

This revision was automatically updated to reflect the committed changes. Closed by commit R116:c13704192284: Refactor enableBluetooth function (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28656: KCM LookAndFeel check if splash screen is provided before applying it.

ngraham accepted this revision. ngraham added a comment. LGTM. Stable branch-worthy, probably. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28656 To: crossi, #plasma, ervin, bport, meven, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n,

D28818: fix(kcm): show output ids in reference to currently applied config

This revision was automatically updated to reflect the committed changes. Closed by commit R104:544a7c14946a: fix(kcm): show output ids in reference to currently applied config (authored by bport). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D28817: fix (kcm): correct output identifier position on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R104:538116fd1096: fix (kcm): correct output identifier position on wayland (authored by bport). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28817?vs=80121=80125#toc REPOSITORY R104 KScreen

D28830: Don't set a custom palette if we have the same palette as the currently active one

davidre created this revision. davidre added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Caused some icons not be colored correctly TEST PLAN Close KWrite with unsaved changes, all

D27786: [notifications] Read appname from desktop file if no appname set

nicolasfella marked an inline comment as done. nicolasfella added a comment. ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27786 To: nicolasfella, #plasma, broulik Cc: crossi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28818: fix(kcm): show output ids in reference to currently applied config

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. I changed up the description a bit more (line length!). Please make sure to push with arc so it fetches this description for the commit message. Code change makes sense. Thanks for

D28817: fix (kcm): correct output identifier position on wayland

bport updated this revision to Diff 80120. bport added a comment. fix leak and style REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28817?vs=80090=80120 REVISION DETAIL https://phabricator.kde.org/D28817 AFFECTED FILES kcm/CMakeLists.txt

D28817: fix (kcm): correct output identifier position on wayland

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Thanks. Some minor remaining nitpicks you can change on push. INLINE COMMENTS > output_identifier.cpp:28 > +#include > +#include > Lexicographical order. Also add an empty line to

D28829: Touchpad kcm: On X11 hide scroll speed as it is not supported

meven created this revision. meven added reviewers: KWin, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 420079 TEST PLAN Tested locally REPOSITORY R119 Plasma Desktop BRANCH master

D28817: fix (kcm): correct output identifier position on wayland

romangg added a comment. Yes, please put the m_timer removal in a separate patch. And if you removed the m_timer the QTimer include in the header file can be removed as well I assume. Thanks. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28817 To: bport,

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

This revision was automatically updated to reflect the committed changes. Closed by commit R106:4c6c5638ef15: Add some new battery sensors : energy_now, energy_full and power_now. (authored by jjorge, committed by ngraham). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

ngraham added a comment. I've landed this for you. Keep up the great work! REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D28127 To: jjorge, #plasma, davidedmundson, ahiemstra Cc: ngraham, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28822: Create StreamRestore channel if none exists

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OMG you fixed it! Works for me. Would be great to get this into the stable branch. REPOSITORY R115 Plasma Audio Volume Applet BRANCH volcontrol REVISION DETAIL

D28832: Avoid creating subwindow on internal page widget

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I am kind of thinking the cast should be asserted or if'd. But I suppose that doesn't add much over just letting it crash on the null dereference. REPOSITORY R871 DrKonqi BRANCH

D28833: [kcm/toucpad] Simplify directory structure

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY There's no need for yet another directory in between. Also removes some redundant

D28832: Avoid creating subwindow on internal page widget

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KWallet::openWallet takes a windowId as a parameter. QWidget->winId()

D28817: Fix KScreen output identifier position on wayland

bport added a comment. In D28817#647930 , @anthonyfieroni wrote: > In D28817#647912 , @bport wrote: > > > I don't think we have a leak, on destructor we delete all view > > qDeleteAll(m_views);

D28818: Identify output according to current applied position, not an unapplied position

romangg requested changes to this revision. romangg removed reviewers: meven, ervin. romangg added a comment. This revision now requires changes to proceed. Message guideline must be adhered. Summary must be more extensive. REPOSITORY R104 KScreen REVISION DETAIL

D28034: [Applet] Port to ExpandableListItem

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b494e08b9bfa: [Applet] Port to ExpandableListItem (authored by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D28034: [Applet] Port to ExpandableListItem

ngraham added a comment. Woohoo! REPOSITORY R116 Plasma Network Management Applet BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL https://phabricator.kde.org/D28034 To: ngraham, #vdg, #plasma, jgrulich Cc: gvgeo, plasma-devel, Orage, LeGast00n,

D28817: Fix KScreen output identifier position on wayland

romangg requested changes to this revision. romangg removed reviewers: meven, ervin. romangg added a comment. This revision now requires changes to proceed. Message guideline must be adhered. Summary must be more extensive. REPOSITORY R104 KScreen REVISION DETAIL

D28703: Make KAccess a regular startup application

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6df845ee5373: Make KAccess a regular startup application (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28703?vs=79713=80094

D28703: Make KAccess a regular startup application

broulik added a comment. Autostart doesn't appear to respect that property and I don't think we just want to check `KService::noDisplay()` *but* kaccess appears to launch and even screen reader works. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28703

D28832: Avoid creating subwindow on internal page widget

This revision was automatically updated to reflect the committed changes. Closed by commit R871:262389b1e49b: Avoid creating subwindow on internal page widget (authored by davidedmundson). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28832?vs=80133=80138

  1   2   >