D28154: Add users KCM

2020-05-06 Thread Nathaniel Graham
ngraham added a comment. Changing a user's avatar and clicking Reset instead of Apply makes the avatar display revert to the default avatar (which I remember you telling me isn't actually possible), not the previous one. This seems inaccurate because the avatar does in fact remain at the

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

2020-05-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R135:f9f3f6ca260a: Use Standard Show/Hide Hidden files shortcuts in directory chooser dialog (authored by ngraham). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Christoph Feck
cfeck added a comment. Instead of darker, you could use the text color with very small alpha. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n,

D28154: Add users KCM

2020-05-06 Thread Nathaniel Graham
ngraham added a subscriber: mart. ngraham added a comment. Nice, that fixes the last of the avatar issues that I can find. After you add icons to the items in the keep/delete menu and make it close it with a click outside the menu, I think I'll be done reviewing the UI--other than the

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Noah Davis
ndavis added a comment. In D29081#665226 , @cblack wrote: > In D29081#665203 , @ndavis wrote: > > > Big +1 to the idea, but this shouldn't use `darker()` because that won't look right in Breeze

D28154: Add users KCM

2020-05-06 Thread Carson Black
cblack updated this revision to Diff 82158. cblack marked 9 inline comments as done. cblack added a comment. Address code and icon feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82150=82158 BRANCH arcpatch-D28154 REVISION

D28194: Fix loading button icons from qrc

2020-05-06 Thread Kevin Ottens
ervin added a comment. In D28194#632629 , @apol wrote: > Fixing QIcon would make sense but I'd say getting this in is not the worst thing either. I don't think it's QIcon's fault to be honest. The pattern used in several places of

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-05-06 Thread Nathaniel Graham
ngraham updated this revision to Diff 82140. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27845?vs=79514=82140 BRANCH iotm-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D27845

D29466: [applets/appmenu] Add search to global application menu

2020-05-06 Thread Mikhail Zolotukhin
gikari added a comment. Is it possible to integrate the search into the help menu, if it exists already or create an entry for it. Much like macOS does. F8290151: Screenshot_20200506_214642.png REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-06 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 82143. gikari edited the summary of this revision. gikari edited the test plan for this revision. gikari added a comment. - Use unique_ptr for buttons - Propagate events to buttons Things to do: - Figure out why does this only work with some

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-05-06 Thread Nathaniel Graham
ngraham added a comment. So now with this patch, the new default panel height is 46px. It seems like there's still a camp that would prefer a smaller value, though and I don't want to steamroll over them. However I agree with @veggero that the 42 and 44px sizes look odd given the current

D28154: Add users KCM

2020-05-06 Thread Carson Black
cblack updated this revision to Diff 82150. cblack added a comment. Fix faceValid checking REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82137=82150 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTED

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-06 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 82167. gikari added a comment. - Make buttons work with Breeze theme by respecting pallete. REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28623?vs=82143=82167 BRANCH decorations-appearance

D29466: [applets/appmenu] Add search to global application menu

2020-05-06 Thread Carson Black
cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack updated this revision to Diff 82125. cblack added a comment. cblack updated this revision to Diff 82138. cblack added a dependency: D29486:

D29466: [applets/appmenu] Add search to global application menu

2020-05-06 Thread Carson Black
cblack updated this revision to Diff 82141. cblack added a comment. Add better non-Wayland guards REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29466?vs=82138=82141 BRANCH cblack/appmenu-search (branched from master) REVISION DETAIL

D29466: [applets/appmenu] Add search to global application menu

2020-05-06 Thread Carson Black
cblack updated this revision to Diff 82144. cblack added a comment. Clear search text on application change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29466?vs=82141=82144 BRANCH cblack/appmenu-search (branched from master) REVISION DETAIL

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Niccolò Venerandi
niccolove accepted this revision as: niccolove. niccolove added a comment. This revision is now accepted and ready to land. VDG wise, this looks good and consistent. REPOSITORY R31 Breeze BRANCH menu-title-looks-less-like-a-menu-item (branched from master) REVISION DETAIL

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Nathaniel Graham
ngraham planned changes to this revision. ngraham added a comment. I messed up the rounded top corner too. Will revise. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: ndavis, niccolove, broulik, plasma-devel,

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Carson Black
cblack added a comment. In D29081#665203 , @ndavis wrote: > Big +1 to the idea, but this shouldn't use `darker()` because that won't look right in Breeze Dark. Personally, I think this will look fine when always using `darker()`.

D29466: [applets/appmenu] Add search to global application menu

2020-05-06 Thread Carson Black
cblack added a comment. In D29466#665145 , @gikari wrote: > Is it possible to integrate the search into the help menu, if it exists already or create an entry for it. Much like macOS does. > F8290151: Screenshot_20200506_214642.png

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Big +1 to the idea, but this shouldn't use `darker()` because that won't look right in Breeze Dark. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Christoph Feck
cfeck added a comment. What a small difference that makes such a large difference! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n,

D29467: [applets/batterymonitor] Collapse inhibitions list properly

2020-05-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ce6a0ec0aa6a: [applets/batterymonitor] Collapse inhibitions list properly (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28154: Add users KCM

2020-05-06 Thread Carson Black
cblack updated this revision to Diff 82137. cblack added a comment. begone, kule REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82135=82137 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTED FILES

D28194: [WIP] Fix loading button icons from qrc

2020-05-06 Thread Nicolas Fella
nicolasfella updated this revision to Diff 82149. nicolasfella added a comment. - Also handle ':/' prefix REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28194?vs=78197=82149 BRANCH qrcicons REVISION DETAIL

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-05-06 Thread Nathaniel Graham
ngraham updated this revision to Diff 82142. ngraham added a comment. Round up to nearest even number REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27845?vs=82140=82142 BRANCH iotm-by-default (branched from master) REVISION DETAIL

D29490: This removes the negative top margin, as it's already removed by the NotificationPopup

2020-05-06 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R120:571f0aba2fc5: This removes the negative top margin, as its already removed by the… (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29476: WIP: Port klipper to use wayland clipboard

2020-05-06 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > CMakeLists.txt:16 > +ecm_add_qtwayland_client_protocol(systemclipboard_SRCS > +PROTOCOL > /home/david/projects/kde5/src/kde/workspace/kwayland-server/src/protocols/wlr-data-control-unstable-v1.xml > +BASENAME wlr-data-control-unstable-v1

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-05-06 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY D27845 seems to have turned into a compromise that

D28154: Add users KCM

2020-05-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Great. From my perspective this is ready to go! I'd like a #plasma person to review too, and for @mart or another #plasma

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-05-06 Thread Nathaniel Graham
ngraham added a comment. Since I'm not feeling a lot of enthusiasm for this patch, I've submitted an alternative that fully implements the proposal in T12441 with no design compromises: D29501: Use left-aligned thickened panel with IOTM populated with

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

2020-05-06 Thread Nathaniel Graham
ngraham added a comment. JFYI I know this kind of thing needs a lot of discussion so I'm not gonna rush to land it if people accept or offer +1s, so don't be shy about that. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29501 To: ngraham, #vdg, #plasma

D29476: WIP: Port klipper to use wayland clipboard

2020-05-06 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > ngraham wrote in CMakeLists.txt:16 > I don't seem to have your home directory on my system :) Never mind :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29476 To: davidedmundson, #kwin Cc: ngraham, cblack,

D29469: Icon in system tray missing when WireGuard connection active on startup

2020-05-06 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R116:040a5c8ce9b0: Icon in system tray missing when WireGuard connection active on startup (authored by andersonbruce, committed by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES

D27669: [kstyle] Tools area

2020-05-06 Thread Noah Davis
ndavis added a comment. Reposting here so that it won't be forgotten. Some windows are lacking the underline: F8288512: Screenshot_20200506_002747.png F8288514: Screenshot_20200506_002908.png For some

D29234: Fix various bugs introduced with heading

2020-05-06 Thread Niccolò Venerandi
niccolove updated this revision to Diff 82062. niccolove added a comment. Remove inHistory change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=82060=82062 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

2020-05-06 Thread Niccolò Venerandi
niccolove added a comment. Sorry, I'll make a different patch for that REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29234: Fix various bugs introduced with heading

2020-05-06 Thread Kai Uwe Broulik
broulik added a comment. > I added one last thing Can we please not mix behavior changes into a patch that fixes bugs and regressions. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-devel,

Re: Information regarding upcoming Gitlab Migration

2020-05-06 Thread Adriaan de Groot
On 2020 mayula d. 1id 07:08:41 CEST Ben Cooksley wrote: > On Fri, May 1, 2020 at 2:46 AM Nate Graham wrote: > > If I'm understanding things, we have solutions to most or all of the > > objections raised so far: > > > > - Projects will be allowed to live in--or at least appear in--multiple > >

Re: Information regarding upcoming Gitlab Migration

2020-05-06 Thread Adriaan de Groot
There are a whole bunch of considerations and use-cases being discussed at once in this thread, and Leinir's post made me think a bit about different actors can interact with "the collection of repositories". One actor is "tooling", as Albert has pointed out. Whatever the resulting structure

Re: Information regarding upcoming Gitlab Migration

2020-05-06 Thread Adriaan de Groot
On 2020 prilula d. 28id 13:35:22 CEST Ben Cooksley wrote: > Would some form of git alias/custom command script that works similar > to the following be suitable? > > git kde-clone skrooge > > That script would then search the appropriate groups (ignoring any > personal repositories including

Re: Information regarding upcoming Gitlab Migration

2020-05-06 Thread Michał Policht
Hi all, Sorry for late response, but project "cutehmi" fits into "sdk" category better than "applications" (technically it's a framework, but I guess "frameorks" is reserved for well integrated KDE Frameworks). Speaking generally on subject, categorization is always problematic. Categories

Re: Information regarding upcoming Gitlab Migration

2020-05-06 Thread Piyush Aggarwal
On Mon, 27 Apr, 2020, 4:09 pm Aleix Pol, wrote: > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > replies] > > > > Hello Community members, > > > > In view of upcoming Gitlab migration, we sysadmin team wants to

D29234: Fix various bugs introduced with heading

2020-05-06 Thread Niccolò Venerandi
niccolove requested review of this revision. niccolove marked 4 inline comments as done. niccolove added a comment. I added one last thing: I feel like it was not a good idea to show the heading in history for notifications that are not in group. I added a inHistory bool, false by default,

D29234: Fix various bugs introduced with heading

2020-05-06 Thread Niccolò Venerandi
niccolove updated this revision to Diff 82060. niccolove added a comment. Address feedback and add inHistory bool REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81791=82060 BRANCH fix_notifications (branched from master) REVISION

D29234: Fix various bugs introduced with heading

2020-05-06 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf6b8353a73f: Fix various bugs introduced with heading (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=82062=82065

D29475: [Global Shortcuts KCM] Also check PortableText

2020-05-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Allows to find keyboard shortcuts without knowing the localized key designation. TEST PLAN

D29474: Add inHistory bool and hide heading on inHistory

2020-05-06 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This hides the plasmoidHeading on history for not grouped notifications REPOSITORY R120 Plasma Workspace BRANCH

D29476: WIP: Port klipper to use wayland clipboard

2020-05-06 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Wayland has an entire new protocol for getting and setting clipboard when we

D29478: [Clipboard Plasmoid] Port to Prison QML import

2020-05-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, vkrause. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Which does the rendering and proper sizing for us, e.g. ensure integer scaling so the

D29468: Update preview images for new "Flow" wallpaper

2020-05-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:54f59eb2bba4: Update preview images for new Flow wallpaper (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29468?vs=82051=82086

D28922: Port Sensor Face loading from plasmoid

2020-05-06 Thread Marco Martin
mart updated this revision to Diff 82089. mart added a comment. - default to linechart - default to textonly - sensorIds highPrioritySensorIds - kill table visualization - TotalSensor->TotalSensors list - SupportsTotalSensor->SupportsTotalSensors REPOSITORY R111 KSysguard Library

D29476: WIP: Port klipper to use wayland clipboard

2020-05-06 Thread Nicolas Fella
nicolasfella added a comment. Isn't this something that should be in QClipboard in an ideal world? Or is that currently not feasible since the protocol is non-standard? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29476 To: davidedmundson, #kwin Cc:

D29478: [Clipboard Plasmoid] Port to Prison QML import

2020-05-06 Thread Nathaniel Graham
ngraham added a comment. +1, very nice. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29478 To: broulik, #plasma, vkrause Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf,

D28333: Add a new daemon for stats monitoring

2020-05-06 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R106:75333fc13159: Add a new daemon for stats monitoring (authored by davidedmundson). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28333?vs=81871=82105 REVISION

D28141: Add KSysGuard::Sensors library

2020-05-06 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 82080. ahiemstra added a comment. - Correct Vlad's name in a few more places - Make comments in SensorInfo_p.h a bit more useful REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=81577=82080 BRANCH

D28141: Add KSysGuard::Sensors library

2020-05-06 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 82081. ahiemstra added a comment. Urgh arc REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=82080=82081 BRANCH sensors_lib REVISION DETAIL https://phabricator.kde.org/D28141 AFFECTED FILES

D29476: WIP: Port klipper to use wayland clipboard

2020-05-06 Thread Vlad Zahorodnii
zzag added a comment. +1 in general. > Not mergable as-is, especially the hardcoded line in CMakeLists but uploaded to show direction. Heh, it seems like we now have a good reason to upstream FindWaylandProtocols.cmake from KWayland to extra-cmake-modules. :-) REPOSITORY R120

D29476: WIP: Port klipper to use wayland clipboard

2020-05-06 Thread Aleix Pol Gonzalez
apol added a comment. In D29476#664751 , @nicolasfella wrote: > Isn't this something that should be in QClipboard in an ideal world? Or is that currently not feasible since the protocol is non-standard? It's more that only few processes

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

2020-05-06 Thread Nathaniel Graham
ngraham updated this revision to Diff 82107. ngraham added a comment. Fix 'Unable to assign [undefined] to QString' warning FIXME REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28321?vs=82038=82107 BRANCH port-to-ExpandableListItem (branched

D29476: WIP: Port klipper to use wayland clipboard

2020-05-06 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > systemclipboard.cpp:61 > + > +#include "qwayland-wlr-data-control-unstable-v1.h" > + Is there a reason this `#include` is all the way down here instead of at the top of the file? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

2020-05-06 Thread Nathaniel Graham
ngraham updated this revision to Diff 82108. ngraham added a comment. Remove TODO comment that was already done REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28321?vs=82107=82108 BRANCH port-to-ExpandableListItem (branched from master)

D29476: WIP: Port klipper to use wayland clipboard

2020-05-06 Thread Aleix Pol Gonzalez
apol added a comment. +1 INLINE COMMENTS > systemclipboard.cpp:63 > + > +class DataControlDeviceManager : public > QWaylandClientExtensionTemplate > +, public QtWayland::zwlr_data_control_manager_v1 Maybe split the DataControl classes into a separate file? > systemclipboard.h:45 >

D29481: Fix blurry icons in KColorSchemeEditor

2020-05-06 Thread Matej Mrenica
mthw created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mthw requested review of this revision. REVISION SUMMARY When using fractional scaling, bottom icons are blurred. This patch fixes the issue. TEST PLAN No side effects. REPOSITORY R119

D28141: Add KSysGuard::Sensors library

2020-05-06 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 82082. ahiemstra added a comment. Maybe right now? REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=82081=82082 BRANCH sensors_lib REVISION DETAIL https://phabricator.kde.org/D28141 AFFECTED

D27669: [kstyle] Tools area

2020-05-06 Thread Nathaniel Graham
ngraham added a comment. In D27669#664515 , @ndavis wrote: > Reposting here so that it won't be forgotten. Some windows are lacking the underline: > > F8288512: Screenshot_20200506_002747.png >

D29474: Add inHistory bool and hide heading on inHistory

2020-05-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Make sure @broulik agrees though REPOSITORY R120 Plasma Workspace BRANCH no_heading_for_ungrouped (branched from master) REVISION DETAIL https://phabricator.kde.org/D29474 To:

D28922: Port Sensor Face loading from plasmoid

2020-05-06 Thread Arjen Hiemstra
ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. Let's get this in and fix anything broken in follow ups. REPOSITORY R111 KSysguard Library BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 To:

D29481: Fix blurry icons in KColorSchemeEditor

2020-05-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:2c46f28170c7: Fix blurry icons in KColorSchemeEditor (authored by mthw, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28333: Add a new daemon for stats monitoring

2020-05-06 Thread Arjen Hiemstra
ahiemstra accepted this revision. ahiemstra added a comment. Let's do this. REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabricator.kde.org/D28333 To: davidedmundson, #plasma, mart, ngraham, ahiemstra Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage,

D29448: Add "Volna" wallpaper

2020-05-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R131:f5e41f9d25ff: Add Volna wallpaper (authored by ngraham). REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29448?vs=82005=82088 REVISION DETAIL

D29449: Use "Flow" wallpaper for Plasma 5.19

2020-05-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R31:00f3ea7b185b: Use Flow wallpaper for Plasma 5.19 (authored by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29449?vs=82049=82087 REVISION DETAIL

D29474: Add inHistory bool and hide heading on inHistory

2020-05-06 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. I kinda think this should be named more generically, e.g. `headerBackgroundVisible` REPOSITORY R120 Plasma Workspace BRANCH no_heading_for_ungrouped (branched from master) REVISION DETAIL https://phabricator.kde.org/D29474 To:

D29481: Fix blurry icons in KColorSchemeEditor

2020-05-06 Thread Matej Mrenica
mthw added a comment. If everything is fine, can you land this, please? Also into 5.18? I am guessing 5.12 is already EOL and 5.19 is not branched yet. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D29481 To: mthw, #plasma, ngraham Cc:

D29476: WIP: Port klipper to use wayland clipboard

2020-05-06 Thread David Edmundson
davidedmundson updated this revision to Diff 82106. davidedmundson added a comment. Fix the klipper code to handle detecting null buffer better X code expected a valid QMimeData object with no contents REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28487: Redesign of system monitor plasmoids

2020-05-06 Thread Marco Martin
mart updated this revision to Diff 82118. mart added a comment. - Controls QQC2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=82117=82118 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487 AFFECTED

D29490: This removes the negative top margin, as it's already removed by the NotificationPopup

2020-05-06 Thread Niccolò Venerandi
niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY The negative top margin was not necessary and causes missing round corners. REPOSITORY R120 Plasma Workspace BRANCH

D28154: Add users KCM

2020-05-06 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > ChangePassword.qml:24 > +import QtQuick.Layouts 1.3 > +import QtQuick.Controls 2.5 > + ...`as QQC2` > CreateUser.qml:24 > +import QtQuick.Layouts 1.3 > +import QtQuick.Controls 2.5 > + ...`as QQC2` > UserDetailsPage.qml:25 > +import

D29140: Fix POTD in lock screen (partly)

2020-05-06 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. So this only fixes the problem when the POTD image has already been cached by the plugin for the desktop wallpaper? While the patch would fix that particular use case, I don't

D28922: Port Sensor Face loading from plasmoid

2020-05-06 Thread Marco Martin
mart updated this revision to Diff 82116. mart added a comment. - move face properties in own file - move face config in own file REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82089=82116 BRANCH mart/sensor_face REVISION DETAIL

D28154: Add users KCM

2020-05-06 Thread Carson Black
cblack updated this revision to Diff 82135. cblack added a comment. Make sure arc diff does what it should REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82048=82135 BRANCH arcpatch-D28154 REVISION DETAIL

D29478: [Clipboard Plasmoid] Port to Prison QML import

2020-05-06 Thread Volker Krause
vkrause added a comment. Technically this looks fine from the Prison POV. Whether the barcode type selection makes sense beyond "because we can" I'm not sure about though (in particular the 1D codes seem to be of questionable use here), but then again that's not something introduced by this

D28922: Port Sensor Face loading from plasmoid

2020-05-06 Thread Marco Martin
mart updated this revision to Diff 82119. mart marked 5 inline comments as done. mart added a comment. - add space REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82116=82119 BRANCH mart/sensor_face REVISION DETAIL

D29474: Add inHistory bool and hide heading on inHistory

2020-05-06 Thread Niccolò Venerandi
This revision was automatically updated to reflect the committed changes. Closed by commit R120:7e4b0979: Add inHistory bool and hide heading on inHistory (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28487: Redesign of system monitor plasmoids

2020-05-06 Thread Marco Martin
mart updated this revision to Diff 82117. mart added a comment. - adapt to api changes - move faces config in own file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=81077=82117 BRANCH mart/mewSystemMonitor REVISION DETAIL

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

2020-05-06 Thread Nathaniel Graham
ngraham added a comment. Ping. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D29238 To: ngraham, #plasma, #frameworks Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

2020-05-06 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 82124. gikari added a comment. - Export decorations as png images Global things to do: - Export decorations in 3 different states: normal, clicked and hovered - Consider exporting in SVG - Write CSS into custom gtk css file REPOSITORY R99

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

2020-05-06 Thread Nathaniel Graham
ngraham updated this revision to Diff 82111. ngraham added a comment. Namespace qqc2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28321?vs=82108=82111 BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL

D29264: New tabs for Breeze

2020-05-06 Thread Manuel Jesús de la Fuente
manueljlin added a comment. In D29264#663444 , @ngraham wrote: > I would suggest to re-add the darkened background for inactive tabs +1 I think it would still look fine with the 1px color line rounded at the top F8289464: image.png