D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

broulik added a comment. > Switching to it would also require user data. How many users use a vertical panel? Yes, please! It also imho depends on the usecase. On a laptop you're more likely to use a left vertical panel than on a giant desktop setup with multiple monitors. REPOSITORY

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

filipf requested changes to this revision. filipf added a comment. This revision now requires changes to proceed. This is a major identity change better suited for Plasma 6. We've never had a vertical panel and are moreover defined by offering a layout familiar to Windows users.

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

filipf added a comment. I'd also be interested if #kde_promo has any insights here. It doesn't seem (?) like we advertise it too much, but I know reviews often praise Plasma for its familiarity for Windows users. Given our major competitor does

D28141: Add KSysGuard::Sensors library

This revision was automatically updated to reflect the committed changes. Closed by commit R111:5cfc09fd4463: Add KSysGuard::Sensors library (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=82082=82181 REVISION

D28922: Port Sensor Face loading from plasmoid

mart updated this revision to Diff 82188. mart added a comment. - remove extra debug REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82185=82188 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED

D29466: [applets/appmenu] Add search to global application menu

nicolasfella added inline comments. INLINE COMMENTS > appmenumodel.cpp:246 > +} > +for (auto : m_menu->findChildren()) { > +if (action->menu() == nullptr) { Extract the list into a variable before iterating, else this might blow up See

D29466: [applets/appmenu] Add search to global application menu

nicolasfella added inline comments. INLINE COMMENTS > appmenumodel.cpp:193 > +removeSearchActionsFromMenu(); > +if (filter == QString()) { > +return; .isEmpty() > appmenumodel.cpp:196 > +} > +auto actions = flatActionList(); > +for (const auto : actions) { const >

D28154: Add users KCM

davidedmundson added a comment. Which release? We need to remove user-manager. We're technically in a repo freeze, and this would involve changing (removing) a repo a breakage of that. Generally this looks quite neat and tidy. A big simplification +++ INLINE COMMENTS

D29394: Add photographic user avatars

filipf added a comment. After additional consideration, I'm not too happy with the car avatar but I did find this: F8292121: Screenshot_20200507_090804.png Speaking of licences, I assume I can leave the CC0 ones at CC0, while the rest should

D28922: Port Sensor Face loading from plasmoid

mart updated this revision to Diff 82185. mart added a comment. - use regexp for multiple sensors - left-alignlegends when they are too wide REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82119=82185 BRANCH mart/sensor_face

D28140: Add a declarative plugin to ProcessCore

This revision was automatically updated to reflect the committed changes. Closed by commit R111:82879c590d99: Add a declarative plugin to ProcessCore (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28140?vs=78360=82182

D28487: Redesign of system monitor plasmoids

mart updated this revision to Diff 82187. mart marked 3 inline comments as done. mart added a comment. - make disk usage a bar chart REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=82118=82187 BRANCH mart/mewSystemMonitor REVISION

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. Every change upsets somebody; that's not a reason to avoid change. We change things when the proposed change is a universal or net improvement, and we leave things the same when it would be worse or no better. So you should evaluate that (and any) patch on its

D29288: Improve PageRouter API

mart added inline comments. INLINE COMMENTS > pagerouter.h:443 > + */ > +Q_PROPERTY(QJSValue watchedRoute READ watchedRoute WRITE setWatchedRoute > NOTIFY watchedRouteChanged) > + could this be just a QStringList? REPOSITORY R169 Kirigami REVISION DETAIL

D29288: Improve PageRouter API

cblack added inline comments. INLINE COMMENTS > mart wrote in pagerouter.h:443 > could this be just a QStringList? It could possibly be a list, but not of pure strings. You want to be able to watch a list of routes? REPOSITORY R169 Kirigami REVISION DETAIL

D29394: Add photographic user avatars

jriddell added a comment. We can't use anything under that Pexels licence, it's non-free. Unsplash and CC0 are good to use. They both explicitly don't need attribution (which is pretty generous), but it's nice to do so and helps clarity in future. Preferably use this format

D29302: Use KSysGuard namespace for KSysGuard library targets

ahiemstra updated this revision to Diff 82193. ahiemstra added a comment. - Add backward-compatibility package config file REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29302?vs=81594=82193 BRANCH lib_namespace REVISION DETAIL

D29394: Add photographic user avatars

ognarb added a comment. CC-0 or any license compatible with CC-BY-SA-4.0 are fine. The Unsplash license is non-free too: "This license does not include the right to compile photos from Unsplash to replicate a similar or competing service. ". REPOSITORY R128 User Manager BRANCH

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

ahiemstra added a comment. > This is a major identity change better suited for Plasma 6. I disagree. I would like Plasma 6 to be a really uneventful release, not one that has a whole bunch of changes. There's going to be enough breakage as it is, let's do things that can be done now,

D29302: Use KSysGuard namespace for KSysGuard library targets

This revision was automatically updated to reflect the committed changes. Closed by commit R111:b1e9126e2087: Use KSysGuard namespace for KSysGuard library targets (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

KonqiDragon added a comment. In D27845#665342 , @ngraham wrote: > Since I'm not feeling a lot of enthusiasm for this patch, I've submitted an alternative that fully implements the proposal in T12441 with no

D29506: rejigger lookup of services by exec

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously we'd simply query for an Exec that contains the primary query word. that is actually

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

davidedmundson added a comment. > There's going to be enough breakage as it is, let's do things that can be done now, now, instead of waiting for some nebulous "Plasma 6". That's a good argument when it comes to adding new code. For flipping defaults it doesn't really apply. We support

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

ngraham added a comment. I don't know if I agree that "Looks like Windows" is a part of Plasma's brand identity, or should be. If anything, we're like //ancient// Windows, with a Windows-95-style Task Manager that everyone else has since moved away from; even Windows itself has used an

D29506: rejigger lookup of services by exec

anthonyfieroni added inline comments. INLINE COMMENTS > servicerunner.cpp:164 > > -QString finalQuery = QStringLiteral("exist Exec and ( (%1) or (%2) > or (%3) or ('%4' ~~ Exec) or (%5) )") > -.arg(keywordTemplate, genericNameTemplate, nameTemplate, >

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

broulik added a comment. Ah, right, we just use the sort filter model, no model from C++. Meh, so I can't think of a better way right now either.. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To: kmaterka, #plasma_workspaces, #plasma, ngraham,

D28154: Add users KCM

davidedmundson added inline comments. INLINE COMMENTS > cblack wrote in kcm.cpp:97 > taking the initials of a user's real name OH! Initial-ise not initialise as in "to prepare" Makes sense :) > usermodel.cpp:37 > +connect(m_dbusInterface, ::UserAdded, > this, [this](const

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b34e88da7a5d: [applets/systemtray] Hide/show expander arrow - regression fix (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28154: Add users KCM

ngraham added a comment. I would like to get this into 5.19, which would mean moving the code back into the user-manager repo, or removing it as a dependency for Plasma 5.19 by requesting an exception to the repo freeze. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D28154 REVISION

D29507: Use KSysGuard namespace for KSysGuard targets

This revision was automatically updated to reflect the committed changes. Closed by commit R106:dbb0b515364b: Use KSysGuard namespace for KSysGuard targets (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29507?vs=82204=82207

D28154: Add users KCM

cblack marked 5 inline comments as done. cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:94 > what's this for? used as a hook for QML to know when the KCM needs to apply > davidedmundson wrote in kcm.cpp:97 > This is an odd method name. > > I don't really

D28154: Add users KCM

cblack updated this revision to Diff 82211. cblack added a comment. Refine method signature and add a comment for less ambiguity REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82210=82211 BRANCH arcpatch-D28154 REVISION DETAIL

D28154: Add users KCM

davidedmundson added inline comments. INLINE COMMENTS > cblack wrote in kcm.cpp:121 > that looks like it could possibly run into race conditions, as the applyjob > is executed asynchronously and IIRC is able to still be running when > everything else, including this, has destructed and removed

D28154: Add users KCM

cblack updated this revision to Diff 82212. cblack added a comment. realize you forgot to change the name of the argument in the body as well REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82211=82212 BRANCH arcpatch-D28154 REVISION

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

rikmills added a comment. Is this to land in 5.19? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, The-Feren-OS-Dev, plasma-devel, Orage,

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

gikari updated this revision to Diff 82206. gikari added a comment. - Render buttons to SVGs REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28623?vs=82167=82206 BRANCH decorations-appearance (branched from master) REVISION DETAIL

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

ngraham added a comment. In D29501#665639 , @filipf wrote: > If user data would show low vertical panel usage, what are we really fixing and for who? Extrapolating from that and presuming that a fair share of them are content with the current

D28154: Add users KCM

cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:121 > Normally the app creating a temp file would clean it up. > > A quick fix would be > file = new QTemporaryFile(this); > > It's sort of leaking the object, but on exit it'll tidy everything up. that looks like

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

broulik added a comment. I would suggest we add a `count` property with a `NOTIFY` signal on the model which is then updated on C++ side? I find that cleaner than doing that from QML like this REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To:

D29507: Use KSysGuard namespace for KSysGuard targets

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY With D29302 all KSysGuard targets have been placed in

D29288: Improve PageRouter API

cblack added inline comments. INLINE COMMENTS > cblack wrote in pagerouter.h:443 > It could possibly be a list, but not of pure strings. You want to be able to > watch a list of routes? Watching a list of routes is probably going to result in both clunky code and clunky API design in return

D28154: Add users KCM

davidedmundson added inline comments. INLINE COMMENTS > cblack wrote in kcm.cpp:121 > whoever is normally cleaning up tempfiles Normally the app creating a temp file would clean it up. A quick fix would be file = new QTemporaryFile(this); It's sort of leaking the object, but on exit it'll

D28154: Add users KCM

nicolasfella added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:97 > OH! > > Initial-ise > > not initialise as in "to prepare" > > Makes sense :) Then it should have a different name, like "getInitials", else the next person will be just as confused REPOSITORY R119

D28154: Add users KCM

davidedmundson added a comment. From my POV. +1 I still need a reply on: "Which release?" REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: mart, yurchor, iasensio, meven, crossi,

D28154: Add users KCM

cblack updated this revision to Diff 82210. cblack marked an inline comment as done. cblack added a comment. Parent the dynamically created user to the model REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82209=82210 BRANCH

D28154: Add users KCM

cblack updated this revision to Diff 82209. cblack marked 4 inline comments as done. cblack added a comment. Address some of the code feedback from d_ed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82158=82209 BRANCH arcpatch-D28154

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

ngraham added a comment. #plasma ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n,

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

kmaterka updated this revision to Diff 82205. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28180?vs=78148=82205 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28180 AFFECTED FILES

D28154: Add users KCM

cblack updated this revision to Diff 82214. cblack marked 4 inline comments as done. cblack added a comment. Parent temporary file to the application REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82212=82214 BRANCH arcpatch-D28154

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ngraham added a comment. There's still disagreement over whether we should do this or the other one, and how to implement them, so I don't think we know what release one of them will land in (if any). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

filipf added a comment. If user data would show low vertical panel usage, what are we really fixing and for who? Extrapolating from that and presuming that a fair share of them are content with the current default, why do we go against that? And if it's just a matter of not touching

D28487: Redesign of system monitor plasmoids

mart updated this revision to Diff 82224. mart added a comment. - adapt to api changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=82187=82224 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487

D28922: Port Sensor Face loading from plasmoid

mart updated this revision to Diff 82223. mart added a comment. - use QJsonArrays for sensors REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=82188=82223 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922

D29394: Add photographic user avatars

filipf added a comment. IANAL but the Pexels and Unsplash licence look the same to me: free to distribute, free to modify, no attribution needed, but don't use it to make a Pexels/Unsplash clone. Someone once noted that neither exists in some FOSS licence database. I'll just ask everyone to

D29517: Remove remaining icons from applets with custom tooltips

ngraham created this revision. ngraham added reviewers: bugseforuns, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Last bits needed for T12778 . CCBUG:

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

asturmlechner closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29514 To: asturmlechner, #plasma, zzag Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29302: Use KSysGuard namespace for KSysGuard library targets

kmaterka added a comment. With this change, plasma-workspace fails to build on my system (Neon User, kdesrc-build) Error message: CMake Warning at /home/konrad/kde/usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:27 (message): The KF5:: namespace for

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

ngraham added a comment. Never mind, @zzag discovered that I didn't have the `xorg-x11-server-sdk` package installed, so nothing to see here, and sorry for the noise! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29514 To: asturmlechner, #plasma, zzag Cc:

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a comment. @davidre can you extract your test improvement to a separate patch? it would help me in another issue and I don't want to "steal" your code :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28208 To: davidre, kmaterka, broulik,

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

ngraham added a comment. Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: -- The following features have been disabled: * XorgServer, XServer header needed for touchpad KCM (X11 backend) --

D29518: Remove remaining icons from applets with custom tooltips

ngraham created this revision. ngraham added reviewers: bugseforuns, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Last bits needed for T12778 . BUG:

D29516: Remove remaining icon from applet with custom tooltip

ngraham created this revision. ngraham added reviewers: bugseforuns, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Last bits needed for T12778 . CCBUG:

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

asturmlechner added a comment. In D29514#665869 , @ngraham wrote: > Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: Where is synaptics-properties.h located on

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

zzag added a comment. In D29514#665869 , @ngraham wrote: > Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: What distro are you running? REPOSITORY R119

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

ngraham added a comment. In D29514#665916 , @cblack wrote: > That's the source package location, not where you'd expect to find the headers for usage by other packages. You'd probably be looking for `/usr/include/xorg/xserver-properties.h`.

D28922: Port Sensor Face loading from plasmoid

zzag added inline comments. INLINE COMMENTS > SensorFaceController.cpp:177 > +if (component->status() != QQmlComponent::Ready) { > +qCritical() << "Error creating component:"; > +for (auto err : component->errors()) { One could argue that "Error creating component" is a

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

ngraham added a comment. In D29514#665911 , @asturmlechner wrote: > In D29514#665869 , @ngraham wrote: > > > Hmm, on my system, the file is located at

D28922: Port Sensor Face loading from plasmoid

ngraham added a comment. Hmm, this doesn't seem to apply cleanly on top of current master. REPOSITORY R111 KSysguard Library BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n,

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

asturmlechner added a comment. In D29514#665912 , @ngraham wrote: > In D29514#665911 , @asturmlechner wrote: > > > In D29514#665869 , @ngraham wrote: >

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY x11 backend of the touchpad KCM uses xserver-properties.h that is part of

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

cblack added a comment. In D29514#665869 , @ngraham wrote: > Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: > > -- The following features have been disabled:

D29264: New tabs for Breeze

abstractdevelop added a comment. Sorry everybody for not seeing all the new comments sooner! :D Ok, it seems like the some corners being rounded is a common complaint, so we should address it. I agree that it looks a little out of place in System Settings. The only trouble is doing this