Re: notes from the Plasma mobile components breakout session

On Wednesday 27 January 2016 16:12:05 Marco Martin wrote: > On Wednesday 27 January 2016, Marco Martin wrote: > > > If so the property is more "refreshing" than "requestingRefresh" > > > > yes, it's a task for the app to set it back when needed > > also, i think since that view is useful for other

Re: Selecting a Plasma logo

On Tuesday, 26 July 2016 15:52:41 BST Sebastian Kügler wrote: > On Tuesday, July 26, 2016 2:54:26 PM CEST Thomas Pfeiffer wrote: > > On 26.07.2016 14:03, Marco Martin wrote: > > > On Tuesday 26 July 2016 12:57:04 kainz.a wrote: > > >> I'm a fan of anditosan circle logo, > > >> > > >> cause it fit'

Re: Breakout: 10 minute test

On Friday, 28 October 2016 10:35:43 BST Marco Martin wrote: > On Friday 28 October 2016 03:01:47 Aleix Pol wrote: > > What do you have in mind? > > Are these things reported? > > Are the things all these people try the same things? > > > > It doesn't sound like a very stable metric to me. > > for

Re: Review Request 129298: RFC: supporting dependencies on KPackage

e.org/r/129298/ > --------------- > > (Updated Oct. 31, 2016, 5:09 p.m.) > > > Review request for KDE Frameworks, Plasma, Dan Leinir Turthra Jensen, and > Marco Martin. > > > Repository: kpackage > > > Descriptio

Re: Review Request 129298: RFC: supporting dependencies on KPackage

> I don't think it should be server-dependent. If anything, if the user > changes the contents server, it might not find the component. > > Dan Leinir Turthra Jensen wrote: > Hmm... a knsrc points to a providers file, which in turn can hold more > than one provide

Re: Review Request 129298: KPackage dependencies support

viewboard.kde.org/r/129298/ > --------------- > > (Updated Nov. 17, 2016, 4 p.m.) > > > Review request for KDE Frameworks, Plasma, Dan Leinir Turthra Jensen, and > Marco Martin. > > > Repository: kpackage > > >

Re: Review Request 129642: Introduce org.kde.kconfig QML import with KAuthorized

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129642/#review101438 --- Ship it! Ship It! - Dan Leinir Turthra Jensen On Dec

[Differential] [Accepted] D4120: add support for display_name in categories

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. We will need to consider the implications of adding functionality into ocs, but technically this would be fine. REPOSITORY R304 KNewStuff BRANCH phab/displayname REVISION DETAIL htt

[Differential] [Accepted] D4121: add support for display_name in categories

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. This being an extension of ocs, we will need to prepare a proposal of this at some point in the not too far distant future. However, as other things (tags etc) are also going to be required

[Differential] [Accepted] D4156: sort alphabetically category list

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. LGTM :) REPOSITORY R304 KNewStuff BRANCH phab/sort REVISION DETAIL https://phabricator.kde.org/D4156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D4118: if is not an archive, always copy

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Right. I think we can sensibly pick this. I would like a comment added, though, that future "don't simply install things" logic should go into the section above this one, rather than into t

D5046: UI feedback when checking for updates

leinir created this revision. leinir added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This provides some very light user feedback when the update check has not been completed. It

D5046: UI feedback when checking for updates

leinir added a comment. In https://phabricator.kde.org/D5046#95122, @apol wrote: > Have you tested what happens during the update? Does it change to "checking for updates"? i have indeed - and no, it retains the "Updates (xxx)" text during an update, and "Installed" changes to "I

D5046: UI feedback when checking for updates

leinir closed this revision. leinir added a comment. Closed by commit https://commits.kde.org/discover/eb8f4ae2b46a0516a99d26b25f120a5be28e910c REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5046 To: leinir, #discover_software_store, apol Cc: apol,

D5145: Mark "all categories missing" kns sources as invalid

leinir created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KNS being, at times, a little twitchy means that we have to handle such things a bit more gracefully. As such, without this code, the KNS ba

D5145: Mark "all categories missing" kns sources as invalid

leinir abandoned this revision. leinir added a comment. That, apparently, is not how arc works. Very sorry. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5145 To: leinir Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5146: Implement UI feedback for long-running searches, and no-results

leinir created this revision. leinir added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If a search takes longer than a couple of seconds, a spinner will face-and-slide in from the b

D5147: Mark "all categories missing" kns sources as invalid

leinir created this revision. leinir added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KNS being, at times, a little twitchy means that we have to handle such things a bit more grac

D5148: Use the back function, rather than pop, when pressing Escape

leinir created this revision. leinir added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This stops things suddenly just disappearing and leaving us with a grey central area. It also

D5147: Mark "all categories missing" kns sources as invalid

leinir closed this revision. leinir added a comment. Closed by commit 1db3b40cc4f979cc8c50dcfc1a41cddcce973ae7 INLINE COMMENTS > apol wrote in KNSBackend.cpp:111 > Could be moved into a proper slot? It /is/ starting to be more than trivial code in there, that'd make sense, yeah. i'm sure th

D5146: Implement UI feedback for long-running searches, and no-results

leinir added a comment. In https://phabricator.kde.org/D5146#97069, @mart wrote: > just an heads up: ui reviews with VDG as reviewers should have a screenshot attached Ah, thank you yes - there /is/ a video which some of the VDG has already seen on the Discover telegram group, bu

D5146: Implement UI feedback for long-running searches, and no-results

leinir edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5146 To: leinir, apol, #vdg Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5148: Use the back function, rather than pop, when pressing Escape

leinir closed this revision. leinir added a comment. Closed by commit efe7d505eb294b11cc6d513ed8448cd5b8eab668 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5148 To: leinir, apol, #discover_software_store Cc: plasma-devel, progwolff, lesliezhai, ali

D5146: Implement UI feedback for long-running searches, and no-results

leinir closed this revision. leinir added a comment. Closed by commit 73b61fcdf1408871de85d60c7341e283194b92c6 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5146 To: leinir, apol, #vdg Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jens

D5240: Stop perpetual search state for StaticXml KNS stuff

leinir created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If this code is the other way around, as the comment says, because of the direct connect nature of same-thread signal/slot connection, we may e

D5166: introduce ApplicationItem

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. i am inclined to ship this - there are the following couple of things which do show up, but the item works as expected anyway, and i now have a version of Calligra Gemini using Kirigami for

D5240: Stop perpetual search state for StaticXml KNS stuff

This revision was automatically updated to reflect the committed changes. Closed by commit R134:a8031fead6a6: Stop perpetual search state for StaticXml KNS stuff (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5240?vs=12966

Re: Default touch screen edge gestures

Heyhey :) i do rather like the idea of edge gestures, however i would also quite like to keep in mind applications here... Specifically, other touch-focused UXes all have some kind of concept of edges given over to the applications rather than the system. Windows has the bottom edge, Android

Re: Default touch screen edge gestures

On Tuesday, 11 April 2017 11:32:18 BST Martin Gräßlin wrote: > Am 11. April 2017 11:23:01 MESZ schrieb Dan Leinir Turthra Jensen : > >Heyhey :) > > > >i do rather like the idea of edge gestures, however i would also quite > >like > >to keep in mind applicati

Re: Peruse in KDEReview

On Friday, 25 September 2020 14:22:22 BST Dan Leinir Turthra Jensen wrote: > On Tuesday, 15 September 2020 14:11:42 BST Dan Leinir Turthra Jensen wrote: > > > Hey again, this is your friendly neighbourhood leinir, welcoming further > comments (and thinking that a Friday after

Re: Peruse in KDEReview

On Wednesday, 21 October 2020 11:39:32 BST Dan Leinir Turthra Jensen wrote: > Just under a month since that reminder above went out, so i thought i'd > give a quick poke and say that unless i hear opinions otherwise, i'll > consider this an agreement that things are in decen

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir abandoned this revision. leinir added a comment. In D25961#676900 , @nicolasfella wrote: > @leinir it seems like this was merged so I guess this should be closed? Probably make sense, yeah - it basically got moved to invent and wor

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir added inline comments. INLINE COMMENTS > nicolasfella wrote in kdeplatformdependent.cpp:165 > This sounds like a use case for KCMultiDialog, like e.g. in > https://invent.kde.org/kde/kdeconnect-kde/-/blob/master/settings/main.cpp That certainly could be! i'll take a look, thanks for the

D29057: Introduce PlaceholderMessage component

leinir added a comment. Nice! Got a few places where this could be very handy :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29057 To: ngraham, #vdg, #kirigami, mart Cc: leinir, abetts, broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngr

D29709: Give all OverlaySheets consistent headers

leinir accepted this revision. leinir added a comment. Yay consistency! Good idea (and timely ;) ) REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D29709 To: ngraham, apol, #discover_software_store, #vdg, leinir Cc: leinir, plasma-deve

Re: Unannounced new dependency in plasma-desktop

On Friday, 7 August 2020 22:55:20 BST Ben Cooksley wrote: > Hi Plasma Developers, > > It appears that in the past 24 hours you have introduced new > dependencies in the plasma-desktop repository without announcing them > 2 weeks in advance beforehand. > > This can be seen in the CI system failure

Re: Unannounced new dependency in plasma-desktop

On Saturday, 8 August 2020 12:43:49 BST Rik Mills wrote: > On 08/08/2020 12:22, Dan Leinir Turthra Jensen wrote: > > On Friday, 7 August 2020 22:55:20 BST Ben Cooksley wrote: > >> Hi Plasma Developers, > >> > >> It appears that in the past 24 hours you have int

Re: Unannounced new dependency in plasma-desktop

On Saturday, 8 August 2020 13:22:05 BST Ben Cooksley wrote: > On Sat, Aug 8, 2020 at 11:22 PM Dan Leinir Turthra Jensen > > wrote: > > On Friday, 7 August 2020 22:55:20 BST Ben Cooksley wrote: > > > Hi Plasma Developers, > > > > > > It appears that in

Peruse in KDEReview

Hello there :) i've just moved Peruse to KDEReview. It is a comic book reader app and an accompanying creation tool, both based on Kirigami, and targeted both for desktops and mobile (hence the many email lists you may find this email on). The current website is at https://peruse.kde.org/ a

Re: Peruse in KDEReview

On Tuesday, 15 September 2020 19:34:23 BST Albert Astals Cid wrote: > El dimarts, 15 de setembre de 2020, a les 15:11:42 CEST, Dan Leinir Turthra Jensen va escriure: > > where you might grab in particular Pepper & Carrot Volume 1, which also > > will show you some of the fanc

Re: Peruse in KDEReview

On Tuesday, 15 September 2020 19:34:23 BST Albert Astals Cid wrote: > Which seems to point that there's something broken somewhere. There we go... a mutex and a few mutex lockers later, and i... think it's happy? Give it a proper shove and see if it still falls over for you ;) -- ..dan / lein

Re: Peruse in KDEReview

On Wednesday, 16 September 2020 21:00:00 BST Albert Astals Cid wrote: > Missing i18n? Indeed, and sorted! Thanks for spotting those :) -- ..dan / leinir.. http://leinir.dk/

Re: Peruse in KDEReview

On Tuesday, 15 September 2020 14:11:42 BST Dan Leinir Turthra Jensen wrote: Hey again, this is your friendly neighbourhood leinir, welcoming further comments (and thinking that a Friday afternoon would be a sensible time to do this, to catch the people who weren't caught on the Tuesd

D16776: Better error handling in KNewStuff backend

leinir created this revision. leinir added reviewers: Discover Software Store, apol. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Previously error handling was

D16776: Better error handling in KNewStuff backend

leinir marked 2 inline comments as done. leinir added a comment. In D16776#356741 , @apol wrote: > Where will the `All categories are missing` error fall right now? That is a configuration file error (which is the case, unless there's a n

D16776: Better error handling in KNewStuff backend

leinir updated this revision to Diff 45355. leinir marked 2 inline comments as done. leinir added a comment. Address @apol's comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16776?vs=45166&id=45355 REVISION DETAIL https://phabricat

D16776: Better error handling in KNewStuff backend

This revision was automatically updated to reflect the committed changes. Closed by commit R134:7f6caf385809: Better error handling in KNewStuff backend (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16776?vs=45355&id=4539

D17050: Allow clicking of links in app descriptions

leinir created this revision. leinir added reviewers: Discover Software Store, apol. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this patch, links fou

D17050: Allow clicking of links in app descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit R134:8bea95730eab: Allow clicking of links in app descriptions (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17050?vs=45887&id=458

D17079: Provide a qqc2/kirigami-based about page

leinir added a comment. Basically what Nate said, this is a great idea :) Thinking that having this is already an improvement, but also perhaps that having it as a scrollable page would indeed feel more natural here rather than tabs... Thinking this seems like a good place to use the fact th

D17177: Drop tab-based UI for the about page

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. It does seem that the bugAddress being an email address is a bit odd... The address given by KAboutData::bugAddress

D17177: Drop tab-based UI for the about page

leinir added a comment. Ah yes, somehow i managed to miss the button @colomar mentions, which does the bug reporting linkage already. Removing the link in favour of just keeping that button seems a sensible option :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabri

D17177: Drop tab-based UI for the about page

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Lovin' it - i also like how sort of... well, how little code there really is here, QML done absolutely the right way, only the presentation and that's it, nifty :) REPOSITORY R134 Discov

D17216: Move the about page from Discover to Kirigami

leinir added inline comments. INLINE COMMENTS > apol wrote in AboutPage.qml:102 > I do agree it can read a bit weird. > It's generally done on public emails though, I'm not sure why it's bad. > > If we feel better about it, I can drop it and we port it to something else > we're happy with some

D17961: Fix static Kirigami (about page etc)

leinir created this revision. leinir added reviewers: Kirigami, apol, mart. leinir added a project: Kirigami. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Without this patch, if you tried to use the AboutPage component in a static Kirigami

D17961: Fix static Kirigami (about page etc)

This revision was automatically updated to reflect the committed changes. Closed by commit R169:99e9679b44af: Fix static Kirigami (about page etc) (authored by leinir). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17961?vs=48668&id=48670 REVISION DETAIL

D18150: Unbreak the AboutPage layout on smaller devices

leinir created this revision. leinir added reviewers: apol, mart, Kirigami. leinir added a project: Kirigami. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Without this patch, if the about page is scaled down past a certain width (common on

D18150: Unbreak the AboutPage layout on smaller devices

leinir added a comment. In D18150#390493 , @apol wrote: > Can you show a screenshot of before/after so I understand? So far it looks a bit random. Well, the previous state was "crash" so i /could/ take a shot of an empty desktop or a bac

D18150: Unbreak the AboutPage layout on smaller devices

This revision was automatically updated to reflect the committed changes. Closed by commit R169:de624a35bd52: Unbreak the AboutPage layout on smaller devices (authored by leinir). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18150?vs=49143&id=49158 REVISIO

D18180: Fix layout issues in the AboutPage personDelegate component

leinir created this revision. leinir added a reviewer: Kirigami. leinir added a project: Kirigami. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Without this patch, a couple of somewhat odd layout issues would happen in the person delegate w

D18180: Fix layout issues in the AboutPage personDelegate component

leinir added a comment. Before (initial): F6539760: image.png Before (after resizing): F6539762: image.png After (after resizing): F6539758: image.png REPOSITORY

D18246: Fix premature firing of allInitialized signal

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY In case this is in fa

D18246: Fix premature firing of allInitialized signal

leinir added a comment. In D18246#393094 , @ngraham wrote: > Nice catch. Looks like this might fix 401334? i think that is precisely what's going on there, yes - the symptoms certainly match :) REPOSITORY R134 Discover Software Store

D18246: Fix premature firing of allInitialized signal

This revision was automatically updated to reflect the committed changes. Closed by commit R134:798514c11668: Fix premature firing of allInitialized signal (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18246?vs=49451&id=4

D18262: Ensure only one allInitialised emission

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY To ensure we only hav

D18262: Ensure only one allInitialised emission

This revision was automatically updated to reflect the committed changes. Closed by commit R134:88e315953fc0: Ensure only one allInitialised emission (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18262?vs=49523&id=49524

D18318: Prettify and search enable the error page

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY The prettification is

D18320: Search-enable the application page

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Usually the applicati

D18318: Prettify and search enable the error page

leinir added a comment. Yes, quite, of course :D Was going to post one and got sidetracked ;) The shot is identical to the previous state, except for two largeish and contained bits (hence only the one shot): There is a search field shown here where one was missing previously, and there

D18320: Search-enable the application page

leinir added a comment. In D18320#395251 , @ngraham wrote: > Thanks for the copious code comments. Definitely makes things easier to understand in the future. i do prefer to overcomment rather than undercomment... i've come back to thing

D18320: Search-enable the application page

This revision was automatically updated to reflect the committed changes. Closed by commit R134:9aa0a7df1395: Search-enable the application page (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18320?vs=49719&id=49791 REVIS

D18318: Prettify and search enable the error page

leinir added a comment. In D18318#395986 , @ngraham wrote: > +1 for always showing the search field. But that icon looks a bit big. I might make it smaller and lose the opacity. > > Also, while we're prettifying the error page, how about vert

D18318: Prettify and search enable the error page

leinir updated this revision to Diff 49984. leinir added a comment. Changes as discussed: The component is now all nice and centered, and the icon is fully opaque. Yup, much prettier all 'round, and would be nice and easy to turn into a full-on component :) F6559581: image.png

Re: Issue with Discover on the Plasma/5.14 branch

On Monday, 21 January 2019 20:20:24 GMT Nate Graham wrote: > Hello folks, > We have a non-ideal situation with Discover. Its package update > functionality is broken for many users of Plasma 5.14 due to > https://bugs.kde.org/show_bug.cgi?id=399981. > > The fix requires: > - Frameworks 5.54 for >

Re: Issue with Discover on the Plasma/5.14 branch

On Tuesday, 22 January 2019 14:16:34 GMT Nate Graham wrote: > There may be another option too: this has been broken in > Attics+KnewStuff forever, but it only recently regressed in Discover, > perhaps due to this commit: > https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14&id=2bd91b93357318c4f

D18318: Prettify and search enable the error page

leinir updated this revision to Diff 50107. leinir added a comment. Try and pop the the icon above the text, and just use iconsize enormous rather than a hardcoded one, and also raise the whole thing just a bit. And since the plan is to not use a similar layout on the updates page in short o

D18318: Prettify and search enable the error page

leinir updated this revision to Diff 50110. leinir added a comment. In fact, don't need that outer item, so removing that REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18318?vs=50107&id=50110 REVISION DETAIL https://phabricator.kde.org/D

D18318: Prettify and search enable the error page

leinir updated this revision to Diff 50168. leinir added a comment. Hmm... yes, it does seem just perhaps a little more, hmm, pleasing i guess, for lack of a more technical way to say "it looks nice" ;) and most of the time that string will be a little bit shorter than it is, so... yup, updat

D18318: Prettify and search enable the error page

This revision was automatically updated to reflect the committed changes. Closed by commit R134:9144f96baa5c: Prettify and search enable the error page (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18318?vs=50168&id=50217

D18724: Add a timeout for KNS backends

leinir created this revision. leinir added reviewers: ngraham, apol, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This patch will mark

D18724: Add a timeout for KNS backends

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > davidedmundson wrote in KNSBackend.cpp:143 > this already calls setFetching(false). Good spot, i'll just swipe that and get it in :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phab

D18724: Add a timeout for KNS backends

This revision was automatically updated to reflect the committed changes. leinir marked an inline comment as done. Closed by commit R134:003fc9fc9800: Add a timeout for KNS backends (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18724?vs=50845&id=50950#toc REPOSITOR

D18760: Don't accept invalid KNS EntryInternal results

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY In certain cases we m

D18760: Don't accept invalid KNS EntryInternal results

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in KNSBackend.cpp:213 > first arg should be `filtered`. Oh dear! Yes, it should. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18760 To: leinir, apol,

D18760: Don't accept invalid KNS EntryInternal results

leinir updated this revision to Diff 50965. leinir marked an inline comment as done. leinir added a comment. Actually use the filtered list of entries REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18760?vs=50952&id=50965 REVISION DETAIL

D18760: Don't accept invalid KNS EntryInternal results

leinir added a comment. In D18760#405894 , @apol wrote: > Good, now I just wonder why KNS would give us poised entries... Indeed, that would want to be looked at. Essentially, it just forwards the result of the list job from Attica, which

D18760: Don't accept invalid KNS EntryInternal results

This revision was automatically updated to reflect the committed changes. Closed by commit R134:b11cdd776c93: Don't accept invalid KNS EntryInternal results (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18760?vs=50965&id=

D18946: Set parent on newly created fwupd resource

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Without this patch, t

D18946: Set parent on newly created fwupd resource

leinir updated this revision to Diff 51482. leinir added a comment. Slightly different (and more central) approach. This ensures that resources are parented on creation rather than later (such as when being added to the updates list) REPOSITORY R134 Discover Software Store CHANGES SINCE L

D18946: Set parent on newly created fwupd resource

This revision was automatically updated to reflect the committed changes. Closed by commit R134:8c673e79ab45: Set parent on newly created fwupd resource (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18946?vs=51482&id=5148

D19118: Add (and use) a LinkLabel component

leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY The component, which

D19118: Add (and use) a LinkLabel component

This revision was automatically updated to reflect the committed changes. Closed by commit R134:917819ac26f3: Add (and use) a LinkLabel component (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19118?vs=51956&id=52041 REVI

D19179: Use PointingHand when hovering links in Label

leinir created this revision. leinir added reviewers: ngraham, apol, mart, Kirigami. leinir added a project: Kirigami. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This patch simply adds the behaviour usually

D19179: Use PointingHand when hovering links in Label

leinir added a comment. In D19179#416214 , @mart wrote: > that's the thing in question > https://doc.qt.io/qt-5/qml-qtquick-hoverhandler.html Thanks for the link. Hm, i imagine this would probably end up in a late enough release that t

D19179: Use PointingHand when hovering links in Label

leinir added a comment. In D19179#416222 , @filipf wrote: > I had to use I think identical code precisely for this use case recently, however it resulted in increased spacing in ColumnLayout (right after MouseArea). Now I'm just a novice tinkere

D19179: Use PointingHand when hovering links in Label

This revision was automatically updated to reflect the committed changes. Closed by commit R858:632c9cce4a3b: Use PointingHand when hovering links in Label (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19179?vs=52136&id=52197#toc REPOSITORY R858 Qt Quick Controls

D19340: Search new knsrc locations

leinir created this revision. leinir added reviewers: Discover Software Store, apol, ngraham. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Using the search loca

D19340: Search new knsrc locations

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in KNSBackend.cpp:69 > Discover should probably not fallback, i.e. pass false as an argument. > Otherwise the problem will persist. > > This is Plasma 5.16 and by then we should have all applicati

D19340: Search new knsrc locations

leinir updated this revision to Diff 52713. leinir marked an inline comment as done. leinir added a comment. Don't search fallback locations - we're trying to avoid crashes, so unless people update their installation locations, they don't get Discovered:tm: ;) REPOSITORY R134 Discover Softw

D19561: Don't crash if the fwupd error is null

leinir created this revision. leinir added reviewers: Discover Software Store, apol, ngraham. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY I got a difficult-to-

  1   2   3   >