D25844: Add grouping options in Icons-only Task Manager

gvgeo added inline comments. INLINE COMMENTS > layout.js:88 > +// Fit more tasks in this case, that is possible to cut text, > before combining tasks. > +return Math.ceil(length / maximum) * maxStripes() + 1; > +} This has an effect mostly for small displays. On bigger

D25844: Add grouping options in Icons-only Task Manager

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG. gvgeo added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Expose grouping options from 'Task Manager' to 'Icons-only Task Manager'. Also disable the

D25844: Add grouping options in Icons-only Task Manager

gvgeo added a comment. In D25844#574714 , @broulik wrote: > So you want to be able to not group apps in IOTM, that is literally what IOTM is about, isnt it? I don't know what the reasoning between splitting the task managers is. But

D25844: Don't compress tasks before grouping, when task manager is vertical.

gvgeo updated this revision to Diff 71191. gvgeo retitled this revision from "Add grouping options in Icons-only Task Manager" to "Don't compress tasks before grouping, when task manager is vertical.". gvgeo edited the summary of this revision. gvgeo added a comment. In D25844#574741

D25844: Don't compress tasks before grouping, when task manager is vertical

gvgeo updated this revision to Diff 71390. gvgeo retitled this revision from "Don't compress tasks before grouping, when task manager is vertical or icons-only" to "Don't compress tasks before grouping, when task manager is vertical". gvgeo edited the summary of this revision. gvgeo added a

D25844: Don't compress tasks before grouping, when task manager is vertical or icons-only

gvgeo updated this revision to Diff 71388. gvgeo retitled this revision from "Don't compress tasks before grouping, when task manager is vertical." to "Don't compress tasks before grouping, when task manager is vertical or icons-only". gvgeo edited the summary of this revision. gvgeo added a

D26124: Add byte display option in Network Monitor plasmoid

gvgeo updated this revision to Diff 71926. gvgeo added a comment. Correct label of displayUnits in xml. Add values to displayUints options. Correct copyright message. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26124?vs=71921=71926 BRANCH

D26124: Add byte display option in Network Monitor plasmoid

gvgeo updated this revision to Diff 71921. gvgeo added a comment. Add xml display entry, to save the option. Added in the common main.xml. Now the rest 4 system monitor applets will have an extra entry that will not use. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26124: Add byte display option in Network Monitor plasmoid

gvgeo added a comment. I can't find a way to add the new option in the same Interfaces group. If I add Kirigami.FormLayout stops reading the values, even if the layout works. Tried something like this: Kirigami.FormLayout { //

D26124: Add byte display option in Network Monitor plasmoid

gvgeo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Add the option to select between byte and bit display in Network Monitor plasmoid. Bug: 383019 REPOSITORY R120 Plasma Workspace

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

gvgeo added a comment. I get what you mean global, but I'll try to clarify for others, too. Currently, the option in configuration, only works from shortcuts or mouse wheel on task icon. And affects only the default output device, that is selected, at the moment of volume change.

D27199: [Applet]Update layout based on T10470

gvgeo planned changes to this revision. gvgeo added a comment. Clicking and highlight only on the main row, and only when hover. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc:

D27257: [Applet]Move toolbar to the bottom

gvgeo updated this revision to Diff 75291. gvgeo edited the test plan for this revision. gvgeo added a comment. Requested change REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27257?vs=75279=75291 BRANCH flip (branched from

D27257: [Applet]Move toolbar to the bottom

gvgeo updated this revision to Diff 75293. gvgeo added a comment. For some reason arc send both patches together here. Updated with diff. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27257?vs=75291=75293 REVISION DETAIL https://phabricator.kde.org/D27257 AFFECTED FILES

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 75297. gvgeo added a comment. Small improvement of Power Managment checkbox's tooltip code. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74347=75297 BRANCH b3 (branched from master) REVISION

D27257: [Applet]Move toolbar to the bottom

gvgeo added a comment. The was plan to move them all to the bottom, and there are patches for most of them. There is a recent small discussion about it in T10470 . REVISION DETAIL https://phabricator.kde.org/D27257 To: gvgeo, #plasma, #vdg, jgrulich,

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. Added highlight as mention, and brought back background. To do that, had to ignore, theme's margins. I need to clean code, before uploading. **I'm not so sure about this:** When a row is expanded, moving from bottom to top. **Highlight disappears with button,

D27261: [Folder view] Fix binding loop on width

gvgeo added a comment. Also adds smallSpacing at the top. It would not look right with Plasma Components Label, which already has empty space top and bottom. PC3 on the other hand has none... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27261 To:

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76319. gvgeo retitled this revision from "Fix applet configuration ovelap with top line" to "Fixes for applet configuration layout.". gvgeo edited the summary of this revision. gvgeo edited the test plan for this revision. gvgeo added a comment. Added all

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76320. gvgeo added a comment. style restore REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=76319=76320 BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608

D27651: Fixes for applet configuration layout.

gvgeo abandoned this revision. gvgeo added a comment. Accidental patch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27651 To: gvgeo, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27420: [Applet]Improvements for unavailable port.

gvgeo added a comment. Don't see anyone objecting, will commit later. REPOSITORY R115 Plasma Audio Volume Applet BRANCH FreeThePort3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27420 To: gvgeo, #plasma, drosca, ngraham Cc: pino, plasma-devel, Orage, LeGast00n,

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76467. gvgeo added a comment. Added item as a proxy for the devices and applications. This fixed the vertical binding loop. And made scrollbar touch the top and botoom edges. With this patch content is closer, by smallSpacing, to the frame. And

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

gvgeo added inline comments. INLINE COMMENTS > Task.qml:230 > +onAudioIndicatorsEnabledChanged: { > +audioStreamIconLoader.active = audioIndicatorsEnabled; > } Better include hasAudioStream too, or will be active for all tasks, even if it is not visible. REPOSITORY R119

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. I don't see any objections, will push to stable. REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27577 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: ngraham, apol, plasma-devel,

D27734: [Applet/TaskManager]Don't create extra PulseAudio component

gvgeo created this revision. gvgeo added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Use the component already created. TEST PLAN Functionality must stay the same. Test with

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

gvgeo added inline comments. INLINE COMMENTS > main.qml:46 > > +readonly property bool plasmaPaAvailable: > Qt.createComponent("PulseAudio.qml").status === Component.Ready > + I get a feeling there are 2 instances now. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76519. gvgeo added a comment. Removed workaround. (It would be nice to mention breeze theme.) REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76353=76519 BRANCH scaleM (branched from

D27199: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 76526. gvgeo edited the summary of this revision. gvgeo added a comment. rebase REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27199?vs=75906=76526 BRANCH arcpatch-D27199_2 REVISION DETAIL

D27737: Fixed margin of digital clock

gvgeo added a comment. By using paintedWidth size is going to change constantly and will move the rest of the widgets. REPOSITORY R120 Plasma Workspace BRANCH margin_digital_clock (branched from master) REVISION DETAIL https://phabricator.kde.org/D27737 To: niccolove, #vdg, #plasma,

D27737: Fixed margin of digital clock

gvgeo added a comment. I was too late, it does change constantly now. But it depends on the font. The default font has the same width for all numbers, others don't. Wish I could at least help with git, but I struggle with it. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27645: [KCM]Align volume controls row

gvgeo added a comment. In my opinion this is better even without the workaround. Only when scale is 100% for playback devices, look worse (first photo in before-after). REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma,

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Icons were decreased in sized and placed in row with their labels. 'Enable power management' was

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74014. gvgeo added a comment. Clean up REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74013=74014 BRANCH b3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26806 AFFECTED

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo added a comment. I will not touch any more BatteryItem.qml, has a bug with Grid and uses Flow instead. That made very difficult to fix the tooltip and details. R120:d12521b149fa7766fbbeb9957bde14b4a6278928

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74017. gvgeo added a comment. Remove translating of new lines REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74014=74017 BRANCH b3 (branched from master) REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo marked an inline comment as done. gvgeo added a comment. I believe scroolbars should look good, but didn't test the new scrollbars. I use stable builds, where it touches the scrollbar. F7895378: Screenshot_20200121_152405.png Can someone that

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 77017. gvgeo added a comment. Prevent vertical scrollbar from popping on/off internally. Fix title alignment for RTL. I tried splitting into two patches, to separate the height loop changes, but could not find a good point to cut the patch. All the

D27792: [Applet]Fix traffic monitor labels width

This revision was automatically updated to reflect the committed changes. Closed by commit R116:986341a3fae8: [Applet]Fix traffic monitor labels width (authored by gvgeo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. I don't plan to make more patches, for now. But if the problem would not exist with layouts, prefer to do it than make quick bugfixes. But can't see how the Layouts would help with that. Everything can be done without Layouts too AFAIK, just more messy. I want

D27608: Fixes for applet configuration layout.

gvgeo added a comment. There is a problem, I still try to fix... REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf, ngraham Cc: ngraham, filipf, plasma-devel, Orage,

D27874: Disable the audio stream indicator for IOTM

gvgeo added a comment. Disable the mute function then. And maybe add as an option. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27874 To: ndavis, #vdg, #plasma Cc: gvgeo, ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76869. gvgeo edited the test plan for this revision. gvgeo added a comment. Restore code for vertical line. Cannot find a reason this happens or replicate. But realized that the change was unnecessary. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76873. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76519=76873 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645

D27608: Fixes for applet configuration layout.

gvgeo marked an inline comment as done. gvgeo added a comment. I'll give a bit more time, so @filipf gets a chance to check again and accept if possible. REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608

D27422: [KCM]Update Device item layout based on applet

This revision was automatically updated to reflect the committed changes. Closed by commit R115:606c6499750a: [KCM]Update Device item layout based on applet (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76874. gvgeo added a comment. Math round. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76873=76874 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645

D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76884. gvgeo added a comment. Fix rebase. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76874=76884 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D27645

D27792: [Applet]Fix traffic monitor labels width

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, jgrulich, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Use text metrics to set a proper space for labels. And remove unused plotter

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. Is it? INLINE COMMENTS > TrafficMonitor.qml:107 > +// Measure 888.8 KiB/s > +text: KCoreAddons.Format.formatByteSize(910131) + i18n("/s") > +} Biggest number it can display? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D26946: Changed leftMargins to smallSpacing to be consistent

gvgeo added inline comments. INLINE COMMENTS > PopupDialog.qml:120 > boundsBehavior: Flickable.StopAtBounds > -spacing: Math.round(units.gridUnit / 2) > +spacing: Math.round(units.smallSpacing / 2) > I don't see why decrease this spacing. Were you able to

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76908. gvgeo marked an inline comment as not done. gvgeo added a comment. Fixed margins. Unfortunatly the RTL layout has some issues, had to disable the use of available width for RTL layout, to stop the jumping from the scrollview. REPOSITORY R119

D27645: [KCM]Align volume controls row

This revision was automatically updated to reflect the committed changes. Closed by commit R115:ca15ec82c121: [KCM]Align volume controls row (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76884=76909 REVISION

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76910. gvgeo added a comment. Cancel button was touching the edge in RTL. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=76908=76910 BRANCH configscollcat (branched from master) REVISION DETAIL

D27608: Fixes for applet configuration layout.

gvgeo added a comment. Strange, I don't get the resizing problem as it is now, or in master. Only managed to get this space by changing the theme, and was immediately fixed with resize. Thanks Filip for double checking. REPOSITORY R119 Plasma Desktop BRANCH configscollcat

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. #VDG Does a better way exist, to measure the width of transfer speed text? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27792 To: gvgeo, #vdg, #plasma, jgrulich, ngraham Cc:

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo abandoned this revision. gvgeo added a comment. Unfortunately I won't be able to continue with this patch about battery applet. Feel free to use/modify if you want. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg,

D27669: WIP: [kstyle] Tools area

gvgeo added a comment. Filelight works fine here. Kmag has some buttons with wrong color, but the toolbar row takes correct color. With breeze light when changing active window, color changing is not in sync with the titlebar. The timing is a little off, can get dizzy. REPOSITORY R31

D27711: [Applet]Use gridLayout for details

gvgeo abandoned this revision. gvgeo added a comment. In favor of kirigami form. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo added a comment. @davidedmundson ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27645: [KCM]Align volume controls row

gvgeo added a comment. Should I remove the slider workaround? And leave it with 2 pixel offset? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n,

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. ping REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Kirigami in applet? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27608: Fixes for applet configuration layout.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d6731530bb43: Fixes for applet configuration layout. (authored by gvgeo). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=77046=77050 REVISION

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 77046. gvgeo added a comment. Remove title alingment for kirigami change. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=77017=77046 BRANCH configscollcat (branched from master) REVISION DETAIL

D27608: Fixes for applet configuration layout.

gvgeo added inline comments. INLINE COMMENTS > AppletConfiguration.qml:117 > Kirigami.Separator { > -visible: configDialog.configModel > -anchors.left: sidebar.right > -height: root.height > -} > - > -Kirigami.Separator { > +id: topSeparator >

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. In D27577#616579 , @ngraham wrote: > The changes to labels in `Header.qml` seem unrelated. They are as related as the other 4 changes are. Either will make 5 different patches or 1. But I'm not going to change

D27645: [KCM]Align volume controls row

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Align mute button, slider and percent text. Set proper margin for mute. Cut

D27648: [KCM]Set implicitWidth for main page

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Set implicitWidth in the main page for the initial size when opening audio

D27608: Fixes for applet configuration layout.

gvgeo updated this revision to Diff 76356. gvgeo added a comment. Categories touch top and bottom. Removed 1 unnecessary line. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27608?vs=76320=76356 BRANCH configscollcat (branched from master)

D27645: [KCM]Align volume controls row

gvgeo added inline comments. INLINE COMMENTS > VolumeSlider.qml:43 > +// Workaround: Slider has 2 extra pixels at the bottom, used for the > tickmarks, which move it off-center. > +Layout.bottomMargin: -Math.round(slider.implicitHeight / 11) > + I tried to change

D27608: Fixes for applet configuration layout.

gvgeo added a comment. Can't have everything. now will cat line again. F8130965: Screenshot_20200225_140134.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf Cc: ngraham,

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. I would not call them stylistic choice, the position didn't change. And there are included in description. Make Header always fit inside the scrollview area. They had 2 different problems, when the text is too big. As enabled they would cut text left and

D27608: Fix applet configuration ovelap with top line

gvgeo planned changes to this revision. gvgeo added a comment. Will add more related changes here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27577: [KCM]Fix content below scrollbars

gvgeo added a comment. Today for 5.18.2 or can wait? Apol only looked the code for the first change. And I don't know why vertical margins create bind loop, or if Item as a proxy is good. REPOSITORY R115 Plasma Audio Volume Applet BRANCH advanced2 (branched from master) REVISION

D27651: Fixes for applet configuration layout.

gvgeo created this revision. gvgeo added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Fix applet configuration overlap with top line. Change the margins to move scrollbar so that it

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. @ngraham Is there a better way to fix this? In D27199#620730 , @jgrulich wrote: > Looks this changed introduced an issue. The traffic monitor doesn't fit into the applet. > > See picture below: > F8145280:

D27608: Fixes for applet configuration layout.

gvgeo added a comment. > I'm starting to agree that this is the wrong place to add the titlebar separator. Can this go as is, for now? I don't believe there is an alternative in the near future. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27608 To:

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

gvgeo added a comment. IMO this is the wrong way to do these changes. 1. I don't see "itemSize" to be used anywhere else(didn't check) than "tasksRow" where we already add a smallSpacing. It would be best to increase the size in one place. 2. For tablets already allow to use bigger

D27734: [Applet/TaskManager]Don't create extra PulseAudio component

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bfcc6df32396: [Applet/TaskManager]Dont create extra PulseAudio component (authored by gvgeo). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27577: [KCM]Fix content below scrollbars

This revision was automatically updated to reflect the committed changes. Closed by commit R115:552b0384ffd2: [KCM]Fix content below scrollbars (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27577?vs=76467=76836

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 76840. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=76475=76840 BRANCH kcmports3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27422

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. In D27422#614236 , @ngraham wrote: > I'm seeing some weird jagginess on radio buttons, slider handles, and combobox shadows: > > F8112849: Screenshot_20200219_075319.png > >

D27199: [Applet]Update layout based on T10470

This revision was automatically updated to reflect the committed changes. Closed by commit R116:24b737bc6d5c: [Applet]Update layout based on T10470 (authored by gvgeo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Separate patch so can be easily reverted, if a grid+repeater problem exist R120:d12521b149fa . REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27711: [Applet]Use gridLayout for details

gvgeo created this revision. gvgeo added reviewers: Plasma, jgrulich, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Use gridLayout for repeater in DetailsText. Now right mouse menu(copy) opens on

D27420: [Applet]Improvements for unavailable port.

This revision was automatically updated to reflect the committed changes. Closed by commit R115:ada3385d04c3: [Applet]Improvements for unavailable port. (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27648: [KCM]Set implicitWidth for main page

This revision was automatically updated to reflect the committed changes. Closed by commit R115:8dea974eacf0: [KCM]Set implicitWidth for main page (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27648?vs=76358=76480

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 76475. gvgeo added a comment. Hide portbox if window is too small. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=76093=76475 BRANCH kcmports2 REVISION DETAIL

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo updated this revision to Diff 74298. gvgeo added a comment. Change line order. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26861?vs=74297=74298 BRANCH pos2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26861

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo added a comment. Never going to be correct. Sometimes the highlight touches the edges, other times have big margins. The aim was to avoid getting out of the svg frame. These changes focus even more on the breeze theme. Sweet theme has some issues. F7927628:

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo updated this revision to Diff 74297. gvgeo added a comment. This revision is now accepted and ready to land. Increase right margins by 1.2 when need, to avoid highlight area been drawn out of the frame. Various little changes. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74314. gvgeo added a comment. Don't show suppression messages if PM is disabled. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74262=74314 BRANCH b3 (branched from master) REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74222. gvgeo added a comment. Removed battery tooltip (had no extra info). Changed details view. Would be better without colon and without grid arrangement? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, hein, ngraham. gvgeo added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY When vertical or Icon-only task manager, shrink click area 10% and indicator 30%.

D26256: [Applet] Make 'raise maximum volume' global

gvgeo updated this revision to Diff 74192. gvgeo added a comment. Fix volume icons REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=74146=74192 BRANCH raise2 (branched from master) REVISION DETAIL

D26861: [Applet/Task Manager] Move audio indicator to the corner

gvgeo added a comment. Could not pin point a specific size to disable mute function. If it is still a problem with this patch, maybe need to disable it for 5.18, and add a config option in the next release. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo updated this revision to Diff 74228. gvgeo added a comment. Remove detailsLoader visibility REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26806?vs=74222=74228 BRANCH b3 (branched from master) REVISION DETAIL

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo marked 3 inline comments as done. gvgeo added a comment. I marked 3 comments as done that had forgotten, as I removed the old tooltip code. If there is something else, please be more specific. I can not see a better way to address any of your comments. INLINE COMMENTS >

D27138: [Applet]Display device name if more than one devices

gvgeo updated this revision to Diff 75016. gvgeo retitled this revision from "[Applet]Restore naming convention for devices." to "[Applet]Display device name if more than one devices". gvgeo edited the summary of this revision. gvgeo added a comment. Separate check REPOSITORY R115 Plasma

  1   2   3   >