D9349: Fix qmake build of Kirigami

2017-12-18 Thread Ilya Bizyaev
IlyaBizyaev updated this revision to Diff 24073. IlyaBizyaev added a comment. Updated the revision to reflect the last commit in Kirigami REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9349?vs=23972=24073 REVISION DETAIL

D9349: Fix qmake build of Kirigami

2017-12-19 Thread Ilya Bizyaev
IlyaBizyaev closed this revision. IlyaBizyaev added a comment. Closed by https://phabricator.kde.org/R169:b0bf6b85ccd60aecb57c2cd5c54a912fc62d4113. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9349 To: IlyaBizyaev, #kirigami, davidedmundson Cc: davidedmundson,

D9349: Fix qmake build of Kirigami

2017-12-15 Thread Ilya Bizyaev
IlyaBizyaev created this revision. IlyaBizyaev added a reviewer: Kirigami. IlyaBizyaev added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Build with QMake failed as certain files and include paths were missing from .pri and .qrc. This diff

D9349: Fix qmake build of Kirigami

2017-12-15 Thread Ilya Bizyaev
IlyaBizyaev updated this revision to Diff 23972. IlyaBizyaev added a comment. Turns out some files have been removed from Kirigami while I've been sending a patch xD REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9349?vs=23965=23972 REVISION DETAIL

D9349: Fix qmake build of Kirigami

2017-12-15 Thread Ilya Bizyaev
IlyaBizyaev added a comment. No, I don't REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D9349 To: IlyaBizyaev, #kirigami, davidedmundson Cc: davidedmundson, mart, plasma-devel, apol, hein

D10593: Fix qmake warning for Kirigami

2018-02-16 Thread Ilya Bizyaev
IlyaBizyaev added a reviewer: mart. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10593 To: IlyaBizyaev, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D10593: Fix qmake warning for Kirigami

2018-02-16 Thread Ilya Bizyaev
IlyaBizyaev retitled this revision from "Fix qmake warning for " to "Fix qmake warning for Kirigami". IlyaBizyaev edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10593 To: IlyaBizyaev Cc: plasma-devel, apol, davidedmundson, mart,

D10593: Fix qmake warning for

2018-02-16 Thread Ilya Bizyaev
IlyaBizyaev created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. IlyaBizyaev requested review of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10593 AFFECTED FILES

D3588: Remove inexistent file references from kirigami.qrc

2018-02-16 Thread Ilya Bizyaev
IlyaBizyaev abandoned this revision. IlyaBizyaev added a comment. Outdated, was superceded by D3591 . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3588 To: IlyaBizyaev, #kirigami, mart Cc: bearsh, plasma-devel, apol,

D10593: Fix qmake warning for Kirigami

2018-02-16 Thread Ilya Bizyaev
IlyaBizyaev closed this revision. IlyaBizyaev added a comment. Merged by 389f4c29acc3 . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10593 To: IlyaBizyaev, mart Cc: plasma-devel, apol,

D13663: Refactor the Global ToolBar concept

2018-06-21 Thread Ilya Bizyaev
IlyaBizyaev added inline comments. INLINE COMMENTS > ToolBarApplicationHeader.qml:42 > > +Component.onCopleted: print("Warning: ToolbarApplicationHeader is > deprecated, remove and use the automatic internal toolbar instead.") > pageDelegate: Item { A typo :) REPOSITORY R169

D15696: Fix qmake build

2018-09-28 Thread Ilya Bizyaev
IlyaBizyaev closed this revision. IlyaBizyaev added a comment. Closed by 8691651c1f0d09430416ba5fe2130647554b06a9 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15696 To: IlyaBizyaev,

D15696: Fix qmake build

2018-09-22 Thread Ilya Bizyaev
IlyaBizyaev updated this revision to Diff 42145. IlyaBizyaev edited the summary of this revision. IlyaBizyaev added a comment. Indeed, thanks @alexeymin! REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15696?vs=42142=42145 REVISION DETAIL

D15696: Fix qmake build

2018-09-22 Thread Ilya Bizyaev
IlyaBizyaev created this revision. IlyaBizyaev added a reviewer: mart. IlyaBizyaev added a project: Kirigami. Herald added a subscriber: plasma-devel. IlyaBizyaev requested review of this revision. REVISION SUMMARY Add scenepositionattached.* to the qmake project file REPOSITORY R169

D15696: Fix qmake build

2018-09-22 Thread Ilya Bizyaev
IlyaBizyaev added a comment. I'm not sure... You can try building a Kirigami application that uses Kirigami as a qmake submodule, like Kaidan . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D15696 To: IlyaBizyaev, mart Cc:

D10429: Disable the title bar separator by default

2018-09-16 Thread Ilya Bizyaev
IlyaBizyaev added a comment. I'll be that one person here who likes the separator and notices it easily on the Breeze theme. I have no objections to changing the default, but "just removing it entirely" is not an option. REPOSITORY R31 Breeze REVISION DETAIL

D10429: Disable the title bar separator by default

2018-09-16 Thread Ilya Bizyaev
IlyaBizyaev added a comment. I think this line's goal is not really to separate the title bar from window content, but instead to make the transition smoother and emphasize style consistency. Take a look at these 2 screenshots, for example. F6267692: Screenshot_20180916_124803.png

D22000: [colors/Breeze] Change selected text color to black

2019-06-22 Thread Ilya Bizyaev
IlyaBizyaev added a comment. Looks fine in the menu, but black on bright blue in the list model below is just wrong now. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D22000 To: ndavis, #vdg, #breeze, #plasma, ngraham Cc: IlyaBizyaev, ngraham, cfeck, zzag,

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

2019-12-06 Thread Ilya Bizyaev
IlyaBizyaev added a comment. Somehow I also feel Baloo is not a name to be surfaced... 1. It's not really a brand, and if it was, it would have a terrible reputation due to all the user frustration accumulated. 2. Those users on social media who know the name "Baloo" follow KDE

D24768: Fix incorrect Credits model for Kirigami.AboutPage

2019-10-21 Thread Ilya Bizyaev
This revision was automatically updated to reflect the committed changes. Closed by commit R169:9e3407ec40ab: Fix incorrect Credits model for Kirigami.AboutPage (authored by IlyaBizyaev). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24768?vs=68269=68418

D24768: Fix incorrect Credits model for Kirigami.AboutPage

2019-10-18 Thread Ilya Bizyaev
IlyaBizyaev created this revision. IlyaBizyaev added a reviewer: Kirigami. IlyaBizyaev added a project: Kirigami. Herald added a subscriber: plasma-devel. IlyaBizyaev requested review of this revision. REVISION SUMMARY Credits section currently displays the list of translators. This fixes

D25543: Split Style & Helper into files by widget type

2019-11-26 Thread Ilya Bizyaev
IlyaBizyaev added a comment. Great, navigating in Breeze source will be a lot simpler now  REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25543 To: ndavis, #plasma, #breeze Cc: IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

2019-09-24 Thread Ilya Bizyaev
IlyaBizyaev added a comment. Could you show how this change affects the default color scheme? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24205 To: cblack, #breeze Cc: IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D27380: [GTK Config] Write Font without style name

2020-02-13 Thread Ilya Bizyaev
IlyaBizyaev added a comment. I don't understand the problem in-depth, but isn't it possible to write non-localized style name instead? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari Cc: IlyaBizyaev, plasma-devel, Orage,

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

2020-02-26 Thread Ilya Bizyaev
IlyaBizyaev added a comment. In D27380#618531 , @ngraham wrote: > The problem being solved here is that starting with 5.18, style names were being localized, which GTK doesn't understand, causing it to fall back to the default font. This patch

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-29 Thread Ilya Bizyaev
IlyaBizyaev added a comment. Repeating my comment on the previous diff for this change: on my machine, the current spacing for systray elements already looks like your "after" screenshot. With normal usage, my systray takes up 1/4 of the panel. Does it mean that after this change, it's

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-02-29 Thread Ilya Bizyaev
IlyaBizyaev added a comment. In D27466#620050 , @The-Feren-OS-Dev wrote: > This patch only affects the System Tray widget itself, not anything else on the panel. Only the spacing around the icons that are part of the System Tray applet itself

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-03-01 Thread Ilya Bizyaev
IlyaBizyaev added a comment. It's hard to measure this in pixels, but on the screenshot, it's a 10% increase in size. I use default font settings btw, with a global scaling factor of 1.25. I'm not strongly against this, but I don't really see a point in this either. In, like, 4 years

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-03-01 Thread Ilya Bizyaev
IlyaBizyaev added a comment. In D27466#620191 , @ngraham wrote: > It is (already) font-dependent, yes. A higher font size will result in larger spacing. > > IMO this is not super sensible, but, there is it. :p Ok, so I guess for the

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

2020-03-01 Thread Ilya Bizyaev
IlyaBizyaev added a comment. Well, if dedoimedo likes it this way, then it's probably the right thing to do ;) Since no one else complains about this change, I'll assume I just was lucky to have proper scaling on my machine without "magic number" spacings. BRANCH D27466 (branched

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

2020-02-26 Thread Ilya Bizyaev
IlyaBizyaev added a comment. I am missing context on this bug, but I wonder why there were no issues with font configuration prior to 5.18 Was there a different workaround then? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To:

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

2020-02-26 Thread Ilya Bizyaev
IlyaBizyaev added a comment. In D27380#618526 , @ngraham wrote: > Prior to 5.18, you had to set the GTK font separately; now it's auto-synced. Right, so that's the difference in font style names between Qt and GTK that caused the

D26665: Switch to KNSQuick for getting new wallpapers

2020-01-28 Thread Ilya Bizyaev
IlyaBizyaev added a comment. What about the "Get New Plugins" button in the same dialog? It still uses the old style. Probably unrelated, but for me, both of these buttons fail to actually load anything, stuck connecting forever. I would blame all of my internet connections that I tried

D27438: Increase System Tray Plasmoid spacing value slightly

2020-02-17 Thread Ilya Bizyaev
IlyaBizyaev added a comment. I agree with @broulik in that the spacing already feels quite excessive, or at least doesn't need to be increased (: Does this depend on DPI/panel size maybe? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To:

D26530: ScrollView: Do not overlay scrollbars over contents

2020-01-08 Thread Ilya Bizyaev
IlyaBizyaev added a comment. Visually, this looks like a step back to me... Do you also envision Konsole using opaque overlay scrollbars again? The current scrollbar appearance is quite common on desktop (Telegram and GNOME apps come to mind), so it's not odd/out-of-place by any means.

D27669: [kstyle] Tools area

2020-03-10 Thread Ilya Bizyaev
IlyaBizyaev added a comment. For color schemes that have contrasting titlebar and content colors, this patch makes application headers look giant... F8168755: photo_2020-03-10_15-09-54.jpg It does look good with the proposed default color palette,

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

2020-04-19 Thread Ilya Bizyaev
IlyaBizyaev added a comment. On the screenshots, the notifications block tab bars and toolbars in 3 apps :) Are you sure it's more convenient? REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from master) REVISION DETAIL

D29688: Ignore mount paths that start with '/snap/'

2020-05-13 Thread Ilya Bizyaev
IlyaBizyaev added a comment. Maybe also /var/lib/docker? REPOSITORY R106 KSysguard BRANCH ignore_snap_partitions REVISION DETAIL https://phabricator.kde.org/D29688 To: ahiemstra, #plasma, davidedmundson Cc: IlyaBizyaev, anthonyfieroni, jriddell, plasma-devel, Orage, LeGast00n,

Plasma and a bachelor thesis

2020-10-16 Thread Ilya Bizyaev
ll-defined and meaningful project for KDE. Best regards, Ilya Bizyaev

Re: Plasma and a bachelor thesis

2020-10-20 Thread Ilya Bizyaev
:37 +0400 Aleix Pol написал(а) On Fri, Oct 16, 2020 at 3:26 PM Ilya Bizyaev <mailto:bizy...@zoho.com> wrote: > > Hello! > > I'm currently in my last year of bachelor studies, and I'm now looking for a > topic for my bachelor thesis. I've had a wild idea of doin

Re: Plasma and a bachelor thesis

2020-10-22 Thread Ilya Bizyaev
Hello Christoph, David! Thank you for your input! I have read through the shared materials, browsed Bugzilla reports, dug up and read the https://blogs.kde.org/2018/08/02/engineering-plasma-extensions-and-stability-—-present-and-future by Eike, and watched David's

Re: Synchronized release schedule for Plasma

2021-01-07 Thread Ilya Bizyaev
Hello, I would like to clarify that Promo has not reached any consensus on whether this would be a good idea for us. With my local promo hat on, I do not think Plasma announcements should be any larger than they are now, as that puts an extra load on translators. Best regards, Ilya

[Differential] [Request, 4 lines] D3588: Remove inexistent file references from kirigami.qrc

2016-12-04 Thread IlyaBizyaev (Ilya Bizyaev)
IlyaBizyaev created this revision. IlyaBizyaev set the repository for this revision to R169 Kirigami. IlyaBizyaev added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Some files that are referenced by Kirigami2's kirigami.qrc do not exist. This

[Differential] [Commented On] D3588: Remove inexistent file references from kirigami.qrc

2016-12-04 Thread IlyaBizyaev (Ilya Bizyaev)
IlyaBizyaev added a comment. I don't know. I just removed references to inexistent files to make compilation possible. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3588 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: