Review Request: Make Resize Method selector in Desktop wallpaper settings prettier

2011-10-27 Thread Kai Uwe Broulik
and Slideshow modes. (Would be nice if the changes were applied right after changing but I couldn’t figure out how this is done) Screenshots --- Screenshot http://git.reviewboard.kde.org/r/102978/s/319/ Thanks, Kai Uwe Broulik ___ Plasma

Review Request: Fix KRunner popping up with a white-space character upon pressing Escape key on empty workspace

2012-04-06 Thread Kai Uwe Broulik
- plasma/desktop/containments/desktop/desktop.cpp 8bcb877 Diff: http://git.reviewboard.kde.org/r/104497/diff/ Testing --- KRunner does not pop up when pressing Escape key, works fine in other ways. Thanks, Kai Uwe Broulik ___ Plasma

Re: Review Request: Fix KRunner popping up with a white-space character upon pressing Escape key on empty workspace

2012-04-06 Thread Kai Uwe Broulik
does not pop up when pressing Escape key, works fine in other ways. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: QML Lock/logout applet

2012-04-14 Thread Kai Uwe Broulik
, it will proceed after the countdown runs out. - Kai Uwe Broulik On April 13, 2012, 6:18 p.m., Viranch Mehta wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104592

Re: Review Request: QML Lock/logout applet

2012-04-16 Thread Kai Uwe Broulik
On April 14, 2012, 10:11 p.m., Kai Uwe Broulik wrote: Couldn’t we add a Hibernate dialog, similar to the confirmation on shutdown, i.e that dialog that counts down Shutting down in 30 seconds with the ability to cancel it? You press Hibernate, and a KSMserver dialog (that we don’t

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-04-17 Thread Kai Uwe Broulik
, i.e. hovering the plasmoid also does nothing. You _always_ have to click the battery plasmoid to see the exact percentage. The tooltip thing seems to be a general QML plasmoid issue, the new devicec notifier also lacks one. - Kai Uwe Broulik On April 3, 2012, 5:12 a.m., Viranch Mehta wrote

Re: Review Request: [KActivityManagerDaemon] Activity Changed On Screen Display

2012-05-07 Thread Kai Uwe Broulik
On May 7, 2012, 6:04 p.m., Ivan Čukić wrote: I really don't like having this as a kamd plugin. In general, I dream of a day when kamd will have no GUI code whatsoever. Thomas Lübking wrote: What about using knotify and extending it by an OSD? makis marimpis wrote: heh,

Re: Review Request: Add a keyboard shortcut to stop the current activity

2012-06-17 Thread Kai Uwe Broulik
for Pause, etc. - Kai Uwe Broulik On June 16, 2012, 11:39 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105279

Re: Review Request: use window role to detect the dashboard

2012-06-28 Thread Kai Uwe Broulik
ink levels, so I cannot test whether it causes unexpected behavior, but I don’t think so. Daniel should look over this anyway. Thanks for the patch! :) - Kai Uwe Broulik On June 28, 2012, 7:42 p.m., Thomas Lübking wrote

Re: Review Request: use window role to detect the dashboard

2012-06-28 Thread Kai Uwe Broulik
On June 28, 2012, 8:21 p.m., Kai Uwe Broulik wrote: Nice catch! I do not have a printer that supports reporting ink levels, so I cannot test whether it causes unexpected behavior, but I don’t think so. Daniel should look over this anyway. Thanks for the patch! :) Sorry, Wrong Review

Re: Review Request: Weather Forecast QML port

2012-08-30 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/106225/#comment14442 I think it should not be enabled by default but rather X-Plasma-NotificationArea=true so you can put it in systray like you can with the current implementation - Kai Uwe Broulik On Aug. 30, 2012, 1:53 a.m., Luis Gabriel Lima wrote

Re: Review Request: Block screen edge activation for fullscreen windows

2012-10-04 Thread Kai Uwe Broulik
On Oct. 4, 2012, 3:02 p.m., Martin Gräßlin wrote: After thinking about it some more: I'm most likely not going to push this, but go for an atom solution as noted by Thomas. That would probably also fix issues for non fullscreen applications which need to reserve an area of the

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-08 Thread Kai Uwe Broulik
On Oct. 8, 2012, 3:50 p.m., Jeremy Paul Whiting wrote: That looks a bit better in my opinion. I would change/fix the wording for the dashboard screen locker a bit Click configure to find more about it! doesn't sound quite right for a tooltip, maybe something like Click the configure

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-11 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/106448/#comment15967 This is not related to this patch, and should have already been pushed a few months ago, I think. - Kai Uwe Broulik On Oct. 11, 2012, 6:08 p.m., Greg T wrote: --- This is an automatically generated e

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-14 Thread Kai Uwe Broulik
On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: just an idea: what about hiding the whole X screen saver stuff behind another configure dialog. Looking at the screenshot I find the design puts emphasis on the wrong part: what we want to remove takes more than 50 % of the available

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-14 Thread Kai Uwe Broulik
into account feedback from Thomas, Aaron and Marco. http://agateau.com/tmp/locker-kcm/locker-kcm2.png Kai Uwe Broulik wrote: I thing using a huge listview for three entries (locker, plasma thingie, screensaver) is a bit of a waste? On the other hand, also adding all the screensavers

Review Request: Add Screen Resolution to desktop context menu

2012-10-14 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/106862/diff/ Testing --- Entry shows up (enabled by default), can be enabled and disabled, and clicking it triggeres the Randr KCM. Screenshots --- Context menu entry http://git.reviewboard.kde.org/r/106862/s/771/ Thanks, Kai Uwe Broulik

Re: Review Request: Add Screen Resolution to desktop context menu

2012-10-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106862/#review20355 --- On Oct. 15, 2012, 2:27 a.m., Kai Uwe Broulik wrote

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-15 Thread Kai Uwe Broulik
into account feedback from Thomas, Aaron and Marco. http://agateau.com/tmp/locker-kcm/locker-kcm2.png Kai Uwe Broulik wrote: I thing using a huge listview for three entries (locker, plasma thingie, screensaver) is a bit of a waste? On the other hand, also adding all the screensavers

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Kai Uwe Broulik
On Oct. 21, 2012, 12:14 a.m., Kai Uwe Broulik wrote: plasma/generic/applets/systemtray/package/contents/ui/IconsGrid.qml, line 29 http://git.reviewboard.kde.org/r/106965/diff/1/?file=91322#file91322line29 Can you make the size honour the global KDE icon size settings? This would

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Kai Uwe Broulik
brightness? Now it knows the current brightness and sets it itself to the right value but still aren't these calls not needed and thus a bug also in the plasmoid? - Kai Uwe Broulik On Nov. 21, 2012, 5:43 p.m., Greg T wrote

Review Request: [High-dpi issues] Fix panelcontroller Screen Edge/Height icons fixed size

2012-11-22 Thread Kai Uwe Broulik
/diff/ Testing --- Tested with various small icon sizes and works flawlessly even with 48px icons. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Change Battery Percentage step of battery plasmoid

2012-12-06 Thread Kai Uwe Broulik
means when I have 30% left, the icon will already be red indicating soon power outage - Kai Uwe Broulik On Dec. 6, 2012, 2:23 p.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: show notification summary for last popup notification

2012-12-16 Thread Kai Uwe Broulik
, and font shouldn't be bold since it is not bold in the notification list. - Kai Uwe Broulik On Dec. 15, 2012, 9:17 p.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Review Request: Fix dismissing LastNotificationPopup often failing

2012-12-25 Thread Kai Uwe Broulik
. http://bugs.kde.org/show_bug.cgi?id=311413 Diffs - plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b Diff: http://git.reviewboard.kde.org/r/107908/diff/ Testing --- kdialog --passivepopup bla click, closes. Thanks, Kai Uwe Broulik

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Kai Uwe Broulik
. I guess this is because PowerDevil starts quite early in the startup process and so Plasma (and probably the compositor) is not up and running. Seems that broken detection when compositing state changes (https://bugs.kde.org/show_bug.cgi?id=179042) is the cause. - Kai Uwe Broulik On Jan. 6

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-06 Thread Kai Uwe Broulik
On Jan. 6, 2013, 3:45 p.m., Kai Uwe Broulik wrote: Just applied the patch from Review 107983 and your patch resolves the issue. Would you mind if I use that code to fix KMix OSD? Xuetian Weng wrote: Well.. actually I have a review for kmix :P https://git.reviewboard.kde.org/r

Re: Review Request: use Plasma::Dialog for kmix osd

2013-01-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/#review24946 --- What about KDE/4.10 branch? - Kai Uwe Broulik On Jan. 6

Re: Review Request: use Plasma::Dialog for kmix osd

2013-01-07 Thread Kai Uwe Broulik
On Jan. 7, 2013, 9:35 p.m., Kai Uwe Broulik wrote: What about KDE/4.10 branch? Ok, you merged. Never mind :-) - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-08 Thread Kai Uwe Broulik
interaction with the Fade effect somehow, but it disappeared now (ie. the popup fading in, and fading out when they slide) There is a little visual glitch with the shadow, the corner shadows overlap the side shadows for about one pixel. See http://privat.broulik.de/cornershadow.png - Kai Uwe Broulik

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-09 Thread Kai Uwe Broulik
shadow issue I mentioned earlier but it now only appears in the last bits of the sliding out animation, and in the first bits of the sliding back in animation. - Kai Uwe Broulik On Jan. 9, 2013, 7:08 a.m., Martin Gräßlin wrote

Re: Review Request: Do not clip away shadows in SlidingPopupsEffect

2013-01-09 Thread Kai Uwe Broulik
On Jan. 9, 2013, 8:52 a.m., Kai Uwe Broulik wrote: Tested and works perfect except for that 1px overlapping shadow issue I mentioned earlier but it now only appears in the last bits of the sliding out animation, and in the first bits of the sliding back in animation. Martin Gräßlin

Re: Review Request: various fix for battery plasmoid

2013-01-11 Thread Kai Uwe Broulik
inside the dataengine? - Kai Uwe Broulik On Jan. 11, 2013, 11:37 p.m., Xuetian Weng wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108355

Re: Review Request 108355: various fix for battery plasmoid

2013-01-12 Thread Kai Uwe Broulik
On Jan. 12, 2013, 12:18 a.m., Kai Uwe Broulik wrote: plasma/generic/applets/batterymonitor/contents/code/logic.js, line 97 http://git.reviewboard.kde.org/r/108355/diff/2/?file=106715#file106715line97 But isn't it the dataengine that prematurely triggers a brightnes change and OSD

Re: Review Request 108223: use Plasma::Dialog for kmix osd

2013-02-12 Thread Kai Uwe Broulik
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/ --- (Updated Jan. 6, 2013, 11:52 p.m.) Review request for Plasma, Solid, Aaron J. Seigo, Kai Uwe Broulik, and Christian Esken. Description

Re: Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of text in now playing widget.

2013-02-18 Thread Kai Uwe Broulik
On Feb. 15, 2013, 12:07 a.m., Kai Uwe Broulik wrote: applets/nowplaying/package/contents/ui/Controls.qml, line 27 http://git.reviewboard.kde.org/r/108969/diff/1/?file=114046#file114046line27 You might want to make this adjust to font dpi settings or global icon sizes. Tjaart

Re: Review Request 109124: qml port currentappcontrol

2013-02-24 Thread Kai Uwe Broulik
work automgaically - Kai Uwe Broulik On Feb. 24, 2013, 11:10 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109124

Re: Review Request 109124: qml port currentappcontrol

2013-02-28 Thread Kai Uwe Broulik
On Feb. 26, 2013, 1:36 p.m., Aaron J. Seigo wrote: - If you click on the title on the task bar, it doesn't show the kwin present windows effect, how to implement that? Is there interest in a 'kwin dataengine' or should I go for a mixed C++/QML applet? a WindowSystem qml import

Review Request 110389: Add Configure button to notifications that opens KNotify settings for the app that emitted the notification

2013-05-11 Thread Kai Uwe Broulik
77f5db2 Diff: http://git.reviewboard.kde.org/r/110389/diff/ Testing --- Works, in both the popup and history. Tested with Amarok and Powerdevil. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 110389: Add Configure button to notifications that opens KNotify settings for the app that emitted the notification

2013-05-11 Thread Kai Uwe Broulik
configure button, as expected (it does, when your passed appName happens to match an application, which is rather nice, though) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 110406: Expose more battery properties to the Power Management dataengine

2013-05-12 Thread Kai Uwe Broulik
and it properly reported its name and power supply state. The Type property is somewhat unreliable as UPower also considered the mouse as Primary battery. But the Is Power Supply property was correct and that's the prevailing one. Thanks, Kai Uwe Broulik

Re: Review Request 110389: Add Configure button to notifications that opens KNotify settings for the app that emitted the notification

2013-05-12 Thread Kai Uwe Broulik
option http://git.reviewboard.kde.org/media/uploaded/files/2013/05/12/notificationconfigure1.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110389: Add Configure button to notifications that opens KNotify settings for the app that emitted the notification

2013-05-14 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/110389/#review32519 --- On May 12, 2013, 2:10 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http

Review Request 110431: Improve battery monitor with multiple batteries

2013-05-14 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/media/uploaded/files/2013/05/14/bluetoothmouse4.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110431: Improve battery monitor with multiple batteries

2013-05-15 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/media/uploaded/files/2013/05/14/bluetoothmouse4.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110431: Improve battery monitor with multiple batteries

2013-05-15 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/media/uploaded/files/2013/05/14/bluetoothmouse4.png Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 110608: Add support for keyboard backlight handling to the powermanagement dataengine

2013-05-23 Thread Kai Uwe Broulik
/powermanagementservice.operations 533c00a Diff: http://git.reviewboard.kde.org/r/110608/diff/ Testing --- Adjusting keyboard brightness from the battery monitor so col. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Battery Monitor revamp

2013-05-24 Thread Kai Uwe Broulik
Hi. Oh noes! Please restore this option since it is crucial There's been a huge argument about that on BKO and decision from maintainers was to only have a hidden option for that. I personally would also want to have it. I'm just not sure where to put it. Having a global item in the list just

Re: Battery Monitor revamp

2013-05-25 Thread Kai Uwe Broulik
Hi, tried it out and Marco (who is visiting for a few days) and i looked it over. see these screenshots for some layouting issues: I didn't see those at first because I am using bigger icon sizes and bigger font sizes. I guess using Math.max(48, iconSizes.dialog) would fix that? 48 is the icon

Re: Dependency Freeze for 4.11 in 4 days

2013-05-25 Thread Kai Uwe Broulik
Hi, Dependency freeze for 4.11 releases[...] * kde-workspace depends on kdelibs 4.9.4 For my battery monitor revamp I did adjustments to kdelibs so it exposes more battery properties through Solid. These currently reside in master, meaning kde-workspace would need to depend on kdelibs 4.11.

Re: Battery Monitor revamp

2013-05-26 Thread Kai Uwe Broulik
So I pushed a few patches: Am Samstag, 25. Mai 2013, 13:10:14 schrieb Aaron J. Seigo: see these screenshots for some layouting issues: Fixed. also, after expanding a battery to see detailed information, collapsing it leaves an empty space. that should re-collapse, similar to thow the

Re: Battery Monitor revamp

2013-05-27 Thread Kai Uwe Broulik
life left. I'd be fine with dropping the overlay if we had 10 linear steps for the icon rather than 5 which are unequally distributed. Aaron J. Seigo ase...@kde.org schrieb: On Sunday, May 26, 2013 18:53:24 Kai Uwe Broulik wrote: On the desktop it would work that way, yes. But I really want

Re: Battery Monitor revamp

2013-05-27 Thread Kai Uwe Broulik
I could add it to the expandable battery details but it will show the overall remaining time for all batteries in contrast to the other properties which are directly related to the battery they emerge from. Actually I don't care. I don't have a strong opinion on whether to show it or not.

Re: Battery Monitor revamp

2013-05-27 Thread Kai Uwe Broulik
Am Montag, 27. Mai 2013, 10:53:58 schrieb Kai Uwe Broulik: I'd be fine with dropping the overlay if we had 10 linear steps for the icon rather than 5 which are unequally distributed. I did a few changes to the battery.svgz for the air theme. What do you think? Now we can have 10 equal steps

Re: Battery Monitor revamp

2013-05-28 Thread Kai Uwe Broulik
So I'm a +1 for this change. It will need to be kept backwards compat for other themes in the code, but that's not hard to do. if (fillElementSvg.hasElement(Fill10)) { // use new more accurate method } else { // fallback for other/older themes } would be the approach for this, right?

Re: Battery Monitor revamp

2013-05-28 Thread Kai Uwe Broulik
Just committed patch to the battery monitor. Tested with both the current blocky battery.svgz and my new one. Magic! Attached is the new battery.svgz which belongs into kde-runtime. And obligatory screenshots [1] Have a try. Comments? [1]

Re: Battery Monitor revamp

2013-05-28 Thread Kai Uwe Broulik
* the bottom of the inner rect of the battery is a slightly different colour from all the other borders. it is slightly darker. That's in the current version too and is because the meter elements themselves have a dark bottom border. Was a trivial fix though. * the inner rect cuts off right

Re: Battery Monitor revamp

2013-05-30 Thread Kai Uwe Broulik
Is the graphic ok that way? Dunno what I could do about the other issue you mentioned but it has been that for years now and doesn't really matter at the usual size. What's missing now before the battery monitor can go into master? - Discussion about remaining time. The strings are in place,

Plasma theme cache auto-refresh

2013-05-31 Thread Kai Uwe Broulik
Hi there, as I've just commited a change to the battery icon, something came to my mind again: Plasma uses a cache for its theme elements, and this cache is supposed to be automatically cleared when the theme metadata file is touched. However, the transition to KDE SC 4.10 showed that this is

Re: Plasma theme cache auto-refresh

2013-05-31 Thread Kai Uwe Broulik
Am Freitag, 31. Mai 2013, 11:40:43 schrieb Aaron J. Seigo: i imagine it would look sth like the attached patch (which builds, but i haven't tested it yet) Works! Made my panel svg pink, restarted plasma, no change, only if I eg. moved/resized a panel. Changed version number in the metadata,

Re: Missing commit from kdelibs KDE/4.10 and master. Kde-workspace fails to build.

2013-06-01 Thread Kai Uwe Broulik
Hi, This new functionality is imho no stuff for 4.10, so you need kdelibs master for workspace master (4.10 workspace will build with 4.10 kdelibs ;) ). Regards Antonis Tsiapaliokas kok...@gmail.com schrieb: ___ Plasma-devel mailing list

Re: Battery Monitor revamp

2013-06-03 Thread Kai Uwe Broulik
Is there anything else that needs to be addressed? Would love to merge that code once the remaining dependencies (Review 110607, Review 110608) are commented on and commited. ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Plasma theme cache auto-refresh

2013-06-05 Thread Kai Uwe Broulik
ok, this is now done. it is in master, please test and let me know if you encounter problems. Cool! Will make things easier in the future, if we overhaul themes again. Also added a line to the techbase theming page: If you do changes to SVG files in your theme, make sure to update the version

Re: qml trash

2013-06-08 Thread Kai Uwe Broulik
Hi, Make sure you have requested the run application extension in the metadata desktop file. Otherwise that call will not work. http://techbase.kde.org/Development/Tutorials/Plasma/JavaScript/API-Extensions Heena Mahour heena...@gmail.com schrieb:

Re: qml trash

2013-06-08 Thread Kai Uwe Broulik
Also use openUrl instead of LaunchApplication ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110941: Fix battery status in battery monitor plasmoid

2013-06-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110941/#review34075 --- This should have already been fixed in 4.11. - Kai Uwe

Animate style hint

2013-06-12 Thread Kai Uwe Broulik
Hi, This property [1], once available should be exported to plasmoids in Plasma2, so responsible plasmoid writers can turn off animations if the user doesn't want them. That's one thing that always bothered me that Plasma always animates no matter what the system settings were. I have had a

Re: Animate style hint

2013-06-12 Thread Kai Uwe Broulik
isn't that a qt5 specific option? That's why I said once it is available and plasma 2 ;) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Animate style hint

2013-06-12 Thread Kai Uwe Broulik
Okay, so we have a consent here then. Was just throwing that thing into the room to see what happens. Aaron J. Seigo ase...@kde.org schrieb: On Wednesday, June 12, 2013 10:02:28 Kai Uwe Broulik wrote: user doesn't want them. That's one thing that always bothered me that Plasma always

theme.smallIconSize vs theme.iconSizes.small

2013-06-13 Thread Kai Uwe Broulik
Hi, playing around with the new tasks widget I saw that it does not adapt to my small icon size setting which I have set higher because of my high-dpi screen. Now it seems that icon sizes in Plasma theme are fixed in the theme. Is there some sort of dpi scaling mechanism or how can this be made

Sort Filter Model case sensitivity

2013-06-19 Thread Kai Uwe Broulik
Hi, Testing the battery monitor I found that the batteries are sorted case-sensitive meaning Logitech comes before eva. The API doesn't list a caseSensitivity property. How can I sort case-insensitive? Best, Kai Uwe ___ Plasma-devel mailing list

Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Kai Uwe Broulik
/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-20 Thread Kai Uwe Broulik
/declarativeimports/core/datamodel.h 0943b68 Diff: http://git.reviewboard.kde.org/r/48/diff/ Testing --- Tested with the battery monitor. Now eva comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel

2013-06-22 Thread Kai Uwe Broulik
comes before Logitech :) Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

KLocale imports

2013-07-01 Thread Kai Uwe Broulik
Hi, I just by accident discovered that there are KLocale Plasma QML imports. I think this should be stated in the Plasma QML API techbase page with link to the KLocale API docs and/or notable properties (such as prettyFormatDuration)? Best, Kai Uwe

FocusScope and Plasma CheckBox

2013-07-09 Thread Kai Uwe Broulik
Hi, I'm currently trying to improve (implement at all) keyboard navigation for the battery monitor. It works quite well except that the sliders don't have any visual has focus indication. What also gives me trouble is the checkbox. I have code that looks like FocusScope { id:

Review Request 111465: Use activeFocus for dual state button effect

2013-07-09 Thread Kai Uwe Broulik
with experimental battery monitor keyboard navigation support. Works as expected. Only if the checkbox currently has focus it glows. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Help on some Plasma methods

2013-07-12 Thread Kai Uwe Broulik
Talking about the Digital Clock, I'm curious how that gradient text will work like with QML - or can we simply apply a gradient to Text in Qml2? If so that would make that super easy compared to the way it's currently done. Aaron J. Seigo ase...@kde.org schrieb: On Friday, July 12, 2013

RIght-to-left layout

2013-07-17 Thread Kai Uwe Broulik
Hi, I just saw a bunch of bugreports about RTL issues in KDE applications and then wanted to test what Plasma looks like when run in -reverse mode. The result is … disappointing. C++ written plasmoids and containments such as the panel or the calendar mirror fine whereas QML stuff such as

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-09 Thread Kai Uwe Broulik
On Aug. 9, 2013, 2:55 p.m., David Edmundson wrote: tier1/kconfig/src/gui/kconfigloader.cpp, line 65 http://git.reviewboard.kde.org/r/111908/diff/3/?file=177535#file177535line65 This would be best with use of QLatin1String() thoughout this file. QStringLiteral? - Kai Uwe

Actual width of checkbox element

2013-08-15 Thread Kai Uwe Broulik
Hi there, I got a bug report [1] about that the popup width might get so small that the PM checkbox doesn't fit entirely. Is there a way to determin the actual width of the checkbox including its label? So I could do minimumWidth: Math.max( currentminimumwidth, checkboxwidth) Or should I just

Re: Actual width of checkbox element

2013-08-15 Thread Kai Uwe Broulik
Hi, its implicitWidth should return a proper value (if it doesn't means the component should be fixed ;) implicitWidth seems to return 0 for the checkbox item. (If I could've just kept the switch … :P) ___ Plasma-devel mailing list

Re: Actual width of checkbox element

2013-08-15 Thread Kai Uwe Broulik
patches welcome ;) Hmm, when I try to manually set the implicitWidth or route it somewhereelse it says implicitWidth not available in QtQuick Item 1.0 (or so). ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Actual width of checkbox element

2013-08-15 Thread Kai Uwe Broulik
Am Donnerstag, 15. August 2013, 22:04:54 schrieb Marco Martin: On Thursday 15 August 2013, Kai Uwe Broulik wrote: patches welcome ;) Hmm, when I try to manually set the implicitWidth or route it somewhereelse it says implicitWidth not available in QtQuick Item 1.0 (or so

Re: Review Request 107908: Fix dismissing LastNotificationPopup often failing

2013-08-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107908/#review31508 --- On Dec. 25, 2012, 2:43 p.m., Kai Uwe Broulik wrote

Re: Review Request 112502: Roughly port devicenotifier to plasma2

2013-09-04 Thread Kai Uwe Broulik
/DeviceItem.qml http://git.reviewboard.kde.org/r/112502/#comment28985 QIcon(deviceItem.icon) ? deviceItem.icon (I think) - Kai Uwe Broulik On Sept. 4, 2013, 7:11 a.m., Bhushan Shah wrote: --- This is an automatically generated e

Re: Review Request 112502: Roughly port devicenotifier to plasma2

2013-09-04 Thread Kai Uwe Broulik
On Sept. 4, 2013, 8:50 a.m., Kai Uwe Broulik wrote: plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml, line 90 http://git.reviewboard.kde.org/r/112502/diff/1/?file=186957#file186957line90 QIcon(deviceItem.icon) ? deviceItem.icon (I think) Whoops

Review Request 112690: Take configure button width into account for summary label

2013-09-12 Thread Kai Uwe Broulik
/r/112690/diff/ Testing --- Tested both popup and history with both configurable and non-configurable (kdialog) notifications Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request 107908: Fix dismissing LastNotificationPopup often failing

2013-10-13 Thread Kai Uwe Broulik
/diff/ Testing --- kdialog --passivepopup bla click, closes. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Can we drop kcontrol/workspaceoptions?

2013-10-18 Thread Kai Uwe Broulik
Well, I guess that's due to Plasma's big ass tooltips which sometimes don't go away properly Marco Martin notm...@gmail.com schrieb: ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Can we drop kcontrol/workspaceoptions?

2013-10-18 Thread Kai Uwe Broulik
Which luckily is no longer a problem in Plasma2 \o/ Aaron J. Seigo ase...@kde.org schrieb: On Friday, October 18, 2013 17:08:41 Kai Uwe Broulik wrote: which sometimes don't go away properly which is a problem with event handling in QGraphicsView. it’s also why widget handles on the desktop

Re: Semi-modal sidebar paradigm

2013-11-04 Thread Kai Uwe Broulik
Hi, it’s a very neat idea. Really love it, too. And the blur effect is gorgeous! something that would also be interesting to experiment with in kwin is a special presentation mode for such elements. if it could be done with enough performance/fluidity, it could be quite nice to “shove” the

List of batteries not updated at runtime

2013-11-10 Thread Kai Uwe Broulik
Hi, Tue battery monitor has a strange bug [1] I cannot make sense of. When plugging in a mouse for example, it does not appear right away in the battery monitor. It appears instantly in plasmaengineexplorer though. I am not sure on how that onSourceAdded: connectSource(source) works. Any idea

[plasma-shell] [Bug 327683] Crash at login (no activities found?)

2013-11-22 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=327683 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added CC||k...@privat.broulik.de

Re: Battery Monitor on Plasma 2

2013-12-29 Thread Kai Uwe Broulik
Hi, plasmoid.location should work, if it doesn't, let me know. (I haven't checked for the system tray, but it would be an easy fix.) Haven't tried so far but I guess I need to accomodate to the enum changes using PlasmaCore.Types for location then? Please file a bug, this needs more detailed

Re: Battery Monitor on Plasma 2

2013-12-29 Thread Kai Uwe Broulik
Hi, yes, have to use PlasmaCore.Types prefix, everything in plasma.h is available under there Okay. in the systray having something not square breaks in many edge cases.. so makes me think that we should really introduce a new formfactor for square stuff, so the battery could behave

Re: Review Request 114818: battery monitor renaming to org.kde.plasma.battery

2014-01-03 Thread Kai Uwe Broulik
Hi, Battery-oxygen isn't used anymore by the plasmoid anyway and can be removed. Cheers, Kai Uwe ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Notes from New OSD in Plasma 2

2014-01-18 Thread Kai Uwe Broulik
Hi, (I hope I have used KMail's Reply-To-All feature correctly) That actually brings another quesion - on which screen it should show up? I'd put it wherever mouse cursor currently is. Opinions? I think it depends on what kind of OSD. For Keyboard layout and Volume it's fine to show where

Re: Notes from New OSD in Plasma 2

2014-01-18 Thread Kai Uwe Broulik
Am Samstag, 18. Januar 2014, 14:01:29 schrieb Martin Klapetek: Ah yes, I should have updated the list about that - I talked to Jens shortly after and we came up with more icons than I requested originally, including the keyboard brightness plus one for Wi-Fi being turned on/off Aaaand

Re: When should there be a screen brightness OSD?

2014-01-21 Thread Kai Uwe Broulik
Hi, +1 as well! Especially it popping up on session start where the compositor isn't fully ready. :/ So to summarize: - never ever show it when the brightness changes automatically (session start, mouse movement, screen timeout, ...) - if user changes, it show the OSD on the primary/internal

  1   2   3   4   5   6   7   8   9   10   >