[Differential] [Commented On] D1769: [Service Runner] Don't use KRun::runService

apol added a comment. Would it make sense to add such API in KRun@KIOWidgets? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1769 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: apol,

[Differential] [Updated] D1744: Fix the ignore struts multi-screen handling

apol added a comment. I just tested the patch, the issue isn't solved here. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1744 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, lbeltrame, apol Cc: plasma-devel,

[Differential] [Accepted] D1810: Don't call a plugin "something plugin"

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1810 EMAIL PREFERENCES

[Differential] [Accepted] D1809: Fix i18n in plasmacalendarintegration

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1809 EMAIL PREFERENCES

[Differential] [Accepted] D1676: kfontinst: Port to QApplication and QCommandLineParser

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1676 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1685: kfontinst: Port to QDebug

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1685 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1686: kfontinst: Port away from KIO::NetAccess

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1686 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1687: kfontinst: Port to QFileDialog

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1687 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1688: kfontinst: Port to QSaveFile

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1688 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1689: kfontinst: Port to QMimeDatabase

apol accepted this revision. apol added a reviewer: apol. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > FontFilter.cpp:169 > +QStringList mimes; > +foreach (QString pattern, mime.globPatterns()) > +

[Differential] [Changed Subscribers] D1866: Use QVector and QLatin1String, and range-based for

apol added inline comments. INLINE COMMENTS > xrandroutput.cpp:258 > > -Q_FOREACH(const QString , embedded) { > +for (const QLatin1String : embedded) { > if (name.toUpper().startsWith(pre)) { This one is fine, but I wouldn't change from `foreach -> for` as a norm, as it can

[Differential] [Accepted] D1705: [System Tray] Don't iterate keys()

apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Good stuff! Clazy? Or you actually found this to be a paint point? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Commented On] D782: Require Qt 5.5

apol added a subscriber: apol. apol added a comment. +1 REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D782 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc:

[Differential] [Accepted] D861: Port away from kdelibs4support

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH drop-kdelibs4support REVISION DETAIL https://phabricator.kde.org/D861 EMAIL PREFERENCES

[Differential] [Accepted] D1171: simple cleanup in geometryByDistance

apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Makes sense, for readability. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1171 EMAIL

[Differential] [Commented On] D1066: Fix saving correct length of panel

apol added a comment. +1 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1066 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc: apol, plasma-devel ___

[Differential] [Updated] D1279: Add a template for Weather Ion dataengines

apol added a comment. LGTM REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1279 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, apol Cc: plasma-devel, sebas

[Differential] [Accepted] D1498: Fix memory leak in system tray

apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. LGTM, thanks! REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1498 EMAIL PREFERENCES

[Differential] [Commented On] D1647: kfontinst: Port to QDialog

apol added a comment. Other than that it looks quite good, interesting how much code gets cleaned up. INLINE COMMENTS > Printer.cpp:349 > + > +QDialogButtonBox *buttonBox = new > QDialogButtonBox(QDialogButtonBox::Cancel); > +connect(buttonBox, SIGNAL(rejected()), this,

[Differential] [Commented On] D1676: kfontinst: Port to QApplication and QCommandLineParser

apol added a comment. LGTM +1 INLINE COMMENTS > Viewer.cpp:131 > { > -for (int i = 0; i < args->count(); ++i) > +for (int i = 0; i < urlArgs.count(); ++i) > { Prefer foreach to iterate a QList REPOSITORY rPLASMADESKTOP Plasma Desktop

[Differential] [Commented On] D1675: kfontinst: Port to QTemporaryDir

apol added a comment. I'd say it's generally better to use QDir::filePath there. it will be easier to read. INLINE COMMENTS > FontThumbnail.cpp:96 > { > -realPath=tempDir->name()+entry->name(); > +

[Differential] [Commented On] D1588: [Shell] Replace foreach by range-for where possible

apol added a comment. In https://phabricator.kde.org/D1588#29377, @davidedmundson wrote: > maybe we can, but why? > > foreach is always correct > > for is sometimes correct > > what's the benefit? I tend to think along those lines... if it was actually a problem, it

[Differential] [Commented On] D1514: [Milou] Optimize sources model

apol added a comment. A test would be good, with ModelTest it would be great. INLINE COMMENTS lib/sourcesmodel.cpp:304 This looks wrong. Begin should be on top... lib/sourcesmodel.cpp:307 Same REPOSITORY rMILOU Milou REVISION DETAIL https://phabricator.kde.org/D1514 EMAIL

[Differential] [Commented On] D1675: kfontinst: Port to QTemporaryDir

apol added a comment. Ugh, I was convinced it would exist! My apologies for not checking. For now, can you at least just change from "/" -> QLatin1Char('/')? Also if you can look into adding the API to Qt that would be great as well. Other than that, +1 REPOSITORY rPLASMADESKTOP

[Differential] [Accepted] D1675: kfontinst: Port to QTemporaryDir

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1675 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Closed] D2305: Prefer alias to new property

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI69d297937b01: Prefer alias to new property (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2305?vs=5541=5543#toc REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST

[Differential] [Request, 4 lines] D2305: Prefer alias to new property

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's better to just have a property aliased than duplicating it. Both for readability and performance

[Differential] [Updated, 45 lines] D2306: Make it possible to provide a page header to ScrollablePage

apol updated this revision to Diff 5547. apol added a comment. Add api documentation REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2306?vs=5546=5547 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2306 AFFECTED FILES

[Differential] [Updated, 45 lines] D2306: Make it possible to provide a page header to ScrollablePage

apol updated this revision to Diff 5549. apol added a comment. Fix naming REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2306?vs=5547=5549 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2306 AFFECTED FILES

[Differential] [Commented On] D2306: Make it possible to provide a page header to ScrollablePage

apol added a comment. In https://phabricator.kde.org/D2306#42989, @mart wrote: > seems to behave a bit strangely, especially its interaction with the global ApplicationHeader is quite strange What is that you don't like exactly? I can look into it if you tell me. REPOSITORY

[Differential] [Commented On] D2306: Make it possible to provide a page header to ScrollablePage

apol added a comment. In https://phabricator.kde.org/D2306#43024, @mart wrote: > it should just be a fixed header, always visible and laid out with the main content or flickable, it should be in Page (and just happening to work in scrollablepage too) and the property called just header,

[Differential] [Request, 5 lines] D2326: Properly check if the page is in bounds

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We were just checking on the lower bounds REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION

[Differential] [Closed] D2326: Properly check if the page is in bounds

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMIe24d9e255616: Properly check if the page is in bounds (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2326?vs=5605=5608 REVISION

[Differential] [Request, 4 lines] D2327: Let the drawer contents take the full width

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I'm not sure why it was done like that, but otherwise we're forced into some margins which look weird,

[Differential] [Request, 2 lines] D2335: Respect the bottomPadding for the bottom of the drawer

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make it possible to not leave an empty space below the drawer REPOSITORY rKIRIGAMI Kirigami BRANCH

[Differential] [Abandoned] D2329: Let the drawer contents take the full width

apol abandoned this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2329 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel ___

[Differential] [Closed] D2334: Respect the bottomPadding for the bottom of the drawer

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI7f92f7f9a314: Respect the bottomPadding for the bottom of the drawer (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5636=5637

[Differential] [Closed] D2335: Respect the bottomPadding for the bottom of the drawer

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI2e8371f5bc69: Respect the bottomPadding for the bottom of the drawer (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2335?vs=5631=5632

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol updated this revision to Diff 5635. apol added a comment. Use padding to place the top element as well REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5633=5635 BRANCH margins REVISION DETAIL https://phabricator.kde.org/D2334

[Differential] [Request, 17 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use Layout attached property margins rather than trying to compute sizes REPOSITORY rKIRIGAMI Kirigami

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol updated this revision to Diff 5633. apol added a comment. Update patch REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5630=5633 BRANCH margins REVISION DETAIL https://phabricator.kde.org/D2334 AFFECTED FILES

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol updated this revision to Diff 5636. apol added a comment. Use padding when necessary REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5635=5636 BRANCH margins REVISION DETAIL https://phabricator.kde.org/D2334 AFFECTED FILES

[Differential] [Commented On] D2399: New new SDDM theme

apol added a comment. Shouldn't we be keeping the old theme for nostalgia and such? It's a theme after all. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2399 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Changed Subscribers] D2240: Anchors in a layout item is always wrong

apol added inline comments. INLINE COMMENTS > WidgetExplorer.qml:264 > id: closeButton > -anchors { > -right: parent.right If it needs to be aligned to the right, shouldn't it have a `Layout.alignment: Qt.AlignRight`? REPOSITORY rPLASMADESKTOP Plasma

[Differential] [Updated, 27 lines] D2144: Fix warnings

apol updated this revision to Diff 5345. apol added a comment. Fix morphing, proper testing REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2144?vs=5344=5345 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2144 AFFECTED FILES

[Differential] [Closed] D2144: Fix warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI50b4b7b032a2: Fix warnings (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2144?vs=5345=5346 REVISION DETAIL

[Differential] [Updated, 22 lines] D2144: Fix warnings

apol updated this revision to Diff 5344. apol added a comment. Address Marco's comment REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2144?vs=5096=5344 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2144 AFFECTED FILES

[Differential] [Commented On] D2144: Fix warnings

apol added a comment. > why adding check over mainFlickable.currentItem ? doesn't guard anything We don't want `mainFlickable.currentItem.width` to fail if `mainFlickable.currentItem` is null. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2144 EMAIL

[Differential] [Request, 15 lines] D2144: Fix warnings

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make sure we don't ever call null objects REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION

[Differential] [Abandoned] D2137: Fix warning in BasicListItem.width

apol abandoned this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2137 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel ___

[Differential] [Closed] D2117: Consider the primary screen as default screen

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd1210f5fda01: Consider the primary screen as default screen (authored by apol). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2110: Create a Colors page in the Gallery

apol added a comment. Screenshot: http://i.imgur.com/7agXRFB.png REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2110 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: colomar, plasma-devel

[Differential] [Request, 4 lines] D2117: Consider the primary screen as default screen

apol created this revision. apol added a reviewer: Plasma. apol added a subscriber: Neon. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We used to append them, but that didn't work well and was crashing plasmashell on

[Differential] [Accepted] D2118: add neon mapping

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2118 EMAIL PREFERENCES

[Differential] [Request, 68 lines] D2110: Create a Colors page in the Gallery

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Will list all available colors and show them in a rectangle, so that the user can see what we're

[Differential] [Closed] D2110: Create a Colors page in the Gallery

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI1f949f4eaf7f: Create a Colors page in the Gallery (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2110?vs=5003=5074 REVISION DETAIL

[Differential] [Request, 3 lines] D2137: Fix warning in BasicListItem.width

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY .../org/kde/kirigami/GlobalDrawer.qml:360:25: QML BasicListItem: Binding loop detected for property

[Differential] [Commented On] D2117: Consider the primary screen as default screen

apol added a comment. You mean you applied the patch? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2117 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma Cc: jriddell, plasma-devel, #neon,

[Differential] [Request, 45 lines] D2329: Let the drawer contents take the full width

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I'm not sure why it was done like that, but otherwise we're forced into some margins which look weird,

[Differential] [Updated] D2327: Let the drawer contents take the full width

apol updated the summary for this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2327 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel

[Differential] [Closed] D2327: Let the drawer contents take the full width

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMIcf7ea0a6adda: Let the drawer contents take the full width (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2327?vs=5609=5615 REVISION

[Differential] [Request, 40 lines] D2306: Make it possible to provide a page header to ScrollablePage

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Sometimes we show some information on top of a flickable that goes away as soon as the user scrolls

[Differential] [Request, 8 lines] D2517: Fix warning

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Can't assign an edge to an anchor

[Differential] [Closed] D2517: Fix warning

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI518d1101c129: Fix warning (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2517?vs=6116=6147 REVISION DETAIL

[Differential] [Closed] D2589: Make the AbstractListItem a Rectangle

apol closed this revision. apol added a comment. Submitted as of: commit 9261ecc98d10f38c4eade84746eb5a9b71bff4ff Author: Aleix Pol Date: Tue Sep 6 17:33:20 2016 +0200 I'm unsure why it didn't close the request. REPOSITORY rKIRIGAMI Kirigami

[Differential] [Updated, 2 lines] D2693: Standardize Drawer width

apol updated this revision to Diff 6659. apol added a comment. - Fix warnings REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2693?vs=6538=6659 BRANCH arcpatch-D2693 REVISION DETAIL https://phabricator.kde.org/D2693 AFFECTED FILES

[Differential] [Closed] D2705: Fix warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI341dd95310fa: Fix warnings (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2705?vs=6542=6658 REVISION DETAIL

[Differential] [Closed] D2693: Standardize Drawer width

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI616af4327cc6: Standardize Drawer width (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2693?vs=6659=6660 REVISION DETAIL

[Differential] [Updated, 3 lines] D2776: Silence warnings

apol updated this revision to Diff 6738. apol added a comment. Don't compute and discard REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2776?vs=6737=6738 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2776 AFFECTED FILES

[Differential] [Request, 3 lines] D2776: Silence warnings

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I usually get many like this:

[Differential] [Abandoned] D2593: Unify looks of the GlobalDrawer

apol abandoned this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2593 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol

[Differential] [Request, 7 lines] D2778: Expose the banner sourceSize

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This way one can put svg images TEST PLAN Works with Discover using it and kirigamigallery as is

[Differential] [Updated, 4 lines] D2776: Silence warnings

apol updated this revision to Diff 6739. apol added a comment. I misunderstood the problem REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2776?vs=6738=6739 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2776 AFFECTED FILES

[Differential] [Closed] D2776: Silence warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI0af136764a9b: Silence warnings (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2776?vs=6740=6741 REVISION DETAIL

[Differential] [Updated, 3 lines] D2776: Silence warnings

apol updated this revision to Diff 6740. apol added a comment. as agreed with marco REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2776?vs=6739=6740 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2776 AFFECTED FILES

[Differential] [Commented On] D2779: Port to Grid.

apol added a comment. It's often useful not to have the type on a variable's name so that patches like this don't need to happen. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2779 EMAIL PREFERENCES

[Differential] [Commented On] D2779: Port to Grid.

apol added inline comments. INLINE COMMENTS > main.qml:178 > > property int effectiveRows: { > +if (!pagerModel.count) { Looks like this should be readonly... REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2779 EMAIL

[Differential] [Request, 5 lines] D2790: Make application close upon Ctrl+Q

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Should possibly integrate with the system's defaults but shortcuts are not abstracted out just yet.

[Differential] [Updated] D2790: Make application close upon Ctrl+Q

apol marked an inline comment as done. apol added a comment. Thanks! REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2790 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: broulik, plasma-devel,

[Differential] [Updated, 5 lines] D2790: Make application close upon Ctrl+Q

apol updated this revision to Diff 6764. apol added a comment. Turns out it was already there REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2790?vs=6763=6764 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2790 AFFECTED FILES

[Differential] [Updated] D2790: Make application close upon Ctrl+Q

apol updated the summary for this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2790 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: broulik, plasma-devel, apol

[Differential] [Commented On] D2790: Make application close upon Ctrl+Q

apol added a comment. In https://phabricator.kde.org/D2790#51966, @broulik wrote: > So, Ctrl+Q always quits without confirmation? What about having a > > singal aboutToQuit(var event) > > and then do: > > onActivated: { > var event = {accepted: false} >

[Differential] [Updated, 5 lines] D2790: Make application close upon Ctrl+Q

apol updated this revision to Diff 6767. apol added a comment. Use Window.close rather than Qt.quit Gives the opportunity to the application to do something about the closing REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2790?vs=6764=6767

[Differential] [Commented On] D2580: possible to use OverlaySheet with ListView

apol added a comment. In https://phabricator.kde.org/D2580#50546, @mart wrote: > In https://phabricator.kde.org/D2580#50121, @apol wrote: > > > We've been looking into it with @colomar and we like how it works. We think it would be useful if we'd get a small margin on either side so

[Differential] [Accepted] D2580: possible to use OverlaySheet with ListView

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH phab/listviewsheet REVISION DETAIL https://phabricator.kde.org/D2580 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma,

[Differential] [Accepted] D2858: Fix Plasma discover with the Kirigami it can depend on

apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Please also merge to master and revert the patch there. REPOSITORY rDISCOVER Discover Software Store BRANCH Plasma/5.8 REVISION DETAIL

[Differential] [Accepted] D2859: Bump kirigami dependency to include things we rely on

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rDISCOVER Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D2859 EMAIL PREFERENCES

[Differential] [Requested Changes To] D2858: Fix Plasma discover with the Kirigami it can depend on

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Should be discarded, it's incompatible with another RR REPOSITORY rDISCOVER Discover Software Store REVISION DETAIL https://phabricator.kde.org/D2858 EMAIL PREFERENCES

[Differential] [Accepted] D2887: Fix kcminit phase 1 and 2

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2887 EMAIL PREFERENCES

[Differential] [Accepted] D2930: purpose is a runtime dependency, do not conditional on it at build time

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2930 EMAIL PREFERENCES

[Differential] [Closed] D2968: Don't control the look of the delegate on completion

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI33d03d4920db: Don't control the look of the delegate on completion (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2968?vs=7160=7165

[Differential] [Commented On] D2913: Make the background of the logout screen darker

apol added a comment. FWIW it could still make sense. the text is not super readable sometimes, as it's gray (at least on my system). REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2913 EMAIL PREFERENCES

[Differential] [Request, 6 lines] D2968: Don't control the look of the delegate on completion

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The index could change at any time TEST PLAN Still works, doesn't fix the dreaded warning REPOSITORY

[Differential] [Closed] D2813: Readability. Simplify overly complex code

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE89c34a853b64: Readability. Simplify overly complex code (authored by apol). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2812: Make sure the panel is within the screen's geometry

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE3bf1372dffed: Make sure the panel is within the screen's geometry (authored by apol). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 1 line] D2812: Make sure the panel is within the screen's geometry

apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Whenever we restore, the position of the panel can be random, we need to ensure that it's placed in the screen

[Differential] [Request, 38 lines] D2813: Readability. Simplify overly complex code

apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We have a big case because the size depend on whether the panel is vertical or horizontal but it doesn't really

[Differential] [Updated, 28 lines] D2827: Polish SwipeListItem

apol updated this revision to Diff 6856. apol added a comment. Reduce magic numbers REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2827?vs=6855=6856 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2827 AFFECTED FILES

[Differential] [Updated] D2827: Polish SwipeListItem

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > mart wrote in SwipeListItem.qml:362 > what's the rationale for this? Good point, fixed. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2827 EMAIL PREFERENCES

[Differential] [Closed] D2827: Polish SwipeListItem

This revision was automatically updated to reflect the committed changes. apol marked an inline comment as done. Closed by commit rKIRIGAMIf90a5ca65f04: Polish SwipeListItem (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE

  1   2   3   >