[Differential] [Commented On] D782: Require Qt 5.5

apol added a subscriber: apol. apol added a comment. +1 REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D782 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: apol,

[Differential] [Accepted] D861: Port away from kdelibs4support

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH drop-kdelibs4support REVISION DETAIL https://phabricator.kde.org/D861 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em

[Differential] [Commented On] D1066: Fix saving correct length of panel

apol added a comment. +1 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1066 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc: apol, plasma-devel ___

[Differential] [Accepted] D1171: simple cleanup in geometryByDistance

apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Makes sense, for readability. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1171 EMAIL PREFERENCES

[Differential] [Updated] D1279: Add a template for Weather Ion dataengines

apol added a comment. LGTM REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1279 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, apol Cc: plasma-devel, sebas _

[Differential] [Accepted] D1498: Fix memory leak in system tray

apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. LGTM, thanks! REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1498 EMAIL PREFERENCES https://phabr

[Differential] [Commented On] D1514: [Milou] Optimize sources model

apol added a comment. A test would be good, with ModelTest it would be great. INLINE COMMENTS lib/sourcesmodel.cpp:304 This looks wrong. Begin should be on top... lib/sourcesmodel.cpp:307 Same REPOSITORY rMILOU Milou REVISION DETAIL https://phabricator.kde.org/D1514 EMAIL PREFERENCE

[Differential] [Commented On] D1588: [Shell] Replace foreach by range-for where possible

apol added a comment. In https://phabricator.kde.org/D1588#29377, @davidedmundson wrote: > maybe we can, but why? > > foreach is always correct > > for is sometimes correct > > what's the benefit? I tend to think along those lines... if it was actually a problem, it cou

[Differential] [Commented On] D1647: kfontinst: Port to QDialog

apol added a comment. Other than that it looks quite good, interesting how much code gets cleaned up. INLINE COMMENTS > Printer.cpp:349 > + > +QDialogButtonBox *buttonBox = new > QDialogButtonBox(QDialogButtonBox::Cancel); > +connect(buttonBox, SIGNAL(rejected()), this, SLOT(slotCan

[Differential] [Commented On] D1676: kfontinst: Port to QApplication and QCommandLineParser

apol added a comment. LGTM +1 INLINE COMMENTS > Viewer.cpp:131 > { > -for (int i = 0; i < args->count(); ++i) > +for (int i = 0; i < urlArgs.count(); ++i) > { Prefer foreach to iterate a QList REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION

[Differential] [Commented On] D1675: kfontinst: Port to QTemporaryDir

apol added a comment. I'd say it's generally better to use QDir::filePath there. it will be easier to read. INLINE COMMENTS > FontThumbnail.cpp:96 > { > -realPath=tempDir->name()+entry->name(); > + >

[Differential] [Commented On] D1675: kfontinst: Port to QTemporaryDir

apol added a comment. Ugh, I was convinced it would exist! My apologies for not checking. For now, can you at least just change from "/" -> QLatin1Char('/')? Also if you can look into adding the API to Qt that would be great as well. Other than that, +1 REPOSITORY rPLASMADESKTOP

[Differential] [Accepted] D1675: kfontinst: Port to QTemporaryDir

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1675 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1676: kfontinst: Port to QApplication and QCommandLineParser

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1676 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1685: kfontinst: Port to QDebug

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1685 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1686: kfontinst: Port away from KIO::NetAccess

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1686 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1687: kfontinst: Port to QFileDialog

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1687 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1688: kfontinst: Port to QSaveFile

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1688 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov,

[Differential] [Accepted] D1689: kfontinst: Port to QMimeDatabase

apol accepted this revision. apol added a reviewer: apol. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > FontFilter.cpp:169 > +QStringList mimes; > +foreach (QString pattern, mime.globPatterns()) > +mimes.appe

[Differential] [Accepted] D1705: [System Tray] Don't iterate keys()

apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Good stuff! Clazy? Or you actually found this to be a paint point? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D170

[Differential] [Commented On] D1769: [Service Runner] Don't use KRun::runService

apol added a comment. Would it make sense to add such API in KRun@KIOWidgets? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1769 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: apol, pl

[Differential] [Accepted] D1810: Don't call a plugin "something plugin"

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1810 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Accepted] D1809: Fix i18n in plasmacalendarintegration

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1809 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Updated] D1744: Fix the ignore struts multi-screen handling

apol added a comment. I just tested the patch, the issue isn't solved here. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1744 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, lbeltrame, apol Cc: plasma-devel,

[Differential] [Changed Subscribers] D1866: Use QVector and QLatin1String, and range-based for

apol added inline comments. INLINE COMMENTS > xrandroutput.cpp:258 > > -Q_FOREACH(const QString &pre, embedded) { > +for (const QLatin1String &pre : embedded) { > if (name.toUpper().startsWith(pre)) { This one is fine, but I wouldn't change from `foreach -> for` as a norm, as

[Differential] [Request, 68 lines] D2110: Create a Colors page in the Gallery

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Will list all available colors and show them in a rectangle, so that the user can see what we're talking

[Differential] [Commented On] D2110: Create a Colors page in the Gallery

apol added a comment. Screenshot: http://i.imgur.com/7agXRFB.png REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2110 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: colomar, plasma-devel _

[Differential] [Request, 4 lines] D2117: Consider the primary screen as default screen

apol created this revision. apol added a reviewer: Plasma. apol added a subscriber: Neon. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We used to append them, but that didn't work well and was crashing plasmashell on

[Differential] [Accepted] D2118: add neon mapping

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2118 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Closed] D2110: Create a Colors page in the Gallery

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI1f949f4eaf7f: Create a Colors page in the Gallery (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2110?vs=5003&id=5074 REVISION DETAIL

[Differential] [Request, 3 lines] D2137: Fix warning in BasicListItem.width

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY .../org/kde/kirigami/GlobalDrawer.qml:360:25: QML BasicListItem: Binding loop detected for property "wid

[Differential] [Commented On] D2117: Consider the primary screen as default screen

apol added a comment. You mean you applied the patch? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2117 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma Cc: jriddell, plasma-devel, #neon, jens

[Differential] [Closed] D2117: Consider the primary screen as default screen

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd1210f5fda01: Consider the primary screen as default screen (authored by apol). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2117?

[Differential] [Request, 15 lines] D2144: Fix warnings

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make sure we don't ever call null objects REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETA

[Differential] [Abandoned] D2137: Fix warning in BasicListItem.width

apol abandoned this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2137 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel ___ Plasma-de

[Differential] [Commented On] D2144: Fix warnings

apol added a comment. > why adding check over mainFlickable.currentItem ? doesn't guard anything We don't want `mainFlickable.currentItem.width` to fail if `mainFlickable.currentItem` is null. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2144 EMAIL PRE

[Differential] [Updated, 22 lines] D2144: Fix warnings

apol updated this revision to Diff 5344. apol added a comment. Address Marco's comment REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2144?vs=5096&id=5344 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2144 AFFECTED FILES src/cont

[Differential] [Updated, 27 lines] D2144: Fix warnings

apol updated this revision to Diff 5345. apol added a comment. Fix morphing, proper testing REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2144?vs=5344&id=5345 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2144 AFFECTED FILES src

[Differential] [Closed] D2144: Fix warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI50b4b7b032a2: Fix warnings (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2144?vs=5345&id=5346 REVISION DETAIL https://phabricator.k

[Differential] [Changed Subscribers] D2240: Anchors in a layout item is always wrong

apol added inline comments. INLINE COMMENTS > WidgetExplorer.qml:264 > id: closeButton > -anchors { > -right: parent.right If it needs to be aligned to the right, shouldn't it have a `Layout.alignment: Qt.AlignRight`? REPOSITORY rPLASMADESKTOP Plasma

[Differential] [Request, 4 lines] D2305: Prefer alias to new property

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's better to just have a property aliased than duplicating it. Both for readability and performance RE

[Differential] [Closed] D2305: Prefer alias to new property

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI69d297937b01: Prefer alias to new property (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2305?vs=5541&id=5543#toc REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST U

[Differential] [Request, 40 lines] D2306: Make it possible to provide a page header to ScrollablePage

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Sometimes we show some information on top of a flickable that goes away as soon as the user scrolls down

[Differential] [Updated, 45 lines] D2306: Make it possible to provide a page header to ScrollablePage

apol updated this revision to Diff 5547. apol added a comment. Add api documentation REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2306?vs=5546&id=5547 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2306 AFFECTED FILES examples/g

[Differential] [Updated, 45 lines] D2306: Make it possible to provide a page header to ScrollablePage

apol updated this revision to Diff 5549. apol added a comment. Fix naming REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2306?vs=5547&id=5549 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2306 AFFECTED FILES examples/gallery/cont

[Differential] [Commented On] D2306: Make it possible to provide a page header to ScrollablePage

apol added a comment. In https://phabricator.kde.org/D2306#42989, @mart wrote: > seems to behave a bit strangely, especially its interaction with the global ApplicationHeader is quite strange What is that you don't like exactly? I can look into it if you tell me. REPOSITORY rKI

[Differential] [Commented On] D2306: Make it possible to provide a page header to ScrollablePage

apol added a comment. In https://phabricator.kde.org/D2306#43024, @mart wrote: > it should just be a fixed header, always visible and laid out with the main content or flickable, it should be in Page (and just happening to work in scrollablepage too) and the property called just header,

[Differential] [Request, 5 lines] D2326: Properly check if the page is in bounds

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We were just checking on the lower bounds REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETA

[Differential] [Closed] D2326: Properly check if the page is in bounds

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMIe24d9e255616: Properly check if the page is in bounds (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2326?vs=5605&id=5608 REVISION DE

[Differential] [Request, 4 lines] D2327: Let the drawer contents take the full width

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I'm not sure why it was done like that, but otherwise we're forced into some margins which look weird, e

[Differential] [Updated] D2327: Let the drawer contents take the full width

apol updated the summary for this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2327 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel ___

[Differential] [Closed] D2327: Let the drawer contents take the full width

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMIcf7ea0a6adda: Let the drawer contents take the full width (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2327?vs=5609&id=5615 REVISIO

[Differential] [Request, 45 lines] D2329: Let the drawer contents take the full width

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I'm not sure why it was done like that, but otherwise we're forced into some margins which look weird, e

[Differential] [Request, 17 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use Layout attached property margins rather than trying to compute sizes REPOSITORY rKIRIGAMI Kirigami

[Differential] [Abandoned] D2329: Let the drawer contents take the full width

apol abandoned this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2329 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel ___ Plasma-de

[Differential] [Request, 2 lines] D2335: Respect the bottomPadding for the bottom of the drawer

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make it possible to not leave an empty space below the drawer REPOSITORY rKIRIGAMI Kirigami BRANCH b

[Differential] [Closed] D2335: Respect the bottomPadding for the bottom of the drawer

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI2e8371f5bc69: Respect the bottomPadding for the bottom of the drawer (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2335?vs=5631&id=56

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol updated this revision to Diff 5633. apol added a comment. Update patch REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5630&id=5633 BRANCH margins REVISION DETAIL https://phabricator.kde.org/D2334 AFFECTED FILES src/controls/Globa

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol updated this revision to Diff 5635. apol added a comment. Use padding to place the top element as well REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5633&id=5635 BRANCH margins REVISION DETAIL https://phabricator.kde.org/D2334 AFF

[Differential] [Updated, 15 lines] D2334: Respect the bottomPadding for the bottom of the drawer

apol updated this revision to Diff 5636. apol added a comment. Use padding when necessary REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5635&id=5636 BRANCH margins REVISION DETAIL https://phabricator.kde.org/D2334 AFFECTED FILES src/

[Differential] [Closed] D2334: Respect the bottomPadding for the bottom of the drawer

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI7f92f7f9a314: Respect the bottomPadding for the bottom of the drawer (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2334?vs=5636&id=56

[Differential] [Commented On] D2399: New new SDDM theme

apol added a comment. Shouldn't we be keeping the old theme for nostalgia and such? It's a theme after all. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2399 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Request, 8 lines] D2517: Fix warning

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Can't assign an edge to an anchor file:///home/apol/devel/kde5/lib64/qml/org/kde/kirigami/styles/Des

[Differential] [Closed] D2517: Fix warning

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI518d1101c129: Fix warning (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2517?vs=6116&id=6147 REVISION DETAIL https://phabricator.kd

[Differential] [Request, 16 lines] D2542: Simplify code

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Don't crash if m_stylesFallbackChain is empty It can be reproduced by defining QT_QUICK_CONTROLS_STYL

[Differential] [Closed] D2542: Simplify code

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI892d33e067ba: Simplify code (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2542?vs=6167&id=6180 REVISION DETAIL https://phabricator.

[Differential] [Updated] D1075: Display mouse image in mouse kcm properly on highdpi screen

apol added a comment. Should we close this review? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1075 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, broulik, apol Cc: plasma-devel, lesliezhai, al

[Differential] [Abandoned] D2306: Make it possible to provide a page header to ScrollablePage

apol abandoned this revision. apol added a comment. Too specific to Discover. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2306 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel

[Differential] [Accepted] D2555: Use signal screenRemoved instead of QObject::destroyed

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D2555 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Updated] D2587: Set proper component name for plasma-discover

apol added a comment. Are you sure it wasn't because of this? http://commits.kde.org/discover/31ccc5d258a1833bc67a9af0ae8c9e70d951edd8 REPOSITORY rDISCOVER Discover Software Store REVISION DETAIL https://phabricator.kde.org/D2587 EMAIL PREFERENCES https://phabricator.kde.org/settings

[Differential] [Request, 2 lines] D2589: Make the AbstractListItem a Rectangle

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As described by the documentation and as it makes sense. TEST PLAN Seems to just work REPOSITORY rKI

[Differential] [Accepted] D2587: Set proper component name for plasma-discover

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I thought so. REPOSITORY rDISCOVER Discover Software Store BRANCH setpropercomponentname (branched from master) REVISION DETAIL https://phabricator.kde.org/D2587 EMAIL PREFERENCES htt

[Differential] [Request, 7 lines] D2592: Properly place the title in the layout

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Let the text elide if it doesn't fit Use layout properties instead of adding an empty item REPOSITORY

[Differential] [Closed] D2592: Properly place the title in the layout

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI47337e8b7c34: Properly place the title in the layout (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2592?vs=6302&id=6303 REVISION DET

[Differential] [Request, 18 lines] D2593: Unify looks of the GlobalDrawer

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make sure we specify a sourceSize so that we can render svg images of any size. Make it possible to sp

[Differential] [Request, 25 lines] D2652: Let the application control the menu further

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Introduces a property so that triggering leaf categories doesn't change the state of the menu. Introdu

[Differential] [Updated] D2652: Let the application control the menu further

apol marked an inline comment as done. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2652 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: colomar, plasma-devel, apol

[Differential] [Updated, 25 lines] D2652: Let the application control the menu further

apol updated this revision to Diff 6477. apol added a comment. Fix naming REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2652?vs=6423&id=6477 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2652 AFFECTED FILES src/controls/GlobalDr

[Differential] [Updated, 25 lines] D2652: Let the application control the menu further

apol updated this revision to Diff 6479. apol added a comment. Ugh... REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2652?vs=6477&id=6479 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2652 AFFECTED FILES src/controls/GlobalDrawer

[Differential] [Closed] D2652: Let the application control the menu further

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMIdd4173055e14: Let the application control the menu further (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2652?vs=6479&id=6481 REVISI

[Differential] [Request, 9 lines] D2683: Simplify AbstractListItem logic

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make it an Item rather than a rectangle, the background item is supposed to be the base item. Make sur

[Differential] [Request, 2 lines] D2682: Make sure padding is respected in the GlobalDrawer

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Sets it just like on the other components, could probably be refactored into a parent's margin REPOSITO

[Differential] [Updated] D2683: Simplify AbstractListItem logic

apol marked an inline comment as done. apol added a comment. Fixed issue REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2683 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol

[Differential] [Updated, 16 lines] D2683: Simplify AbstractListItem logic

apol updated this revision to Diff 6489. apol added a comment. address as suggested by marco REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2683?vs=6488&id=6489 BRANCH arcpatch-D2683 REVISION DETAIL https://phabricator.kde.org/D2683 AFFECTED FI

[Differential] [Closed] D2683: Simplify AbstractListItem logic

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI9261ecc98d10: Simplify AbstractListItem logic (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2683?vs=6489&id=6490 REVISION DETAIL h

[Differential] [Request, 2 lines] D2693: Standardize Drawer width

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make it wider, not dependent in terms of the title size REPOSITORY rKIRIGAMI Kirigami BRANCH master

[Differential] [Updated] D2580: possible to use OverlaySheet with ListView

apol added a subscriber: colomar. apol added a comment. We've been looking into it with @colomar and we like how it works. We think it would be useful if we'd get a small margin on either side so that it's easy to close when we're half-way through the scrolling process. Other than that,

[Differential] [Commented On] D2693: Standardize Drawer width

apol added a comment. In https://phabricator.kde.org/D2693#50118, @broulik wrote: > I have to test it how it looks on a phone i agree on the concept, not sure on the implementation as it's potentially breaking on applications How do you foresee it breaking applications? It becomes

[Differential] [Updated, 175 lines] D2693: Standardize Drawer width

apol updated this revision to Diff 6538. apol added a comment. - Fix warnings REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2693?vs=6513&id=6538 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2693 AFFECTED FILES examples/gallery/

[Differential] [Request, 2 lines] D2705: Fix warnings

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY DefaultListItemBackground expects the item to be called listItem REPOSITORY rKIRIGAMI Kirigami BRANCH

[Differential] [Closed] D2589: Make the AbstractListItem a Rectangle

apol closed this revision. apol added a comment. Submitted as of: commit 9261ecc98d10f38c4eade84746eb5a9b71bff4ff Author: Aleix Pol Date: Tue Sep 6 17:33:20 2016 +0200 I'm unsure why it didn't close the request. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://

[Differential] [Closed] D2705: Fix warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI341dd95310fa: Fix warnings (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2705?vs=6542&id=6658 REVISION DETAIL https://phabricator.k

[Differential] [Updated, 2 lines] D2693: Standardize Drawer width

apol updated this revision to Diff 6659. apol added a comment. - Fix warnings REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2693?vs=6538&id=6659 BRANCH arcpatch-D2693 REVISION DETAIL https://phabricator.kde.org/D2693 AFFECTED FILES src/contr

[Differential] [Closed] D2693: Standardize Drawer width

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI616af4327cc6: Standardize Drawer width (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2693?vs=6659&id=6660 REVISION DETAIL https://

[Differential] [Commented On] D2580: possible to use OverlaySheet with ListView

apol added a comment. In https://phabricator.kde.org/D2580#50546, @mart wrote: > In https://phabricator.kde.org/D2580#50121, @apol wrote: > > > We've been looking into it with @colomar and we like how it works. We think it would be useful if we'd get a small margin on either side so t

[Differential] [Accepted] D2580: possible to use OverlaySheet with ListView

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH phab/listviewsheet REVISION DETAIL https://phabricator.kde.org/D2580 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #kir

[Differential] [Request, 3 lines] D2776: Silence warnings

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I usually get many like this: file:///home/apol/devel/kde5/lib64/qml/org/kde/kirigami/templates/Overlay

[Differential] [Updated, 3 lines] D2776: Silence warnings

apol updated this revision to Diff 6738. apol added a comment. Don't compute and discard REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2776?vs=6737&id=6738 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2776 AFFECTED FILES src/co

[Differential] [Updated, 4 lines] D2776: Silence warnings

apol updated this revision to Diff 6739. apol added a comment. I misunderstood the problem REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2776?vs=6738&id=6739 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2776 AFFECTED FILES src/

[Differential] [Updated, 3 lines] D2776: Silence warnings

apol updated this revision to Diff 6740. apol added a comment. as agreed with marco REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2776?vs=6739&id=6740 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2776 AFFECTED FILES src/control

  1   2   3   >