[Differential] [Request, 4 lines] D2212: Reduce Calendar size in Digital clock

ochurlaud created this revision. ochurlaud added reviewers: Plasma: Design, Plasma, davidedmundson. ochurlaud set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. ochurlaud added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I

[Differential] [Updated] D2212: Reduce Calendar size in Digital clock

ochurlaud updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2212 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma:_design, #plasma, davidedmundson Cc: plasma

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

ochurlaud added a comment. Before: F188019: Screenshot_20160719_101221.png After: F188021: Screenshot_20160719_101336.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

ochurlaud added a comment. In https://phabricator.kde.org/D2212#41053, @andreaska wrote: > the reduced calender size in the widget is way better than before, but what's with the text (time) in the panel? the time height in the panel should be the same height than the system tray icon

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

ochurlaud added a comment. In https://phabricator.kde.org/D2212#41483, @mck182 wrote: > In https://phabricator.kde.org/D2212#41055, @drosca wrote: > > > The calendar popup size is fine for me (with patched plasma-framework), what I *still* think is broken is the gridSize scaling - see

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

ochurlaud added a comment. @sebas: just for info, is here my panel config: [PlasmaViews][Panel 97][Horizontal1366] length=1164 thickness=24 the thickness is very small, and changing the font *does not* change the font in the calendar. REPOSITORY rPLASMAWORKSPACE Plasma Workspa

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

ochurlaud added a comment. In https://phabricator.kde.org/D2212#41485, @sebas wrote: > -1, the calendar is only going to look more cramped like this. > > Whitespace is useful and part of the visual language, don't just remove it. > > Also, the size of the calendar is oriented with

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

ochurlaud added a comment. So just to show exactly my issue: F189465: comments.png Other applets are very fine! but look at the font size difference between the clock and the different parts of the calendar. I think on big screens it's good but

[Differential] [Abandoned] D2212: Reduce Calendar size in Digital clock

ochurlaud abandoned this revision. ochurlaud added a comment. Screen too small, and would be a fix only for a niche type of users REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2212 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

[Differential] [Commented On] D2270: Try to be more clever about what sink to use for volume control

ochurlaud added a comment. Just tested, in my case it solves https://bugs.kde.org/show_bug.cgi?id=365771 REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2270 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 5,159 lines] D2409: Update Color KCM

ochurlaud created this revision. ochurlaud added reviewers: Plasma, mart, andreask, VDG. ochurlaud set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As d

[Differential] [Updated] D2409: Update Color KCM

ochurlaud updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma, mart, andreask, #vdg Cc: andreaska, plasma-dev

[Differential] [Commented On] D2409: Update Color KCM

ochurlaud added a comment. In https://phabricator.kde.org/D2409#45025, @andreaska wrote: > Thanks Oliver, > > can you post some screenshots cause I can't compile it. Updated REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL

[Differential] [Commented On] D2409: Update Color KCM

ochurlaud added a comment. In https://phabricator.kde.org/D2409#45058, @whiting wrote: > I like it. Nice work. I agree I would change Config Scheme to Edit Scheme. Done locally. The executable is now KColorSchemeEditor. If someone could tell me what the kcolorschemeditor.

[Differential] [Updated, 5,202 lines] D2409: Update Color KCM

ochurlaud removed rPLASMADESKTOP Plasma Desktop as the repository for this revision. ochurlaud updated this revision to Diff 5843. ochurlaud added a comment. Added a desktop file, finished the app (KAboutData, CommandLineParser,...) Ready to ship, I just wait for your remarks. CHANGES SI

[Differential] [Updated] D2409: Update Color KCM

ochurlaud updated the summary for this revision. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma, andreask, #vdg, mart Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohame

[Differential] [Commandeered] D2409: Update Color KCM

ochurlaud commandeered this revision. ochurlaud edited reviewers, added: bshah; removed: ochurlaud. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, andreask, #vdg, mart, #plasma, bshah Cc: whiting

[Differential] [Updated] D2409: Update Color KCM

ochurlaud reclaimed this revision. REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, andreask, #vdg, mart, #plasma, bshah Cc: whiting, colomar, andreaska, plasma-devel, lesliezhai, ali-mohamed, jen

[Differential] [Closed] D2409: Update Color KCM

ochurlaud closed this revision. ochurlaud added a comment. This was submitted in commit https://phabricator.kde.org/rPLASMADESKTOPb9e2664cc7aa50aa9e6be8368f34390bc756b73a REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

ochurlaud added a comment. In https://phabricator.kde.org/D2478#46347, @sitter wrote: > Pulling in @ochurlaud > > The NoDisplay remark from Bhushan got me wondering how the KCM actually starts the app. And it turns out that it doesn't. > > SchemeEditorDialog* dialog = new Scheme

[Differential] [Accepted] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

ochurlaud accepted this revision. ochurlaud added a comment. After discussion on IRC: the nodisplay bit will be removed in a next iteration when the app will have more context. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D2478 EM

[Differential] [Request, 124 lines] D2631: Correct regression introduced during color kcm rewritting.

ochurlaud created this revision. ochurlaud added reviewers: andreask, Plasma, pino, mart. ochurlaud added a subscriber: andreask. ochurlaud set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscribe

[Differential] [Closed] D2631: Correct regression introduced during color kcm rewritting.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPb5fd8c353448: Colors KCM: Correct regression in previews introduced during rewritting (authored by ochurlaud). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2631?vs=6374&id=6375#toc

[Differential] [Request, 2 lines] D2846: Let kicker display executable items instead of empty buttons.

ochurlaud created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This would partially fix https://bugs.kde.org/show_bug.cgi?id=369242 Another patch is required not to show empty elements (in case `data()`

[Differential] [Updated] D2846: Let kicker display executable items instead of empty buttons.

ochurlaud added a reviewer: hein. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2846 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, hein Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts

[Differential] [Updated] D2846: Let kicker display executable items instead of empty buttons.

ochurlaud added a reviewer: Plasma. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2846 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, hein, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterb

[Differential] [Changed Subscribers] D2846: Let kicker display executable items instead of empty buttons.

ochurlaud added a subscriber: broulik. ochurlaud added a comment. @broulik remarked that a .desktop file should not define a `Exec=""` when it is `Type=Service`. If we want to respect this, we could split all kcm files in one part which defines the service, and one that defines the Exec

[Differential] [Updated, 5 lines] D2846: Let kicker display executable items instead of empty buttons.

ochurlaud updated this revision to Diff 6906. ochurlaud added a comment. Check for type, as asked by Sho REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2846?vs=6896&id=6906 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28

[Differential] [Updated, 5 lines] D2846: Let kicker display executable items instead of empty buttons.

ochurlaud updated this revision to Diff 6909. ochurlaud added a comment. Use !contains() instead of index() == -1 REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2846?vs=6906&id=6909 BRANCH master REVISION DETAIL https://phabricator.kd

[Differential] [Closed] D2846: Let kicker display executable items instead of empty buttons.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP5c966a42554f: Let kicker display executable items instead of empty buttons. (authored by ochurlaud). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator

[Differential] [Request, 184 lines] D3048: [Colors KCM] Default scheme is now installed as a file

ochurlaud created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The default values are not anymore taken from the hardcoded ones in kconfigwidget. BUG: 370305 REPOSITORY rPLASMADESKTOP Plasma Desk

[Differential] [Updated] D3048: [Colors KCM] Default scheme is now installed as a file

ochurlaud added reviewers: Plasma, mart, broulik. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3048 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma, mart, broulik Cc: plasma-devel, lesliezhai, a

[Differential] [Commented On] D3048: [Colors KCM] Default scheme is now installed as a file

ochurlaud added a comment. One draw back of this way is that if `Default.colors` is erased or not found, there is no "Default", and in case no `*.colors` are found, the kcm will be empty... REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3048 EMAIL

[Differential] [Commented On] D3048: [Colors KCM] Default scheme is now installed as a file

ochurlaud added a comment. In https://phabricator.kde.org/D3048#56488, @mart wrote: > i am in favor of this chane, but i think the real reson of the breakage should be investigated as well, uf there may be problems in kconfigwidget itself Then I need help :) INLINE COMMENTS > m

[Differential] [Abandoned] D3048: [Colors KCM] Default scheme is now installed as a file

ochurlaud abandoned this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3048 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma, broulik, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jen