D10620: Improve sidebar header visibility
ngraham closed this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
ngraham updated this revision to Diff 27550. ngraham added a comment. re-base on Plasma 5.12 branch REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10620?vs=27540=27550 BRANCH more-visible-headers (branched from Plasma/5.12) REVISION DETAIL https://phabricator.kde.org/D10620 AFFECTED FILES sidebar/package/contents/ui/CategoriesPage.qml sidebar/package/contents/ui/SubCategoryPage.qml To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R124 System Settings BRANCH more-visible-headers (branched from master) REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
ngraham edited the test plan for this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
ngraham updated this revision to Diff 27540. ngraham marked 2 inline comments as done. ngraham added a comment. Also improve subcategory headers REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10620?vs=27539=27540 BRANCH more-visible-headers (branched from master) REVISION DETAIL https://phabricator.kde.org/D10620 AFFECTED FILES sidebar/package/contents/ui/CategoriesPage.qml sidebar/package/contents/ui/SubCategoryPage.qml To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
ngraham edited the test plan for this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
ngraham updated this revision to Diff 27539. ngraham added a comment. Use supportsMouseEvents: false instead REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10620?vs=27438=27539 BRANCH more-visible-headers (branched from master) REVISION DETAIL https://phabricator.kde.org/D10620 AFFECTED FILES sidebar/package/contents/ui/CategoriesPage.qml To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
mart added inline comments. INLINE COMMENTS > mart wrote in CategoriesPage.qml:134 > hoverEnabled: false should be enough (iirc there are also properties to make > it not do mousepressed effects) should be supportsMouseEvents: false REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
mart added a comment.
I'm ok with making the text darker in the headers.
I'm not exactly sure why as viewbackgroundcolor should be correct(tough
deprecated), but in the breeze light screenshots the headers have a background
slightly ligher than the other elements, which makes it look a bit weird
INLINE COMMENTS
> CategoriesPage.qml:134
> +// Ideally, we would use real header items
> +background: Rectangle {
> +color: Kirigami.Theme.viewBackgroundColor
hoverEnabled: false should be enough (iirc there are also properties to make it
not do mousepressed effects)
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D10620
To: ngraham, #plasma, #kirigami, mart
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
ngraham added a comment. Oh shoot, I hadn't noticed that. :( REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
rkflx added a comment. Note that for the light theme this changes the background colour from `#FCFCFC` to `#FF`. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D10620 To: ngraham, #plasma, #kirigami, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
D10620: Improve sidebar header visibility
ngraham created this revision. ngraham added reviewers: Plasma, Kirigami, mart. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 384638 FIXED-IN: KDE Plasma 5.12.2 System Settings' sidebar headers were implemented as orginary Kirigami list items that had `enabled: false` set, which made them turn an almost unreadable light color. This was the wrong hack. This patch changes the hack to a different one that works much better. Ideally we would use real Kirigami list headers here, but the current system settings implementation seems to make this a challenge and I'm not sure it's worth it. TEST PLAN Before: After, Breeze light: After, Breeze dark: REPOSITORY R124 System Settings BRANCH more-visible-headers (branched from master) REVISION DETAIL https://phabricator.kde.org/D10620 AFFECTED FILES sidebar/package/contents/ui/CategoriesPage.qml To: ngraham, #plasma, #kirigami, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
