D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
apol added a comment. For some reason, didn't see this review >.<. Thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
ngraham closed this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
ngraham added a comment. Thanks! I'll land this later tonight, if Alex doesn't beat me to it. REPOSITORY R134 Discover Software Store BRANCH diffD10701 REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
akrutzler updated this revision to Diff 27724. akrutzler added a comment. Rebase to origin/Plasma/5.12. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10701?vs=27642=27724 BRANCH diffD10701 REVISION DETAIL https://phabricator.kde.org/D10701 AFFECTED FILES discover/qml/Shadow.qml To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
ngraham added a comment. Since this is a small bugfix, I'd like to land it on the Stable branch (Plasma 5.12). However, I can't easily do this using `arc` because you did the work on master without a branch (in the future, see https://community.kde.org/Infrastructure/Phabricator#Workflow). Can you put it on a branch and re-base this patch on Plasma 5.12 branch? Here's how to do that: git checkout -b [branchname] #create a new branch git fetch # fetch all changes from the remote repo git rebase --onto origin/Plasma/5.12 master #re-base your branch onto the Plasma/5.12 branch arc diff --update D10701 #update this diff See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
ngraham accepted this revision. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
akrutzler added a comment. Not yet, @ngraham did all the commits for me so far. Just in case, my email is andreas.krutz...@gmx.net :) REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
davidedmundson added a comment. Do you have commit access? REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: davidedmundson, acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
akrutzler added a comment. The gifs were the hardest part :) REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
acrouthamel added a comment. Super nice, thanks! REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
ngraham added a reviewer: Discover Software Store. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Beautiful! Lovely gif too. Thanks for that. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
akrutzler edited the summary of this revision. akrutzler added reviewers: apol, ngraham. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D10701: Fix ApplicationScreenshots shadow for Breeze Dark.
akrutzler created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. akrutzler requested review of this revision. REVISION SUMMARY If you're using Breeze Dark or probably any other dark theme, the screenshot shadow-gradient will run from white to transparent. With this patch, the shadow runs from the currently set background color to transparent. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 AFFECTED FILES discover/qml/Shadow.qml To: akrutzler Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
