D12036: Change "different user" icon on login screen

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7d19c5059b10: Change "different user" icon on 
login screen (authored by sharvey, committed by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12036?vs=31631&id=31699

REVISION DETAIL
  https://phabricator.kde.org/D12036

AFFECTED FILES
  sddm-theme/Main.qml

To: sharvey, ngraham, #vdg, #plasma, davidedmundson
Cc: abetts, sebas, davidedmundson, #vdg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, apol, mart

D12036: Change "different user" icon on login screen

[Nathaniel Graham]

ngraham added a comment.


  Let's stay with `system-switch-user` for now and see how that goes.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  change-user-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12036

To: sharvey, ngraham, #vdg, #plasma, davidedmundson
Cc: abetts, sebas, davidedmundson, #vdg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, apol, mart

D12036: Change "different user" icon on login screen

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  change-user-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12036

To: sharvey, ngraham, #vdg, #plasma, davidedmundson
Cc: abetts, sebas, davidedmundson, #vdg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, apol, mart

D12036: Change "different user" icon on login screen

[Scott Harvey]

sharvey added a subscriber: sebas.
sharvey added a comment.


  PS: Credit to @sebas for making Cuttlefish!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  change-user-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12036

To: sharvey, ngraham, #vdg, #plasma, davidedmundson
Cc: sebas, davidedmundson, #vdg, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D12036: Change "different user" icon on login screen

[Scott Harvey]

sharvey added a comment.


  In D12036#242299 , @ngraham wrote:
  
  >   In the Login screen, it lets you **//find//** other users not listed 
there to log in as.
  
  
  With all due respect to the designers, I never made that connection.
  
  I know the one you selected is named `system-switch-users`, but there's also 
this one, named `system-users`:
  
  F5800737: Screenshot_20180408_17.png 

  
  It doesn't have the arrow (which connotes action), but it clearly 
demonstrates "multiple people", another valid metaphor.
  
  It's simple enough to change if the reviewers like it better.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  change-user-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12036

To: sharvey, ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, #vdg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12036: Change "different user" icon on login screen

[Nathaniel Graham]

ngraham added reviewers: Plasma, davidedmundson.
ngraham accepted this revision.
ngraham added a subscriber: davidedmundson.
ngraham added a comment.
This revision is now accepted and ready to land.


  I think I understand why the icons are currently different: because the 
functionalities are different! In the lock screen, clicking on that button/icon 
switches to another visible user. In the Login screen, it lets you find other 
users not listed there to log in as.
  
  However, the the distinction is basically academic in the average user's 
mind, and the objective of both is to log in as a different user from the one 
that's been presented to you. Furthermore, the lock screen icon honestly does 
seem to fit both use cases, if you consider that each one is a subtle variation 
of  "log in as some other user".
  
  Therefore thumbs up from me. Let's let Plasma folks weigh in too, and 
especially @davidedmundson, who's the guardian of the SDDM theme.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  change-user-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12036

To: sharvey, ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, #vdg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12036: Change "different user" icon on login screen

[Scott Harvey]

sharvey created this revision.
sharvey added a reviewer: ngraham.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sharvey requested review of this revision.

REVISION SUMMARY
  Replace "different user" icon on SDDM login screen to match icon used on
  unlock screen. Original icon was `system-search`, now changed to 
`system-switch-user`.
  
  BUG 392830

TEST PLAN
  - Recompile `plasma-workspace`
- Log out of current session
  - Check that `Different User` icon is now a figure with an arrow

REPOSITORY
  R120 Plasma Workspace

BRANCH
  change-user-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12036

AFFECTED FILES
  sddm-theme/Main.qml

To: sharvey, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart