D12069: Implement a keyboard selector plasmoid

2018-04-21 Thread Martin Flöser
graesslin added a comment. I don't think that there's any reason to discard this. It's a start and improvement over the current situation and a fallback is needed anyway. So we start with the fallback instead of adding it later on. REPOSITORY R120 Plasma Workspace REVISION DETAIL https:

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Eike Hein
hein added a comment. Dated shots but relevant: https://blogs.gnome.org/mclasen/2012/09/21/input-sources-in-gnome/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12069 To: apol, #plasma Cc: hein, graesslin, broulik, davidedmundson, plasma-devel, ragreen, P

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Eike Hein
hein added a comment. In D12069#243315 , @davidedmundson wrote: > Is that something that can happen now? We have a GSoC project in the Ideas list this year that's aimed at it, and there are other Linux desktops that prove it's possible (

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread David Edmundson
davidedmundson added a comment. > once we switch to a proper model of managing input languages vs. just keyboard layouts in the workspace. Is that something that can happen now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12069 To: apol, #plasma Cc

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Eike Hein
hein added a comment. It's long been known that the keyboard layout switcher SNI is legacy stuff and will eventually become redundant with the Input Method Panel widget once we switch to a proper model of managing input languages vs. just keyboard layouts in the workspace. I suggest thi

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:42 > "apl" and "mao" are 3 letters. > No idea what either of those mean, it's just in the list. I'm not sure whether a substring is the correct solution anyhow. On Wayland we get a proper name like German, but t

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > main.qml:38 > +Plasmoid.preferredRepresentation: Plasmoid.compactRepresentation > +Plasmoid.compactRepresentation: PlasmaComponents.Label { > +fontSizeMode: Text.Fit Also set `height: undefined`, I've seen issues where `Text.Fit` f

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread David Edmundson
davidedmundson added a comment. > Mimics the behavior of the status notifier item The keyboard kded module when it's used on X has one more option for its SNI - show flag - show label - show label on flag "show layout indicator" and "show for single layout" become just normal

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Mimics the behavior of the status notifier item REPOSITORY R120 Plasma W