D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5c8ce892e394: [sddm-theme] Start moving from QQC1 to QQC2 
(authored by cblack).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=64261=68716

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson, filipf
Cc: ndavis, GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson, filipf
Cc: ndavis, GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Noah Davis]

ndavis added a comment.


  > F7256235: image.png 
  
  Is this screenshot outdated? Why does the selected item extend outside the 
width of the list?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson, filipf
Cc: ndavis, GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack added a comment.


  @davidedmundson any objections?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson, filipf
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Filip Fila]

filipf added a comment.


  Yo @cblack I think you can land this.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson, filipf
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 64261.
cblack added a comment.


  Unscrew indentation

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=64260=64261

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 64260.
cblack added a comment.


  Add font.pointSize: config.fontSize

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=63936=64260

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Filip Fila]

filipf added a comment.


  LGTM in use. The only thing I'd ask you to do is add `font.pointSize: 
config.fontSize` to both of the QQC2.Labels you were working on. SDDM defaults 
to 9pt font sizes; we need to override that so it's 10pt (same as the Plasma 
default).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 63936.
cblack added a comment.


  The new highlight style has been yeeted in favor of the current one

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=60379=63936

BRANCH
  arcpatch-D21815

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Björn Feber]

GB_2 added a comment.


  In D21815#490482 , @filipf wrote:
  
  > If keeping the new menu style we have to wait until all those patches get 
merged in Plasma.
  >
  > Might be better to just follow current style; updating it to the new one 
would be a quick review.
  
  
  Yeah, keep the current style.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Nathaniel Graham]

ngraham added a comment.


  In D21815#490482 , @filipf wrote:
  
  > Might be better to just follow current style; updating it to the new one 
would be a quick review.
  
  
  +1

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Filip Fila]

filipf added a comment.


  If keeping the new menu style we have to wait until all those patches get 
merged in Plasma.
  
  Might be better to just follow current style; updating it to the new one 
would be a quick review.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 60379.
cblack added a comment.


  - Change toolBtn to be more descriptive based on file the id was in
  - Styling changes on menus (they now have shadows)
  - Menu item highlight is tweaked as per T11124 
 (can revert if shouldn't be here)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=60136=60379

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack added a comment.


  In D21815#482624 , @filipf wrote:
  
  > For positioning the menu maybe you could have a look at how it was done in 
Kickoff config window: 
https://github.com/KDE/plasma-desktop/blob/master/applets/kickoff/package/contents/ui/ConfigGeneral.qml
  
  
  The menu seems to be extremely stubborn when it comes to y positioning. No 
amount of properties set or values passed to popup will get it to budge from 
its y position, including the method Kickoff uses.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Filip Fila]

filipf added a comment.


  For positioning the menu maybe you could have a look at how it was done in 
Kickoff config window: 
https://github.com/KDE/plasma-desktop/blob/master/applets/kickoff/package/contents/ui/ConfigGeneral.qml

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> KeyboardButton.qml:10
>  PlasmaComponents.ToolButton {
> -id: keyboardButton
> +id: toolBtn
>  

Prefer descriptive variable names; `toolButton` is better than `toolBtn`, but 
even better would be a description of what this button is actually for. The 
original was better and didn't need to be changed IMO.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: ngraham, filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 60136.
cblack added a comment.


  - Remove Item {} root and embed QQC2.Menu {} in PlasmaComponents.ToolButton{}
  - If toolbutton is larger than largest menu item, resize menu to size of 
toolbutton
  - Other minor things

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=59884=60136

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> filipf wrote in SessionButton.qml:47
> While we're doing this, can you perhaps make the menu pop up *above* the 
> button?

It seems that changing the `y` value doesn't affect its y position for whatever 
reason.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Filip Fila]

filipf added a comment.


  Added some comments that apply to both button files.
  
  On a final note, watch out for whitespace because there's lots of it that's 
been added. You can turn on whitespace displaying in Kate:
  
  F6894460: image.png 

INLINE COMMENTS

> SessionButton.qml:47
> +onClicked: {
> +sessionMenu.popup(x, y)
> +}

While we're doing this, can you perhaps make the menu pop up *above* the button?

> SessionButton.qml:65
> +implicitHeight: 40
> +implicitWidth: sessionMenu.largestWidth
> +color: PlasmaCore.ColorScope.backgroundColor

This can be up for debate, but I sort of liked the older behavior more when the 
menu's width would be determined by the size of the ToolButton at a particular 
point.

> SessionButton.qml:87
> +text: model.name
> +font: menuItem.font
> +color: PlasmaCore.ColorScope.textColor

Why do we need to set this?

> cblack wrote in SessionButton.qml:27
> QML files can only have one root, and the ToolButton's `menu` property 
> doesn't accept QQC2 menus, meaning they have to be separated.

It seems to be running fine without the Item wrapper for me. What I did though 
was but the QQC2 menu inside the button, I didn't split them up.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 59884.
cblack added a comment.


  Use PC3 components in the kb & session buttons instead of PC2 components

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=59880=59884

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> cblack wrote in SessionButton.qml:23
> The `menu` property seems to be removed in PC3

Additionally, `ToolButton` 

 still seems to use QQC1 even in PC3.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in SessionButton.qml:23
> Note that (confusingly) Plasma components 2 is QQC1
> Plasma components3 is QQC2
> 
> It might fix the menu issue

The `menu` property seems to be removed in PC3

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> SessionButton.qml:23
>  import org.kde.plasma.core 2.0 as PlasmaCore
>  import org.kde.plasma.components 2.0 as PlasmaComponents
>  

Note that (confusingly) Plasma components 2 is QQC1
Plasma components3 is QQC2

It might fix the menu issue

> SessionButton.qml:29
>  id: root
> -property int currentIndex: -1
> +implicitWidth: width
> +height: toolBtn.implicitHeight

I meant

implicitWidth: toolBtn.implicitWidth

width by default is bound to the implicitWidth so you don't need to set it
but more importantly you still have the data of the size something wants to be 
after someone else (a layout) sets the size

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Filip Fila]

filipf added a comment.


  Seems like you have all the QQC1 imports covered. I'm seeing a couple more in 
other files that are unused so it would be perfectly fine to remove them as a 
part of this diff.
  
  I'll give the new code a spin soon and then I can add more detailed comments.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in SessionButton.qml:27
> Why the wrapper?

QML files can only have one root, and the ToolButton's `menu` property doesn't 
accept QQC2 menus, meaning they have to be separated.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 59880.
cblack added a comment.


  Updates based off of feedback, and adding the standard menu fade animation to 
the QQC2 menus.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=59842=59880

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Concept makes sense, minor tweaks above
  
  Make sure you  test in full sddm, the test mode will infer some settings from 
your session which won't be valid in real usage.

INLINE COMMENTS

> KeyboardButton.qml:23
>  
> -menu: QQC.Menu {
> +// menu: QQC.Menu {
> +// id: keyboardMenu

Please fix.

> SessionButton.qml:27
>  
> -PlasmaComponents.ToolButton {
> +Item {
>  id: root

Why the wrapper?

> SessionButton.qml:29
>  id: root
> -property int currentIndex: -1
> +height: toolBtn.height
> +width: toolBtn.width

Implicit height should be propagated upwards, not height.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21815

To: cblack, #plasma, #vdg, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack updated this revision to Diff 59842.
cblack added a comment.


  Looks like this change managed to hide from Arcanist's gaze. Should have been 
there in the first place.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21815?vs=59841=59842

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21815: [sddm-theme] Start moving from QQC1 to QQC2

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Components that used QQC1 in `sddm-theme/` (excluding the symlinked 
`components` folder) have been changed to use QQC2.

TEST PLAN
  Ensure no loss of functionality, style, or bugs from the port of QQC1 to QQC2.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  sddm-qqc2-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21815

AFFECTED FILES
  sddm-theme/BreezeMenuStyle.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Main.qml
  sddm-theme/SessionButton.qml

To: cblack, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart