D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-16 Thread Carson Black 
cblack updated this revision to Diff 61859.
cblack added a comment.


  Remove sourceSize.width

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61825=61859

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma, filipf
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-16 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> filipf wrote in Main.qml:421
> try implicitWidth to avoid binding loop

Just remove sourceSize.width

We dont define a width.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma, filipf
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-16 Thread Filip Fila 
filipf accepted this revision as: filipf.
filipf added a comment.
This revision is now accepted and ready to land.


  As far as I'm concerned the patch is landable; I really like that it's 
developed into a more generic placeholder rather than one just for distro 
logos. Nice work @cblack, make sure to edit the commit title and message to 
reflect this though.
  
  Some things to still consider in the near or more distant future:
  
  - present to distros (namely openSUSE) and see if this is what they wanted
  - see if we want this on by default
  - add a UI option for having a logo and then an image chooser
  - see if the drop shadow will be interfering with existing drop shadows in 
logos (but logo authors can just remove it themselves I guess)
  - move the default svg to the artwork subfolder since it feels like it 
belongs there
  - fix the binding loop related to `sourceSize.width`

INLINE COMMENTS

> Main.qml:421
> +sourceSize.height: height
> +sourceSize.width: width
> +opacity: loginScreenRoot.uiVisible ? 0 : 1

try implicitWidth to avoid binding loop

REPOSITORY
  R120 Plasma Workspace

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma, filipf
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black 
cblack updated this revision to Diff 61825.
cblack added a comment.


  More sizing tweaks

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61819=61825

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Nathaniel Graham 
ngraham added a comment.


  Yeah, I woudn't actually mind showing the Plasma logo and text there by 
default at some point as long as it's small and tasteful. Our branding is 
pretty weak right now and any improvement there is welcome IMO.
  
  But yeah, that's a discussion for later.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Filip Fila 
filipf added a comment.


  Logo size still looks too big to me; IMO these things shouldn't be too much 
in the users' face and the logo shouldn't overpower the clock. Also I think the 
second screenshot doesn't accurately represent new code.
  
  You had `units.largeSpacing * 8` before => 8 * 8 = 64
  
  Now it's `units.gridUnits * 6` => 18 * 6 = 108
  
  Ideally we'd multiply `units.gridUnits` with 3 or 4 to get to 64 again (or do 
Math.round when multiplying with 3.5).
  
  For me `units.gridUnits * 3` looks perfect:
  
  F7028361: Screenshot_20190715_210721.png 

  
  And it seems I didn't give the best of advice for `sourceSize.width` as 
there's now a binding loop. If `width` is changed with `implicitWidth` it goes 
away though.
  
  
  
  On a more general note, I'd keep the logo turned off by default but let's see 
what others think. Looking into the future it would also be good to add a UI 
option and chooser too, but not important now.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Hazem Salem 
Codezela added a comment.


  please don't make this
  it look not good
  we can make it more smaller and put it on any corner

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, 
LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black 
cblack updated this revision to Diff 61819.
cblack added a comment.


  Sizing tweaks

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61814=61819

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Filip Fila 
filipf added a comment.


  I'm testing this out now and there seems to be only one obstacle left, see 
inline comment

INLINE COMMENTS

> Main.qml:424
> +fillMode: Image.PreserveAspectFit
> +height: units.gridUnit * 8
> +Behavior on opacity {

units.gridUnit is larger than units.largeSpacing, you can't keep 8 as the 
multiplier:

F7028050: Screenshot_20190715_195255.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black 
cblack updated this revision to Diff 61814.
cblack added a comment.


  Add sourceSize.width to the party

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61813=61814

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Filip Fila 
filipf added inline comments.

INLINE COMMENTS

> cblack wrote in Main.qml:415
> I don't really have a defined width, but I guess I could define the height

You'll notice that in my example I didn't have height defined, but the 
`sourceSize `code should still work because the `fillMode` magic does set some 
definitive width.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black 
cblack updated this revision to Diff 61813.
cblack added a comment.


  Define sourceSize.height

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61809=61813

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black 
cblack added inline comments.

INLINE COMMENTS

> filipf wrote in Main.qml:415
> to the height and width of the item I believe, at least that's what I did 
> here: https://github.com/KDE/sddm-kcm/blob/master/src/qml/main.qml#L54

I don't really have a defined width, but I guess I could define the height

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Filip Fila 
filipf added inline comments.

INLINE COMMENTS

> cblack wrote in Main.qml:415
> I haven't a clue what I should set `sourceSize` to ¯\_(ツ)_/¯

to the height and width of the item I believe, at least that's what I did here: 
https://github.com/KDE/sddm-kcm/blob/master/src/qml/main.qml#L54

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black 
cblack added inline comments.

INLINE COMMENTS

> broulik wrote in Main.qml:415
> Also set a `sourceSize` and probably `asynchronous: true`

I haven't a clue what I should set `sourceSize` to ¯\_(ツ)_/¯

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black 
cblack updated this revision to Diff 61809.
cblack added a comment.


  Rename config file properties to not say "distro"
  Use gridunit
  Use opacityanimator

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61774=61809

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Carson Black 
cblack added inline comments.

INLINE COMMENTS

> broulik wrote in Main.qml:414
> Why not just a bool?

the config object exposes `true` as `"true"`, not `true`, so ¯\_(ツ)_/¯

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread David Edmundson 
davidedmundson added a comment.


  Idea makes sense.
  
  lets drop the word "distro" and then we can use it for 
corporation/city/whatever logos

INLINE COMMENTS

> Main.qml:423
> +Behavior on opacity {
> +NumberAnimation {
> +duration: units.longDuration

OpacityAnimator is better where possible

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: davidedmundson, broulik, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-15 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> Main.qml:414
> +id: logo
> +visible: config.showdistrologo == "shown"
> +source: config.distrologo

Why not just a bool?

> Main.qml:415
> +visible: config.showdistrologo == "shown"
> +source: config.distrologo
> +anchors.horizontalCenter: parent.horizontalCenter

Also set a `sourceSize` and probably `asynchronous: true`

> Main.qml:421
> +fillMode: Image.PreserveAspectFit
> +height: units.largeSpacing * 8
> +Behavior on opacity {

This is not what `spacing` is supposed to be used for. Try `units.gridUnit`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black 
cblack updated this revision to Diff 61774.
cblack added a comment.


  Use units.longDuration

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61761=61774

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> Main.qml:424
> +NumberAnimation {
> +duration: 500
> +easing.type: Easing.InOutQuad

Match the duration for other opacity animation effects (i.e. use 
`units.longDuration`)

> Main.qml:444
> +NumberAnimation {
> +duration: 500
> +easing.type: Easing.InOutQuad

ditto

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black 
cblack updated this revision to Diff 61761.
cblack added a comment.


  Logo has text now

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61756=61761

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black 
cblack added a comment.


  In D22458#495455 , @ngraham wrote:
  
  > An interesting idea. Are you in contact with any distros that have 
requested this or would make use of it?
  
  
  This was created directly because an LCP (artwork dude) at openSUSE requested 
it (see VDG chat).
  
  In D22458#495455 , @ngraham wrote:
  
  > I wouldn't mind adding some text to the default logo so for any distros 
that opt to turn it on and not override the defaults, people learn what it 
actually is (Plasma's logo recognition is low right now). Then again that means 
unlocalized text, unless you do something clever to allow the logo component to 
pull text from a localizable file.
  
  
  Names in logos tend not to be localized from roman characters -> other 
character sets, so this really isn't a large concern for me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Nathaniel Graham 
ngraham added a reviewer: Plasma.
ngraham added a comment.


  An interesting idea. Are you in contact with any distros that have requested 
this or would make use of it?
  
  I wouldn't mind adding some text to the default logo so for any distros that 
opt to turn it on and not override the defaults, people learn what it actually 
is (Plasma's logo recognition is low right now). Then again that means 
unlocalized text, unless you do something clever to allow the logo component to 
pull text from a localizable file.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22458

To: cblack, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black 
cblack updated this revision to Diff 61756.
cblack added a comment.


  This is why you shouldn't forget to test - default logo is now no longer 
pitifully small

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22458?vs=61755=61756

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

2019-07-14 Thread Carson Black 
cblack created this revision.
cblack added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The Breeze SDDM theme now shows a logo that can be configured by distro 
vendors or curious users.

TEST PLAN
  Test configuration and defaults.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  distro-logo-slot (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22458

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/default-logo.svg
  sddm-theme/theme.conf.cmake

To: cblack, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart