D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava abandoned this revision.
tcanabrava added inline comments.

INLINE COMMENTS

> broulik wrote in kcmaccess.cpp:141
> Are you sure this shouldn't be something like
> 
>   modifiers & (ScrollMask | LockMask | NumMask)

good catch.

> broulik wrote in kcmaccess.desktop:9
> What about this? We still need to autostart kaccess on login.
> Perhaps, while at it, you could port it over to proper autostart mechanism 
> rather than abusing kcminit for that.

Can you elaborate on that? I don't really know what you mean.

> broulik wrote in kcmaccess.h:42
> Where is this being used?

It was used in the old code, I forgot to add in the Ui.

> broulik wrote in Bell.qml:89
> Why are you writing to a different property than you check for immutability?

changed the names on the kcfg file and forgot to update here. it's a bit 
annoying that part of the kconfig is string based and other part is proper code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D25375: Start of the accessibility KCM

[Carl Schwan]

ognarb added a comment.


  Ping? it would be sad to see this good work lost :(

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D25375: Start of the accessibility KCM

[Nathaniel Graham]

ngraham added a comment.


  Ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D25375: Start of the accessibility KCM

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Almost there!

INLINE COMMENTS

> Bell.qml:53
> +}
> +Row {
> +Kirigami.FormData.label: i18nc("Defines if the system will use a 
> sound system bell", "Audible Bell:")

Redo the layout do be more like this:

  Audible bell: [] Enable
[] Custom sound file: []

> Bell.qml:54
> +Row {
> +Kirigami.FormData.label: i18nc("Defines if the system will use a 
> sound system bell", "Audible Bell:")
> +

Remove this `Kirigami.FormData.label`; the checkbox above already has the same 
label

> Bell.qml:144
> +Kirigami.FormData.label: i18nc("Notification Bells", "Notification:")
> +text: i18n("Bell when a gesture is used to toggle an accessibility 
> feature")
> +

This isn't a grammatically correct sentence ("bell" is inappropriately used as 
a verb).

How about: "Trigger when an accessibility feature is activated with a gesture"

> main.qml:56
> +RowLayout {
> +anchors.margins: Kirigami.Units.largeSpacing
> +

This also needs a height set so that it fills the full height available in the 
KCM. probably `anchors.fill: parent` would be appropriate

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Carson Black]

cblack added a comment.


  F7878328: image.png 
  
  If you're going to do this faux sidebar thing, why not just split the 
accessibility KCM into multiple KCMs so it can use the proper system settings 
sidebar?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> tcanabrava wrote in kcmaccess.cpp:194
> care to elaborate? This is old code and I haven't touched it.

In that case, I can submit a separate patch to use glib instead of the 
gsettings command line interface.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73274.
tcanabrava marked 16 inline comments as done.
tcanabrava added a comment.


  - ListElement does not handle i18n calls, use raw array
  - Dont complain about null background - Failing on Qt 5.14
  - Add Key entries to the kconfigxt generator
  - ArtsBell* -> CustomBell*
  - kModifiers* -> KeyboardModifiers*
  - Rename mouse settings
  - Remove deprecated call
  - Fix nitpicks
  - Fix Qml Style
  - Use QFileDialog to look for audio files
  - Fix Binary checks
  - Mark as Q_INVOKABLE, not Q_SCRIPTABLE
  - Use QtQuick Dialogs for the audio file
  - Fix orca calls
  - Use Label instead of placeholder text
  - Fix icon & text for search audio files
  - Fix Triggers
  - Trigger orcaInstalled() only when entering ScreenReader
  - Add explanation for magic number
  - Add transient window for the KNofityConfigWidget dialog
  - Fix KConfig Misuse
  - Explain property
  - Audible Bell Layout
  - Add string context

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=73058=73274

BRANCH
  arcpatch-D25375

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kcmaccess.cpp:141
>  
> -QString result;
> -if ((modifiers & ScrollMask) != 0)
> -if ((modifiers & LockMask) != 0)
> -if ((modifiers & NumMask) != 0)
> -result = i18n("Press %1 while NumLock, CapsLock and 
> ScrollLock are active", keyname);
> -else
> -result = i18n("Press %1 while CapsLock and ScrollLock are 
> active", keyname);
> -else if ((modifiers & NumMask) != 0)
> -result = i18n("Press %1 while NumLock and ScrollLock are 
> active", keyname);
> -else
> -result = i18n("Press %1 while ScrollLock is active", keyname);
> -else if ((modifiers & LockMask) != 0)
> -if ((modifiers & NumMask) != 0)
> -result = i18n("Press %1 while NumLock and CapsLock are active", 
> keyname);
> -else
> -result = i18n("Press %1 while CapsLock is active", keyname);
> -else if ((modifiers & NumMask) != 0)
> -result = i18n("Press %1 while NumLock is active", keyname);
> -else
> -result = i18n("Press %1", keyname);
> -
> -return result;
> +return modifiers & ScrollMask & LockMask & NumMask ? i18n("Press %1 
> while NumLock, CapsLock and ScrollLock are active", keyname)
> + : modifiers & ScrollMask & LockMask ? i18n("Press %1 while CapsLock 
> and ScrollLock are active", keyname)

Are you sure this shouldn't be something like

  modifiers & (ScrollMask | LockMask | NumMask)

> kcmaccess.cpp:170
>  
> -ui.setupUi(this);
> -
> -connect(ui.soundButton, ::clicked, this, 
> ::selectSound);
> -connect(ui.customBell, ::clicked, this, 
> ::checkAccess);
> -connect(ui.systemBell, ::clicked, this, 
> ::configChanged);
> -connect(ui.customBell, ::clicked, this, 
> ::configChanged);
> -connect(ui.soundEdit, ::textChanged, this, 
> ::configChanged);
> -
> -connect(ui.invertScreen, ::clicked, this, 
> ::configChanged);
> -connect(ui.flashScreen, ::clicked, this, 
> ::configChanged);
> -connect(ui.visibleBell, ::clicked, this, 
> ::configChanged);
> -connect(ui.visibleBell, ::clicked, this, 
> ::checkAccess);
> -connect(ui.colorButton, ::clicked, this, 
> ::changeFlashScreenColor);
> -
> -connect(ui.invertScreen, ::clicked, this, 
> ::invertClicked);
> -connect(ui.flashScreen, ::clicked, this, 
> ::flashClicked);
> -
> -connect(ui.duration, static_cast (QSpinBox::*)(int)>(::valueChanged), this, 
> ::configChanged);
> -
> -
> -// modifier key settings ---
> -
> -connect(ui.stickyKeys, ::clicked, this, 
> ::configChanged);
> -connect(ui.stickyKeysLock, ::clicked, this, 
> ::configChanged);
> -connect(ui.stickyKeysAutoOff, ::clicked, this, 
> ::configChanged);
> -connect(ui.stickyKeys, ::clicked, this, 
> ::checkAccess);
> -
> -connect(ui.stickyKeysBeep, ::clicked, this, 
> ::configChanged);
> -connect(ui.toggleKeysBeep, ::clicked, this, 
> ::configChanged);
> -connect(ui.kNotifyModifiers, ::clicked, this, 
> ::configChanged);
> -connect(ui.kNotifyModifiers, ::clicked, this, 
> ::checkAccess);
> -connect(ui.kNotifyModifiersButton, ::clicked, this, 
> ::configureKNotify);
> -
> -// key filter settings -
> -
> -connect(ui.slowKeysDelay, static_cast (QSpinBox::*)(int)>(::valueChanged), this, 
> ::configChanged);
> -connect(ui.slowKeys, ::clicked, this, 
> ::configChanged);
> -connect(ui.slowKeys, ::clicked, this, 
> ::checkAccess);
> -
> -connect(ui.slowKeysPressBeep, ::clicked, this, 
> ::configChanged);
> -connect(ui.slowKeysAcceptBeep, ::clicked, this, 
> ::configChanged);
> -connect(ui.slowKeysRejectBeep, ::clicked, this, 
> ::configChanged);
> -
> -connect(ui.bounceKeysDelay, static_cast (QSpinBox::*)(int)>(::valueChanged), this, 
> ::configChanged);
> -connect(ui.bounceKeys, ::clicked, this, 
> ::configChanged);
> -connect(ui.bounceKeysRejectBeep, ::clicked, this, 
> ::configChanged);
> -connect(ui.bounceKeys, ::clicked, this, 
> ::checkAccess);
> -
> -// gestures 
> -
> -QString shortcut = mouseKeysShortcut(QX11Info::display());
> -if (shortcut.isEmpty())
> -ui.gestures->setToolTip(i18n("Here you can activate keyboard 
> gestures that turn on the following features: \n"
> -"Sticky keys: Press Shift key 5 
> consecutive times\n"
> -"Slow keys: Hold down Shift for 8 
> seconds"));
> -else
> -ui.gestures->setToolTip(i18n("Here you can activate keyboard 
> gestures that turn on the following features: \n"
> -"Mouse Keys: %1\n"
> -"Sticky keys: Press Shift key 5 
> consecutive times\n"
> -"Slow keys: Hold down Shift for 8 
> seconds", shortcut));
> -
> -

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73058.
tcanabrava added a comment.


  - Use QFileDialog to look for audio files

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=73057=73058

BRANCH
  arcpatch-D25375

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham, ervin
Cc: cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava marked 4 inline comments as done.
tcanabrava added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:53
> title should already be translated; no need to put this in an `i18n()` call

this was a ListElement Q_NOOP_TR issue

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73057.
tcanabrava marked 5 inline comments as done.
tcanabrava added a comment.


  - ListElement does not handle i18n calls, use raw array
  - Dont complain about null background - Failing on Qt 5.14
  - Add Key entries to the kconfigxt generator
  - ArtsBell* -> CustomBell*
  - kModifiers* -> KeyboardModifiers*
  - Rename mouse settings
  - Remove deprecated call
  - Fix nitpicks
  - Fix Qml Style

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=71008=73057

BRANCH
  arcpatch-D25375

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham, ervin
Cc: cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  In D25375#575980 , @ervin wrote:
  
  > I think we discussed this already, but I'm not sure so before it gets 
lost... :-)
  >
  > Please consider using both key and name for your kcfg items, this allows to 
both respect the past storage format and provide nicer property names on the 
C++/QML side. Currently the storage used names are leaking to the internal API.
  
  
  Done.

INLINE COMMENTS

> cblack wrote in CMakeLists.txt:17
> What purpose does this serve? It looks like you're simply printing a list of 
> source files with a Portuguese header.

stray debug. fixed.

> cblack wrote in kcmaccess.cpp:194
> You could consider using glib for a stable ABI instead of invoking a command 
> line that could change at any time. Also would reduce dependencies for most 
> distros, as glib's command line tools are often packaged separately from glib 
> itself.

care to elaborate? This is old code and I haven't touched it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Carson Black]

cblack added a comment.


  The QML code could use some help in the style department. Some changes I 
would do:
  
  1. Make ID separate from other properties
  2. Chunk together related properties in a consistent manner
  
  https://doc.qt.io/qt-5/qml-codingconventions.html and 
https://community.kde.org/Plasma/QMLStyle are relevant here.
  
  Also, I wonder if it would be better to spin out each tab into a KCM of its 
own instead of retaining a single Accessibility KCM as a catch-all for 
accessibility stuff that doesn't go anywhere else.

INLINE COMMENTS

> CMakeLists.txt:17
>  
> -target_link_libraries(kcm_access
> -Qt5::X11Extras
> +message("Arquivos" ${kcmaccess_PART_SRCS})
> +target_link_libraries(kcmaccess

What purpose does this serve? It looks like you're simply printing a list of 
source files with a Portuguese header.

> kcmaccess.cpp:194
> +
>  int ret = QProcess::execute(QStringLiteral("gsettings"), gsettingArgs);
>  if (ret) {

You could consider using glib for a stable ABI instead of invoking a command 
line that could change at any time. Also would reduce dependencies for most 
distros, as glib's command line tools are often packaged separately from glib 
itself.

> ModifierKeys.qml:98
> +icon.name: "preferences-desktop-notification"
> +onClicked: kcm.keyboardSettings.configureKNotify();
> +}

Redundant semicolon; there's only one statement on this line.

> ScreenReader.qml:35
> +QQC2.Button {
> +text: i18n("Launch Orca Screen Reader Configuration")
> +onClicked: kcm.screenReaderSettings.launchOrcaConfiguration()

There should be an ellipsis here since this is opening another configuration 
window.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: cblack, ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25375: Start of the accessibility KCM

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.


  I think we discussed this already, but I'm not sure so before it gets lost... 
:-)
  
  Please consider using both key and name for your kcfg items, this allows to 
both respect the past storage format and provide nicer property names on the 
C++/QML side. Currently the storage used names are leaking to the internal API.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: ervin, ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Now the KCM doesn't load:
  

"file:///home/nate/kde/usr/share/kpackage/kcms/kcmaccess/contents/ui/main.qml" 
 "Error loading QML file.\n76: ListElement: cannot use script for property 
value\n"
  
  Also can you mark the inline comments as done once they're addressed? That 
makes it easier to review. Thanks!

INLINE COMMENTS

> tcanabrava wrote in ModifierKeys.qml:51
> I can't correct you here, those where the original texts and since haven't 
> got a clue on what they are talking about I choose not to change them.

> since haven't got a clue on what they are talking about

That's a great sign that they're in desperate need of being changed. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  Updated texts by ngraham sugestions.

INLINE COMMENTS

> ngraham wrote in ActivationGestures.qml:50
> This section doesn't have anything to do with activation gestures. Its 
> checkboxes might be better placed on other pages more relevant to their 
> content.

Agree. This is a 1 to 1 translation of the old KCM. I'm doing the changes you 
requested.

> ngraham wrote in ModifierKeys.qml:51
> Can be shortened to "Use system bell when modifier keys are used" (I *think* 
> this is what the string is trying to  communicate; correct me if I'm wrong)

I can't correct you here, those where the original texts and since haven't got 
a clue on what they are talking about I choose not to change them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 71008.
tcanabrava added a comment.


  - Fix localization calls

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=71005=71008

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 71005.
tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  - Typos and onToggled instead of onCheckStateChanged
  - Better UX / Texts
  - Text updates
  - Remove ActivationGestures page, Fix orca information

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70754=71005

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  All the left labels in the formLayouts need to end with a colon, e.g.:
  
Delay: [ 0]
  
  Don't use `onCheckStateChanged` or `onCheckedChanged` for checkboxes when you 
want to handle user interaction;i t causes binding loops. Use `onToggled` 
instead.
  
  Put whitespace between logical sections in the formlayout. For example 
between the audible bell and visual bell sections. You can do this like so:
  
Item {
Kirigami.FormData.isSection: true
}
  
  Change `QtQuick.Controls 2.12` to `QtQuick.Controls 2.11` everywhere; we 
don't formally depends on Qt 5.12 yet.

INLINE COMMENTS

> ActivationGestures.qml:29
> +QQC2.CheckBox {
> +Kirigami.FormData.label: i18n("Activation Gestures")
> +text: i18n("Use gestures for activating sticky keys and slow keys")

This section can be expressed more clearly and compactly as follows:

  Sticky and slow keys: [ ] Use gestures to activate
[ ] Disable after: [99 seconds ^v]

In fact, this section maybe should be moved to the Modifier Keys page, and then 
we can remove the Activation Gestures page entirely.

> ActivationGestures.qml:30
> +Kirigami.FormData.label: i18n("Activation Gestures")
> +text: i18n("Use gestures for activating sticky keys and slow keys")
> +checked: kcm.keyboardSettings.stickyKeys

Can be shortened to "Use gestures for activating sticky and slow keys"

> ActivationGestures.qml:50
> +QQC2.CheckBox {
> +Kirigami.FormData.label: i18n("Notification")
> +text: i18n("Use the system bell whenever a gesture is used to toggle 
> an accessibility feature")

This section doesn't have anything to do with activation gestures. Its 
checkboxes might be better placed on other pages more relevant to their content.

> ActivationGestures.qml:69
> +QQC2.Button {
> +text: i18n("Configure Notifications")
> +onClicked: kcm.configureKNotify();

add ellipsis and an icon (`preferences-desktop-notification`)

> ModifierKeys.qml:38
> +enabled: !kcm.keyboardSettings.isImmutable("StickyKeysLatch") && 
> kcm.keyboardSettings.stickyKeys
> +text: i18n("Lock sticky keys")
> +checked: kcm.keyboardSettings.stickyKeysLatch

Can be shortened to just "Lock"

> ModifierKeys.qml:45
> +enabled: !kcm.keyboardSettings.isImmutable("StickyKeysAutoOff") && 
> kcm.keyboardSettings.stickyKeys
> +text: i18n("Turn off sticky keys when two keys are pressed 
> continuously")
> +checked: kcm.keyboardSettings.stickyKeysAutoOff

Can be shortened to "Disable when two keys are held down"

> ModifierKeys.qml:51
> +enabled: !kcm.keyboardSettings.isImmutable("StickyKeysBeep") && 
> kcm.keyboardSettings.stickyKeys
> +text: i18n("Use system bell whenever a modifier gets latched, locked 
> or unlocked")
> +checked: kcm.keyboardSettings.stickyKeysBeep

Can be shortened to "Use system bell when modifier keys are used" (I *think* 
this is what the string is trying to  communicate; correct me if I'm wrong)

> ModifierKeys.qml:58
> +Kirigami.FormData.label: i18n("Locking Keys")
> +text: i18n("Use system bell whenever a locking key gets toggled")
> +checked: kcm.keyboardSettings.toggleKeysBeep

Can be slightly shortened to "Use system bell when locking keys are toggled"

> ModifierKeys.qml:64
> +QQC2.CheckBox {
> +text: i18n("Show a notification for modifier or locking key state 
> changes")
> +checked: kcm.keyboardSettings.kNotifyModifiers

Can be shortened to "Show notification when modifier or locking keys are used"

> MouseNavigation.qml:31
> +Kirigami.FormData.label:  i18n("Activation Gestures")
> +text: i18n("Move pointer with keyboard (using the num pad)")
> +checked: kcm.mouseSettings.mouseKeys

Change to "Enable using keyboard number pad to move cursor"

> MouseNavigation.qml:35
> +enabled: !kcm.mouseSettings.isImmutable("MouseKeys")
> +}
> +QQC2.SpinBox {

Add spacing after this

> ScreenReader.qml:30
> +Kirigami.FormData.label:  i18n("Screen Reader")
> +text: i18n("enabled")
> +checked: kcm.screenReaderSettings.enabled

In this case, just put the whole text in the checkbox:

  [ ] Enable screen reader
  [ Launch Orca Configuration...]

> ScreenReader.qml:36
> +QQC2.Button {
> +text: i18n("Launch Orca Configuration")
> +onClicked: kcm.screenReaderSettings.launchOrcaConfiguration()

What's Orca? Isn't that a kind of whale? :p Make change the text to be 
"Configure Orca Screen Reader..."

> ScreenReader.qml:37
> +text: i18n("Launch Orca Configuration")
> +onClicked: kcm.screenReaderSettings.launchOrcaConfiguration()
> +enabled: !kcm.screenReaderSettings.isImmutable("Enabled")

If Orca isn't installed, clicking on this button does nothing. In this 

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  Missing apply button being enabled seems something related to 
ManagedConfigModule. I don't know what to do there yet.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70754.
tcanabrava marked 6 inline comments as done.
tcanabrava added a comment.


  - Add missing setButtons
  - Fix Typo

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70751=70754

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70751.
tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  - Fix factory name

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70749=70751

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70749.
tcanabrava added a comment.


  - Fixes
  - Fixes texts and UI
  - Simplify Algorithm
  - Fix Enable / Disable status

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70103=70749

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  In general the UI here is pretty good. I think we can polish it a bit. In 
particular, instead of having a header for a section and then a checkbox below 
it to enable that section with the same text as the header, here's an idea for 
an alternative: just use the checkbox itself as the header.  For example:
  
[] Audible bell
Custom Bell: [] Sound: [   ]

[] Visual bell
 Duration: [99]
Visual effect: (o) Flash color: [ color ]
   ( ) Invert screen
  
  Another thing: you can save a lot of space by taking advantage of the 
properties of a FormLayout by splitting strings up a bit. For example, for Slow 
Keys, you can do the following:
  
Show System Bell: [x] When a key is pressed
  [ ] When a key is accepted
  [ ] When a key is rejected
  
  Finally, I notice that the Apply button never gets enabled when a control is 
changed.

INLINE COMMENTS

> Bell.qml:35
> +id: systemBell
> +text: i18n("Use system bell")
> +checked: kcm.bellSettings.systemBell

Instead of having a header and then a checkbox to enable it, with the same text 
as the header, let's just use the checkbox itself as the header. i.e.:

  [] Audible bell
  Custom Bell: [] Sound: [   ]
  
  [] Visual bell
   Duration: [99]
  Visual effect: (o) Flash color: [ color ]
 ( ) Invert screen

> Bell.qml:47
> +}
> +QQC2.TextField {
> +id: textEdit

Indent this by one GridUnit to show that its dependency on the checkbox above 
it, or place it on the same line

> Bell.qml:70
> +text: i18n("Invert Screen")
> +enabled: !kcm.bellSettings.isImmutable("InvertScreen") && 
> kcm.bellSettings.visibleBell
> +checked: kcm.bellSettings.invertScreen

This radio button never gets enabled

> Bell.qml:81
> +onCheckedChanged: kcm.bellSettings.invertScreen = !checked
> +enabled: !kcm.bellSettings.isImmutable("InvertScreen")
> +}

This radio button never gets enabled

> Bell.qml:94
> +onValueChanged: kcm.bellSettings.visibleBellPause = value
> +Kirigami.FormData.label: i18n("Duration")
> +}

"Duration:"

> MouseNavigation.qml:38
> +onCheckStateChanged: kcm.mouseSettings.mouseKeys = checked
> +enabled: !kcm.keyboardSettings.isImmutable("MouseKeys")
> +}

This checkbox never gets enabled

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70103.
tcanabrava added a comment.


  - Fixes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=69947=70103

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Carl Schwan]

ognarb added a comment.


  :)

INLINE COMMENTS

> CMakeLists.txt:2
>  # KI18N Translation Domain for this library
> +# KI18N Translation Domain for this library
>  add_definitions(-DTRANSLATION_DOMAIN=\"kcmaccess\")

Duplicate line

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:42
> Needs keyboard navigation. See 
> https://cgit.kde.org/plasma-desktop.git/commit/?id=659fe0a76f19b60021733c4a74e451d4318a8359
>  for details regarding how.

more than that, the correct way of doing keyboard navigation in ListView is 
setting in the ListView instance

activeFocusOnTab: true
keyNavigationEnabled: true

(and leaving keyNavigationWraps to false)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:42
> +
> +ListView {
> +id: listView

Needs keyboard navigation. See 
https://cgit.kde.org/plasma-desktop.git/commit/?id=659fe0a76f19b60021733c4a74e451d4318a8359
 for details regarding how.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  This rewrites the Accessibility KCM to use Qml and the new Managed
  Config classes.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart