This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3a6e3f927111: [KFilePlacesModel] Fix supported scheme
check for devices (authored by broulik).
Herald added a
ngraham added a comment.
No response, I think you can land this.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25991
To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus,
broulik added a comment.
Ping
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25991
To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot,
ngraham added a comment.
@bruns?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25991
To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot,
broulik added inline comments.
INLINE COMMENTS
> bruns wrote in kfileplacesmodel.cpp:758
> you have dropped the `allowedHere` check. Probably just `if (!allowedHere)
> continue`.
>
> And for reasons unknown to me, `tags:` is not filtered per app - move the
> allowedHere check to the very
bruns added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:758
> +KFilePlacesItem *item = nullptr;
> +if (deviceAvailable) {
> +item = new KFilePlacesItem(bookmarkManager,
> bookmark.address(), udi);
you have dropped the
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Oh so nice.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25991
To: broulik, #frameworks, dfaure, ngraham
Cc: ngraham, plasma-devel, LeGast00n,
broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
A device doesn't usually have a URL so we need to actutally check the
underlying
